[{"id":3480,"web_url":"https://patchwork.libcamera.org/comment/3480/","msgid":"<20200117160009.GB1074550@oden.dyn.berto.se>","date":"2020-01-17T16:00:09","subject":"Re: [libcamera-devel] [PATCH v2 2/2] utils: rkisp1: sync topology\n\twith upstream driver in capture script","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Helen,\n\nThanks for your patch.\n\nOn 2020-01-17 11:58:02 -0300, Helen Koike wrote:\n> rkisp1 kernel driver was merged upstream with minor changes in the\n> topology from the original driver libcamera based it's first support to\n> rkisp1.\n> \n> Adapt libcamera capture script to work with upstream driver.\n\nHow did you test this patch? I tried running the script as such:\n\n$ ./rkisp1-capture.sh --no-save -s 1296x972 \"ov5695 7-0036\"\nCapturing 1296x972 from sensor ov5695 7-0036 in SBGGR10_1X10\nConfiguring pipeline for ov5695 7-0036 in fmt:SBGGR10_1X10/1296x972\nDevice /dev/video0 opened.\nDevice `rkisp1' on `platform:rkisp1' (driver 'rkisp1') supports video, \ncapture, with mplanes.\nVideo format set: YUYV (56595559) 1296x972 field none, 1 planes: \n * Stride 2592, buffer size 2519424\n Video format: YUYV (56595559) 1296x972 field none, 1 planes: \n  * Stride 2592, buffer size 2519424\n  5 buffers requested.\n  length: 1 offset: 4215579600 timestamp type/source: mono/EoF\n  Buffer 0/0 mapped at address 0x7f8bdb5000.\n  length: 1 offset: 4215579600 timestamp type/source: mono/EoF\n  Buffer 1/0 mapped at address 0x7f8bb4d000.\n  length: 1 offset: 4215579600 timestamp type/source: mono/EoF\n  Buffer 2/0 mapped at address 0x7f8b8e5000.\n  length: 1 offset: 4215579600 timestamp type/source: mono/EoF\n  Buffer 3/0 mapped at address 0x7f8b67d000.\n  length: 1 offset: 4215579600 timestamp type/source: mono/EoF\n  Buffer 4/0 mapped at address 0x7f8b415000.\n\nBut I get no buffers back and yavta stops here and have to be killed.\n\n> \n> * Remove subdevice dphy from the pipeline.\n> * Add resizer in the pipeline.\n> * Fix links.\n> * Update entity names.\n> \n> Signed-off-by: Helen Koike <helen.koike@collabora.com>\n> \n> ---\n> \n> changes in v2:\n> * New commit (splitted from previous one)\n> ---\n>  utils/rkisp1/rkisp1-capture.sh | 16 ++++++++--------\n>  1 file changed, 8 insertions(+), 8 deletions(-)\n> \n> diff --git a/utils/rkisp1/rkisp1-capture.sh b/utils/rkisp1/rkisp1-capture.sh\n> index cffe9fe..4d09f5d 100755\n> --- a/utils/rkisp1/rkisp1-capture.sh\n> +++ b/utils/rkisp1/rkisp1-capture.sh\n> @@ -68,14 +68,14 @@ configure_pipeline() {\n>  \n>  \t$mediactl -r\n>  \n> -\t$mediactl -l \"'$sensor':0 -> 'rockchip-sy-mipi-dphy':0 [1]\"\n> -\t$mediactl -l \"'rockchip-sy-mipi-dphy':1 -> 'rkisp1-isp-subdev':0 [1]\"\n> -\t$mediactl -l \"'rkisp1-isp-subdev':2 -> 'rkisp1_mainpath':0 [1]\"\n> +\t$mediactl -l \"'$sensor':0 -> 'rkisp1_isp':0 [1]\"\n> +\t$mediactl -l \"'rkisp1_isp':2 -> 'rkisp1_resizer_mainpath':0 [1]\"\n>  \n>  \t$mediactl -V \"\\\"$sensor\\\":0 [$format]\"\n> -\t$mediactl -V \"'rockchip-sy-mipi-dphy':1 [$format]\"\n> -\t$mediactl -V \"'rkisp1-isp-subdev':0 [$format crop:(0,0)/$sensor_size]\"\n> -\t$mediactl -V \"'rkisp1-isp-subdev':2 [fmt:$capture_mbus_code/$capture_size crop:(0,0)/$capture_size]\"\n> +\t$mediactl -V \"'rkisp1_isp':0 [$format crop:(0,0)/$sensor_size]\"\n> +\t$mediactl -V \"'rkisp1_isp':2 [fmt:$capture_mbus_code/$sensor_size crop:(0,0)/$sensor_size]\"\n> +\t$mediactl -V \"'rkisp1_resizer_mainpath':0 [fmt:$capture_mbus_code/$sensor_size crop:(0,0)/$sensor_size]\"\n> +\t$mediactl -V \"'rkisp1_resizer_mainpath':1 [fmt:$capture_mbus_code/$capture_size]\"\n>  }\n>  \n>  # Capture frames\n> @@ -161,8 +161,8 @@ fi\n>  \n>  sensor_name=$1\n>  \n> -modprobe mipi_dphy_sy\n> -modprobe video_rkisp1\n> +modprobe phy_rockchip_dphy_rx0\n> +modprobe rockchip_isp1\n>  \n>  sensor=$(find_sensor $sensor_name) || exit\n>  mdev=$(find_media_device rkisp1) || exit\n> -- \n> 2.24.0\n>","headers":{"Return-Path":"<niklas.soderlund@ragnatech.se>","Received":["from mail-lj1-x241.google.com (mail-lj1-x241.google.com\n\t[IPv6:2a00:1450:4864:20::241])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CB89860456\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 17 Jan 2020 17:00:10 +0100 (CET)","by mail-lj1-x241.google.com with SMTP id z22so27002622ljg.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 17 Jan 2020 08:00:10 -0800 (PST)","from localhost (h-93-159.A463.priv.bahnhof.se. [46.59.93.159])\n\tby smtp.gmail.com with ESMTPSA id\n\th7sm12389475lfj.29.2020.01.17.08.00.09\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 17 Jan 2020 08:00:09 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=mNjo/ELb0+YU2jTcWIJqQ7Yu7kyVtR6IJof/QAfW/7s=;\n\tb=BRXckEeby6ImaYX28aXlCISZ5+/m2aRwWVsVpG5Bomww0e3jReCE/POS2aQYQEKJWQ\n\tQqLu9VlYjlTeG/Wr924IahoX+fkMnmyvhpPbWDLvTrYlPZ1nhvhYEp5oDQJE3bB6FQvx\n\ttE11xjFV4TH7I/s1KENxXWD9i1YyuyPKawo0XBhwDkLNZWBpv+7QBxBlKFLWJt3VqLaj\n\tk/h2o5iFmNipk+dsNwbWH8A/jhw8F5pxE1nLVuP4eDZsuu8GA44wmS1J3zhIYlhe7xLJ\n\tKT4oPVO2RXASl+iSkXrMcWSS2bArBXuJ1nadCDoDscg+25frXOB518OQrRG5WhJFGSzy\n\tqtuA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=mNjo/ELb0+YU2jTcWIJqQ7Yu7kyVtR6IJof/QAfW/7s=;\n\tb=FGTrCrvbT6YYJeHfCA66WSt9/76+rEymKdlMadxGCDPakZI/Vo4Y5KgEmhyumJrfPL\n\tKpaHkkVtBnaFeVgRvfq0LLoQmdqrx/wW/qGJJCIsqw3VEVyFllSDgLs6qHC+4D6Kt56D\n\t9TKH8iKnF4V/6MGqPW0+Bruefh/yp2D5Cd9O3cDbTVydW1exuAR12xCCnFyTf9kSlrsJ\n\txmc4HTABJcz5wPaK5QcNCmyTDP4fvc5CLuWSKPFLn3heIXd7g+YRQ2pIMJFrFVLQKppp\n\tjVA8bYeJpCuFsMtfY87uxdj4XjUJ+ERYJUXxIYJDqwODQV6HYNzJ4x0GR7S1SQUAoznQ\n\tBHtA==","X-Gm-Message-State":"APjAAAW/WLjBDtlCnR5Nd7XPfNL0FqsSkJWAEseaZvWbjBHDRybqDDwe\n\treymye+Gdl6hSxZy1ejd5rs7lA==","X-Google-Smtp-Source":"APXvYqxy8F6/96y9NO7LxcegvWm7cICsmDSbqd7LwuJzlwrk65eP2t84obTjUkn8m1wZoOjEnKY2LQ==","X-Received":"by 2002:a2e:8603:: with SMTP id a3mr5882075lji.210.1579276810100;\n\tFri, 17 Jan 2020 08:00:10 -0800 (PST)","Date":"Fri, 17 Jan 2020 17:00:09 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= <niklas.soderlund@ragnatech.se>","To":"Helen Koike <helen.koike@collabora.com>","Cc":"libcamera-devel@lists.libcamera.org, laurent.pinchart@ideasonboard.com, \n\tkernel@collabora.com, heiko@sntech.de, tfiga@chromium.org,\n\tjoacim.zetterling@gmail.com","Message-ID":"<20200117160009.GB1074550@oden.dyn.berto.se>","References":"<20200117145802.3322874-1-helen.koike@collabora.com>\n\t<20200117145802.3322874-2-helen.koike@collabora.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200117145802.3322874-2-helen.koike@collabora.com>","Subject":"Re: [libcamera-devel] [PATCH v2 2/2] utils: rkisp1: sync topology\n\twith upstream driver in capture script","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Fri, 17 Jan 2020 16:00:11 -0000"}},{"id":3481,"web_url":"https://patchwork.libcamera.org/comment/3481/","msgid":"<ed8fd8cd-7d0e-d23d-9c36-dfa94e00dd73@collabora.com>","date":"2020-01-17T20:01:48","subject":"Re: [libcamera-devel] [PATCH v2 2/2] utils: rkisp1: sync topology\n\twith upstream driver in capture script","submitter":{"id":20,"url":"https://patchwork.libcamera.org/api/people/20/","name":"Helen Koike","email":"helen.koike@collabora.com"},"content":"On 1/17/20 2:00 PM, Niklas Söderlund wrote:\n> Hi Helen,\n> \n> Thanks for your patch.\n> \n> On 2020-01-17 11:58:02 -0300, Helen Koike wrote:\n>> rkisp1 kernel driver was merged upstream with minor changes in the\n>> topology from the original driver libcamera based it's first support to\n>> rkisp1.\n>>\n>> Adapt libcamera capture script to work with upstream driver.\n> \n> How did you test this patch? I tried running the script as such:\n> \n> $ ./rkisp1-capture.sh --no-save -s 1296x972 \"ov5695 7-0036\"\n> Capturing 1296x972 from sensor ov5695 7-0036 in SBGGR10_1X10\n> Configuring pipeline for ov5695 7-0036 in fmt:SBGGR10_1X10/1296x972\n> Device /dev/video0 opened.\n> Device `rkisp1' on `platform:rkisp1' (driver 'rkisp1') supports video, \n> capture, with mplanes.\n> Video format set: YUYV (56595559) 1296x972 field none, 1 planes: \n>  * Stride 2592, buffer size 2519424\n>  Video format: YUYV (56595559) 1296x972 field none, 1 planes: \n>   * Stride 2592, buffer size 2519424\n>   5 buffers requested.\n>   length: 1 offset: 4215579600 timestamp type/source: mono/EoF\n>   Buffer 0/0 mapped at address 0x7f8bdb5000.\n>   length: 1 offset: 4215579600 timestamp type/source: mono/EoF\n>   Buffer 1/0 mapped at address 0x7f8bb4d000.\n>   length: 1 offset: 4215579600 timestamp type/source: mono/EoF\n>   Buffer 2/0 mapped at address 0x7f8b8e5000.\n>   length: 1 offset: 4215579600 timestamp type/source: mono/EoF\n>   Buffer 3/0 mapped at address 0x7f8b67d000.\n>   length: 1 offset: 4215579600 timestamp type/source: mono/EoF\n>   Buffer 4/0 mapped at address 0x7f8b415000.\n> \n> But I get no buffers back and yavta stops here and have to be killed.\n\nThis is because I was testing other things and forgot this like that\nenable a link (sorry about that):\n\n$mediactl -l \"'rkisp1_resizer_mainpath':1 -> 'rkisp1_mainpath':0 [1]\"\n\nIn any case there is a bug in the driver, it shouldn't stall, it should fail\nin link validation.\n\nAlso, the driver allows too many links to be disabled (which doesn't make\nsense). Hold this patchset a bit, let me send a patch making almost all\nlinks immutable, so the line above won't be required.\n\nHelen\n\n> \n>>\n>> * Remove subdevice dphy from the pipeline.\n>> * Add resizer in the pipeline.\n>> * Fix links.\n>> * Update entity names.\n>>\n>> Signed-off-by: Helen Koike <helen.koike@collabora.com>\n>>\n>> ---\n>>\n>> changes in v2:\n>> * New commit (splitted from previous one)\n>> ---\n>>  utils/rkisp1/rkisp1-capture.sh | 16 ++++++++--------\n>>  1 file changed, 8 insertions(+), 8 deletions(-)\n>>\n>> diff --git a/utils/rkisp1/rkisp1-capture.sh b/utils/rkisp1/rkisp1-capture.sh\n>> index cffe9fe..4d09f5d 100755\n>> --- a/utils/rkisp1/rkisp1-capture.sh\n>> +++ b/utils/rkisp1/rkisp1-capture.sh\n>> @@ -68,14 +68,14 @@ configure_pipeline() {\n>>  \n>>  \t$mediactl -r\n>>  \n>> -\t$mediactl -l \"'$sensor':0 -> 'rockchip-sy-mipi-dphy':0 [1]\"\n>> -\t$mediactl -l \"'rockchip-sy-mipi-dphy':1 -> 'rkisp1-isp-subdev':0 [1]\"\n>> -\t$mediactl -l \"'rkisp1-isp-subdev':2 -> 'rkisp1_mainpath':0 [1]\"\n>> +\t$mediactl -l \"'$sensor':0 -> 'rkisp1_isp':0 [1]\"\n>> +\t$mediactl -l \"'rkisp1_isp':2 -> 'rkisp1_resizer_mainpath':0 [1]\"\n>>  \n>>  \t$mediactl -V \"\\\"$sensor\\\":0 [$format]\"\n>> -\t$mediactl -V \"'rockchip-sy-mipi-dphy':1 [$format]\"\n>> -\t$mediactl -V \"'rkisp1-isp-subdev':0 [$format crop:(0,0)/$sensor_size]\"\n>> -\t$mediactl -V \"'rkisp1-isp-subdev':2 [fmt:$capture_mbus_code/$capture_size crop:(0,0)/$capture_size]\"\n>> +\t$mediactl -V \"'rkisp1_isp':0 [$format crop:(0,0)/$sensor_size]\"\n>> +\t$mediactl -V \"'rkisp1_isp':2 [fmt:$capture_mbus_code/$sensor_size crop:(0,0)/$sensor_size]\"\n>> +\t$mediactl -V \"'rkisp1_resizer_mainpath':0 [fmt:$capture_mbus_code/$sensor_size crop:(0,0)/$sensor_size]\"\n>> +\t$mediactl -V \"'rkisp1_resizer_mainpath':1 [fmt:$capture_mbus_code/$capture_size]\"\n>>  }\n>>  \n>>  # Capture frames\n>> @@ -161,8 +161,8 @@ fi\n>>  \n>>  sensor_name=$1\n>>  \n>> -modprobe mipi_dphy_sy\n>> -modprobe video_rkisp1\n>> +modprobe phy_rockchip_dphy_rx0\n>> +modprobe rockchip_isp1\n>>  \n>>  sensor=$(find_sensor $sensor_name) || exit\n>>  mdev=$(find_media_device rkisp1) || exit\n>> -- \n>> 2.24.0\n>>\n>","headers":{"Return-Path":"<helen.koike@collabora.com>","Received":["from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1A3856077B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 17 Jan 2020 21:01:56 +0100 (CET)","from [127.0.0.1] (localhost [127.0.0.1])\n\t(Authenticated sender: koike) with ESMTPSA id 9A26F293B15"],"To":"=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>","Cc":"libcamera-devel@lists.libcamera.org, laurent.pinchart@ideasonboard.com, \n\tkernel@collabora.com, heiko@sntech.de, tfiga@chromium.org,\n\tjoacim.zetterling@gmail.com","References":"<20200117145802.3322874-1-helen.koike@collabora.com>\n\t<20200117145802.3322874-2-helen.koike@collabora.com>\n\t<20200117160009.GB1074550@oden.dyn.berto.se>","From":"Helen Koike <helen.koike@collabora.com>","Autocrypt":"addr=helen.koike@collabora.com; keydata=\n\tmQINBFmOMD4BEADb2nC8Oeyvklh+ataw2u/3mrl+hIHL4WSWtii4VxCapl9+zILuxFDrxw1p\n\tXgF3cfx7g9taWBrmLE9VEPwJA6MxaVnQuDL3GXxTxO/gqnOFgT3jT+skAt6qMvoWnhgurMGH\n\twRaA3dO4cFrDlLsZIdDywTYcy7V2bou81ItR5Ed6c5UVX7uTTzeiD/tUi8oIf0XN4takyFuV\n\tRf09nOhi24bn9fFN5xWHJooFaFf/k2Y+5UTkofANUp8nn4jhBUrIr6glOtmE0VT4pZMMLT63\n\thyRB+/s7b1zkOofUGW5LxUg+wqJXZcOAvjocqSq3VVHcgyxdm+Nv0g9Hdqo8bQHC2KBK86VK\n\tvB+R7tfv7NxVhG1sTW3CQ4gZb0ZugIWS32Mnr+V+0pxci7QpV3jrtVp5W2GA5HlXkOyC6C7H\n\tAo7YhogtvFehnlUdG8NrkC3HhCTF8+nb08yGMVI4mMZ9v/KoIXKC6vT0Ykz434ed9Oc9pDow\n\tVUqaKi3ey96QczfE4NI029bmtCY4b5fucaB/aVqWYRH98Jh8oIQVwbt+pY7cL5PxS7dQ/Zuz\n\t6yheqDsUGLev1O3E4R8RZ8jPcfCermL0txvoXXIA56t4ZjuHVcWEe2ERhLHFGq5Zw7KC6u12\n\tkJoiZ6WDBYo4Dp+Gd7a81/WsA33Po0j3tk/8BWoiJCrjXzhtRwARAQABtCdIZWxlbiBLb2lr\n\tZSA8aGVsZW4ua29pa2VAY29sbGFib3JhLmNvbT6JAlQEEwEKAD4CGwEFCwkIBwMFFQoJCAsF\n\tFgIDAQACHgECF4AWIQSofQA6zrItXEgHWTzAfqwo9yFiXQUCXEz3bwUJBKaPRQAKCRDAfqwo\n\t9yFiXdUCD/4+WZr503hQ13KB4DijOW76ju8JDPp4p++qoPxtoAsld3yROoTI+VPWmt7ojHrr\n\tTZc7sTLxOFzaUC8HjGTb3r9ilIhIKf/M9KRLkpIJ+iLA+VoUbcSOMYWoVNfgLmbnqoezjPcy\n\tOHJwVw9dzEeYpvG6nkY6E4UktANySp27AniSXNuHOvYsOsXmUOqU1ScdsrQ9s732p/OGdTyw\n\t1yd3gUMLZvCKFOBVHILH59HCRJgpwUPiws8G4dGMs4GTRvHT2s2mDQdQ0HEvcM9rvCRVixuC\n\t5ZeOymZNi6lDIUIysgiZ+yzk6i5l/Ni6r7v20N3JppZvhPK6LqtaYceyAGyc3jjnOqoHT/qR\n\tkPjCwzmKiPtXjLw6HbRXtGgGtP5m3y8v6bfHH+66zd2vGCY0Z9EsqcnK4DCqRkLncFLPM2gn\n\t9cZcCmO4ZqXUhTyn1nHM494kd5NX1Op4HO+t9ErnpufkVjoMUeBwESdQwwwHT3rjUueGmCrn\n\tVJK69/qhA4La72VTxHutl+3Z0Xy20HWsZS8Gsam39f95/LtPLzbBwnOOi5ZoXnm97tF8HrAZ\n\t2h+kcRLMWw3BXy5q4gic+oFZMZP9oq1G9XTFld4FGgJ9ys8aGmhLM+uB1pFxb3XFtWQ2z4AJ\n\tiEp2VLl34quwfD6Gg4csiZe2KzvQHUe0w8SJ9LplrHPPprkCDQRZjjChARAAzISLQaHzaDOv\n\tZxcoCNBk/hUGo2/gsmBW4KSj73pkStZ+pm3Yv2CRtOD4jBlycXjzhwBV7/70ZMH70/Y25dJa\n\tCnJKl/Y76dPPn2LDWrG/4EkqUzoJkhRIYFUTpkPdaVYznqLgsho19j7HpEbAum8r3jemYBE1\n\tAIuVGg4bqY3UkvuHWLVRMuaHZNy55aYwnUvd46E64JH7O990mr6t/nu2a1aJ0BDdi8HZ0RMo\n\tEg76Avah+YR9fZrhDFmBQSL+mcCVWEbdiOzHmGYFoToqzM52wsNEpo2aStH9KLk8zrCXGx68\n\tohJyQoALX4sS03RIWh1jFjnlw2FCbEdj/HDX0+U0i9COtanm54arYXiBTnAnx0F7LW7pv7sb\n\t6tKMxsMLmprP/nWyV5AfFRi3jxs5tdwtDDk/ny8WH6KWeLR/zWDwpYgnXLBCdg8l97xUoPQO\n\t0VkKSa4JEXUZWZx9q6kICzFGsuqApqf9gIFJZwUmirsxH80Fe04Tv+IqIAW7/djYpOqGjSyk\n\toaEVNacwLLgZr+/j69/1ZwlbS8K+ChCtyBV4kEPzltSRZ4eU19v6sDND1JSTK9KSDtCcCcAt\n\tVGFlr4aE00AD/aOkHSylc93nPinBFO4AGhcs4WypZ3GGV6vGWCpJy9svfWsUDhSwI7GS/i/v\n\tUQ1+bswyYEY1Q3DjJqT7fXcAEQEAAYkEcgQYAQoAJgIbAhYhBKh9ADrOsi1cSAdZPMB+rCj3\n\tIWJdBQJcTPfVBQkEpo7hAkDBdCAEGQEKAB0WIQSomGMEg78Cd/pMshveCRfNeJ05lgUCWY4w\n\toQAKCRDeCRfNeJ05lp0gD/49i95kPKjpgjUbYeidjaWuINXMCA171KyaBAp+Jp2Qrun4sIJB\n\tZ6srMj6O/gC34AhZln2sXeQdxe88sNbg6HjlN+4AkhTd6DttjOfUwnamLDA7uw+YIapGgsgN\n\tlznjLnqOaQ9mtEwRbZMUOdyRf9osSuL14vHl4ia3bYNJ52WYre6gLMu4K+Ghd02og+ILgIio\n\tQ827h0spqIJYHrR3Ynnhxdlv5GPCobh+AKsQMdTIuCzR6JSCBk6GHkg33SiWScKMUzT8B/cn\n\typLfGnfV/LDZ9wS2TMzIlK/uv0Vd4C0OGDd/GCi5Gwu/Ot0aY7fzZo2CiRV+/nJBWPRRBTji\n\tbE4FG2rt7WSRLO/QmH2meIW4f0USDiHeNwznHkPei59vRdlMyQdsxrmgSRDuX9Y3UkERxbgd\n\tuscqC8Cpcy5kpF11EW91J8aGpcxASc+5Pa66/+7CrpBC2DnfcfACdMAje7yeMn9XlHrqXNlQ\n\tGaglEcnGN2qVqRcKgcjJX+ur8l56BVpBPFYQYkYkIdQAuhlPylxOvsMcqI6VoEWNt0iFF3dA\n\t//0MNb8fEqw5TlxDPOt6BDhDKowkxOGIA9LOcF4PkaR9Qkvwo2P4vA/8fhCnMqlSPom4xYdk\n\tEv8P554zDoL/XMHl+s7A0MjIJzT253ejZKlWeO68pAbNy/z7QRn2lFDnjwkQwH6sKPchYl2f\n\t0g//Yu3vDkqk8+mi2letP3XBl2hjv2eCZjTh34VvtgY5oeL2ROSJWNd18+7O6q3hECZ727EW\n\tgIb3LK9g4mKF6+Rch6Gwz1Y4fmC5554fd2Y2XbVzzz6AGUC6Y+ohNg7lTAVO4wu43+IyTB8u\n\tip5rX/JDGFv7Y1sl6tQJKAVIKAJE+Z3Ncqh3doQr9wWHl0UiQYKbSR9HpH1lmC1C3EEbTpwK\n\tfUIpZd1eQNyNJl1jHsZZIBYFsAfVNH/u6lB1TU+9bSOsV5SepdIb88d0fm3oZ4KzjhRHLFQF\n\tRwNUNn3ha6x4fbxYcwbvu5ZCiiX6yRTPoage/LUNkgQNX2PtPcur6CdxK6Pqm8EAI7PmYLfN\n\tNY3y01XhKNRvaVZoH2FugfUkhsBITglTIpI+n6YU06nDAcbeINFo67TSE0iL6Pek5a6gUQQC\n\t6w+hJCaMr8KYud0q3ccHyU3TlAPDe10En3GsVz7Y5Sa3ODGdbmkfjK8Af3ogGNBVmpV16Xl8\n\t4rETFv7POSUB2eMtbpmBopd+wKqHCwUEy3fx1zDbM9mp+pcDoL73rRZmlgmNfW/4o4qBzxRf\n\tFYTQLE69wAFU2IFce9PjtUAlBdC+6r3X24h3uD+EC37s/vWhxuKj2glaU9ONrVJ/SPvlqXOO\n\tWR1Zqw57vHMKimLdG3c24l8PkSw1usudgAA5OyO5Ag0EWY4wyQEQAMVp0U38Le7d80Mu6AT+\n\t1dMes87iKn30TdMuLvSg2uYqJ1T2riRBF7zU6u74HF6zps0rPQviBXOgoSuKa1hnS6OwFb9x\n\tyQPlk76LY96SUB5jPWJ3fO78ZGSwkVbJFuG9gpD/41n8Unn1hXgDb2gUaxD0oXv/723EmTYC\n\tvSo3z6Y8A2aBQNr+PyhQAPDazvVQ+P7vnZYq1oK0w+D7aIix/Bp4mo4VbgAeAeMxXWSZs8N5\n\tNQtXeTBgB7DqrfJP5wWwgCsROfeds6EoddcYgqhG0zVU9E54C8JcPOA0wKVs+9+gt2eyRNtx\n\t0UhFbah7qXuJGhWy/0CLXvVoCoS+7qpWz070TBAlPZrg9D0o2gOw01trQgoKAYBKKgJhxaX/\n\t4gzi+5Ccm33LYH9lAVTdzdorejuV1xWdsnNyc8OAPeoXBf9RIIWfQVmbhVXBp2DAPjV6/kIJ\n\tEml7MNJfEvqjV9zKsWF9AFlsqDWZDCyUdqR96ahTSD34pRwb6a9H99/GrjeowKaaL95DIVZT\n\tC6STvDNL6kpys4sOe2AMmQGv2MMcJB3aYLzH8f1sEQ9S0UMX7/6CifEG6JodG6Y/W/lLo1Vv\n\tDxeDA+u4Lgq6qxlksp8M78FjcmxFVlf4cpCi2ucbZxurhlBkjtZZ8MVAEde3hlqjcBl2Ah6Q\n\tD826FTxscOGlHEfNABEBAAGJAjwEGAEKACYCGwwWIQSofQA6zrItXEgHWTzAfqwo9yFiXQUC\n\tXEz31QUJBKaOuQAKCRDAfqwo9yFiXUvnEACBWe8wSnIvSX+9k4LxuLq6GQTOt+RNfliZQkCW\n\t5lT3KL1IJyzzOm4x+/slHRBl8bF7KEZyOPinXQXyJ/vgIdgSYxDqoZ7YZn3SvuNe4aT6kGwL\n\tEYYEV8Ecj4ets15FR2jSUNnVv5YHWtZ7bP/oUzr2LT54fjRcstYxgwzoj8AREtHQ4EJWAWCO\n\tZuEHTSm5clMFoi41CmG4DlJbzbo4YfilKYm69vwh50Y8WebcRN31jh0g8ufjOJnBldYYBLwN\n\tObymhlfy/HKBDIbyCGBuwYoAkoJ6LR/cqzl/FuhwhuDocCGlXyYaJOwXgHaCvVXI3PLQPxWZ\n\t+vPsD+TSVHc9m/YWrOiYDnZn6aO0Uk1Zv/m9+BBkWAwsreLJ/evn3SsJV1omNBTITG+uxXcf\n\tJkgmmesIAw8mpI6EeLmReUJLasz8QkzhZIC7t5rGlQI94GQG3Jg2dC+kpaGWOaT5G4FVMcBj\n\tiR1nXfMxENVYnM5ag7mBZyD/kru5W1Uj34L6AFaDMXFPwedSCpzzqUiHb0f+nYkfOodf5xy0\n\t46+3THy/NUS/ZZp/rI4F7Y77+MQPVg7vARfHHX1AxYUKfRVW5j88QUB70txn8Vgi1tDrOr4J\n\teD+xr0CvIGa5lKqgQacQtGkpOpJ8zY4ObSvpNubey/qYUE3DCXD0n2Xxk4muTvqlkFpOYA==","Message-ID":"<ed8fd8cd-7d0e-d23d-9c36-dfa94e00dd73@collabora.com>","Date":"Fri, 17 Jan 2020 17:01:48 -0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.3.0","MIME-Version":"1.0","In-Reply-To":"<20200117160009.GB1074550@oden.dyn.berto.se>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH v2 2/2] utils: rkisp1: sync topology\n\twith upstream driver in capture script","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Fri, 17 Jan 2020 20:01:56 -0000"}},{"id":3497,"web_url":"https://patchwork.libcamera.org/comment/3497/","msgid":"<20200117224253.GK1074550@oden.dyn.berto.se>","date":"2020-01-17T22:42:53","subject":"Re: [libcamera-devel] [PATCH v2 2/2] utils: rkisp1: sync topology\n\twith upstream driver in capture script","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Helen,\n\nOn 2020-01-17 17:01:48 -0300, Helen Koike wrote:\n> \n> \n> On 1/17/20 2:00 PM, Niklas Söderlund wrote:\n> > Hi Helen,\n> > \n> > Thanks for your patch.\n> > \n> > On 2020-01-17 11:58:02 -0300, Helen Koike wrote:\n> >> rkisp1 kernel driver was merged upstream with minor changes in the\n> >> topology from the original driver libcamera based it's first support to\n> >> rkisp1.\n> >>\n> >> Adapt libcamera capture script to work with upstream driver.\n> > \n> > How did you test this patch? I tried running the script as such:\n> > \n> > $ ./rkisp1-capture.sh --no-save -s 1296x972 \"ov5695 7-0036\"\n> > Capturing 1296x972 from sensor ov5695 7-0036 in SBGGR10_1X10\n> > Configuring pipeline for ov5695 7-0036 in fmt:SBGGR10_1X10/1296x972\n> > Device /dev/video0 opened.\n> > Device `rkisp1' on `platform:rkisp1' (driver 'rkisp1') supports video, \n> > capture, with mplanes.\n> > Video format set: YUYV (56595559) 1296x972 field none, 1 planes: \n> >  * Stride 2592, buffer size 2519424\n> >  Video format: YUYV (56595559) 1296x972 field none, 1 planes: \n> >   * Stride 2592, buffer size 2519424\n> >   5 buffers requested.\n> >   length: 1 offset: 4215579600 timestamp type/source: mono/EoF\n> >   Buffer 0/0 mapped at address 0x7f8bdb5000.\n> >   length: 1 offset: 4215579600 timestamp type/source: mono/EoF\n> >   Buffer 1/0 mapped at address 0x7f8bb4d000.\n> >   length: 1 offset: 4215579600 timestamp type/source: mono/EoF\n> >   Buffer 2/0 mapped at address 0x7f8b8e5000.\n> >   length: 1 offset: 4215579600 timestamp type/source: mono/EoF\n> >   Buffer 3/0 mapped at address 0x7f8b67d000.\n> >   length: 1 offset: 4215579600 timestamp type/source: mono/EoF\n> >   Buffer 4/0 mapped at address 0x7f8b415000.\n> > \n> > But I get no buffers back and yavta stops here and have to be killed.\n> \n> This is because I was testing other things and forgot this like that\n> enable a link (sorry about that):\n> \n> $mediactl -l \"'rkisp1_resizer_mainpath':1 -> 'rkisp1_mainpath':0 [1]\"\n\nNo worries.\n\n> \n> In any case there is a bug in the driver, it shouldn't stall, it should fail\n> in link validation.\n> \n> Also, the driver allows too many links to be disabled (which doesn't make\n> sense). Hold this patchset a bit, let me send a patch making almost all\n> links immutable, so the line above won't be required.\n\nThis also effects the pipeline handler patch, do you want to hold that \npatch too? Or would you prefer we try and merge both patches in this \nseries (with the fix for the script) now and then you can send a follow \nup series when the immutable link fixes are merged in the media-tree?\n\n> \n> Helen\n> \n> > \n> >>\n> >> * Remove subdevice dphy from the pipeline.\n> >> * Add resizer in the pipeline.\n> >> * Fix links.\n> >> * Update entity names.\n> >>\n> >> Signed-off-by: Helen Koike <helen.koike@collabora.com>\n> >>\n> >> ---\n> >>\n> >> changes in v2:\n> >> * New commit (splitted from previous one)\n> >> ---\n> >>  utils/rkisp1/rkisp1-capture.sh | 16 ++++++++--------\n> >>  1 file changed, 8 insertions(+), 8 deletions(-)\n> >>\n> >> diff --git a/utils/rkisp1/rkisp1-capture.sh b/utils/rkisp1/rkisp1-capture.sh\n> >> index cffe9fe..4d09f5d 100755\n> >> --- a/utils/rkisp1/rkisp1-capture.sh\n> >> +++ b/utils/rkisp1/rkisp1-capture.sh\n> >> @@ -68,14 +68,14 @@ configure_pipeline() {\n> >>  \n> >>  \t$mediactl -r\n> >>  \n> >> -\t$mediactl -l \"'$sensor':0 -> 'rockchip-sy-mipi-dphy':0 [1]\"\n> >> -\t$mediactl -l \"'rockchip-sy-mipi-dphy':1 -> 'rkisp1-isp-subdev':0 [1]\"\n> >> -\t$mediactl -l \"'rkisp1-isp-subdev':2 -> 'rkisp1_mainpath':0 [1]\"\n> >> +\t$mediactl -l \"'$sensor':0 -> 'rkisp1_isp':0 [1]\"\n> >> +\t$mediactl -l \"'rkisp1_isp':2 -> 'rkisp1_resizer_mainpath':0 [1]\"\n> >>  \n> >>  \t$mediactl -V \"\\\"$sensor\\\":0 [$format]\"\n> >> -\t$mediactl -V \"'rockchip-sy-mipi-dphy':1 [$format]\"\n> >> -\t$mediactl -V \"'rkisp1-isp-subdev':0 [$format crop:(0,0)/$sensor_size]\"\n> >> -\t$mediactl -V \"'rkisp1-isp-subdev':2 [fmt:$capture_mbus_code/$capture_size crop:(0,0)/$capture_size]\"\n> >> +\t$mediactl -V \"'rkisp1_isp':0 [$format crop:(0,0)/$sensor_size]\"\n> >> +\t$mediactl -V \"'rkisp1_isp':2 [fmt:$capture_mbus_code/$sensor_size crop:(0,0)/$sensor_size]\"\n> >> +\t$mediactl -V \"'rkisp1_resizer_mainpath':0 [fmt:$capture_mbus_code/$sensor_size crop:(0,0)/$sensor_size]\"\n> >> +\t$mediactl -V \"'rkisp1_resizer_mainpath':1 [fmt:$capture_mbus_code/$capture_size]\"\n> >>  }\n> >>  \n> >>  # Capture frames\n> >> @@ -161,8 +161,8 @@ fi\n> >>  \n> >>  sensor_name=$1\n> >>  \n> >> -modprobe mipi_dphy_sy\n> >> -modprobe video_rkisp1\n> >> +modprobe phy_rockchip_dphy_rx0\n> >> +modprobe rockchip_isp1\n> >>  \n> >>  sensor=$(find_sensor $sensor_name) || exit\n> >>  mdev=$(find_media_device rkisp1) || exit\n> >> -- \n> >> 2.24.0\n> >>\n> >","headers":{"Return-Path":"<niklas.soderlund@ragnatech.se>","Received":["from mail-lf1-x141.google.com (mail-lf1-x141.google.com\n\t[IPv6:2a00:1450:4864:20::141])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B684560792\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 17 Jan 2020 23:42:54 +0100 (CET)","by mail-lf1-x141.google.com with SMTP id n25so19570576lfl.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 17 Jan 2020 14:42:54 -0800 (PST)","from localhost (h-93-159.A463.priv.bahnhof.se. [46.59.93.159])\n\tby smtp.gmail.com with ESMTPSA id\n\tr20sm12611881lfi.91.2020.01.17.14.42.53\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 17 Jan 2020 14:42:53 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=lBX2Vdks5Sx28Z/M+D95THfX1lnyCnCFEBU2MVxEptI=;\n\tb=zBGsk0YFlIEj3PNDFR9w+3KKqkXS/oQKU8nDa8t1/n/7hPcrzvo0jhr2qmnkC07s9+\n\tjB7HM2f7/HPBQRi7TGVhugzEge93rSg9nXu/friQNb/HFNJ1PAnmRcs9gQBWgS/txtc2\n\tLClfGgN3baBaHz4QM8ygRdkaCvq8S2arnsvc3GRW7aRHxKEXekuv2Tkp+xK3RzWnK0Vs\n\t1Z3qKnqQoLiizFd4Mr3hcNk4k1CxJLkjCZTbAbp477QfCu4UFm3Ua9mQremeV8X+aK/b\n\tqtixKEXmwODybyyDNi8uWekOS8RpVvVuNf2R+yh2DlP1lO1iySACiuooANADcNSZ+QPo\n\t6uMg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=lBX2Vdks5Sx28Z/M+D95THfX1lnyCnCFEBU2MVxEptI=;\n\tb=RhurcIIzoR1qkGGPPx1di3EH4sJ7rpLSaJ9HhVRQPi1m6ZE7wYyltipllfOQEmeHXa\n\tHsuXHNgbmS0PEog0CrC8LRSGi+2xyJl15osyHx7vlaHafwhLSF467ZssL6HrvKPsu1Oe\n\tJoIpreccxLg1fXGYbDzFWwTT9zc8+d7+Fh2Ngrl+Di+9QF7gya/TkAfNH3jDI2UVnZ/l\n\tthFZMMvageWbdvVrLF5elaNF3SuwWBxmFQ1SarisPAYgB41uXIZE9rPqR8lKcw3yytoZ\n\tQRh5XMOV73H+Gh0B5dk/hKxExW2iMUzrW9ugvSRlAtxKUtwDpWRF+vvgki+TLW51Koz6\n\tj6Gg==","X-Gm-Message-State":"APjAAAUr1T/yTAteDppQYzVmHF04XUdxVy0XL47uH+RDeMQGJY/RvbWY\n\tt+BgcvAQ6k+ZC5ofxBwFCk0BcQ==","X-Google-Smtp-Source":"APXvYqzbq2dFn+RJGLK6de8RPDw9+ZfFajgh/frHPY/W+VPOkPJW+IeUujaPCZMoFN54usepKcFt5A==","X-Received":"by 2002:a05:6512:307:: with SMTP id\n\tt7mr6627845lfp.201.1579300974135; \n\tFri, 17 Jan 2020 14:42:54 -0800 (PST)","Date":"Fri, 17 Jan 2020 23:42:53 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= <niklas.soderlund@ragnatech.se>","To":"Helen Koike <helen.koike@collabora.com>","Cc":"libcamera-devel@lists.libcamera.org, laurent.pinchart@ideasonboard.com, \n\tkernel@collabora.com, heiko@sntech.de, tfiga@chromium.org,\n\tjoacim.zetterling@gmail.com","Message-ID":"<20200117224253.GK1074550@oden.dyn.berto.se>","References":"<20200117145802.3322874-1-helen.koike@collabora.com>\n\t<20200117145802.3322874-2-helen.koike@collabora.com>\n\t<20200117160009.GB1074550@oden.dyn.berto.se>\n\t<ed8fd8cd-7d0e-d23d-9c36-dfa94e00dd73@collabora.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<ed8fd8cd-7d0e-d23d-9c36-dfa94e00dd73@collabora.com>","Subject":"Re: [libcamera-devel] [PATCH v2 2/2] utils: rkisp1: sync topology\n\twith upstream driver in capture script","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Fri, 17 Jan 2020 22:42:54 -0000"}},{"id":3519,"web_url":"https://patchwork.libcamera.org/comment/3519/","msgid":"<3976335e-4350-6e5d-7dae-186451e8d14b@collabora.com>","date":"2020-01-19T15:24:22","subject":"Re: [libcamera-devel] [PATCH v2 2/2] utils: rkisp1: sync topology\n\twith upstream driver in capture script","submitter":{"id":20,"url":"https://patchwork.libcamera.org/api/people/20/","name":"Helen Koike","email":"helen.koike@collabora.com"},"content":"On 1/17/20 8:42 PM, Niklas Söderlund wrote:\n> Hi Helen,\n> \n> On 2020-01-17 17:01:48 -0300, Helen Koike wrote:\n>>\n>>\n>> On 1/17/20 2:00 PM, Niklas Söderlund wrote:\n>>> Hi Helen,\n>>>\n>>> Thanks for your patch.\n>>>\n>>> On 2020-01-17 11:58:02 -0300, Helen Koike wrote:\n>>>> rkisp1 kernel driver was merged upstream with minor changes in the\n>>>> topology from the original driver libcamera based it's first support to\n>>>> rkisp1.\n>>>>\n>>>> Adapt libcamera capture script to work with upstream driver.\n>>>\n>>> How did you test this patch? I tried running the script as such:\n>>>\n>>> $ ./rkisp1-capture.sh --no-save -s 1296x972 \"ov5695 7-0036\"\n>>> Capturing 1296x972 from sensor ov5695 7-0036 in SBGGR10_1X10\n>>> Configuring pipeline for ov5695 7-0036 in fmt:SBGGR10_1X10/1296x972\n>>> Device /dev/video0 opened.\n>>> Device `rkisp1' on `platform:rkisp1' (driver 'rkisp1') supports video, \n>>> capture, with mplanes.\n>>> Video format set: YUYV (56595559) 1296x972 field none, 1 planes: \n>>>  * Stride 2592, buffer size 2519424\n>>>  Video format: YUYV (56595559) 1296x972 field none, 1 planes: \n>>>   * Stride 2592, buffer size 2519424\n>>>   5 buffers requested.\n>>>   length: 1 offset: 4215579600 timestamp type/source: mono/EoF\n>>>   Buffer 0/0 mapped at address 0x7f8bdb5000.\n>>>   length: 1 offset: 4215579600 timestamp type/source: mono/EoF\n>>>   Buffer 1/0 mapped at address 0x7f8bb4d000.\n>>>   length: 1 offset: 4215579600 timestamp type/source: mono/EoF\n>>>   Buffer 2/0 mapped at address 0x7f8b8e5000.\n>>>   length: 1 offset: 4215579600 timestamp type/source: mono/EoF\n>>>   Buffer 3/0 mapped at address 0x7f8b67d000.\n>>>   length: 1 offset: 4215579600 timestamp type/source: mono/EoF\n>>>   Buffer 4/0 mapped at address 0x7f8b415000.\n>>>\n>>> But I get no buffers back and yavta stops here and have to be killed.\n>>\n>> This is because I was testing other things and forgot this like that\n>> enable a link (sorry about that):\n>>\n>> $mediactl -l \"'rkisp1_resizer_mainpath':1 -> 'rkisp1_mainpath':0 [1]\"\n> \n> No worries.\n> \n>>\n>> In any case there is a bug in the driver, it shouldn't stall, it should fail\n>> in link validation.\n>>\n>> Also, the driver allows too many links to be disabled (which doesn't make\n>> sense). Hold this patchset a bit, let me send a patch making almost all\n>> links immutable, so the line above won't be required.\n> \n> This also effects the pipeline handler patch, do you want to hold that \n> patch too? Or would you prefer we try and merge both patches in this \n> series (with the fix for the script) now and then you can send a follow \n> up series when the immutable link fixes are merged in the media-tree?\n\nThe immutable patch is really small, I was hoping it wouldn't take long to be\naccepted, so I think we can wait a few days.\n\nI was also thinking if we could make the function link->setEnabled(true) not\nfail if the link is immutable, so the pipeline patch would work with\nor without the immutable fix in the driver. But I see that setupLink() just\nmake the MEDIA_IOC_SETUP_LINK ioctl and it would complicate the function a bit.\n\nHelen\n\n> \n>>\n>> Helen\n>>\n>>>\n>>>>\n>>>> * Remove subdevice dphy from the pipeline.\n>>>> * Add resizer in the pipeline.\n>>>> * Fix links.\n>>>> * Update entity names.\n>>>>\n>>>> Signed-off-by: Helen Koike <helen.koike@collabora.com>\n>>>>\n>>>> ---\n>>>>\n>>>> changes in v2:\n>>>> * New commit (splitted from previous one)\n>>>> ---\n>>>>  utils/rkisp1/rkisp1-capture.sh | 16 ++++++++--------\n>>>>  1 file changed, 8 insertions(+), 8 deletions(-)\n>>>>\n>>>> diff --git a/utils/rkisp1/rkisp1-capture.sh b/utils/rkisp1/rkisp1-capture.sh\n>>>> index cffe9fe..4d09f5d 100755\n>>>> --- a/utils/rkisp1/rkisp1-capture.sh\n>>>> +++ b/utils/rkisp1/rkisp1-capture.sh\n>>>> @@ -68,14 +68,14 @@ configure_pipeline() {\n>>>>  \n>>>>  \t$mediactl -r\n>>>>  \n>>>> -\t$mediactl -l \"'$sensor':0 -> 'rockchip-sy-mipi-dphy':0 [1]\"\n>>>> -\t$mediactl -l \"'rockchip-sy-mipi-dphy':1 -> 'rkisp1-isp-subdev':0 [1]\"\n>>>> -\t$mediactl -l \"'rkisp1-isp-subdev':2 -> 'rkisp1_mainpath':0 [1]\"\n>>>> +\t$mediactl -l \"'$sensor':0 -> 'rkisp1_isp':0 [1]\"\n>>>> +\t$mediactl -l \"'rkisp1_isp':2 -> 'rkisp1_resizer_mainpath':0 [1]\"\n>>>>  \n>>>>  \t$mediactl -V \"\\\"$sensor\\\":0 [$format]\"\n>>>> -\t$mediactl -V \"'rockchip-sy-mipi-dphy':1 [$format]\"\n>>>> -\t$mediactl -V \"'rkisp1-isp-subdev':0 [$format crop:(0,0)/$sensor_size]\"\n>>>> -\t$mediactl -V \"'rkisp1-isp-subdev':2 [fmt:$capture_mbus_code/$capture_size crop:(0,0)/$capture_size]\"\n>>>> +\t$mediactl -V \"'rkisp1_isp':0 [$format crop:(0,0)/$sensor_size]\"\n>>>> +\t$mediactl -V \"'rkisp1_isp':2 [fmt:$capture_mbus_code/$sensor_size crop:(0,0)/$sensor_size]\"\n>>>> +\t$mediactl -V \"'rkisp1_resizer_mainpath':0 [fmt:$capture_mbus_code/$sensor_size crop:(0,0)/$sensor_size]\"\n>>>> +\t$mediactl -V \"'rkisp1_resizer_mainpath':1 [fmt:$capture_mbus_code/$capture_size]\"\n>>>>  }\n>>>>  \n>>>>  # Capture frames\n>>>> @@ -161,8 +161,8 @@ fi\n>>>>  \n>>>>  sensor_name=$1\n>>>>  \n>>>> -modprobe mipi_dphy_sy\n>>>> -modprobe video_rkisp1\n>>>> +modprobe phy_rockchip_dphy_rx0\n>>>> +modprobe rockchip_isp1\n>>>>  \n>>>>  sensor=$(find_sensor $sensor_name) || exit\n>>>>  mdev=$(find_media_device rkisp1) || exit\n>>>> -- \n>>>> 2.24.0\n>>>>\n>>>\n>","headers":{"Return-Path":"<helen.koike@collabora.com>","Received":["from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4139A60454\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 19 Jan 2020 16:24:28 +0100 (CET)","from [IPv6:2804:431:e7cc:d244:9e0a:75ab:540f:cbbe] (unknown\n\t[IPv6:2804:431:e7cc:d244:9e0a:75ab:540f:cbbe])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits))\n\t(No client certificate requested) (Authenticated sender: koike)\n\tby bhuna.collabora.co.uk (Postfix) with ESMTPSA id B0A6028C5A3;\n\tSun, 19 Jan 2020 15:24:25 +0000 (GMT)"],"To":"=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>","Cc":"libcamera-devel@lists.libcamera.org, laurent.pinchart@ideasonboard.com, \n\tkernel@collabora.com, heiko@sntech.de, tfiga@chromium.org,\n\tjoacim.zetterling@gmail.com","References":"<20200117145802.3322874-1-helen.koike@collabora.com>\n\t<20200117145802.3322874-2-helen.koike@collabora.com>\n\t<20200117160009.GB1074550@oden.dyn.berto.se>\n\t<ed8fd8cd-7d0e-d23d-9c36-dfa94e00dd73@collabora.com>\n\t<20200117224253.GK1074550@oden.dyn.berto.se>","From":"Helen Koike <helen.koike@collabora.com>","Autocrypt":"addr=helen.koike@collabora.com; keydata=\n\tmQINBFmOMD4BEADb2nC8Oeyvklh+ataw2u/3mrl+hIHL4WSWtii4VxCapl9+zILuxFDrxw1p\n\tXgF3cfx7g9taWBrmLE9VEPwJA6MxaVnQuDL3GXxTxO/gqnOFgT3jT+skAt6qMvoWnhgurMGH\n\twRaA3dO4cFrDlLsZIdDywTYcy7V2bou81ItR5Ed6c5UVX7uTTzeiD/tUi8oIf0XN4takyFuV\n\tRf09nOhi24bn9fFN5xWHJooFaFf/k2Y+5UTkofANUp8nn4jhBUrIr6glOtmE0VT4pZMMLT63\n\thyRB+/s7b1zkOofUGW5LxUg+wqJXZcOAvjocqSq3VVHcgyxdm+Nv0g9Hdqo8bQHC2KBK86VK\n\tvB+R7tfv7NxVhG1sTW3CQ4gZb0ZugIWS32Mnr+V+0pxci7QpV3jrtVp5W2GA5HlXkOyC6C7H\n\tAo7YhogtvFehnlUdG8NrkC3HhCTF8+nb08yGMVI4mMZ9v/KoIXKC6vT0Ykz434ed9Oc9pDow\n\tVUqaKi3ey96QczfE4NI029bmtCY4b5fucaB/aVqWYRH98Jh8oIQVwbt+pY7cL5PxS7dQ/Zuz\n\t6yheqDsUGLev1O3E4R8RZ8jPcfCermL0txvoXXIA56t4ZjuHVcWEe2ERhLHFGq5Zw7KC6u12\n\tkJoiZ6WDBYo4Dp+Gd7a81/WsA33Po0j3tk/8BWoiJCrjXzhtRwARAQABtCdIZWxlbiBLb2lr\n\tZSA8aGVsZW4ua29pa2VAY29sbGFib3JhLmNvbT6JAlQEEwEKAD4CGwEFCwkIBwMFFQoJCAsF\n\tFgIDAQACHgECF4AWIQSofQA6zrItXEgHWTzAfqwo9yFiXQUCXEz3bwUJBKaPRQAKCRDAfqwo\n\t9yFiXdUCD/4+WZr503hQ13KB4DijOW76ju8JDPp4p++qoPxtoAsld3yROoTI+VPWmt7ojHrr\n\tTZc7sTLxOFzaUC8HjGTb3r9ilIhIKf/M9KRLkpIJ+iLA+VoUbcSOMYWoVNfgLmbnqoezjPcy\n\tOHJwVw9dzEeYpvG6nkY6E4UktANySp27AniSXNuHOvYsOsXmUOqU1ScdsrQ9s732p/OGdTyw\n\t1yd3gUMLZvCKFOBVHILH59HCRJgpwUPiws8G4dGMs4GTRvHT2s2mDQdQ0HEvcM9rvCRVixuC\n\t5ZeOymZNi6lDIUIysgiZ+yzk6i5l/Ni6r7v20N3JppZvhPK6LqtaYceyAGyc3jjnOqoHT/qR\n\tkPjCwzmKiPtXjLw6HbRXtGgGtP5m3y8v6bfHH+66zd2vGCY0Z9EsqcnK4DCqRkLncFLPM2gn\n\t9cZcCmO4ZqXUhTyn1nHM494kd5NX1Op4HO+t9ErnpufkVjoMUeBwESdQwwwHT3rjUueGmCrn\n\tVJK69/qhA4La72VTxHutl+3Z0Xy20HWsZS8Gsam39f95/LtPLzbBwnOOi5ZoXnm97tF8HrAZ\n\t2h+kcRLMWw3BXy5q4gic+oFZMZP9oq1G9XTFld4FGgJ9ys8aGmhLM+uB1pFxb3XFtWQ2z4AJ\n\tiEp2VLl34quwfD6Gg4csiZe2KzvQHUe0w8SJ9LplrHPPprkCDQRZjjChARAAzISLQaHzaDOv\n\tZxcoCNBk/hUGo2/gsmBW4KSj73pkStZ+pm3Yv2CRtOD4jBlycXjzhwBV7/70ZMH70/Y25dJa\n\tCnJKl/Y76dPPn2LDWrG/4EkqUzoJkhRIYFUTpkPdaVYznqLgsho19j7HpEbAum8r3jemYBE1\n\tAIuVGg4bqY3UkvuHWLVRMuaHZNy55aYwnUvd46E64JH7O990mr6t/nu2a1aJ0BDdi8HZ0RMo\n\tEg76Avah+YR9fZrhDFmBQSL+mcCVWEbdiOzHmGYFoToqzM52wsNEpo2aStH9KLk8zrCXGx68\n\tohJyQoALX4sS03RIWh1jFjnlw2FCbEdj/HDX0+U0i9COtanm54arYXiBTnAnx0F7LW7pv7sb\n\t6tKMxsMLmprP/nWyV5AfFRi3jxs5tdwtDDk/ny8WH6KWeLR/zWDwpYgnXLBCdg8l97xUoPQO\n\t0VkKSa4JEXUZWZx9q6kICzFGsuqApqf9gIFJZwUmirsxH80Fe04Tv+IqIAW7/djYpOqGjSyk\n\toaEVNacwLLgZr+/j69/1ZwlbS8K+ChCtyBV4kEPzltSRZ4eU19v6sDND1JSTK9KSDtCcCcAt\n\tVGFlr4aE00AD/aOkHSylc93nPinBFO4AGhcs4WypZ3GGV6vGWCpJy9svfWsUDhSwI7GS/i/v\n\tUQ1+bswyYEY1Q3DjJqT7fXcAEQEAAYkEcgQYAQoAJgIbAhYhBKh9ADrOsi1cSAdZPMB+rCj3\n\tIWJdBQJcTPfVBQkEpo7hAkDBdCAEGQEKAB0WIQSomGMEg78Cd/pMshveCRfNeJ05lgUCWY4w\n\toQAKCRDeCRfNeJ05lp0gD/49i95kPKjpgjUbYeidjaWuINXMCA171KyaBAp+Jp2Qrun4sIJB\n\tZ6srMj6O/gC34AhZln2sXeQdxe88sNbg6HjlN+4AkhTd6DttjOfUwnamLDA7uw+YIapGgsgN\n\tlznjLnqOaQ9mtEwRbZMUOdyRf9osSuL14vHl4ia3bYNJ52WYre6gLMu4K+Ghd02og+ILgIio\n\tQ827h0spqIJYHrR3Ynnhxdlv5GPCobh+AKsQMdTIuCzR6JSCBk6GHkg33SiWScKMUzT8B/cn\n\typLfGnfV/LDZ9wS2TMzIlK/uv0Vd4C0OGDd/GCi5Gwu/Ot0aY7fzZo2CiRV+/nJBWPRRBTji\n\tbE4FG2rt7WSRLO/QmH2meIW4f0USDiHeNwznHkPei59vRdlMyQdsxrmgSRDuX9Y3UkERxbgd\n\tuscqC8Cpcy5kpF11EW91J8aGpcxASc+5Pa66/+7CrpBC2DnfcfACdMAje7yeMn9XlHrqXNlQ\n\tGaglEcnGN2qVqRcKgcjJX+ur8l56BVpBPFYQYkYkIdQAuhlPylxOvsMcqI6VoEWNt0iFF3dA\n\t//0MNb8fEqw5TlxDPOt6BDhDKowkxOGIA9LOcF4PkaR9Qkvwo2P4vA/8fhCnMqlSPom4xYdk\n\tEv8P554zDoL/XMHl+s7A0MjIJzT253ejZKlWeO68pAbNy/z7QRn2lFDnjwkQwH6sKPchYl2f\n\t0g//Yu3vDkqk8+mi2letP3XBl2hjv2eCZjTh34VvtgY5oeL2ROSJWNd18+7O6q3hECZ727EW\n\tgIb3LK9g4mKF6+Rch6Gwz1Y4fmC5554fd2Y2XbVzzz6AGUC6Y+ohNg7lTAVO4wu43+IyTB8u\n\tip5rX/JDGFv7Y1sl6tQJKAVIKAJE+Z3Ncqh3doQr9wWHl0UiQYKbSR9HpH1lmC1C3EEbTpwK\n\tfUIpZd1eQNyNJl1jHsZZIBYFsAfVNH/u6lB1TU+9bSOsV5SepdIb88d0fm3oZ4KzjhRHLFQF\n\tRwNUNn3ha6x4fbxYcwbvu5ZCiiX6yRTPoage/LUNkgQNX2PtPcur6CdxK6Pqm8EAI7PmYLfN\n\tNY3y01XhKNRvaVZoH2FugfUkhsBITglTIpI+n6YU06nDAcbeINFo67TSE0iL6Pek5a6gUQQC\n\t6w+hJCaMr8KYud0q3ccHyU3TlAPDe10En3GsVz7Y5Sa3ODGdbmkfjK8Af3ogGNBVmpV16Xl8\n\t4rETFv7POSUB2eMtbpmBopd+wKqHCwUEy3fx1zDbM9mp+pcDoL73rRZmlgmNfW/4o4qBzxRf\n\tFYTQLE69wAFU2IFce9PjtUAlBdC+6r3X24h3uD+EC37s/vWhxuKj2glaU9ONrVJ/SPvlqXOO\n\tWR1Zqw57vHMKimLdG3c24l8PkSw1usudgAA5OyO5Ag0EWY4wyQEQAMVp0U38Le7d80Mu6AT+\n\t1dMes87iKn30TdMuLvSg2uYqJ1T2riRBF7zU6u74HF6zps0rPQviBXOgoSuKa1hnS6OwFb9x\n\tyQPlk76LY96SUB5jPWJ3fO78ZGSwkVbJFuG9gpD/41n8Unn1hXgDb2gUaxD0oXv/723EmTYC\n\tvSo3z6Y8A2aBQNr+PyhQAPDazvVQ+P7vnZYq1oK0w+D7aIix/Bp4mo4VbgAeAeMxXWSZs8N5\n\tNQtXeTBgB7DqrfJP5wWwgCsROfeds6EoddcYgqhG0zVU9E54C8JcPOA0wKVs+9+gt2eyRNtx\n\t0UhFbah7qXuJGhWy/0CLXvVoCoS+7qpWz070TBAlPZrg9D0o2gOw01trQgoKAYBKKgJhxaX/\n\t4gzi+5Ccm33LYH9lAVTdzdorejuV1xWdsnNyc8OAPeoXBf9RIIWfQVmbhVXBp2DAPjV6/kIJ\n\tEml7MNJfEvqjV9zKsWF9AFlsqDWZDCyUdqR96ahTSD34pRwb6a9H99/GrjeowKaaL95DIVZT\n\tC6STvDNL6kpys4sOe2AMmQGv2MMcJB3aYLzH8f1sEQ9S0UMX7/6CifEG6JodG6Y/W/lLo1Vv\n\tDxeDA+u4Lgq6qxlksp8M78FjcmxFVlf4cpCi2ucbZxurhlBkjtZZ8MVAEde3hlqjcBl2Ah6Q\n\tD826FTxscOGlHEfNABEBAAGJAjwEGAEKACYCGwwWIQSofQA6zrItXEgHWTzAfqwo9yFiXQUC\n\tXEz31QUJBKaOuQAKCRDAfqwo9yFiXUvnEACBWe8wSnIvSX+9k4LxuLq6GQTOt+RNfliZQkCW\n\t5lT3KL1IJyzzOm4x+/slHRBl8bF7KEZyOPinXQXyJ/vgIdgSYxDqoZ7YZn3SvuNe4aT6kGwL\n\tEYYEV8Ecj4ets15FR2jSUNnVv5YHWtZ7bP/oUzr2LT54fjRcstYxgwzoj8AREtHQ4EJWAWCO\n\tZuEHTSm5clMFoi41CmG4DlJbzbo4YfilKYm69vwh50Y8WebcRN31jh0g8ufjOJnBldYYBLwN\n\tObymhlfy/HKBDIbyCGBuwYoAkoJ6LR/cqzl/FuhwhuDocCGlXyYaJOwXgHaCvVXI3PLQPxWZ\n\t+vPsD+TSVHc9m/YWrOiYDnZn6aO0Uk1Zv/m9+BBkWAwsreLJ/evn3SsJV1omNBTITG+uxXcf\n\tJkgmmesIAw8mpI6EeLmReUJLasz8QkzhZIC7t5rGlQI94GQG3Jg2dC+kpaGWOaT5G4FVMcBj\n\tiR1nXfMxENVYnM5ag7mBZyD/kru5W1Uj34L6AFaDMXFPwedSCpzzqUiHb0f+nYkfOodf5xy0\n\t46+3THy/NUS/ZZp/rI4F7Y77+MQPVg7vARfHHX1AxYUKfRVW5j88QUB70txn8Vgi1tDrOr4J\n\teD+xr0CvIGa5lKqgQacQtGkpOpJ8zY4ObSvpNubey/qYUE3DCXD0n2Xxk4muTvqlkFpOYA==","Message-ID":"<3976335e-4350-6e5d-7dae-186451e8d14b@collabora.com>","Date":"Sun, 19 Jan 2020 12:24:22 -0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.3.0","MIME-Version":"1.0","In-Reply-To":"<20200117224253.GK1074550@oden.dyn.berto.se>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH v2 2/2] utils: rkisp1: sync topology\n\twith upstream driver in capture script","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Sun, 19 Jan 2020 15:24:28 -0000"}}]