[{"id":38673,"web_url":"https://patchwork.libcamera.org/comment/38673/","msgid":"<177754639465.45302.14153951748790810341@ping.linuxembedded.co.uk>","date":"2026-04-30T10:53:14","subject":"Re: [PATCH v1 1/2] libcamera: base: regex: Fix preprocessor check","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2026-04-28 09:45:49)\n> clang has no `maybe-uninitialized` warning, therefore the suppression\n> will generate a compiler error. This was probably hidden by the fact that\n> `__SANITIZE_*__` macros have only been added to clang since llvm 22.\n> \n> Link: https://github.com/llvm/llvm-project/commit/568c23bbd3303518c5056d7f03444dae4fdc8a9c\n> Fixes: b01918978c82 (\"libcamera: v4l2_subdevice: Work around false positive warning\")\n> Signed-off-by: Barnabás Pőcze \n\nReviewed-by: Kieran Bingham \n\n> ---\n> include/libcamera/base/regex.h | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/include/libcamera/base/regex.h b/include/libcamera/base/regex.h\n> index 45f4da8cb..c80cca6fe 100644\n> --- a/include/libcamera/base/regex.h\n> +++ b/include/libcamera/base/regex.h\n> @@ -8,7 +8,7 @@\n> #include \n> \n> #pragma GCC diagnostic push\n> -#if defined __SANITIZE_ADDRESS__ && defined __OPTIMIZE__\n> +#if (defined(__GNUC__) && !defined(__clang__)) && defined __SANITIZE_ADDRESS__ && defined __OPTIMIZE__\n> #pragma GCC diagnostic ignored \"-Wmaybe-uninitialized\"\n> #endif\n> #include \n> -- \n> 2.54.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CA47CBDCB5\n\tfor ;\n\tThu, 30 Apr 2026 10:53:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C16D362FE2;\n\tThu, 30 Apr 2026 12:53:18 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1975C62FC8\n\tfor ;\n\tThu, 30 Apr 2026 12:53:17 +0200 (CEST)","from monstersaurus.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C632E8FA;\n\tThu, 30 Apr 2026 12:51:32 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"aWiYUA+A\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1777546292;\n\tbh=gF3kJnXwmvFbNBPLXrn7t98RpyvbLiabNwDjzVGku6M=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=aWiYUA+Ac/ZRaYuEN+GnA3NO0jvz4dnB6UvTEm4CrXrLWRCjgkUJdUkpu6eq5VkZD\n\tTBNBrLYjcVqyZStwz0OreTXDApgyZAuaX92t4pJJM/IyZ3s7hASVrh46LsYUJ29khL\n\t/Ln5j6HyWLnJp+pW4GtSIDlwdZTDkTxJvEtuEZ48=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20260428084550.91669-1-barnabas.pocze@ideasonboard.com>","References":"<20260428084550.91669-1-barnabas.pocze@ideasonboard.com>","Subject":"Re: [PATCH v1 1/2] libcamera: base: regex: Fix preprocessor check","From":"Kieran Bingham ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 30 Apr 2026 11:53:14 +0100","Message-ID":"<177754639465.45302.14153951748790810341@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]