[{"id":38676,"web_url":"https://patchwork.libcamera.org/comment/38676/","msgid":"<177754692812.45302.3380805788622002416@ping.linuxembedded.co.uk>","date":"2026-04-30T11:02:08","subject":"Re: [PATCH v2] libcamera: Add initial OV02E10 sensor support","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Marcel Berger (2026-04-26 20:37:43)\n> Signed-off-by: Marcel Berger \n> ---\n> Changes in v2:\n\nI'm struggling to find v1 ... was it something posted to the list? \n\nhttps://patchwork.libcamera.org/project/libcamera/list/?submitter=268&archive=both&state=*\nshows that only this v2 patch is available from you, and I'm struggling\nto find a match with the OV02E10 keyword.\n\nhttps://patchwork.libcamera.org/project/libcamera/list/?state=%2A&q=OV02E10&series=&submitter=&delegate=&archive=both\n\nalso only finds this patch.\n\n> - Update the OV02E10 analogue gain model.\n> - Treat gain code 0x10 as 1.0x, resulting in a 1.0x to 15.5x range.\n> - Keep the simple IPA YAML intentionally minimal; image tuning is left for follow-up work.\n\nI'm afraid - I think it would be better to keep the tuning file out of\nthis or separate.\n\n> \n> src/ipa/libipa/camera_sensor_helper.cpp | 18 ++++++++++++++++++\n> src/ipa/simple/data/ov02e10.yaml | 19 +++++++++++++++++++\n> .../sensor/camera_sensor_properties.cpp | 12 ++++++++++++\n> 3 files changed, 49 insertions(+)\n> create mode 100644 src/ipa/simple/data/ov02e10.yaml\n> \n> diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\n> index e3e3e535..bee50ec8 100644\n> --- a/src/ipa/libipa/camera_sensor_helper.cpp\n> +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n> @@ -653,6 +653,24 @@ public:\n> };\n> REGISTER_CAMERA_SENSOR_HELPER(\"imx708\", CameraSensorHelperImx708)\n> \n> +class CameraSensorHelperOv02e10 : public CameraSensorHelper\n> +{\n> +public:\n> + CameraSensorHelperOv02e10()\n> + {\n> + /*\n> + * OV02E10 reports RAW10. The Intel IPU6 HAL configuration uses\n> + * SGRBG10 at 1928x1088 and exposure/gain lag of 2 frames.\n> + *\n> + * The analogue gain model is not yet datasheet-validated.\n> + * Use the common OmniVision 1/128 linear gain model as a\n> + * conservative first approximation.\n> + */\n> + gain_ = AnalogueGainLinear{ 1, 0, 0, 16 };\n> + }\n> +};\n> +REGISTER_CAMERA_SENSOR_HELPER(\"ov02e10\", CameraSensorHelperOv02e10)\n> +\n> class CameraSensorHelperOv2685 : public CameraSensorHelper\n> {\n> public:\n> diff --git a/src/ipa/simple/data/ov02e10.yaml b/src/ipa/simple/data/ov02e10.yaml\n> new file mode 100644\n> index 00000000..fc90ca52\n> --- /dev/null\n> +++ b/src/ipa/simple/data/ov02e10.yaml\n> @@ -0,0 +1,19 @@\n> +# SPDX-License-Identifier: CC0-1.0\n> +%YAML 1.1\n> +---\n> +version: 1\n> +algorithms:\n> + - BlackLevel:\n> + - Awb:\n> + # Color correction matrices can be defined here. The CCM algorithm\n> + # has a significant performance impact, and should only be enabled\n> + # if tuned.\n> + # - Ccm:\n> + # ccms:\n> + # - ct: 6500\n> + # ccm: [ 1, 0, 0,\n> + # 0, 1, 0,\n> + # 0, 0, 1]\n> + - Adjust:\n> + - Agc:\n> +...\n\nWe shouldn't duplicate the uncalibrated just to stop a warning which\ndoesn't add any value.\n\nLets leave this out - and fall back to uncalibrated until someone has a\ncorrect tuning definition for the camera.\n\nRegards\n--\nKieran\n\n\n> diff --git a/src/libcamera/sensor/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp\n> index b217363d..30638836 100644\n> --- a/src/libcamera/sensor/camera_sensor_properties.cpp\n> +++ b/src/libcamera/sensor/camera_sensor_properties.cpp\n> @@ -325,6 +325,18 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> .hblankDelay = 3\n> },\n> } },\n> + { \"ov02e10\", {\n> + .unitCellSize = { 1120, 1120 },\n> + .testPatternModes = {\n> + { controls::draft::TestPatternModeOff, 0 },\n> + },\n> + .sensorDelays = {\n> + .exposureDelay = 2,\n> + .gainDelay = 2,\n> + .vblankDelay = 2,\n> + .hblankDelay = 2\n> + },\n> + } },\n> { \"ov2685\", {\n> .unitCellSize = { 1750, 1750 },\n> .testPatternModes = {\n> -- \n> 2.53.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4E9B3BE173\n\tfor ;\n\tThu, 30 Apr 2026 11:02:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 11D7862FEC;\n\tThu, 30 Apr 2026 13:02:13 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C210562FC8\n\tfor ;\n\tThu, 30 Apr 2026 13:02:10 +0200 (CEST)","from monstersaurus.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7F07C10C;\n\tThu, 30 Apr 2026 13:00:26 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"irvNBD+5\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1777546826;\n\tbh=tOeA954u2G8gweAbbEicftGcmcxovQEXa6FmxHjJqiE=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=irvNBD+5UHstkOXSzcCLAHbv/x29mEslmagXrEtC2vGAXyvv4P2G96lf9eyP+NYnw\n\t5wecFSmtCvmFwl3LRfz4ML9kA+sGLTNG8ZlEXCSBJHN16AmHJ9zuDlNqrsROsccs3M\n\tIvFIQMPwd+g2SS3oArgBgkQYvnwrnMxszs8cexHQ=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20260426193743.107637-1-marbe@gmx.de>","References":"<20260426193743.107637-1-marbe@gmx.de>","Subject":"Re: [PATCH v2] libcamera: Add initial OV02E10 sensor support","From":"Kieran Bingham ","Cc":"Marcel Berger ","To":"Marcel Berger , libcamera-devel@lists.libcamera.org","Date":"Thu, 30 Apr 2026 12:02:08 +0100","Message-ID":"<177754692812.45302.3380805788622002416@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]