{"id":26567,"url":"https://patchwork.libcamera.org/api/patches/26567/?format=json","web_url":"https://patchwork.libcamera.org/patch/26567/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260424200255.356798-8-mzamazal@redhat.com>","date":"2026-04-24T20:02:53","name":"[RFC,v3,7/7] libcamera: software_isp: debayer_egl: Add LSC support","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"b3a2385e909efc8503072c01ecafe0f99d96256c","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/26567/mbox/","series":[{"id":5885,"url":"https://patchwork.libcamera.org/api/series/5885/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5885","date":"2026-04-24T20:02:46","name":"LSC for SoftISP simple pipeline","version":3,"mbox":"https://patchwork.libcamera.org/series/5885/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/26567/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/26567/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F31A9BE173\n\tfor ;\n\tFri, 24 Apr 2026 20:03:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AEF4662FB3;\n\tFri, 24 Apr 2026 22:03:30 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3659062F97\n\tfor ;\n\tFri, 24 Apr 2026 22:03:28 +0200 (CEST)","from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-518-soYW6skoNYi-xhqZfql7zw-1;\n\tFri, 24 Apr 2026 16:03:23 -0400","from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 549ED18003FC; Fri, 24 Apr 2026 20:03:21 +0000 (UTC)","from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.44.32.33])\n\tby mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 6E39C3007572; Fri, 24 Apr 2026 20:03:19 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"XG6mSr+C\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1777061007;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=EbN0C/ahqPlYSlXy9ErgKlw5rLdue4jJfvvG4oUmK6g=;\n\tb=XG6mSr+CMgODg4NubSC0F2wNRy97darGQnCukb7xIoSDTbaozrkRa3ssAt36uABsf3P83E\n\t+K40IM7pj90RaWnHwHh5QIzskQyrS2iJD5Flvm8QNO305j7HhpDNGHnEZttxmbX8cN9jrv\n\tuRQxatUQJfATNktw2BvsKI8P/A9GAvI=","X-MC-Unique":"soYW6skoNYi-xhqZfql7zw-1","X-Mimecast-MFC-AGG-ID":"soYW6skoNYi-xhqZfql7zw_1777061001","From":"Milan Zamazal ","To":"libcamera-devel@lists.libcamera.org","Cc":"Xander Pronk ,\n\tBryan O'Donoghue ,\n\tHans de Goede ,\n\tRick ten Wolde ,\n\tMilan Zamazal ","Subject":"[RFC PATCH v3 7/7] libcamera: software_isp: debayer_egl: Add LSC\n\tsupport","Date":"Fri, 24 Apr 2026 22:02:53 +0200","Message-ID":"<20260424200255.356798-8-mzamazal@redhat.com>","In-Reply-To":"<20260424200255.356798-1-mzamazal@redhat.com>","References":"<20260424200255.356798-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.4","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"E8XOmTRkPvBmB6rjS_2_oMavOqiBq02VbRXs_IF9EXc_1777061001","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","content-type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Xander Pronk \n\nAdd support for passing the LSC table from debayerParams to the shaders.\n\nCo-developed-by: Rick ten Wolde \nSigned-off-by: Rick ten Wolde \nSigned-off-by: Xander Pronk \nSigned-off-by: Milan Zamazal \n---\n src/libcamera/software_isp/debayer_egl.cpp | 25 +++++++++++++++++++++-\n src/libcamera/software_isp/debayer_egl.h | 5 +++++\n 2 files changed, 29 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/software_isp/debayer_egl.cpp b/src/libcamera/software_isp/debayer_egl.cpp\nindex 399915164..77f245b4c 100644\n--- a/src/libcamera/software_isp/debayer_egl.cpp\n+++ b/src/libcamera/software_isp/debayer_egl.cpp\n@@ -111,6 +111,8 @@ int DebayerEGL::getShaderVariableLocations(void)\n \ttextureUniformBayerFirstRed_ = glGetUniformLocation(programId_, \"tex_bayer_first_red\");\n \ttextureUniformProjMatrix_ = glGetUniformLocation(programId_, \"proj_matrix\");\n \n+\ttextureUniformLsc_ = glGetUniformLocation(programId_, \"lsc_tex\");\n+\n \tLOG(Debayer, Debug) << \"vertexIn \" << attributeVertex_ << \" textureIn \" << attributeTexture_\n \t\t\t << \" tex_y \" << textureUniformBayerDataIn_\n \t\t\t << \" ccm \" << ccmUniformDataIn_\n@@ -121,7 +123,8 @@ int DebayerEGL::getShaderVariableLocations(void)\n \t\t\t << \" tex_size \" << textureUniformSize_\n \t\t\t << \" stride_factor \" << textureUniformStrideFactor_\n \t\t\t << \" tex_bayer_first_red \" << textureUniformBayerFirstRed_\n-\t\t\t << \" proj_matrix \" << textureUniformProjMatrix_;\n+\t\t\t << \" proj_matrix \" << textureUniformProjMatrix_\n+\t\t\t << \" lsc \" << textureUniformLsc_;\n \treturn 0;\n }\n \n@@ -140,6 +143,9 @@ int DebayerEGL::initBayerShaders(PixelFormat inputFormat, PixelFormat outputForm\n \t/* Specify GL_OES_EGL_image_external */\n \tegl_.pushEnv(shaderEnv, \"#extension GL_OES_EGL_image_external: enable\");\n \n+\tif (lscEnabled_)\n+\t\tegl_.pushEnv(shaderEnv, \"#define APPLY_LSC\");\n+\n \t/*\n \t * Tell shaders how to re-order output taking account of how the pixels\n \t * are actually stored by EGL.\n@@ -339,6 +345,16 @@ int DebayerEGL::configure(const StreamConfiguration &inputCfg,\n \t */\n \tstats_->setWindow(Rectangle(window_.size()));\n \n+\tif (lscEnabled_) {\n+\t\tconstexpr unsigned int gridSize = DebayerParams::kLscGridSize;\n+\t\teglImageLscLookup_ =\n+\t\t\tstd::make_unique(gridSize,\n+\t\t\t\t\t\t gridSize,\n+\t\t\t\t\t\t gridSize * DebayerParams::kLscBytesPerCell,\n+\t\t\t\t\t\t GL_TEXTURE2,\n+\t\t\t\t\t\t 2);\n+\t}\n+\n \treturn 0;\n }\n \n@@ -478,6 +494,13 @@ void DebayerEGL::setShaderVariableValues(const DebayerParams ¶ms)\n \tglUniformMatrix3fv(ccmUniformDataIn_, 1, GL_FALSE, ccm);\n \tLOG(Debayer, Debug) << \" ccmUniformDataIn_ \" << ccmUniformDataIn_ << \" data \" << params.combinedMatrix;\n \n+\tif (lscEnabled_) {\n+\t\tegl_.createTexture2D(*eglImageLscLookup_, GL_RGB,\n+\t\t\t\t DebayerParams::kLscGridSize, DebayerParams::kLscGridSize,\n+\t\t\t\t params.lscLut.data(), GL_LINEAR);\n+\t\tglUniform1i(textureUniformLsc_, eglImageLscLookup_->texture_unit_uniform_id_);\n+\t}\n+\n \t/*\n \t * 0 = Red, 1 = Green, 2 = Blue\n \t */\ndiff --git a/src/libcamera/software_isp/debayer_egl.h b/src/libcamera/software_isp/debayer_egl.h\nindex 0c700b19d..2efe8deeb 100644\n--- a/src/libcamera/software_isp/debayer_egl.h\n+++ b/src/libcamera/software_isp/debayer_egl.h\n@@ -76,7 +76,10 @@ private:\n \tstd::unique_ptr eglImageBayerIn_;\n \tstd::unique_ptr eglImageBayerOut_;\n \n+\t/* LSC lookup table */\n+\tstd::unique_ptr eglImageLscLookup_;\n \tbool lscEnabled_;\n+\n \t/* Shader parameters */\n \tfloat firstRed_x_;\n \tfloat firstRed_y_;\n@@ -90,6 +93,8 @@ private:\n \n \tGLint textureUniformBayerDataIn_;\n \n+\tGLint textureUniformLsc_;\n+\n \t/* Represent per-frame CCM as a uniform vector of floats 3 x 3 */\n \tGLint ccmUniformDataIn_;\n \n","prefixes":["RFC","v3","7/7"]}