[{"id":3476,"web_url":"https://patchwork.libcamera.org/comment/3476/","msgid":"<0541742e-d884-e439-d960-d2dff2ed4cdc@collabora.com>","date":"2020-01-17T15:00:17","subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: pipeline: rkisp1: sync\n\ttopology with upstream driver","submitter":{"id":20,"url":"https://patchwork.libcamera.org/api/people/20/","name":"Helen Koike","email":"helen.koike@collabora.com"},"content":"On 1/17/20 12:56 PM, Helen Koike wrote:\n> rkisp1 kernel driver was merged upstream with minor changes in the\n> topology from the original driver libcamera based it's first support to\n> rkisp1.\n> \n> Adapt libcamera pipeline to work with upstream driver.\n> \n> * Remove subdevice dphy from the pipeline.\n> * Add resizer in the pipeline.\n> * Fix links.\n> * Update entity names.\n> \n> Signed-off-by: Helen Koike \n\nPlease, ignore this patch, I sent by mistake. Please check v2.\n\nHelen\n\n> \n> ---\n> \n> Changes in v2:\n> * Update rkisp1-capture.sh in a different patch\n> * Fix typos in commit message.\n> * Remove \"receiver\" and \"CSI-2\" reference at:\n> \n> << \" link from sensor '\"\n> << link->source()->entity()->name()\n> - << \"' to CSI-2 receiver\";\n> + << \"' to ISP\";\n> ...\n> \n> - * Enumerate all sensors connected to the ISP receiver and create one\n> + * Enumerate all sensors connected to the ISP and create one\n> ---\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 65 +++++++++++++-----------\n> 1 file changed, 36 insertions(+), 29 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index 389a99c..e25b215 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -207,8 +207,8 @@ private:\n> \tint freeBuffers(Camera *camera);\n> \n> \tMediaDevice *media_;\n> -\tV4L2Subdevice *dphy_;\n> \tV4L2Subdevice *isp_;\n> +\tV4L2Subdevice *resizer_;\n> \tV4L2VideoDevice *video_;\n> \tV4L2VideoDevice *param_;\n> \tV4L2VideoDevice *stat_;\n> @@ -513,7 +513,7 @@ CameraConfiguration::Status RkISP1CameraConfiguration::validate()\n> }\n> \n> PipelineHandlerRkISP1::PipelineHandlerRkISP1(CameraManager *manager)\n> -\t: PipelineHandler(manager), dphy_(nullptr), isp_(nullptr),\n> +\t: PipelineHandler(manager), isp_(nullptr), resizer_(nullptr),\n> \t video_(nullptr), param_(nullptr), stat_(nullptr)\n> {\n> }\n> @@ -523,8 +523,8 @@ PipelineHandlerRkISP1::~PipelineHandlerRkISP1()\n> \tdelete param_;\n> \tdelete stat_;\n> \tdelete video_;\n> +\tdelete resizer_;\n> \tdelete isp_;\n> -\tdelete dphy_;\n> }\n> \n> /* -----------------------------------------------------------------------------\n> @@ -564,7 +564,7 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)\n> \t * Configure the sensor links: enable the link corresponding to this\n> \t * camera and disable all the other sensor links.\n> \t */\n> -\tconst MediaPad *pad = dphy_->entity()->getPadByIndex(0);\n> +\tconst MediaPad *pad = isp_->entity()->getPadByIndex(0);\n> \n> \tfor (MediaLink *link : pad->links()) {\n> \t\tbool enable = link->source()->entity() == sensor->entity();\n> @@ -576,7 +576,7 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)\n> \t\t\t<< (enable ? \"Enabling\" : \"Disabling\")\n> \t\t\t<< \" link from sensor '\"\n> \t\t\t<< link->source()->entity()->name()\n> -\t\t\t<< \"' to CSI-2 receiver\";\n> +\t\t\t<< \"' to ISP\";\n> \n> \t\tret = link->setEnabled(enable);\n> \t\tif (ret < 0)\n> @@ -596,16 +596,6 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)\n> \n> \tLOG(RkISP1, Debug) << \"Sensor configured with \" << format.toString();\n> \n> -\tret = dphy_->setFormat(0, &format);\n> -\tif (ret < 0)\n> -\t\treturn ret;\n> -\n> -\tLOG(RkISP1, Debug) << \"Configuring ISP input pad with \" << format.toString();\n> -\n> -\tret = dphy_->getFormat(1, &format);\n> -\tif (ret < 0)\n> -\t\treturn ret;\n> -\n> \tret = isp_->setFormat(0, &format);\n> \tif (ret < 0)\n> \t\treturn ret;\n> @@ -622,6 +612,22 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)\n> \n> \tLOG(RkISP1, Debug) << \"ISP output pad configured with \" << format.toString();\n> \n> +\tret = resizer_->setFormat(0, &format);\n> +\tif (ret < 0)\n> +\t\treturn ret;\n> +\n> +\tLOG(RkISP1, Debug) << \"Resizer input pad configured with \" << format.toString();\n> +\n> +\tformat.size = cfg.size;\n> +\n> +\tLOG(RkISP1, Debug) << \"Configuring resizer output pad with \" << format.toString();\n> +\n> +\tret = resizer_->setFormat(1, &format);\n> +\tif (ret < 0)\n> +\t\treturn ret;\n> +\n> +\tLOG(RkISP1, Debug) << \"Resizer output pad configured with \" << format.toString();\n> +\n> \tV4L2DeviceFormat outputFormat = {};\n> \toutputFormat.fourcc = video_->toV4L2Fourcc(cfg.pixelFormat);\n> \toutputFormat.size = cfg.size;\n> @@ -868,7 +874,7 @@ int PipelineHandlerRkISP1::initLinks()\n> \tif (ret < 0)\n> \t\treturn ret;\n> \n> -\tlink = media_->link(\"rockchip-sy-mipi-dphy\", 1, \"rkisp1-isp-subdev\", 0);\n> +\tlink = media_->link(\"rkisp1_isp\", 2, \"rkisp1_resizer_mainpath\", 0);\n> \tif (!link)\n> \t\treturn -ENODEV;\n> \n> @@ -876,7 +882,7 @@ int PipelineHandlerRkISP1::initLinks()\n> \tif (ret < 0)\n> \t\treturn ret;\n> \n> -\tlink = media_->link(\"rkisp1-isp-subdev\", 2, \"rkisp1_mainpath\", 0);\n> +\tlink = media_->link(\"rkisp1_resizer_mainpath\", 1, \"rkisp1_mainpath\", 0);\n> \tif (!link)\n> \t\treturn -ENODEV;\n> \n> @@ -923,24 +929,25 @@ bool PipelineHandlerRkISP1::match(DeviceEnumerator *enumerator)\n> \tconst MediaPad *pad;\n> \n> \tDeviceMatch dm(\"rkisp1\");\n> -\tdm.add(\"rkisp1-isp-subdev\");\n> +\tdm.add(\"rkisp1_isp\");\n> +\tdm.add(\"rkisp1_resizer_selfpath\");\n> +\tdm.add(\"rkisp1_resizer_mainpath\");\n> \tdm.add(\"rkisp1_selfpath\");\n> \tdm.add(\"rkisp1_mainpath\");\n> -\tdm.add(\"rkisp1-statistics\");\n> -\tdm.add(\"rkisp1-input-params\");\n> -\tdm.add(\"rockchip-sy-mipi-dphy\");\n> +\tdm.add(\"rkisp1_stats\");\n> +\tdm.add(\"rkisp1_params\");\n> \n> \tmedia_ = acquireMediaDevice(enumerator, dm);\n> \tif (!media_)\n> \t\treturn false;\n> \n> \t/* Create the V4L2 subdevices we will need. */\n> -\tdphy_ = V4L2Subdevice::fromEntityName(media_, \"rockchip-sy-mipi-dphy\");\n> -\tif (dphy_->open() < 0)\n> +\tisp_ = V4L2Subdevice::fromEntityName(media_, \"rkisp1_isp\");\n> +\tif (isp_->open() < 0)\n> \t\treturn false;\n> \n> -\tisp_ = V4L2Subdevice::fromEntityName(media_, \"rkisp1-isp-subdev\");\n> -\tif (isp_->open() < 0)\n> +\tresizer_ = V4L2Subdevice::fromEntityName(media_, \"rkisp1_resizer_mainpath\");\n> +\tif (resizer_->open() < 0)\n> \t\treturn false;\n> \n> \t/* Locate and open the capture video node. */\n> @@ -948,11 +955,11 @@ bool PipelineHandlerRkISP1::match(DeviceEnumerator *enumerator)\n> \tif (video_->open() < 0)\n> \t\treturn false;\n> \n> -\tstat_ = V4L2VideoDevice::fromEntityName(media_, \"rkisp1-statistics\");\n> +\tstat_ = V4L2VideoDevice::fromEntityName(media_, \"rkisp1_stats\");\n> \tif (stat_->open() < 0)\n> \t\treturn false;\n> \n> -\tparam_ = V4L2VideoDevice::fromEntityName(media_, \"rkisp1-input-params\");\n> +\tparam_ = V4L2VideoDevice::fromEntityName(media_, \"rkisp1_params\");\n> \tif (param_->open() < 0)\n> \t\treturn false;\n> \n> @@ -967,10 +974,10 @@ bool PipelineHandlerRkISP1::match(DeviceEnumerator *enumerator)\n> \t}\n> \n> \t/*\n> -\t * Enumerate all sensors connected to the CSI-2 receiver and create one\n> +\t * Enumerate all sensors connected to the ISP and create one\n> \t * camera instance for each of them.\n> \t */\n> -\tpad = dphy_->entity()->getPadByIndex(0);\n> +\tpad = isp_->entity()->getPadByIndex(0);\n> \tif (!pad)\n> \t\treturn false;\n> \n>","headers":{"Return-Path":"","Received":["from bhuna.collabora.co.uk (bhuna.collabora.co.uk\n\t[IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D369060456\n\tfor ;\n\tFri, 17 Jan 2020 16:00:24 +0100 (CET)","from [127.0.0.1] (localhost [127.0.0.1])\n\t(Authenticated sender: koike) with ESMTPSA id 8FF14292AED"],"From":"Helen Koike ","To":"libcamera-devel@lists.libcamera.org","Cc":"heiko@sntech.de, joacim.zetterling@gmail.com, kernel@collabora.com","References":"<20200117145619.3321911-1-helen.koike@collabora.com>","Autocrypt":"addr=helen.koike@collabora.com; keydata=\n\tmQINBFmOMD4BEADb2nC8Oeyvklh+ataw2u/3mrl+hIHL4WSWtii4VxCapl9+zILuxFDrxw1p\n\tXgF3cfx7g9taWBrmLE9VEPwJA6MxaVnQuDL3GXxTxO/gqnOFgT3jT+skAt6qMvoWnhgurMGH\n\twRaA3dO4cFrDlLsZIdDywTYcy7V2bou81ItR5Ed6c5UVX7uTTzeiD/tUi8oIf0XN4takyFuV\n\tRf09nOhi24bn9fFN5xWHJooFaFf/k2Y+5UTkofANUp8nn4jhBUrIr6glOtmE0VT4pZMMLT63\n\thyRB+/s7b1zkOofUGW5LxUg+wqJXZcOAvjocqSq3VVHcgyxdm+Nv0g9Hdqo8bQHC2KBK86VK\n\tvB+R7tfv7NxVhG1sTW3CQ4gZb0ZugIWS32Mnr+V+0pxci7QpV3jrtVp5W2GA5HlXkOyC6C7H\n\tAo7YhogtvFehnlUdG8NrkC3HhCTF8+nb08yGMVI4mMZ9v/KoIXKC6vT0Ykz434ed9Oc9pDow\n\tVUqaKi3ey96QczfE4NI029bmtCY4b5fucaB/aVqWYRH98Jh8oIQVwbt+pY7cL5PxS7dQ/Zuz\n\t6yheqDsUGLev1O3E4R8RZ8jPcfCermL0txvoXXIA56t4ZjuHVcWEe2ERhLHFGq5Zw7KC6u12\n\tkJoiZ6WDBYo4Dp+Gd7a81/WsA33Po0j3tk/8BWoiJCrjXzhtRwARAQABtCdIZWxlbiBLb2lr\n\tZSA8aGVsZW4ua29pa2VAY29sbGFib3JhLmNvbT6JAlQEEwEKAD4CGwEFCwkIBwMFFQoJCAsF\n\tFgIDAQACHgECF4AWIQSofQA6zrItXEgHWTzAfqwo9yFiXQUCXEz3bwUJBKaPRQAKCRDAfqwo\n\t9yFiXdUCD/4+WZr503hQ13KB4DijOW76ju8JDPp4p++qoPxtoAsld3yROoTI+VPWmt7ojHrr\n\tTZc7sTLxOFzaUC8HjGTb3r9ilIhIKf/M9KRLkpIJ+iLA+VoUbcSOMYWoVNfgLmbnqoezjPcy\n\tOHJwVw9dzEeYpvG6nkY6E4UktANySp27AniSXNuHOvYsOsXmUOqU1ScdsrQ9s732p/OGdTyw\n\t1yd3gUMLZvCKFOBVHILH59HCRJgpwUPiws8G4dGMs4GTRvHT2s2mDQdQ0HEvcM9rvCRVixuC\n\t5ZeOymZNi6lDIUIysgiZ+yzk6i5l/Ni6r7v20N3JppZvhPK6LqtaYceyAGyc3jjnOqoHT/qR\n\tkPjCwzmKiPtXjLw6HbRXtGgGtP5m3y8v6bfHH+66zd2vGCY0Z9EsqcnK4DCqRkLncFLPM2gn\n\t9cZcCmO4ZqXUhTyn1nHM494kd5NX1Op4HO+t9ErnpufkVjoMUeBwESdQwwwHT3rjUueGmCrn\n\tVJK69/qhA4La72VTxHutl+3Z0Xy20HWsZS8Gsam39f95/LtPLzbBwnOOi5ZoXnm97tF8HrAZ\n\t2h+kcRLMWw3BXy5q4gic+oFZMZP9oq1G9XTFld4FGgJ9ys8aGmhLM+uB1pFxb3XFtWQ2z4AJ\n\tiEp2VLl34quwfD6Gg4csiZe2KzvQHUe0w8SJ9LplrHPPprkCDQRZjjChARAAzISLQaHzaDOv\n\tZxcoCNBk/hUGo2/gsmBW4KSj73pkStZ+pm3Yv2CRtOD4jBlycXjzhwBV7/70ZMH70/Y25dJa\n\tCnJKl/Y76dPPn2LDWrG/4EkqUzoJkhRIYFUTpkPdaVYznqLgsho19j7HpEbAum8r3jemYBE1\n\tAIuVGg4bqY3UkvuHWLVRMuaHZNy55aYwnUvd46E64JH7O990mr6t/nu2a1aJ0BDdi8HZ0RMo\n\tEg76Avah+YR9fZrhDFmBQSL+mcCVWEbdiOzHmGYFoToqzM52wsNEpo2aStH9KLk8zrCXGx68\n\tohJyQoALX4sS03RIWh1jFjnlw2FCbEdj/HDX0+U0i9COtanm54arYXiBTnAnx0F7LW7pv7sb\n\t6tKMxsMLmprP/nWyV5AfFRi3jxs5tdwtDDk/ny8WH6KWeLR/zWDwpYgnXLBCdg8l97xUoPQO\n\t0VkKSa4JEXUZWZx9q6kICzFGsuqApqf9gIFJZwUmirsxH80Fe04Tv+IqIAW7/djYpOqGjSyk\n\toaEVNacwLLgZr+/j69/1ZwlbS8K+ChCtyBV4kEPzltSRZ4eU19v6sDND1JSTK9KSDtCcCcAt\n\tVGFlr4aE00AD/aOkHSylc93nPinBFO4AGhcs4WypZ3GGV6vGWCpJy9svfWsUDhSwI7GS/i/v\n\tUQ1+bswyYEY1Q3DjJqT7fXcAEQEAAYkEcgQYAQoAJgIbAhYhBKh9ADrOsi1cSAdZPMB+rCj3\n\tIWJdBQJcTPfVBQkEpo7hAkDBdCAEGQEKAB0WIQSomGMEg78Cd/pMshveCRfNeJ05lgUCWY4w\n\toQAKCRDeCRfNeJ05lp0gD/49i95kPKjpgjUbYeidjaWuINXMCA171KyaBAp+Jp2Qrun4sIJB\n\tZ6srMj6O/gC34AhZln2sXeQdxe88sNbg6HjlN+4AkhTd6DttjOfUwnamLDA7uw+YIapGgsgN\n\tlznjLnqOaQ9mtEwRbZMUOdyRf9osSuL14vHl4ia3bYNJ52WYre6gLMu4K+Ghd02og+ILgIio\n\tQ827h0spqIJYHrR3Ynnhxdlv5GPCobh+AKsQMdTIuCzR6JSCBk6GHkg33SiWScKMUzT8B/cn\n\typLfGnfV/LDZ9wS2TMzIlK/uv0Vd4C0OGDd/GCi5Gwu/Ot0aY7fzZo2CiRV+/nJBWPRRBTji\n\tbE4FG2rt7WSRLO/QmH2meIW4f0USDiHeNwznHkPei59vRdlMyQdsxrmgSRDuX9Y3UkERxbgd\n\tuscqC8Cpcy5kpF11EW91J8aGpcxASc+5Pa66/+7CrpBC2DnfcfACdMAje7yeMn9XlHrqXNlQ\n\tGaglEcnGN2qVqRcKgcjJX+ur8l56BVpBPFYQYkYkIdQAuhlPylxOvsMcqI6VoEWNt0iFF3dA\n\t//0MNb8fEqw5TlxDPOt6BDhDKowkxOGIA9LOcF4PkaR9Qkvwo2P4vA/8fhCnMqlSPom4xYdk\n\tEv8P554zDoL/XMHl+s7A0MjIJzT253ejZKlWeO68pAbNy/z7QRn2lFDnjwkQwH6sKPchYl2f\n\t0g//Yu3vDkqk8+mi2letP3XBl2hjv2eCZjTh34VvtgY5oeL2ROSJWNd18+7O6q3hECZ727EW\n\tgIb3LK9g4mKF6+Rch6Gwz1Y4fmC5554fd2Y2XbVzzz6AGUC6Y+ohNg7lTAVO4wu43+IyTB8u\n\tip5rX/JDGFv7Y1sl6tQJKAVIKAJE+Z3Ncqh3doQr9wWHl0UiQYKbSR9HpH1lmC1C3EEbTpwK\n\tfUIpZd1eQNyNJl1jHsZZIBYFsAfVNH/u6lB1TU+9bSOsV5SepdIb88d0fm3oZ4KzjhRHLFQF\n\tRwNUNn3ha6x4fbxYcwbvu5ZCiiX6yRTPoage/LUNkgQNX2PtPcur6CdxK6Pqm8EAI7PmYLfN\n\tNY3y01XhKNRvaVZoH2FugfUkhsBITglTIpI+n6YU06nDAcbeINFo67TSE0iL6Pek5a6gUQQC\n\t6w+hJCaMr8KYud0q3ccHyU3TlAPDe10En3GsVz7Y5Sa3ODGdbmkfjK8Af3ogGNBVmpV16Xl8\n\t4rETFv7POSUB2eMtbpmBopd+wKqHCwUEy3fx1zDbM9mp+pcDoL73rRZmlgmNfW/4o4qBzxRf\n\tFYTQLE69wAFU2IFce9PjtUAlBdC+6r3X24h3uD+EC37s/vWhxuKj2glaU9ONrVJ/SPvlqXOO\n\tWR1Zqw57vHMKimLdG3c24l8PkSw1usudgAA5OyO5Ag0EWY4wyQEQAMVp0U38Le7d80Mu6AT+\n\t1dMes87iKn30TdMuLvSg2uYqJ1T2riRBF7zU6u74HF6zps0rPQviBXOgoSuKa1hnS6OwFb9x\n\tyQPlk76LY96SUB5jPWJ3fO78ZGSwkVbJFuG9gpD/41n8Unn1hXgDb2gUaxD0oXv/723EmTYC\n\tvSo3z6Y8A2aBQNr+PyhQAPDazvVQ+P7vnZYq1oK0w+D7aIix/Bp4mo4VbgAeAeMxXWSZs8N5\n\tNQtXeTBgB7DqrfJP5wWwgCsROfeds6EoddcYgqhG0zVU9E54C8JcPOA0wKVs+9+gt2eyRNtx\n\t0UhFbah7qXuJGhWy/0CLXvVoCoS+7qpWz070TBAlPZrg9D0o2gOw01trQgoKAYBKKgJhxaX/\n\t4gzi+5Ccm33LYH9lAVTdzdorejuV1xWdsnNyc8OAPeoXBf9RIIWfQVmbhVXBp2DAPjV6/kIJ\n\tEml7MNJfEvqjV9zKsWF9AFlsqDWZDCyUdqR96ahTSD34pRwb6a9H99/GrjeowKaaL95DIVZT\n\tC6STvDNL6kpys4sOe2AMmQGv2MMcJB3aYLzH8f1sEQ9S0UMX7/6CifEG6JodG6Y/W/lLo1Vv\n\tDxeDA+u4Lgq6qxlksp8M78FjcmxFVlf4cpCi2ucbZxurhlBkjtZZ8MVAEde3hlqjcBl2Ah6Q\n\tD826FTxscOGlHEfNABEBAAGJAjwEGAEKACYCGwwWIQSofQA6zrItXEgHWTzAfqwo9yFiXQUC\n\tXEz31QUJBKaOuQAKCRDAfqwo9yFiXUvnEACBWe8wSnIvSX+9k4LxuLq6GQTOt+RNfliZQkCW\n\t5lT3KL1IJyzzOm4x+/slHRBl8bF7KEZyOPinXQXyJ/vgIdgSYxDqoZ7YZn3SvuNe4aT6kGwL\n\tEYYEV8Ecj4ets15FR2jSUNnVv5YHWtZ7bP/oUzr2LT54fjRcstYxgwzoj8AREtHQ4EJWAWCO\n\tZuEHTSm5clMFoi41CmG4DlJbzbo4YfilKYm69vwh50Y8WebcRN31jh0g8ufjOJnBldYYBLwN\n\tObymhlfy/HKBDIbyCGBuwYoAkoJ6LR/cqzl/FuhwhuDocCGlXyYaJOwXgHaCvVXI3PLQPxWZ\n\t+vPsD+TSVHc9m/YWrOiYDnZn6aO0Uk1Zv/m9+BBkWAwsreLJ/evn3SsJV1omNBTITG+uxXcf\n\tJkgmmesIAw8mpI6EeLmReUJLasz8QkzhZIC7t5rGlQI94GQG3Jg2dC+kpaGWOaT5G4FVMcBj\n\tiR1nXfMxENVYnM5ag7mBZyD/kru5W1Uj34L6AFaDMXFPwedSCpzzqUiHb0f+nYkfOodf5xy0\n\t46+3THy/NUS/ZZp/rI4F7Y77+MQPVg7vARfHHX1AxYUKfRVW5j88QUB70txn8Vgi1tDrOr4J\n\teD+xr0CvIGa5lKqgQacQtGkpOpJ8zY4ObSvpNubey/qYUE3DCXD0n2Xxk4muTvqlkFpOYA==","Message-ID":"<0541742e-d884-e439-d960-d2dff2ed4cdc@collabora.com>","Date":"Fri, 17 Jan 2020 12:00:17 -0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.3.0","MIME-Version":"1.0","In-Reply-To":"<20200117145619.3321911-1-helen.koike@collabora.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: pipeline: rkisp1: sync\n\ttopology with upstream driver","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 17 Jan 2020 15:00:25 -0000"}}]