{"id":26554,"url":"https://patchwork.libcamera.org/api/patches/26554/?format=json","web_url":"https://patchwork.libcamera.org/patch/26554/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260423230059.3180987-33-laurent.pinchart@ideasonboard.com>","date":"2026-04-23T23:00:54","name":"[v3,32/37] libcamera: global_configuration: Populate empty configuration","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"ad547604ca0eeb80a9f69ce35d6d1efa9f4fb8e7","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/26554/mbox/","series":[{"id":5883,"url":"https://patchwork.libcamera.org/api/series/5883/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5883","date":"2026-04-23T23:00:22","name":"libcamera: Global configuration file improvements","version":3,"mbox":"https://patchwork.libcamera.org/series/5883/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/26554/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/26554/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4E0EFBDCB5\n\tfor ;\n\tThu, 23 Apr 2026 23:02:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B574062FB7;\n\tFri, 24 Apr 2026 01:02:04 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5240362FD1\n\tfor ;\n\tFri, 24 Apr 2026 01:01:45 +0200 (CEST)","from killaraus.ideasonboard.com\n\t(2001-14ba-703d-e500--2a1.rev.dnainternet.fi\n\t[IPv6:2001:14ba:703d:e500::2a1])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C15ED103F\n\tfor ;\n\tFri, 24 Apr 2026 01:00:05 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"cjghgjJn\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1776985205;\n\tbh=3SF+tBB3vleQvw6gacY2li+u7UTo/rNJT8YeOKI+U+k=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=cjghgjJnVWGlyAjrkXAz+3Ek3bvGTT3ZOo7NN0WhPyITqMMlfVoKm/9xwDMBOgYW3\n\tcK2Qxx1S/gXVmOfaFyr+0oYdbsMXfUZwM4UUF01Kh1CJcNxqXVBvj6ejlyQl35NVJL\n\tloXgvegeoCgQzblEM8/0rVukNfpXvLOcqSdoEGqU=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH v3 32/37] libcamera: global_configuration: Populate empty\n\tconfiguration","Date":"Fri, 24 Apr 2026 02:00:54 +0300","Message-ID":"<20260423230059.3180987-33-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260423230059.3180987-1-laurent.pinchart@ideasonboard.com>","References":"<20260423230059.3180987-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"If no configuration file can be parsed, populate an empty configuration.\nThis will serve as a base to store the configuration options set through\nenvironment variables.\n\nSigned-off-by: Laurent Pinchart \nReviewed-by: Barnabás Pőcze \nReviewed-by: Isaac Scott \n---\nChanges since v1:\n\n- Move code to constructor to cover all loadFile() calls\n---\n src/libcamera/global_configuration.cpp | 5 +++++\n 1 file changed, 5 insertions(+)","diff":"diff --git a/src/libcamera/global_configuration.cpp b/src/libcamera/global_configuration.cpp\nindex a70562614b12..62b9762d3e31 100644\n--- a/src/libcamera/global_configuration.cpp\n+++ b/src/libcamera/global_configuration.cpp\n@@ -61,6 +61,11 @@ LOG_DEFINE_CATEGORY(Configuration)\n GlobalConfiguration::GlobalConfiguration()\n {\n \tload();\n+\n+\tif (configuration_->isEmpty()) {\n+\t\tconfiguration_->add(\"version\", std::make_unique(1));\n+\t\tconfiguration_->add(\"configuration\", std::make_unique());\n+\t}\n }\n \n void GlobalConfiguration::load()\n","prefixes":["v3","32/37"]}