{"id":26550,"url":"https://patchwork.libcamera.org/api/patches/26550/?format=json","web_url":"https://patchwork.libcamera.org/patch/26550/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260423230059.3180987-29-laurent.pinchart@ideasonboard.com>","date":"2026-04-23T23:00:50","name":"[v3,28/37] libcamera: global_configuration: Add missing include and comment","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"8bb403a549a79067e27c97035873647f7c59ff06","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/26550/mbox/","series":[{"id":5883,"url":"https://patchwork.libcamera.org/api/series/5883/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5883","date":"2026-04-23T23:00:22","name":"libcamera: Global configuration file improvements","version":3,"mbox":"https://patchwork.libcamera.org/series/5883/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/26550/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/26550/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CAB85BDCB5\n\tfor ;\n\tThu, 23 Apr 2026 23:01:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7A66562FC5;\n\tFri, 24 Apr 2026 01:01:57 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DF0AC62FAC\n\tfor ;\n\tFri, 24 Apr 2026 01:01:39 +0200 (CEST)","from killaraus.ideasonboard.com\n\t(2001-14ba-703d-e500--2a1.rev.dnainternet.fi\n\t[IPv6:2001:14ba:703d:e500::2a1])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5F43B802\n\tfor ;\n\tFri, 24 Apr 2026 01:00:00 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"NLIvyShh\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1776985200;\n\tbh=H17CFpc7lt+X2xsRg7UVhGV+7ZOtaknrN2oERFj/RQw=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=NLIvyShhwrBy72D62YwZCoIbpwl1jHTH4IgyCjIFY2JThH4A8B0FbbAr1nfbU4sRd\n\tJUcywPoUCB9Tiov6NaKcTLW+bIYt7kZ4z9jgEGh24u6cbmhq5oQKBPu3Et4BqDk1xT\n\txMldQsXixWuaWMnFsKfEdxmmUAZw9LJLa3IidZAU=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH v3 28/37] libcamera: global_configuration: Add missing\n\tinclude and comment","Date":"Fri, 24 Apr 2026 02:00:50 +0300","Message-ID":"<20260423230059.3180987-29-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260423230059.3180987-1-laurent.pinchart@ideasonboard.com>","References":"<20260423230059.3180987-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"global_configuration.h uses std::initializer_list, include the\ncorresponding header. Add a comment in global_configuration.cpp to close\nan anonymous namespace, as mandated by the coding style.\n\nSigned-off-by: Laurent Pinchart \nReviewed-by: Barnabás Pőcze \nReviewed-by: Isaac Scott \n---\n include/libcamera/internal/global_configuration.h | 1 +\n src/libcamera/global_configuration.cpp | 4 +++-\n 2 files changed, 4 insertions(+), 1 deletion(-)","diff":"diff --git a/include/libcamera/internal/global_configuration.h b/include/libcamera/internal/global_configuration.h\nindex 84bdf90244d9..80b57b38ba03 100644\n--- a/include/libcamera/internal/global_configuration.h\n+++ b/include/libcamera/internal/global_configuration.h\n@@ -8,6 +8,7 @@\n #pragma once\n \n #include \n+#include \n #include \n #include \n #include \ndiff --git a/src/libcamera/global_configuration.cpp b/src/libcamera/global_configuration.cpp\nindex c853a028c91d..44ed206de78f 100644\n--- a/src/libcamera/global_configuration.cpp\n+++ b/src/libcamera/global_configuration.cpp\n@@ -24,11 +24,13 @@\n namespace libcamera {\n \n namespace {\n+\n const std::vector globalConfigurationFiles = {\n \tstd::filesystem::path(LIBCAMERA_SYSCONF_DIR) / \"configuration.yaml\",\n \tstd::filesystem::path(LIBCAMERA_DATA_DIR) / \"configuration.yaml\",\n };\n-}\n+\n+} /* namespace */\n \n LOG_DEFINE_CATEGORY(Configuration)\n \n","prefixes":["v3","28/37"]}