[{"id":3501,"web_url":"https://patchwork.libcamera.org/comment/3501/","msgid":"<20200117225932.GL1074550@oden.dyn.berto.se>","date":"2020-01-17T22:59:32","subject":"Re: [libcamera-devel] [PATCH] qcam: Support scaling of the\n\tviewfinder","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2020-01-17 02:54:20 +0200, Laurent Pinchart wrote:\n> The viewfinder is drawn using a QLabel. This could support scaling\n> through QLabel::setScaledContents(), but in a very inefficient way. To\n> maintain reasonable efficiency, turn the viewfinder into a QWidget and\n> draw the image directly using a QPainter.\n> \n> No performance change was noticed running on a fast x86 machine, and\n> performance was 60% higher when scaling up to full screen compared to\n> QLabel.\n\nI could not detect any performance change on Scarlet.\n\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/qcam/main_window.cpp | 1 -\n> src/qcam/viewfinder.cpp | 22 +++++++++++++++-------\n> src/qcam/viewfinder.h | 8 ++++++--\n> 3 files changed, 21 insertions(+), 10 deletions(-)\n> \n> diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\n> index 1d9c756f147a..df51fa888342 100644\n> --- a/src/qcam/main_window.cpp\n> +++ b/src/qcam/main_window.cpp\n> @@ -33,7 +33,6 @@ MainWindow::MainWindow(CameraManager *cm, const OptionsParser::Options &options)\n> \n> \tviewfinder_ = new ViewFinder(this);\n> \tsetCentralWidget(viewfinder_);\n> -\tviewfinder_->setFixedSize(500, 500);\n> \tadjustSize();\n> \n> \tret = openCamera(cm);\n> diff --git a/src/qcam/viewfinder.cpp b/src/qcam/viewfinder.cpp\n> index 98a8ab68e5f6..6de284d1b782 100644\n> --- a/src/qcam/viewfinder.cpp\n> +++ b/src/qcam/viewfinder.cpp\n> @@ -6,13 +6,13 @@\n> */\n> \n> #include \n> -#include \n> +#include \n> \n> #include \"format_converter.h\"\n> #include \"viewfinder.h\"\n> \n> ViewFinder::ViewFinder(QWidget *parent)\n> -\t: QLabel(parent), format_(0), width_(0), height_(0), image_(nullptr)\n> +\t: QWidget(parent), format_(0), width_(0), height_(0), image_(nullptr)\n> {\n> }\n> \n> @@ -24,9 +24,7 @@ ViewFinder::~ViewFinder()\n> void ViewFinder::display(const unsigned char *raw, size_t size)\n> {\n> \tconverter_.convert(raw, size, image_);\n> -\n> -\tQPixmap pixmap = QPixmap::fromImage(*image_);\n> -\tsetPixmap(pixmap);\n> +\tupdate();\n> }\n> \n> int ViewFinder::setFormat(unsigned int format, unsigned int width,\n> @@ -42,10 +40,20 @@ int ViewFinder::setFormat(unsigned int format, unsigned int width,\n> \twidth_ = width;\n> \theight_ = height;\n> \n> -\tsetFixedSize(width, height);\n> -\n> \tdelete image_;\n> \timage_ = new QImage(width, height, QImage::Format_RGB32);\n> \n> +\tupdateGeometry();\n> \treturn 0;\n> }\n> +\n> +void ViewFinder::paintEvent(QPaintEvent *)\n> +{\n> +\tQPainter painter(this);\n> +\tpainter.drawImage(rect(), *image_, image_->rect());\n> +}\n> +\n> +QSize ViewFinder::sizeHint() const\n> +{\n> +\treturn image_ ? image_->size() : QSize(640, 480);\n> +}\n> diff --git a/src/qcam/viewfinder.h b/src/qcam/viewfinder.h\n> index 33bdb1460f84..ef5fd45b264a 100644\n> --- a/src/qcam/viewfinder.h\n> +++ b/src/qcam/viewfinder.h\n> @@ -7,13 +7,13 @@\n> #ifndef __QCAM_VIEWFINDER_H__\n> #define __QCAM_VIEWFINDER_H__\n> \n> -#include \n> +#include \n> \n> #include \"format_converter.h\"\n> \n> class QImage;\n> \n> -class ViewFinder : public QLabel\n> +class ViewFinder : public QWidget\n> {\n> public:\n> \tViewFinder(QWidget *parent);\n> @@ -23,6 +23,10 @@ public:\n> \t\t unsigned int height);\n> \tvoid display(const unsigned char *rgb, size_t size);\n> \n> +protected:\n> +\tvoid paintEvent(QPaintEvent *) override;\n> +\tQSize sizeHint() const override;\n> +\n> private:\n> \tunsigned int format_;\n> \tunsigned int width_;\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lj1-x231.google.com (mail-lj1-x231.google.com\n\t[IPv6:2a00:1450:4864:20::231])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6EF7F60792\n\tfor ;\n\tFri, 17 Jan 2020 23:59:34 +0100 (CET)","by mail-lj1-x231.google.com with SMTP id z22so28100384ljg.1\n\tfor ;\n\tFri, 17 Jan 2020 14:59:34 -0800 (PST)","from localhost (h-93-159.A463.priv.bahnhof.se. [46.59.93.159])\n\tby smtp.gmail.com with ESMTPSA id\n\tb17sm12671016lfp.15.2020.01.17.14.59.33\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 17 Jan 2020 14:59:33 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=emDcFmE0+1YS0cW7A+x9M3wB0hlaC/hk8pAz7IWyr+E=;\n\tb=pMZvNf2fi2FbqXXsxj9wWy40EvDKdeHrP7+itCYZ+t9tuKs3Je9xbpVL0KbjIqwWwt\n\tfQsuzDvfd4rpHW5WcdNTvPqnIr+UGyQCVbmwj3Ihi6ELpTmBIckIcZK4UWSS5y77Ns1F\n\tkny+NO2d2+TI9fP+1mV0674mH6FDTGsKFuHyg5enBohxH82oy3abtSFmFQX5bOzlsvG3\n\t+MQXTiBXcxYCcl7E4rsLRwKoJvW+UaaB8/UcSoBC5yUDsE34MSS6LVO1/INsYfXNxuKx\n\taVorfik2rWuG7yShO8w/jXl4aRI9Y3gtdW1UJHQCCMhg4nWB8zbSEG6AcMLLniGIKnmG\n\tiygA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=emDcFmE0+1YS0cW7A+x9M3wB0hlaC/hk8pAz7IWyr+E=;\n\tb=Rmgf+/nzitjKX54rDPfBcP03cpyI2dMEDTdaA2/QffD5qA/ZgUfbnW9BEyiRV3x5Rw\n\toZmbzpe0VwzsYaM5i/ffkg6egKATET5WkWV9067ASyoPOdOAYCeAK6uXBVU5LMUbEvxA\n\t3+WL8zGANB2ohvCaeOR1pEebP6zoEA9p5y6PhXY9smOSu19CiMETnU3As1lrKWywQNlo\n\tC5ZwpYQebGsVH2bdE8bTqN8TJeDT7zbIwBn7uJbj8tK+ioKnPKugakv+v2cNh2mKiAB2\n\tJb0D/VkoR4rYi+Za3a05w3EOgtLfmdxNRQ7he+FSYOKN2y5ypxIDQdkLpjnLcjQMvnoQ\n\t9hLg==","X-Gm-Message-State":"APjAAAWl3zDKLeNfb3L0IHfnwa0XJcZPi33/Wg1svDZEz/GRkA2JMkew\n\tt6Mz5nvCr/CdhTVVQFNu1Fv91mY7ePo=","X-Google-Smtp-Source":"APXvYqxKjY1mboLLYyXiICTCMxoFgjNKJGZV+/rwMklNs126IHB91xgZE62H0PZODkJoR/kjbp1IZg==","X-Received":"by 2002:a2e:9850:: with SMTP id\n\te16mr7113070ljj.268.1579301973624; \n\tFri, 17 Jan 2020 14:59:33 -0800 (PST)","Date":"Fri, 17 Jan 2020 23:59:32 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200117225932.GL1074550@oden.dyn.berto.se>","References":"<20200117005420.18210-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200117005420.18210-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] qcam: Support scaling of the\n\tviewfinder","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 17 Jan 2020 22:59:34 -0000"}},{"id":3542,"web_url":"https://patchwork.libcamera.org/comment/3542/","msgid":"<723bce5e-12de-6757-4021-1d404ce247af@ideasonboard.com>","date":"2020-01-20T14:50:00","subject":"Re: [libcamera-devel] [PATCH] qcam: Support scaling of the\n\tviewfinder","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 17/01/2020 00:54, Laurent Pinchart wrote:\n> The viewfinder is drawn using a QLabel. This could support scaling\n> through QLabel::setScaledContents(), but in a very inefficient way. To\n> maintain reasonable efficiency, turn the viewfinder into a QWidget and\n> draw the image directly using a QPainter.\n> \n> No performance change was noticed running on a fast x86 machine, and\n> performance was 60% higher when scaling up to full screen compared to\n> QLabel.\n\nThis does indeed bring scaling performance improvements for me, and I am\nvery happy that we can now scale the QCam ViewFinder window both up and\ndown :-D\n\nWe should add a means to return to the original window size easily at\nsome point (perhaps a reset button on a toolbar) but that's out of scope\nfor this patch.\n\nReviewed-by: Kieran Bingham \n\n> Signed-off-by: Laurent Pinchart \n> ---\n> src/qcam/main_window.cpp | 1 -\n> src/qcam/viewfinder.cpp | 22 +++++++++++++++-------\n> src/qcam/viewfinder.h | 8 ++++++--\n> 3 files changed, 21 insertions(+), 10 deletions(-)\n> \n> diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\n> index 1d9c756f147a..df51fa888342 100644\n> --- a/src/qcam/main_window.cpp\n> +++ b/src/qcam/main_window.cpp\n> @@ -33,7 +33,6 @@ MainWindow::MainWindow(CameraManager *cm, const OptionsParser::Options &options)\n> \n> \tviewfinder_ = new ViewFinder(this);\n> \tsetCentralWidget(viewfinder_);\n> -\tviewfinder_->setFixedSize(500, 500);\n> \tadjustSize();\n> \n> \tret = openCamera(cm);\n> diff --git a/src/qcam/viewfinder.cpp b/src/qcam/viewfinder.cpp\n> index 98a8ab68e5f6..6de284d1b782 100644\n> --- a/src/qcam/viewfinder.cpp\n> +++ b/src/qcam/viewfinder.cpp\n> @@ -6,13 +6,13 @@\n> */\n> \n> #include \n> -#include \n> +#include \n> \n> #include \"format_converter.h\"\n> #include \"viewfinder.h\"\n> \n> ViewFinder::ViewFinder(QWidget *parent)\n> -\t: QLabel(parent), format_(0), width_(0), height_(0), image_(nullptr)\n> +\t: QWidget(parent), format_(0), width_(0), height_(0), image_(nullptr)\n> {\n> }\n> \n> @@ -24,9 +24,7 @@ ViewFinder::~ViewFinder()\n> void ViewFinder::display(const unsigned char *raw, size_t size)\n> {\n> \tconverter_.convert(raw, size, image_);\n> -\n> -\tQPixmap pixmap = QPixmap::fromImage(*image_);\n> -\tsetPixmap(pixmap);\n> +\tupdate();\n> }\n> \n> int ViewFinder::setFormat(unsigned int format, unsigned int width,\n> @@ -42,10 +40,20 @@ int ViewFinder::setFormat(unsigned int format, unsigned int width,\n> \twidth_ = width;\n> \theight_ = height;\n> \n> -\tsetFixedSize(width, height);\n> -\n> \tdelete image_;\n> \timage_ = new QImage(width, height, QImage::Format_RGB32);\n> \n> +\tupdateGeometry();\n> \treturn 0;\n> }\n> +\n> +void ViewFinder::paintEvent(QPaintEvent *)\n> +{\n> +\tQPainter painter(this);\n> +\tpainter.drawImage(rect(), *image_, image_->rect());\n> +}\n> +\n> +QSize ViewFinder::sizeHint() const\n> +{\n> +\treturn image_ ? image_->size() : QSize(640, 480);\n> +}\n> diff --git a/src/qcam/viewfinder.h b/src/qcam/viewfinder.h\n> index 33bdb1460f84..ef5fd45b264a 100644\n> --- a/src/qcam/viewfinder.h\n> +++ b/src/qcam/viewfinder.h\n> @@ -7,13 +7,13 @@\n> #ifndef __QCAM_VIEWFINDER_H__\n> #define __QCAM_VIEWFINDER_H__\n> \n> -#include \n> +#include \n> \n> #include \"format_converter.h\"\n> \n> class QImage;\n> \n> -class ViewFinder : public QLabel\n> +class ViewFinder : public QWidget\n> {\n> public:\n> \tViewFinder(QWidget *parent);\n> @@ -23,6 +23,10 @@ public:\n> \t\t unsigned int height);\n> \tvoid display(const unsigned char *rgb, size_t size);\n> \n> +protected:\n> +\tvoid paintEvent(QPaintEvent *) override;\n> +\tQSize sizeHint() const override;\n> +\n> private:\n> \tunsigned int format_;\n> \tunsigned int width_;\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 856EC60804\n\tfor ;\n\tMon, 20 Jan 2020 15:50:04 +0100 (CET)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D002DA62;\n\tMon, 20 Jan 2020 15:50:03 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1579531804;\n\tbh=lGyeOiuewdHbRvIgXEQdWAzxPoqWcfz4RRRRnBX7YmQ=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=J36lj+j9sFlsne+GeuFmEm6JorykM7LW2p9kl2VQAYY7GXs7hGcAq5yDPw4xiv52H\n\tZQ1DXibvunBxlg0APH3OJzSKbHBtHqa3beBjaY9OB74C8QL2Jk10sURKQdhHjwQQOt\n\tyvbnMurplW0PExWjmY8VAJEIpf774XSzL2/cb/XY=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20200117005420.18210-1-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<723bce5e-12de-6757-4021-1d404ce247af@ideasonboard.com>","Date":"Mon, 20 Jan 2020 14:50:00 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.9.0","MIME-Version":"1.0","In-Reply-To":"<20200117005420.18210-1-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH] qcam: Support scaling of the\n\tviewfinder","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 20 Jan 2020 14:50:04 -0000"}}]