[{"id":38642,"web_url":"https://patchwork.libcamera.org/comment/38642/","msgid":"<5ae7b362-4804-4835-87bf-cd7b3e4d21cf@ideasonboard.com>","date":"2026-04-24T07:54:27","subject":"Re: [PATCH v3 24/37] test: yaml-parser: Fix typos in error messages","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2026. 04. 24. 1:00 keltezéssel, Laurent Pinchart írta:\n> The unit test contains a few typos in error messages. Fix them.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n\nReviewed-by: Barnabás Pőcze \n\n\n> test/yaml-parser.cpp | 12 ++++++------\n> 1 file changed, 6 insertions(+), 6 deletions(-)\n> \n> diff --git a/test/yaml-parser.cpp b/test/yaml-parser.cpp\n> index e8fd9ad61cd0..a4b26c17e1f9 100644\n> --- a/test/yaml-parser.cpp\n> +++ b/test/yaml-parser.cpp\n> @@ -71,13 +71,13 @@ protected:\n> \t\t/* Test parsing invalid YAML file. */\n> \t\tFile file{ invalidYamlFile_ };\n> \t\tif (!file.open(File::OpenModeFlag::ReadOnly)) {\n> -\t\t\tstd::cerr << \"Fail to open invalid YAML file\" << std::endl;\n> +\t\t\tstd::cerr << \"Failed to open invalid YAML file\" << std::endl;\n> \t\t\treturn TestFail;\n> \t\t}\n> \n> \t\tstd::unique_ptr root = YamlParser::parse(file);\n> \t\tif (root) {\n> -\t\t\tstd::cerr << \"Invalid YAML file parse successfully\" << std::endl;\n> +\t\t\tstd::cerr << \"Invalid YAML file parsed successfully\" << std::endl;\n> \t\t\treturn TestFail;\n> \t\t}\n> \n> @@ -199,14 +199,14 @@ protected:\n> \t\tauto &level1Obj = (*root)[\"level1\"];\n> \n> \t\tif (!level1Obj.isDictionary()) {\n> -\t\t\tstd::cerr << \"level1 object fail to parse as Dictionary\" << std::endl;\n> +\t\t\tstd::cerr << \"level1 object failed to parse as Dictionary\" << std::endl;\n> \t\t\treturn TestFail;\n> \t\t}\n> \n> \t\tauto &level2Obj = level1Obj[\"level2\"];\n> \n> \t\tif (!level2Obj.isList() || level2Obj.size() != 2) {\n> -\t\t\tstd::cerr << \"level2 object should be a 2 elements list\" << std::endl;\n> +\t\t\tstd::cerr << \"level2 object should be a 2 element list\" << std::endl;\n> \t\t\treturn TestFail;\n> \t\t}\n> \n> @@ -215,7 +215,7 @@ protected:\n> \t\t firstElement.size() != 2 ||\n> \t\t firstElement[0].get(0) != 1 ||\n> \t\t firstElement[1].get(0) != 2) {\n> -\t\t\tstd::cerr << \"The first element of level2 object fail to parse as integer list\" << std::endl;\n> +\t\t\tstd::cerr << \"The first element of level2 object failed to parse as integer list\" << std::endl;\n> \t\t\treturn TestFail;\n> \t\t}\n> \n> @@ -231,7 +231,7 @@ protected:\n> \t\t !secondElement.contains(\"two\") ||\n> \t\t secondElement[\"one\"].get(0) != 1 ||\n> \t\t secondElement[\"two\"].get(0) != 2) {\n> -\t\t\tstd::cerr << \"The second element of level2 object fail to parse as dictionary\" << std::endl;\n> +\t\t\tstd::cerr << \"The second element of level2 object failed to parse as dictionary\" << std::endl;\n> \t\t\treturn TestFail;\n> \t\t}\n> \n> --\n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5CC53BDCB5\n\tfor ;\n\tFri, 24 Apr 2026 07:54:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 15DC462F62;\n\tFri, 24 Apr 2026 09:54:31 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C6C6662F62\n\tfor ;\n\tFri, 24 Apr 2026 09:54:29 +0200 (CEST)","from [192.168.33.62] (185.221.140.120.nat.pool.zt.hu\n\t[185.221.140.120])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1CF31802;\n\tFri, 24 Apr 2026 09:52:50 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"QsU+Q8JP\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1777017170;\n\tbh=cjo/BEHXrwrfPF1X0DurztXjaUuNOOTCPAknJSIELmg=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=QsU+Q8JPQ9UQM1lMPvcomcYI22ZQP0bfkAweKio82LGiCEi+PbHqzn8qJut0H7OJN\n\tq7y6BtNgFvSnC6OiDedpPs6I26iHQgFZ+VgZCyDt/k9gVxaAd3RPzankSarsvnA5NP\n\tIJGLh6fHPGTq+8zitFo8GEFRqHM0vSFsCW/IXsiQ=","Message-ID":"<5ae7b362-4804-4835-87bf-cd7b3e4d21cf@ideasonboard.com>","Date":"Fri, 24 Apr 2026 09:54:27 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v3 24/37] test: yaml-parser: Fix typos in error messages","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20260423230059.3180987-1-laurent.pinchart@ideasonboard.com>\n\t\n\t<20260423230059.3180987-25-laurent.pinchart@ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20260423230059.3180987-25-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":38647,"web_url":"https://patchwork.libcamera.org/comment/38647/","msgid":"<177704547593.319800.1583784315591914966@t16>","date":"2026-04-24T15:44:35","subject":"Re: [PATCH v3 24/37] test: yaml-parser: Fix typos in error messages","submitter":{"id":215,"url":"https://patchwork.libcamera.org/api/people/215/","name":"Isaac Scott","email":"isaac.scott@ideasonboard.com"},"content":"Hi Laurent,\n\nQuoting Laurent Pinchart (2026-04-24 00:00:46)\n> The unit test contains a few typos in error messages. Fix them.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> test/yaml-parser.cpp | 12 ++++++------\n> 1 file changed, 6 insertions(+), 6 deletions(-)\n> \n> diff --git a/test/yaml-parser.cpp b/test/yaml-parser.cpp\n> index e8fd9ad61cd0..a4b26c17e1f9 100644\n> --- a/test/yaml-parser.cpp\n> +++ b/test/yaml-parser.cpp\n> @@ -71,13 +71,13 @@ protected:\n> /* Test parsing invalid YAML file. */\n> File file{ invalidYamlFile_ };\n> if (!file.open(File::OpenModeFlag::ReadOnly)) {\n> - std::cerr << \"Fail to open invalid YAML file\" << std::endl;\n> + std::cerr << \"Failed to open invalid YAML file\" << std::endl;\n> return TestFail;\n> }\n> \n> std::unique_ptr root = YamlParser::parse(file);\n> if (root) {\n> - std::cerr << \"Invalid YAML file parse successfully\" << std::endl;\n> + std::cerr << \"Invalid YAML file parsed successfully\" << std::endl;\n> return TestFail;\n> }\n> \n> @@ -199,14 +199,14 @@ protected:\n> auto &level1Obj = (*root)[\"level1\"];\n> \n> if (!level1Obj.isDictionary()) {\n> - std::cerr << \"level1 object fail to parse as Dictionary\" << std::endl;\n> + std::cerr << \"level1 object failed to parse as Dictionary\" << std::endl;\n> return TestFail;\n> }\n> \n> auto &level2Obj = level1Obj[\"level2\"];\n> \n> if (!level2Obj.isList() || level2Obj.size() != 2) {\n> - std::cerr << \"level2 object should be a 2 elements list\" << std::endl;\n> + std::cerr << \"level2 object should be a 2 element list\" << std::endl;\n> return TestFail;\n> }\n> \n> @@ -215,7 +215,7 @@ protected:\n> firstElement.size() != 2 ||\n> firstElement[0].get(0) != 1 ||\n> firstElement[1].get(0) != 2) {\n> - std::cerr << \"The first element of level2 object fail to parse as integer list\" << std::endl;\n> + std::cerr << \"The first element of level2 object failed to parse as integer list\" << std::endl;\n> return TestFail;\n> }\n> \n> @@ -231,7 +231,7 @@ protected:\n> !secondElement.contains(\"two\") ||\n> secondElement[\"one\"].get(0) != 1 ||\n> secondElement[\"two\"].get(0) != 2) {\n> - std::cerr << \"The second element of level2 object fail to parse as dictionary\" << std::endl;\n> + std::cerr << \"The second element of level2 object failed to parse as dictionary\" << std::endl;\n\nThanks for doing this,\n\nReviewed-by: Isaac Scott \n\n> return TestFail;\n> }\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 59877BE173\n\tfor ;\n\tFri, 24 Apr 2026 15:44:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EB7CD62F6D;\n\tFri, 24 Apr 2026 17:44:39 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 32CEC62E6A\n\tfor ;\n\tFri, 24 Apr 2026 17:44:39 +0200 (CEST)","from thinkpad.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1638D1A63;\n\tFri, 24 Apr 2026 17:42:59 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"RnGpCvt3\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1777045379;\n\tbh=wonrQof61O7SesZ+cJuR37N6xFNLKFUw6rim22h2k1E=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=RnGpCvt3TZXj6isIc/tpsA4Nq5pO+Qy7uWCM1ltESm74qRrCOA28KlBAi8tIlykml\n\tim42lQiT0SnjwLIfqCY+TTG1HuVToB2fW1Yk6sHaXxwNsfNR3zGKbPnnjlvgIumxy7\n\tCaHG/CqYruB4syZlJVKWDIaXZ4ah7j/3AO9VZTJo=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20260423230059.3180987-25-laurent.pinchart@ideasonboard.com>","References":"<20260423230059.3180987-1-laurent.pinchart@ideasonboard.com>\n\t<20260423230059.3180987-25-laurent.pinchart@ideasonboard.com>","Subject":"Re: [PATCH v3 24/37] test: yaml-parser: Fix typos in error messages","From":"Isaac Scott ","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 24 Apr 2026 16:44:35 +0100","Message-ID":"<177704547593.319800.1583784315591914966@t16>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]