{"id":26546,"url":"https://patchwork.libcamera.org/api/patches/26546/?format=json","web_url":"https://patchwork.libcamera.org/patch/26546/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260423230059.3180987-25-laurent.pinchart@ideasonboard.com>","date":"2026-04-23T23:00:46","name":"[v3,24/37] test: yaml-parser: Fix typos in error messages","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"dfd5a1267786961d5ef182fce7cd9006c7609949","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/26546/mbox/","series":[{"id":5883,"url":"https://patchwork.libcamera.org/api/series/5883/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5883","date":"2026-04-23T23:00:22","name":"libcamera: Global configuration file improvements","version":3,"mbox":"https://patchwork.libcamera.org/series/5883/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/26546/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/26546/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EC3E7BDCB5\n\tfor ;\n\tThu, 23 Apr 2026 23:01:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 75F0862FDD;\n\tFri, 24 Apr 2026 01:01:51 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7C93962FB7\n\tfor ;\n\tFri, 24 Apr 2026 01:01:34 +0200 (CEST)","from killaraus.ideasonboard.com\n\t(2001-14ba-703d-e500--2a1.rev.dnainternet.fi\n\t[IPv6:2001:14ba:703d:e500::2a1])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F330BC77\n\tfor ;\n\tFri, 24 Apr 2026 00:59:54 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"DIZjaTW0\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1776985195;\n\tbh=NLKSu4ahEffnyIzmiQhApix/r2n0nFFWD7S65XMZhVQ=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=DIZjaTW0qbPd01GFlUdnkE+F7Bx0C54g/wS7Gxo1LwENALmxM49zOdHlvV01TK8JU\n\trR/NFnlXp3d6wvn5n75mXpEkKkR3JkrHBhqvxem/Acm0pV1q6DHMsuBRAU31yH3VDS\n\tQAsWwotQ4divHbwI0LPEm861kylJuMJMM4/yrJjs=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH v3 24/37] test: yaml-parser: Fix typos in error messages","Date":"Fri, 24 Apr 2026 02:00:46 +0300","Message-ID":"<20260423230059.3180987-25-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260423230059.3180987-1-laurent.pinchart@ideasonboard.com>","References":"<20260423230059.3180987-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The unit test contains a few typos in error messages. Fix them.\n\nSigned-off-by: Laurent Pinchart \n---\n test/yaml-parser.cpp | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)","diff":"diff --git a/test/yaml-parser.cpp b/test/yaml-parser.cpp\nindex e8fd9ad61cd0..a4b26c17e1f9 100644\n--- a/test/yaml-parser.cpp\n+++ b/test/yaml-parser.cpp\n@@ -71,13 +71,13 @@ protected:\n \t\t/* Test parsing invalid YAML file. */\n \t\tFile file{ invalidYamlFile_ };\n \t\tif (!file.open(File::OpenModeFlag::ReadOnly)) {\n-\t\t\tstd::cerr << \"Fail to open invalid YAML file\" << std::endl;\n+\t\t\tstd::cerr << \"Failed to open invalid YAML file\" << std::endl;\n \t\t\treturn TestFail;\n \t\t}\n \n \t\tstd::unique_ptr root = YamlParser::parse(file);\n \t\tif (root) {\n-\t\t\tstd::cerr << \"Invalid YAML file parse successfully\" << std::endl;\n+\t\t\tstd::cerr << \"Invalid YAML file parsed successfully\" << std::endl;\n \t\t\treturn TestFail;\n \t\t}\n \n@@ -199,14 +199,14 @@ protected:\n \t\tauto &level1Obj = (*root)[\"level1\"];\n \n \t\tif (!level1Obj.isDictionary()) {\n-\t\t\tstd::cerr << \"level1 object fail to parse as Dictionary\" << std::endl;\n+\t\t\tstd::cerr << \"level1 object failed to parse as Dictionary\" << std::endl;\n \t\t\treturn TestFail;\n \t\t}\n \n \t\tauto &level2Obj = level1Obj[\"level2\"];\n \n \t\tif (!level2Obj.isList() || level2Obj.size() != 2) {\n-\t\t\tstd::cerr << \"level2 object should be a 2 elements list\" << std::endl;\n+\t\t\tstd::cerr << \"level2 object should be a 2 element list\" << std::endl;\n \t\t\treturn TestFail;\n \t\t}\n \n@@ -215,7 +215,7 @@ protected:\n \t\t firstElement.size() != 2 ||\n \t\t firstElement[0].get(0) != 1 ||\n \t\t firstElement[1].get(0) != 2) {\n-\t\t\tstd::cerr << \"The first element of level2 object fail to parse as integer list\" << std::endl;\n+\t\t\tstd::cerr << \"The first element of level2 object failed to parse as integer list\" << std::endl;\n \t\t\treturn TestFail;\n \t\t}\n \n@@ -231,7 +231,7 @@ protected:\n \t\t !secondElement.contains(\"two\") ||\n \t\t secondElement[\"one\"].get(0) != 1 ||\n \t\t secondElement[\"two\"].get(0) != 2) {\n-\t\t\tstd::cerr << \"The second element of level2 object fail to parse as dictionary\" << std::endl;\n+\t\t\tstd::cerr << \"The second element of level2 object failed to parse as dictionary\" << std::endl;\n \t\t\treturn TestFail;\n \t\t}\n \n","prefixes":["v3","24/37"]}