{"id":26528,"url":"https://patchwork.libcamera.org/api/patches/26528/?format=json","web_url":"https://patchwork.libcamera.org/patch/26528/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260423230059.3180987-7-laurent.pinchart@ideasonboard.com>","date":"2026-04-23T23:00:28","name":"[v3,06/37] libcamera: yaml_parser: Add function to set a YamlObject value","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"542006f72dbe216ee4211b4fcc82c6c7801a1b80","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/26528/mbox/","series":[{"id":5883,"url":"https://patchwork.libcamera.org/api/series/5883/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5883","date":"2026-04-23T23:00:22","name":"libcamera: Global configuration file improvements","version":3,"mbox":"https://patchwork.libcamera.org/series/5883/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/26528/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/26528/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 00344BDCB5\n\tfor ;\n\tThu, 23 Apr 2026 23:01:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0637B62F86;\n\tFri, 24 Apr 2026 01:01:15 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3626562F5D\n\tfor ;\n\tFri, 24 Apr 2026 01:01:09 +0200 (CEST)","from killaraus.ideasonboard.com\n\t(2001-14ba-703d-e500--2a1.rev.dnainternet.fi\n\t[IPv6:2001:14ba:703d:e500::2a1])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A4ACF9A6\n\tfor ;\n\tFri, 24 Apr 2026 00:59:29 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"nheJTvKT\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1776985169;\n\tbh=TZbqWbmHjLgu+HQLVtGYpdUZlq/uo4VB5e+cAOBAzcw=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=nheJTvKTO83Ke8Y64vIXsR51lLcDySFyowPDYO8/xT1cNn9cDw7ds3RxjWhgOedqb\n\t1ROugWPj7SajKJfYDGAFofiTiSP0E5oPEkApXE6jJlhZVcg1M0xk8Ck2AQRWwhuK2B\n\td7k9iDchn+rxUM2CnpeuBZ1wheUfXPXIOo8HVPFY=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH v3 06/37] libcamera: yaml_parser: Add function to set a\n\tYamlObject value","Date":"Fri, 24 Apr 2026 02:00:28 +0300","Message-ID":"<20260423230059.3180987-7-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260423230059.3180987-1-laurent.pinchart@ideasonboard.com>","References":"<20260423230059.3180987-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add a YamlObject::set() function to set the value of an object, with\nspecializations for scalar types.\n\nSigned-off-by: Laurent Pinchart \nReviewed-by: Isaac Scott \nReviewed-by: Barnabás Pőcze \n---\nChanges since v2:\n\n- Drop std::forward()\n\nChanges since v1:\n\n- Remove cv in addition to reference in YamlObject::set()\n---\n include/libcamera/internal/yaml_parser.h | 8 ++++\n src/libcamera/yaml_parser.cpp | 59 ++++++++++++++++++++++++\n 2 files changed, 67 insertions(+)","diff":"diff --git a/include/libcamera/internal/yaml_parser.h b/include/libcamera/internal/yaml_parser.h\nindex 7953befe11e2..0666762308ac 100644\n--- a/include/libcamera/internal/yaml_parser.h\n+++ b/include/libcamera/internal/yaml_parser.h\n@@ -182,6 +182,13 @@ public:\n \t\treturn get().value_or(std::forward(defaultValue));\n \t}\n \n+\ttemplate\n+\tvoid set(T &&value)\n+\t{\n+\t\treturn Accessor>>{}\n+\t\t\t.set(*this, std::forward(value));\n+\t}\n+\n \tDictAdapter asDict() const { return DictAdapter{ list_ }; }\n \tListAdapter asList() const { return ListAdapter{ list_ }; }\n \n@@ -207,6 +214,7 @@ private:\n \ttemplate\n \tstruct Accessor {\n \t\tstd::optional get(const YamlObject &obj) const;\n+\t\tvoid set(YamlObject &obj, T value);\n \t};\n \n \tType type_;\ndiff --git a/src/libcamera/yaml_parser.cpp b/src/libcamera/yaml_parser.cpp\nindex 399e7529385f..8c84f560ff0f 100644\n--- a/src/libcamera/yaml_parser.cpp\n+++ b/src/libcamera/yaml_parser.cpp\n@@ -137,6 +137,20 @@ std::size_t YamlObject::size() const\n * \\return The YamlObject value, or \\a defaultValue if parsing failed\n */\n \n+/**\n+ * \\fn template YamlObject::set(T &&value)\n+ * \\brief Set the value of a YamlObject\n+ * \\param[in] value The value\n+ *\n+ * This function sets the value stored in a YamlObject to \\a value. The value is\n+ * converted to a string in an implementation-specific way that guarantees that\n+ * subsequent calls to get() will return the same value.\n+ *\n+ * Values can only be set on YamlObject of Type::Value type or empty YamlObject.\n+ * Attempting to set a value on an object of type Type::Dict or Type::List does\n+ * not modify the YamlObject.\n+ */\n+\n #ifndef __DOXYGEN__\n \n template<>\n@@ -154,6 +168,16 @@ YamlObject::Accessor::get(const YamlObject &obj) const\n \treturn std::nullopt;\n }\n \n+template<>\n+void YamlObject::Accessor::set(YamlObject &obj, bool value)\n+{\n+\tif (obj.type_ != Type::Empty && obj.type_ != Type::Value)\n+\t\treturn;\n+\n+\tobj.type_ = Type::Value;\n+\tobj.value_ = value ? \"true\" : \"false\";\n+}\n+\n template\n struct YamlObject::Accessor ||\n@@ -178,6 +202,15 @@ struct YamlObject::Accessor;\n@@ -194,6 +227,12 @@ YamlObject::Accessor::get(const YamlObject &obj) const\n \treturn obj.get();\n }\n \n+template<>\n+void YamlObject::Accessor::set(YamlObject &obj, float value)\n+{\n+\tobj.set(value);\n+}\n+\n template<>\n std::optional\n YamlObject::Accessor::get(const YamlObject &obj) const\n@@ -215,6 +254,16 @@ YamlObject::Accessor::get(const YamlObject &obj) const\n \treturn value;\n }\n \n+template<>\n+void YamlObject::Accessor::set(YamlObject &obj, double value)\n+{\n+\tif (obj.type_ != Type::Empty && obj.type_ != Type::Value)\n+\t\treturn;\n+\n+\tobj.type_ = Type::Value;\n+\tobj.value_ = std::to_string(value);\n+}\n+\n template<>\n std::optional\n YamlObject::Accessor::get(const YamlObject &obj) const\n@@ -225,6 +274,16 @@ YamlObject::Accessor::get(const YamlObject &obj) const\n \treturn obj.value_;\n }\n \n+template<>\n+void YamlObject::Accessor::set(YamlObject &obj, std::string value)\n+{\n+\tif (obj.type_ != Type::Empty && obj.type_ != Type::Value)\n+\t\treturn;\n+\n+\tobj.type_ = Type::Value;\n+\tobj.value_ = std::move(value);\n+}\n+\n template<>\n std::optional\n YamlObject::Accessor::get(const YamlObject &obj) const\n","prefixes":["v3","06/37"]}