{"id":26524,"url":"https://patchwork.libcamera.org/api/patches/26524/?format=json","web_url":"https://patchwork.libcamera.org/patch/26524/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260423230059.3180987-3-laurent.pinchart@ideasonboard.com>","date":"2026-04-23T23:00:24","name":"[v3,02/37] libcamera: yaml_parser: Use std::make_unique<>","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"5fdb345427c65c483d8dbc41666e4455b47a83e6","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/26524/mbox/","series":[{"id":5883,"url":"https://patchwork.libcamera.org/api/series/5883/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5883","date":"2026-04-23T23:00:22","name":"libcamera: Global configuration file improvements","version":3,"mbox":"https://patchwork.libcamera.org/series/5883/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/26524/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/26524/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A1E0BBDCB5\n\tfor ;\n\tThu, 23 Apr 2026 23:01:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C406062F60;\n\tFri, 24 Apr 2026 01:01:06 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9A79762F57\n\tfor ;\n\tFri, 24 Apr 2026 01:01:03 +0200 (CEST)","from killaraus.ideasonboard.com\n\t(2001-14ba-703d-e500--2a1.rev.dnainternet.fi\n\t[IPv6:2001:14ba:703d:e500::2a1])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1AF7434\n\tfor ;\n\tFri, 24 Apr 2026 00:59:24 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"v+or/6WT\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1776985164;\n\tbh=vqb+V5KiW+iQzA+wKfrOttyEJip+8YUkGI2wXdO0r/4=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=v+or/6WT7In/fLhwVIQJaZ5Ds3iq+pPf9rvoYz0vEckNyxL1FOJDJQl2vzXp+V1sy\n\tqQ3uMlV2WCfPKvY8yOxWvoGQDve3242ganNthB5UyUhLeNbescixSvtTNNNgLM4xAx\n\thJl7rcl98oq4w1gWgSs/U8watV6StHVxSi8fvU2w=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH v3 02/37] libcamera: yaml_parser: Use std::make_unique<>","Date":"Fri, 24 Apr 2026 02:00:24 +0300","Message-ID":"<20260423230059.3180987-3-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260423230059.3180987-1-laurent.pinchart@ideasonboard.com>","References":"<20260423230059.3180987-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The YamlParser::parse() function constructs a std::unique_ptr<> instance\nwith a manual call to operator new. Replace it with std::make_unique<>.\n\nSigned-off-by: Laurent Pinchart \nReviewed-by: Barnabás Pőcze \nReviewed-by: Stefan Klug \n---\n src/libcamera/yaml_parser.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/yaml_parser.cpp b/src/libcamera/yaml_parser.cpp\nindex e13b5faedd81..791fb6eeafa8 100644\n--- a/src/libcamera/yaml_parser.cpp\n+++ b/src/libcamera/yaml_parser.cpp\n@@ -769,7 +769,7 @@ std::unique_ptr YamlParser::parse(File &file)\n \tif (context.init(file))\n \t\treturn nullptr;\n \n-\tstd::unique_ptr root(new YamlObject());\n+\tstd::unique_ptr root = std::make_unique();\n \n \tif (context.parseContent(*root)) {\n \t\tLOG(YamlParser, Error)\n","prefixes":["v3","02/37"]}