[{"id":38601,"web_url":"https://patchwork.libcamera.org/comment/38601/","msgid":"<177608602102.1693075.16347552655661840824@ping.linuxembedded.co.uk>","date":"2026-04-13T13:13:41","subject":"Re: [PATCH v1 3/3] libcamera: software_isp: debayer_egl: Remove\n\tunnecessary declarations","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2026-04-13 12:47:13)\n> These functions are not defined, so remove them.\n> \n> Signed-off-by: Barnabás Pőcze \n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/libcamera/software_isp/debayer_egl.h | 9 ---------\n> 1 file changed, 9 deletions(-)\n> \n> diff --git a/src/libcamera/software_isp/debayer_egl.h b/src/libcamera/software_isp/debayer_egl.h\n> index d563bfa55..644f6604e 100644\n> --- a/src/libcamera/software_isp/debayer_egl.h\n> +++ b/src/libcamera/software_isp/debayer_egl.h\n> @@ -61,18 +61,9 @@ public:\n> private:\n> static int getInputConfig(PixelFormat inputFormat, DebayerInputConfig &config);\n> static int getOutputConfig(PixelFormat outputFormat, DebayerOutputConfig &config);\n> - int setupStandardBayerOrder(BayerFormat::Order order);\n> - void pushEnv(std::vector &shaderEnv, const char *str);\n> int initBayerShaders(PixelFormat inputFormat, PixelFormat outputFormat);\n> - int initEGLContext();\n> - int generateTextures();\n> - int compileShaderProgram(GLuint &shaderId, GLenum shaderType,\n> - unsigned char *shaderData, int shaderDataLen,\n> - std::vector shaderEnv);\n> - int linkShaderProgram(void);\n> int getShaderVariableLocations();\n> void setShaderVariableValues(const DebayerParams ¶ms);\n> - void configureTexture(GLuint &texture);\n> int debayerGPU(MappedFrameBuffer &in, int out_fd, const DebayerParams ¶ms);\n> \n> /* Shader program identifiers */\n> -- \n> 2.53.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 63656BDCBD\n\tfor ;\n\tMon, 13 Apr 2026 13:13:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 928C262E8C;\n\tMon, 13 Apr 2026 15:13:45 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6D83B6271A\n\tfor ;\n\tMon, 13 Apr 2026 15:13:44 +0200 (CEST)","from monstersaurus.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7A8617FE;\n\tMon, 13 Apr 2026 15:12:12 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"rlYWGJaW\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1776085932;\n\tbh=9fRQI4kKuKDFD210C+Xs1ifOPuKbNJf+CYCXgGf3q1w=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=rlYWGJaWY4/MNCnJFl23FYX1M0bDCAtyjlbdl/d9TQVW+Q+bykRrU8cQC7o+EgeZ3\n\t5IR7MeEvlXz3GWZ8s5cHut8RYtMxyOHsJdHN+vmcEpkXq1rkNmeuEoDXLjOZI3D/Xq\n\tqJIM+a/YVAwIZ+G5FnpRDBBpCdam3AgM2JQlzcEI=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20260413114713.426459-3-barnabas.pocze@ideasonboard.com>","References":"<20260413114713.426459-1-barnabas.pocze@ideasonboard.com>\n\t<20260413114713.426459-3-barnabas.pocze@ideasonboard.com>","Subject":"Re: [PATCH v1 3/3] libcamera: software_isp: debayer_egl: Remove\n\tunnecessary declarations","From":"Kieran Bingham ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 13 Apr 2026 14:13:41 +0100","Message-ID":"<177608602102.1693075.16347552655661840824@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]