[{"id":3461,"web_url":"https://patchwork.libcamera.org/comment/3461/","msgid":"<51b6d32f-1476-7876-4e71-42e6948470d0@ideasonboard.com>","date":"2020-01-16T22:00:15","subject":"Re: [libcamera-devel] [PATCH 1/2] checkstyle: Move from pep8 to\n\tpycodestyle","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Nicolas,\n\nThank you for the patch\n\nOn 16/01/2020 18:26, nicolas@ndufresne.ca wrote:\n> From: Nicolas Dufresne \n> \n> The tool has been renamed in 2016 to make it more obvious what it\n> is doing. There is no other changes needed on our side.\n> \n> See https://github.com/PyCQA/pycodestyle/issues/466\n\n\nSounds good to me, and the updated naming is available on my system at\nleast.\n\n> Signed-off-by: Nicolas Dufresne \n\nExcept for the mode change, which prevents me executing the script from\nthe command line...\n\nReviewed-by: Kieran Bingham \n\n> ---\n> utils/checkstyle.py | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> mode change 100755 => 100644 utils/checkstyle.py\n\nSomething happened here... The mode changed?\n\nThat prevented me from executing the script...\n\n> diff --git a/utils/checkstyle.py b/utils/checkstyle.py\n> old mode 100755\n> new mode 100644\n> index 93f0291..7edea25\n> --- a/utils/checkstyle.py\n> +++ b/utils/checkstyle.py\n> @@ -321,10 +321,10 @@ class Pep8Checker(StyleChecker):\n> data = ''.join(self.__content).encode('utf-8')\n> \n> try:\n> - ret = subprocess.run(['pep8', '--ignore=E501', '-'],\n> + ret = subprocess.run(['pycodestyle', '--ignore=E501', '-'],\n> input=data, stdout=subprocess.PIPE)\n> except FileNotFoundError:\n> - issues.append(StyleIssue(0, None, \"Please install pep8 to validate python additions\"))\n> + issues.append(StyleIssue(0, None, \"Please install pycodestyle to validate python additions\"))\n> return issues\n> \n> results = ret.stdout.decode('utf-8').splitlines()\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0245260705\n\tfor ;\n\tThu, 16 Jan 2020 23:00:18 +0100 (CET)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C77252D2;\n\tThu, 16 Jan 2020 23:00:17 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1579212018;\n\tbh=WI8Yt07gb3oe+kF6a6PuQNrAheXyaNdKcoFk+QpTdF0=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=hrVW4i2/SUteDxTG6EPxGE3XYjFXpP4Ce1cbTAaANqAkbew6pF1Lt6hMiFbV1+Ytd\n\tRIa//DvWykCBq1fonjjeUGxTbYDzLKGWsn+DEGLKRZfQefc9iaGlFRGwZn32dngmLm\n\tGJMq4ZgxVHsq7tSl3zAodUUL1AG0SZz7nHWtIyoQ=","Reply-To":"kieran.bingham@ideasonboard.com","To":"nicolas@ndufresne.ca, libcamera-devel@lists.libcamera.org","Cc":"Nicolas Dufresne ","References":"<20200116182603.108966-1-nicolas@ndufresne.ca>\n\t<20200116182603.108966-2-nicolas@ndufresne.ca>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<51b6d32f-1476-7876-4e71-42e6948470d0@ideasonboard.com>","Date":"Thu, 16 Jan 2020 22:00:15 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.9.0","MIME-Version":"1.0","In-Reply-To":"<20200116182603.108966-2-nicolas@ndufresne.ca>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH 1/2] checkstyle: Move from pep8 to\n\tpycodestyle","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 16 Jan 2020 22:00:19 -0000"}},{"id":3470,"web_url":"https://patchwork.libcamera.org/comment/3470/","msgid":"<526f96a2844ec09574c927c640e485d8ab7d81e1.camel@ndufresne.ca>","date":"2020-01-17T00:50:27","subject":"Re: [libcamera-devel] [PATCH 1/2] checkstyle: Move from pep8 to\n\tpycodestyle","submitter":{"id":30,"url":"https://patchwork.libcamera.org/api/people/30/","name":"Nicolas Dufresne","email":"nicolas@ndufresne.ca"},"content":"Le jeudi 16 janvier 2020 à 22:00 +0000, Kieran Bingham a écrit :\n> Hi Nicolas,\n> \n> Thank you for the patch\n> \n> On 16/01/2020 18:26, nicolas@ndufresne.ca wrote:\n> > From: Nicolas Dufresne \n> > \n> > The tool has been renamed in 2016 to make it more obvious what it\n> > is doing. There is no other changes needed on our side.\n> > \n> > See https://github.com/PyCQA/pycodestyle/issues/466\n> \n> Sounds good to me, and the updated naming is available on my system at\n> least.\n> \n> > Signed-off-by: Nicolas Dufresne \n> \n> Except for the mode change, which prevents me executing the script from\n> the command line...\n\nThat's is really weird, since it's still executable on my machine. It\nsmells like a pretty wrong git settings, need to search that up. I got\na fresh installed system, so loads of things to reconfigure, I didn't\nexpect this one though.\n\nAnyway, will be fixed in the version.\n\n> \n> Reviewed-by: Kieran Bingham \n> \n> > ---\n> > utils/checkstyle.py | 4 ++--\n> > 1 file changed, 2 insertions(+), 2 deletions(-)\n> > mode change 100755 => 100644 utils/checkstyle.py\n> \n> Something happened here... The mode changed?\n> \n> That prevented me from executing the script...\n> \n> > diff --git a/utils/checkstyle.py b/utils/checkstyle.py\n> > old mode 100755\n> > new mode 100644\n> > index 93f0291..7edea25\n> > --- a/utils/checkstyle.py\n> > +++ b/utils/checkstyle.py\n> > @@ -321,10 +321,10 @@ class Pep8Checker(StyleChecker):\n> > data = ''.join(self.__content).encode('utf-8')\n> > \n> > try:\n> > - ret = subprocess.run(['pep8', '--ignore=E501', '-'],\n> > + ret = subprocess.run(['pycodestyle', '--ignore=E501', '-'],\n> > input=data, stdout=subprocess.PIPE)\n> > except FileNotFoundError:\n> > - issues.append(StyleIssue(0, None, \"Please install pep8 to validate python additions\"))\n> > + issues.append(StyleIssue(0, None, \"Please install pycodestyle to validate python additions\"))\n> > return issues\n> > \n> > results = ret.stdout.decode('utf-8').splitlines()\n> >","headers":{"Return-Path":"","Received":["from mail-qk1-x742.google.com (mail-qk1-x742.google.com\n\t[IPv6:2607:f8b0:4864:20::742])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A1F4D6075C\n\tfor ;\n\tFri, 17 Jan 2020 01:50:30 +0100 (CET)","by mail-qk1-x742.google.com with SMTP id t129so21122521qke.10\n\tfor ;\n\tThu, 16 Jan 2020 16:50:30 -0800 (PST)","from skullcanyon ([192.222.193.21])\n\tby smtp.gmail.com with ESMTPSA id\n\tj15sm11814764qtn.37.2020.01.16.16.50.28\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 16 Jan 2020 16:50:28 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ndufresne-ca.20150623.gappssmtp.com; s=20150623;\n\th=message-id:subject:from:to:date:in-reply-to:references:user-agent\n\t:mime-version:content-transfer-encoding;\n\tbh=zVSITLIja2tvcOcmDQjfZvPvXEpi0pDH31AI4WtEbW0=;\n\tb=Rr1+hn+V4R0DjcovrXppxNLkf5qZvZqlNRycjjMmayQ9AaX83fpqIIVeY2K7atTdjJ\n\tV3R1kPRGEai/ZlsujE7CboexiadQCd35R/cZ1efj8h6EkfNSSIPjP8OiLGBEeAMBB/y1\n\tI6YxOh8Mtjl4YPo5WzM7USESuXvZBrUiD7BVmIj91HjL+4rgfgREZLBI6cWHXj9nizKK\n\tENW1ODrJ2YHSRPmPJ9/8eN1cLSPKXNeC/wrJNWxZr0m3BnJbCXFEDAp0Af09+hCdSj/p\n\t0BoTdPYEXkJJWexI0pntJ5R6DNhcp4mtTk6T0lNtWOsSwJ1gUiqUPNsMW762Td5mg6KA\n\tOwzw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:message-id:subject:from:to:date:in-reply-to\n\t:references:user-agent:mime-version:content-transfer-encoding;\n\tbh=zVSITLIja2tvcOcmDQjfZvPvXEpi0pDH31AI4WtEbW0=;\n\tb=kN3aQwXtVSzQp6GD+5GUeysAzCM6KFDG9o2tMGYMKXlqxx68v0RsL05r0mpFYJHZb9\n\teApdvyPM3rFCI/H+DfPAUKw/8aZe5+MiukUlO4Pw4/xGWhLBWMg1RhKdhb9+VWoJ+73m\n\t6vCO8oY92XScEX5EIkJUJE8pGNFT9rHdKpPn5K5jjQRAtAfOC6++79gFQAUpuWLTiM0c\n\tq8whb+OUNZW7G9xqyWh1dkKdL1Aztwd5onBldOJ9X8aSlzYuzdyI1BsuAVnzFLjgnaYn\n\tR3faTGC9QRDmbx6FxGKJmCiWBsKaNlaknIIXergKmAJpeXAQYb0EF+/bs3k6Rn+usrw/\n\t2TaQ==","X-Gm-Message-State":"APjAAAV3m6N6q4i2LIzcEX36MX3B6cNCaYTFhMGK+hLlKKyVEtlZX+B7\n\tBparmkEk13u58Hj/IdkAmUUgsqGr3Z0=","X-Google-Smtp-Source":"APXvYqzorTX5b6rSAFKQ5g0fbzjdZreKepYBJBZjl26KQqruIiV8izv6UWdFaY1KymEmS+O/aS4zAw==","X-Received":"by 2002:a37:5d1:: with SMTP id 200mr1087766qkf.492.1579222229424;\n\tThu, 16 Jan 2020 16:50:29 -0800 (PST)","Message-ID":"<526f96a2844ec09574c927c640e485d8ab7d81e1.camel@ndufresne.ca>","From":"Nicolas Dufresne ","To":"kieran.bingham@ideasonboard.com, libcamera-devel@lists.libcamera.org","Date":"Thu, 16 Jan 2020 19:50:27 -0500","In-Reply-To":"<51b6d32f-1476-7876-4e71-42e6948470d0@ideasonboard.com>","References":"<20200116182603.108966-1-nicolas@ndufresne.ca>\n\t<20200116182603.108966-2-nicolas@ndufresne.ca>\n\t<51b6d32f-1476-7876-4e71-42e6948470d0@ideasonboard.com>","Content-Type":"text/plain; charset=\"UTF-8\"","User-Agent":"Evolution 3.34.2 (3.34.2-1.fc31) ","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH 1/2] checkstyle: Move from pep8 to\n\tpycodestyle","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 17 Jan 2020 00:50:30 -0000"}}]