{"id":26509,"url":"https://patchwork.libcamera.org/api/patches/26509/?format=json","web_url":"https://patchwork.libcamera.org/patch/26509/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260408115630.12456-3-johannes.goede@oss.qualcomm.com>","date":"2026-04-08T11:56:29","name":"[2/3] libcamera: media_object: Add MediaEntity::disableLinks()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"2301e2657bf8ee7e9f6a6e53d3e68a73a37f30d4","submitter":{"id":242,"url":"https://patchwork.libcamera.org/api/people/242/?format=json","name":"Hans de Goede","email":"johannes.goede@oss.qualcomm.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/26509/mbox/","series":[{"id":5877,"url":"https://patchwork.libcamera.org/api/series/5877/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5877","date":"2026-04-08T11:56:27","name":"libcamera: Finer grained MediaDevice locking","version":1,"mbox":"https://patchwork.libcamera.org/series/5877/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/26509/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/26509/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EBB63BDCBD\n\tfor ;\n\tWed, 8 Apr 2026 11:56:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AD32662E11;\n\tWed, 8 Apr 2026 13:56:40 +0200 (CEST)","from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com\n\t[205.220.168.131])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C4E4C62E0D\n\tfor ;\n\tWed, 8 Apr 2026 13:56:38 +0200 (CEST)","from pps.filterd (m0279867.ppops.net [127.0.0.1])\n\tby mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n\t638Aii0r249550 for ;\n\tWed, 8 Apr 2026 11:56:37 GMT","from mail-qt1-f199.google.com (mail-qt1-f199.google.com\n\t[209.85.160.199])\n\tby mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dd8x9ayhy-1\n\t(version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n\tfor ;\n\tWed, 08 Apr 2026 11:56:37 +0000 (GMT)","by mail-qt1-f199.google.com with SMTP id\n\td75a77b69052e-50d5d1c2289so147135151cf.2\n\tfor ;\n\tWed, 08 Apr 2026 04:56:37 -0700 (PDT)","from t14s\n\t(2001-1c00-0c32-7800-07d4-cca3-ec08-7ac7.cable.dynamic.v6.ziggo.nl.\n\t[2001:1c00:c32:7800:7d4:cca3:ec08:7ac7])\n\tby smtp.gmail.com with ESMTPSA id\n\ta640c23a62f3a-b9c3c97219dsm632410766b.5.2026.04.08.04.56.33\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 08 Apr 2026 04:56:34 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=qualcomm.com header.i=@qualcomm.com\n\theader.b=\"ga+odE8H\"; dkim=pass (2048-bit key;\n\tunprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n\theader.b=\"Uo+VBgsG\"; dkim-atps=neutral","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n\tcc:content-transfer-encoding:date:from:in-reply-to:message-id\n\t:mime-version:references:subject:to; s=qcppdkim1; bh=VGDyW/FEB0G\n\tbROb7MhWm4EA0EZyx0U/3giZ87KYrgO0=; b=ga+odE8HhiDFgCXdFfPtfhTgDXL\n\t4bKPYKqQ+FYv2ZvkxME0vL270/J2uhqt3Wuh4lDj3BORXB3ZbcTcpGfDtSqu7ubm\n\t4ZJYQQ1yrPKBx8EHoSF7bjNfRNtMoQX/Iddo4GkYzm+VY/Hk8ZtfzOzIhFNvEblq\n\tdDfwcN8BAZGXiPVqlCav8oGEi5S04zv+Fm4MxIGU0Y1P6ykZoPo+krAu/JaHuXJt\n\tHn+S2XFNw7ag+ccI/qDTtnPYZWZ2oGACloUb8ennTUDjKuDrhJ3JIdDZV0GchGBn\n\tut4qwqLnMRCATL/MMpZEFAl/MDUDvaIPB9HbLVS36JtbHdDWy/3aCW2SaRA==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=oss.qualcomm.com; s=google; t=1775649395; x=1776254195;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=VGDyW/FEB0GbROb7MhWm4EA0EZyx0U/3giZ87KYrgO0=;\n\tb=Uo+VBgsGqEvdPItDTKi6oHVLbwRTlv7pwUjXH889fznVNtc9Gta93sknLvBXBoP5Cd\n\tnlT1n179JKM2cl/ahNhXuV11CP7f91LQo7aCaFLPfaamzWyZFyzBtdGWk4FMRnVbQaVg\n\tbREA8jJ3jqBLFp0tgdAXt5rNFl9PFPZqmAIScPnX6xAp1JYPbZT+PjuyzhMtFbl+h91C\n\tLLJPdsXz6qR2s3GXDTCS5kOHbwlHvqEF6R6n0VwV3DNbnuuSh1FsLqpqjXwFUsFHGCyS\n\t07IudMJRWT7wE2BCSE+cJmWAn5HGQ6oWjBAKJLIh/6FtFMmGmf6hJQPY3+yKSKAXqobI\n\t5g6g=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20251104; t=1775649395; x=1776254195;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=VGDyW/FEB0GbROb7MhWm4EA0EZyx0U/3giZ87KYrgO0=;\n\tb=Zmwga7a/pXLJHEBTI73NXUXrFKFp6KzjpadQFBIT336EWV71OMTAou1Rg0Thb6H0Rf\n\tC+kDCXl2Nwu05vqSmsLaKFfeKdVr1xY0fmPOKetqO/TAEYnGFVzfmMDMr0BHzanjxA1r\n\tqFAfyU6q5Dd6dkx3eONXT79zL8UkA/oC0P/DazWOM+Zk1TygFwfaaE15ayt9eyPiSdtL\n\tNnmSAxZZCnw7LpTMZEJRVEMko+7K+kM3NSPCeSjK8lnXzKiDxpKJeaWPwYnMbqZLdaWO\n\tZimB5hYrDijLpq7JfFDX6O7+MC0oQ4hT+5brwhbY19X6NxZ0LXzPBT1o8VvJq50QceWL\n\t1nnA==","X-Gm-Message-State":"AOJu0YwVrIeg1dafBuA56L+4ZOU5wxX9uc9Vy+F1BHPDe4w39tgqb8ff\n\t9ywzxpj5Ox2ujUrA2vob5LFqzkDE4D5KQ+rkn+rBIzE8rVEc9OlexWT4TzrZcvO+OPqEohLKQsM\n\tzAu0KSzoTMIrTRBMpyQet4j6/sakJWt0sUXYu9u7VhBj/7g7ae9oU5wZVzb6Aq06VW0kVT+sLl0\n\t5Ic4TPTwTL","X-Gm-Gg":"AeBDievvgOR7hOVxup2phm2OMQXB3T3VeSjTlScR01M0xbm7mG5ldrcmxA33QXuJzBn\n\tRh113D6btwa1VJfbtFqMh0txEw5ExZQjkSLPbrJWuib8XxgbyAjv7ETrTCRE/qesGBZYgaoN50V\n\tJBi83ONvM99t27VxyD1w2FnOX9kYOfhXzvIDFCSu09pa5DPZWlrhBwoj6Xy1o4mK0UYX1vAy8HZ\n\tzkS3bWzulmDRxzopXvG5d4qNCMwDsVnfgtlsLQBGi8ekAhonMRsCteZLNA5G1dNgtPZ3jFCA2TP\n\t7NNC8X/L9gv58AOaDPoTZWDGYphU2RYOYWXDi902ANgkAe8DaO13Z6JWApoFP1Dd1/pb7We/k4X\n\t3mL8VjOqDnPimLQApa2KERDuQwFBpY3hhWJlUByh1jTrPGIUKdIZLULmHfA+6uAE2UGytry8L/P\n\tmGLbFHegZw8V3DXgpZaUGFWJ6mg/JL+GDJ","X-Received":["by 2002:a05:622a:aa0b:10b0:509:2677:68f7 with SMTP id\n\td75a77b69052e-50d6260b06dmr244381621cf.5.1775649395568; \n\tWed, 08 Apr 2026 04:56:35 -0700 (PDT)","by 2002:a05:622a:aa0b:10b0:509:2677:68f7 with SMTP id\n\td75a77b69052e-50d6260b06dmr244381381cf.5.1775649395117; \n\tWed, 08 Apr 2026 04:56:35 -0700 (PDT)"],"From":"Hans de Goede ","To":"libcamera-devel@lists.libcamera.org","Cc":"Loic Poulain ,\n\tHans de Goede ","Subject":"[PATCH 2/3] libcamera: media_object: Add MediaEntity::disableLinks()","Date":"Wed, 8 Apr 2026 13:56:29 +0200","Message-ID":"<20260408115630.12456-3-johannes.goede@oss.qualcomm.com>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260408115630.12456-1-johannes.goede@oss.qualcomm.com>","References":"<20260408115630.12456-1-johannes.goede@oss.qualcomm.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Authority-Analysis":"v=2.4 cv=Rr716imK c=1 sm=1 tr=0 ts=69d64275 cx=c_pps\n\ta=WeENfcodrlLV9YRTxbY/uA==:117 a=xqWC_Br6kY4A:10 a=A5OVakUREuEA:10\n\ta=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22\n\ta=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=jrADUgksUtfPzxcU8k8A:9\n\ta=kacYvNCVWA4VmyqE58fU:22","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDA4MDExMCBTYWx0ZWRfXyiBV9gi7gj39\n\t4vFnsq2kbEW6R3faCoHQGu7h+sDeKpV2EforoztUySn1WdFNmwFJPs4/a4R1YsR7Qld7yjzHIRp\n\tmucvQHi+Vh7//NGx8DHexvMHKQPF423GoaNC+6EKx8J2QMhd/n01N4KtqhUmyHXXisvUphDJ5Zv\n\tMwGmCIrppSLOm9gZgS9lSB/WN3lG94NsnSa06PmRvtdtJ0G5Yp5PhKQKsXDGdesb95ModnqS1PY\n\tbrfx9rn0ugKlpHrSAso8Pg3RbpH7zB38jqUbWNr7LQZLkxDePdlUDrDuzdkFutHmGiQ2zlXz+m4\n\taUGVhWyZz4ZVhkvR5hkFwHefuQjc56X2dgMzoBhd+zp1aq8lIV6vkByfF0YD/TDOIaryshMAmuW\n\tr6Ey6b+MmDQjZoF9VlyokKj7wRmXneYO1pT45zh9FH+fPms3mwxqxGAK5OZJXAFb85IP+MKxPcT\n\tN1Xn9LdnzHhHHtSzskQ==","X-Proofpoint-ORIG-GUID":"V_7hWNY1pGtLxZwPjX7wKYZmECX1Wa2I","X-Proofpoint-GUID":"V_7hWNY1pGtLxZwPjX7wKYZmECX1Wa2I","X-Proofpoint-Virus-Version":"vendor=baseguard\n\tengine=ICAP:2.0.293, Aquarius:18.0.1143, Hydra:6.1.51,\n\tFMLib:17.12.100.49\n\tdefinitions=2026-04-08_03,2026-04-08_01,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\timpostorscore=0 priorityscore=1501 suspectscore=0 malwarescore=0\n\tclxscore=1015 bulkscore=0 phishscore=0 adultscore=0 spamscore=0\n\tlowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc=\n\troute=outbound adjust=0 reason=mlx scancount=1\n\tengine=8.22.0-2604010000\n\tdefinitions=main-2604080110","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Some pipeline-handlers may want finer-grained control over disabling\nlinks then MediaDevice::disableLinks() which simply disables all\nlinks on a media-device.\n\nAdd a new MediaEntity::disableLinks() method which disables the links\non a single MediaEntity and use that in MediaDevice::disableLinks()\nto avoid code duplication.\n\nSigned-off-by: Hans de Goede \n---\n include/libcamera/internal/media_object.h | 1 +\n src/libcamera/media_device.cpp | 16 +++-----------\n src/libcamera/media_object.cpp | 27 +++++++++++++++++++++++\n 3 files changed, 31 insertions(+), 13 deletions(-)","diff":"diff --git a/include/libcamera/internal/media_object.h b/include/libcamera/internal/media_object.h\nindex 54e2e5cef..121e80bac 100644\n--- a/include/libcamera/internal/media_object.h\n+++ b/include/libcamera/internal/media_object.h\n@@ -118,6 +118,7 @@ public:\n \tconst MediaPad *getPadById(unsigned int id) const;\n \n \tint setDeviceNode(const std::string &deviceNode);\n+\tint disableLinks() const;\n \n private:\n \tLIBCAMERA_DISABLE_COPY_AND_MOVE(MediaEntity)\ndiff --git a/src/libcamera/media_device.cpp b/src/libcamera/media_device.cpp\nindex 3f974eaab..4833d4bba 100644\n--- a/src/libcamera/media_device.cpp\n+++ b/src/libcamera/media_device.cpp\n@@ -463,19 +463,9 @@ MediaLink *MediaDevice::link(const MediaPad *source, const MediaPad *sink)\n int MediaDevice::disableLinks()\n {\n \tfor (MediaEntity *entity : entities_) {\n-\t\tfor (MediaPad *pad : entity->pads()) {\n-\t\t\tif (!(pad->flags() & MEDIA_PAD_FL_SOURCE))\n-\t\t\t\tcontinue;\n-\n-\t\t\tfor (MediaLink *link : pad->links()) {\n-\t\t\t\tif (link->flags() & MEDIA_LNK_FL_IMMUTABLE)\n-\t\t\t\t\tcontinue;\n-\n-\t\t\t\tint ret = link->setEnabled(false);\n-\t\t\t\tif (ret)\n-\t\t\t\t\treturn ret;\n-\t\t\t}\n-\t\t}\n+\t\tint ret = entity->disableLinks();\n+\t\tif (ret)\n+\t\t\treturn ret;\n \t}\n \n \treturn 0;\ndiff --git a/src/libcamera/media_object.cpp b/src/libcamera/media_object.cpp\nindex 3e3772a62..82ba5f4b2 100644\n--- a/src/libcamera/media_object.cpp\n+++ b/src/libcamera/media_object.cpp\n@@ -428,6 +428,33 @@ int MediaEntity::setDeviceNode(const std::string &deviceNode)\n \treturn 0;\n }\n \n+/**\n+ * \\brief Disable all links on the media entity\n+ *\n+ * Disable all the media entity links, clearing the MEDIA_LNK_FL_ENABLED flag\n+ * on links which are not flagged as IMMUTABLE.\n+ *\n+ * \\return 0 on success or a negative error code otherwise\n+ */\n+int MediaEntity::disableLinks() const\n+{\n+\tfor (MediaPad *pad : pads_) {\n+\t\tif (!(pad->flags() & MEDIA_PAD_FL_SOURCE))\n+\t\t\tcontinue;\n+\n+\t\tfor (MediaLink *link : pad->links()) {\n+\t\t\tif (link->flags() & MEDIA_LNK_FL_IMMUTABLE)\n+\t\t\t\tcontinue;\n+\n+\t\t\tint ret = link->setEnabled(false);\n+\t\t\tif (ret)\n+\t\t\t\treturn ret;\n+\t\t}\n+\t}\n+\n+\treturn 0;\n+}\n+\n /**\n * \\brief Construct a MediaEntity\n * \\param[in] dev The media device this entity belongs to\n","prefixes":["2/3"]}