[{"id":38562,"web_url":"https://patchwork.libcamera.org/comment/38562/","msgid":"","date":"2026-04-09T08:09:01","subject":"Re: [PATCH v4 4/4] libcamera: software_isp: Explicitly load \"simple\"\n\tIPA","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Hans\n\nOn Wed, Apr 08, 2026 at 01:56:06PM +0200, Hans de Goede wrote:\n> Explicitly specify the \"simple\" IPA name when loading the IPA so that\n> the softISP can be used with other pipeline-handlers too.\n>\n> Signed-off-by: Hans de Goede \n> ---\n> src/libcamera/software_isp/software_isp.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\n> index 60228369f..99e4635b3 100644\n> --- a/src/libcamera/software_isp/software_isp.cpp\n> +++ b/src/libcamera/software_isp/software_isp.cpp\n> @@ -127,7 +127,7 @@ SoftwareIsp::SoftwareIsp(PipelineHandler *pipe, const CameraSensor *sensor,\n> \tdebayer_->inputBufferReady.connect(this, &SoftwareIsp::inputReady);\n> \tdebayer_->outputBufferReady.connect(this, &SoftwareIsp::outputReady);\n>\n> -\tipa_ = IPAManager::createIPA(pipe, 0, 0);\n> +\tipa_ = IPAManager::createIPA(pipe, \"simple\", 0, 0);\n\nI might be missing how this used to work before this patch when only a\n1-to-1 matching between the pipeline and the IPA name was allowed.\n\nIf nothing has changed on the IPA/PH naming, do you need this change\nor can you resort on the createIPA(pipe, min, max) overload ?\n\n> \tif (!ipa_) {\n> \t\tLOG(SoftwareIsp, Error)\n> \t\t\t<< \"Creating IPA for software ISP failed\";\n> --\n> 2.53.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6C5C5BEFBE\n\tfor ;\n\tThu, 9 Apr 2026 08:09:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 918D36271A;\n\tThu, 9 Apr 2026 10:09:06 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 16AE36271A\n\tfor ;\n\tThu, 9 Apr 2026 10:09:05 +0200 (CEST)","from ideasonboard.com (net-93-65-100-155.cust.vodafonedsl.it\n\t[93.65.100.155])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5694C1849;\n\tThu, 9 Apr 2026 10:07:36 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Mc71V/Mh\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1775722056;\n\tbh=GVX5j3a1Ti3fFVk5OKkpGpqxte243w7a0Vox8WjG8EY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Mc71V/MhtbPCdBRnhoJbjSyU+liztKUIfBa+muXtI73QnKMaC99g3+j4YoKJTaRdr\n\trveJuQ07oBM1MUJuPOIn65xFR/tAiVdXCxwE/8Ng3CBAyDvQZ5+l04ZpCnFDaJln8l\n\t1tS7Dr44o8MFXvZKg1BNieroodb/CWoZvUncHGyo=","Date":"Thu, 9 Apr 2026 10:09:01 +0200","From":"Jacopo Mondi ","To":"Hans de Goede ","Cc":"libcamera-devel@lists.libcamera.org, \n\tLoic Poulain ","Subject":"Re: [PATCH v4 4/4] libcamera: software_isp: Explicitly load \"simple\"\n\tIPA","Message-ID":"","References":"<20260408115606.12417-1-johannes.goede@oss.qualcomm.com>\n\t<20260408115606.12417-5-johannes.goede@oss.qualcomm.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20260408115606.12417-5-johannes.goede@oss.qualcomm.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":38568,"web_url":"https://patchwork.libcamera.org/comment/38568/","msgid":"","date":"2026-04-09T14:22:33","subject":"Re: [PATCH v4 4/4] libcamera: software_isp: Explicitly load \"simple\"\n\tIPA","submitter":{"id":242,"url":"https://patchwork.libcamera.org/api/people/242/","name":"Hans de Goede","email":"johannes.goede@oss.qualcomm.com"},"content":"Hi Jacopo,\n\nOn 9-Apr-26 10:09, Jacopo Mondi wrote:\n> Hi Hans\n> \n> On Wed, Apr 08, 2026 at 01:56:06PM +0200, Hans de Goede wrote:\n>> Explicitly specify the \"simple\" IPA name when loading the IPA so that\n>> the softISP can be used with other pipeline-handlers too.\n>>\n>> Signed-off-by: Hans de Goede \n>> ---\n>> src/libcamera/software_isp/software_isp.cpp | 2 +-\n>> 1 file changed, 1 insertion(+), 1 deletion(-)\n>>\n>> diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\n>> index 60228369f..99e4635b3 100644\n>> --- a/src/libcamera/software_isp/software_isp.cpp\n>> +++ b/src/libcamera/software_isp/software_isp.cpp\n>> @@ -127,7 +127,7 @@ SoftwareIsp::SoftwareIsp(PipelineHandler *pipe, const CameraSensor *sensor,\n>> \tdebayer_->inputBufferReady.connect(this, &SoftwareIsp::inputReady);\n>> \tdebayer_->outputBufferReady.connect(this, &SoftwareIsp::outputReady);\n>>\n>> -\tipa_ = IPAManager::createIPA(pipe, 0, 0);\n>> +\tipa_ = IPAManager::createIPA(pipe, \"simple\", 0, 0);\n> \n> I might be missing how this used to work before this patch when only a\n> 1-to-1 matching between the pipeline and the IPA name was allowed.\n> \n> If nothing has changed on the IPA/PH naming, do you need this change\n> or can you resort on the createIPA(pipe, min, max) overload ?\n\nThis change is necessary to allow instantiating a SoftWareIsp object\nfrom the camss pipeline-handler.\n\nOtherwise loading the IPA will fail in this case because it will\ntry to load a camss IPA which does not exist (yet).\n\nRegards,\n\nHans","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F3A1EBDCBD\n\tfor ;\n\tThu, 9 Apr 2026 14:22:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1CB3462E4E;\n\tThu, 9 Apr 2026 16:22:39 +0200 (CEST)","from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com\n\t[205.220.180.131])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4110E62010\n\tfor ;\n\tThu, 9 Apr 2026 16:22:38 +0200 (CEST)","from pps.filterd (m0279872.ppops.net [127.0.0.1])\n\tby mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n\t639D1scm2624720 for ;\n\tThu, 9 Apr 2026 14:22:37 GMT","from mail-vk1-f197.google.com (mail-vk1-f197.google.com\n\t[209.85.221.197])\n\tby mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4decmu0a0m-1\n\t(version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n\tfor ;\n\tThu, 09 Apr 2026 14:22:36 +0000 (GMT)","by mail-vk1-f197.google.com with SMTP id\n\t71dfb90a1353d-56b67e8c2f5so1764341e0c.0\n\tfor ;\n\tThu, 09 Apr 2026 07:22:36 -0700 (PDT)","from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec?\n\t(2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl.\n\t[2001:1c00:c32:7800:5bfa:a036:83f0:f9ec])\n\tby smtp.gmail.com with ESMTPSA id\n\t4fb4d7f45d1cf-66e02d36f16sm5704638a12.3.2026.04.09.07.22.34\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tThu, 09 Apr 2026 07:22:34 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=qualcomm.com header.i=@qualcomm.com\n\theader.b=\"ITnU9vXn\"; dkim=pass (2048-bit key;\n\tunprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n\theader.b=\"aZyM7bCE\"; dkim-atps=neutral","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n\tcc:content-transfer-encoding:content-type:date:from:in-reply-to\n\t:message-id:mime-version:references:subject:to; s=qcppdkim1; bh=\n\tfQ49+3r+mB1O6I+MAqscUBcq595F1FA9m1O/EReNyAk=; b=ITnU9vXnllTtkq3W\n\tK+fudllgdOXpTXJsofit6P5g/4YAx/AOfrfHxxTIQ5wkmu1x+zDe6OKltZkmWQfC\n\tr4kN6tNbOn8coWiujjxLf4X7gA0lmY2yPKHNipbrBLVnO+QatlPwg/uZ0zslnj+V\n\t8XVYnZ3Uue3fRfrozRmezaKUPayOe8uBxlHNcWMIEeHXeT/3BL8rIrgCjkjcmCGW\n\tHmwZyMB+6mAaJcueUqLpAwDoUNO6L9Rp5bWYeY5uLx7cuadSDbt0epXHBWcExfhf\n\tso2azvdU9U2v1BX4Gnwg+XvuH9xQ/OGL/LmQ57gCcKsGV71cwMgaB1YEy+x0Mpxp\n\tOnCRxg==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=oss.qualcomm.com; s=google; t=1775744556; x=1776349356;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:in-reply-to:content-language:references\n\t:cc:to:subject:from:user-agent:mime-version:date:message-id:from:to\n\t:cc:subject:date:message-id:reply-to;\n\tbh=fQ49+3r+mB1O6I+MAqscUBcq595F1FA9m1O/EReNyAk=;\n\tb=aZyM7bCEVBL5qDfPAP/pV3wq+DUp44OYLQR2fKwktFrQwDBtbRnK9Jqcn0Mzf8sc1D\n\t3MqRzYlnD/Fijpy0lzWAKKC7mSfUX7pGhvVR4WLITkrNMiHcrtSygl/BYSzYNNCElSq3\n\tml4vgEks7FPtIfd74k/mO3l9zCmWB0l37oFPBQ+TUl6cp2727LN3oOgxh2uKpyrQjGYp\n\t0Lda7NWSvaWweiyUwEgDvidoQ5oY0JAIOO7N8mDjwtP50qgz5S0ilCxZyx1g+Viq8qI9\n\twVe/ble+v6+C4NFyBj3EprxmFUHe6gDCwv+coQ99RNi1oESyh127nxkyywXl42INmqNz\n\tZojQ=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20251104; t=1775744556; x=1776349356;\n\th=content-transfer-encoding:in-reply-to:content-language:references\n\t:cc:to:subject:from:user-agent:mime-version:date:message-id:x-gm-gg\n\t:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n\tbh=fQ49+3r+mB1O6I+MAqscUBcq595F1FA9m1O/EReNyAk=;\n\tb=TtV8GOSyOWETmpu4WHXsoVoU/c0hdZi0m+HnkuJDjPZK/8oU76M+mKxpT5/XlkztCR\n\tXUNif/18GFkXWtcS8FNoWCreNwwON9Z8FcNQAXC5Fosk/TanS/QQHQyVkAU6HmFymkY5\n\t05qr82UJ7xzZjKv0nLOI2daQ6n+0EG9xgAFRkqsKBuU4AcEkLkP7WnX9vJDVwGbkwnA9\n\tKaK8V8ZEMVzMjqUXny3rmQM5PMLuoCpT2IgEteFye8WP5Att5nu4yzY4mv4vtaT37M+n\n\tKukiiy9vR3qmGdSQBwQf6SY1mc6JZMh3Gl+inbFWWCd/vOEJ9bNTrU6tn2dWInMApO2p\n\t8sZg==","X-Gm-Message-State":"AOJu0YyNYiW/Cw4EjzDVKIo4xbmEw+na4M0sdNi74MHbyAuTS/N1SHSu\n\t+PLo7+4msqwK6fWQbH+4Yr/8ZP8LB3/kNbKISlN4X3s+2VEb6vN0dHmvAHYzNarVtJdJavLhspJ\n\ttsn+PDdu6VsNxa7jxe1zaWb6kZl4r1NC0ZDc6TGGFpLOFAvumc8vKpscH0HhdgrDm317IxlaDD1\n\t++","X-Gm-Gg":"AeBDiesEXyH29mXt2qnMQ46V4vzRjeEhqNersClaqOdgQT0cCnCHcUEfjxjo07r2RjY\n\t+H+CMge9v8s+jfviA5O4EU69LBayZXAO/SftLkPWfsYdv9MI8ENlu5IiVQ9Jt5YAPyDEVCZENas\n\tq0hDBR69d9lwrxi7jECnpSjxx2IlpRqpgiQVfOdJDlDUnS3ZlWBoANmn3OwuzOmLpGCSTjttuOP\n\tTmVZKvwswdJi4YcqkOph1l1ahskSeDYVU1RFpvApHnizlUx0nNJXM8ebheZOHTH0CFn4twQcg10\n\t+MBMDPmEHIQ/yZLfNOPk8cEiExt+J1tdwllFuXIAQ2Nfo8/T8R5kDMtaZZ2lFchgGWJlWTf7P/9\n\tYc4dNlefdvT5H4IMJIj47LqiSXijhnJJxtr/vZWkMCodtHdQ5bHVWBncGSnWQM5vy8+0qLSzXHq\n\thkbrdWyX4+5ZCXDEm6EClhIc3VzA2J4U8vCztjAqlEGzSFeRxVLSB8nEgOpwQ3GE7iszKmpVFmG\n\to547N+dlU7tis69","X-Received":["by 2002:a05:6122:83d3:b0:56d:451b:e4dd with SMTP id\n\t71dfb90a1353d-56dab9c582amr10634775e0c.12.1775744556234; \n\tThu, 09 Apr 2026 07:22:36 -0700 (PDT)","by 2002:a05:6122:83d3:b0:56d:451b:e4dd with SMTP id\n\t71dfb90a1353d-56dab9c582amr10634736e0c.12.1775744555756; \n\tThu, 09 Apr 2026 07:22:35 -0700 (PDT)"],"Message-ID":"","Date":"Thu, 9 Apr 2026 16:22:33 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","From":"Hans de Goede ","Subject":"Re: [PATCH v4 4/4] libcamera: software_isp: Explicitly load \"simple\"\n\tIPA","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org,\n\tLoic Poulain ","References":"<20260408115606.12417-1-johannes.goede@oss.qualcomm.com>\n\t<20260408115606.12417-5-johannes.goede@oss.qualcomm.com>\n\t","Content-Language":"en-US, nl","In-Reply-To":"","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"7bit","X-Proofpoint-GUID":"f6kZXtOZ-xY3gtMtT2Zqxe6d5fR3J4am","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDA5MDEzMSBTYWx0ZWRfXwrntQcpj4y7D\n\tRLQ1/k6lNYHIu5SOR6d+Y0jJNDjx7heLEAIj8lLkoJRrGMykubLTecgpL+3xhACGzBEB+9swKLQ\n\tHaFxStvbZK+5e6Fx3OG298sGiANyfMqMuK2uAkd+Ktnk7Lv+BpaQFhX4gOh3NDYDSYOVaoVFk5D\n\t1Uh1b4vPduFfwpmlD4M1UDXAxHXTYkTOZ8Rle+wgsuxK3itBgzWOarPwK+laRe84K8PMaqhnEPE\n\thD8kxRkYwpMe95deXZe5vVaeC+vUcA+2kz4j8mOl9ro3wLmVnAGN0DwJP9Fm20USLChdsWrPSt+\n\tk/8huYp4L1skbmdkyzCzt+FVyF6vZtX4nwfWid/sadzbS21Qq+Z5AkNVE2I1zmKcdOXGFGKCier\n\tqkaZKMq287Ni6b394tCEaJdyE2Up3+GpK83j7jZ+ovL97AlUusaSkH008NRZSrRQQXD3WFanX28\n\tW94onZOxoBWd5Y208xw==","X-Proofpoint-ORIG-GUID":"f6kZXtOZ-xY3gtMtT2Zqxe6d5fR3J4am","X-Authority-Analysis":"v=2.4 cv=DslmPm/+ c=1 sm=1 tr=0 ts=69d7b62c cx=c_pps\n\ta=JIY1xp/sjQ9K5JH4t62bdg==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10\n\ta=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22\n\ta=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8\n\ta=70GUvWJWgtV0a-w-PAkA:9 a=QEXdDO2ut3YA:10 a=tNoRWFLymzeba-QzToBc:22","X-Proofpoint-Virus-Version":"vendor=baseguard\n\tengine=ICAP:2.0.293, Aquarius:18.0.1143, Hydra:6.1.51,\n\tFMLib:17.12.100.49\n\tdefinitions=2026-04-09_04,2026-04-09_02,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tphishscore=0 lowpriorityscore=0 suspectscore=0 adultscore=0\n\tmalwarescore=0\n\tclxscore=1015 impostorscore=0 bulkscore=0 priorityscore=1501\n\tspamscore=0\n\tclassifier=typeunknown authscore=0 authtc= authcc= route=outbound\n\tadjust=0\n\treason=mlx scancount=1 engine=8.22.0-2604010000\n\tdefinitions=main-2604090131","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]