{"id":26504,"url":"https://patchwork.libcamera.org/api/patches/26504/?format=json","web_url":"https://patchwork.libcamera.org/patch/26504/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260408115606.12417-3-johannes.goede@oss.qualcomm.com>","date":"2026-04-08T11:56:04","name":"[v4,2/4] ipa: ipa_module: Remove pipelineName","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"b69ad0df66719c36049d4be386dc3f049b4011ce","submitter":{"id":242,"url":"https://patchwork.libcamera.org/api/people/242/?format=json","name":"Hans de Goede","email":"johannes.goede@oss.qualcomm.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/26504/mbox/","series":[{"id":5876,"url":"https://patchwork.libcamera.org/api/series/5876/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5876","date":"2026-04-08T11:56:02","name":"ipa: Allow IPA creation by name","version":4,"mbox":"https://patchwork.libcamera.org/series/5876/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/26504/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/26504/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A5011C32BB\n\tfor ;\n\tWed, 8 Apr 2026 11:56:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 83FB762DEE;\n\tWed, 8 Apr 2026 13:56:18 +0200 (CEST)","from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com\n\t[205.220.180.131])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2EE6E62DD4\n\tfor ;\n\tWed, 8 Apr 2026 13:56:15 +0200 (CEST)","from pps.filterd (m0279873.ppops.net [127.0.0.1])\n\tby mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n\t638AwIMJ072568 for ;\n\tWed, 8 Apr 2026 11:56:13 GMT","from mail-qt1-f198.google.com (mail-qt1-f198.google.com\n\t[209.85.160.198])\n\tby mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dd7sxb4tg-1\n\t(version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n\tfor ;\n\tWed, 08 Apr 2026 11:56:13 +0000 (GMT)","by mail-qt1-f198.google.com with SMTP id\n\td75a77b69052e-50d5d1c2289so147121311cf.2\n\tfor ;\n\tWed, 08 Apr 2026 04:56:13 -0700 (PDT)","from t14s\n\t(2001-1c00-0c32-7800-07d4-cca3-ec08-7ac7.cable.dynamic.v6.ziggo.nl.\n\t[2001:1c00:c32:7800:7d4:cca3:ec08:7ac7])\n\tby smtp.gmail.com with ESMTPSA id\n\ta640c23a62f3a-b9c3cec6c1csm639102066b.39.2026.04.08.04.56.10\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 08 Apr 2026 04:56:11 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=qualcomm.com header.i=@qualcomm.com\n\theader.b=\"MqR3vIfy\"; dkim=pass (2048-bit key;\n\tunprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n\theader.b=\"As/VrGby\"; dkim-atps=neutral","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n\tcc:content-transfer-encoding:content-type:date:from:in-reply-to\n\t:message-id:mime-version:references:subject:to; s=qcppdkim1; bh=\n\tuxgktgJEbr0ayrA3gM4T0imubDWEGmXH66vsSiGkbRI=; b=MqR3vIfy7oxnkp5o\n\tzpjM2wK8C71USmMdl++qKLwT0OMycQ0L9ijm3V0aaK9zHkQffRY3U0WgZeC5szgA\n\tLMoHXDwRBGok+CQCGmicBdknpYP7B5BkCeulpx9yCYfFPxjJ642ZmSe2gMM4Lbeq\n\tvn7NkbFH80Er2qwEbI9z66WFkqVAeHxCeuUqKZWs8YDY0ir9wCEgL6LFe+KNvNwv\n\tYeyKsBtu7hUJVAXfsZ8M1GFgIIAhaQCnmqbfEq4NeDwYq/POXx+6aIkDrOmpbofP\n\tOiUnBwa6TowqJ6coQWUhUn3wTJ+R6JLIHYdOJJPIJKuGfg65dbPYjS9RV/cs75zB\n\taotMsg==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=oss.qualcomm.com; s=google; t=1775649373; x=1776254173;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=uxgktgJEbr0ayrA3gM4T0imubDWEGmXH66vsSiGkbRI=;\n\tb=As/VrGbyI0vaN88S1frKqS30o3dJm0vBOL2nReIE9OBqAFzj6r43CM7nQbD0c43cf6\n\t6lPMbQ+kBvcoBPVVVf+VGRPMYJMJOSA6qLxW+GbevjWj0it6W7p4vHKmMwbu37Qu4H1w\n\t7XdMWxY9sT50wdl4n88ItROEyoIaFQGu+jXi6uHJ1pW3ZDujrjHhheqhMxn7MJarXm3o\n\tM64xpPjAUdk0tqUXfVG/shgXK6SszpR6b9gPG3lTclJbChLmoJZG9wWRcMJwbvVXmE31\n\tydznRs+MLPBZgjH5ey5lF89iSVijaTj/EJ7ecavjtoEd0s0lyS/TLiwKOv+vEg5ZxPZm\n\tfrPQ=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20251104; t=1775649373; x=1776254173;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=uxgktgJEbr0ayrA3gM4T0imubDWEGmXH66vsSiGkbRI=;\n\tb=TaEFlaBa/2SkxFNAOXEa5//7AuWAe+GFdYTw+OP6znU0HCRPbHVGjHyXZZyZx1qELL\n\trgNGyFyNaILG11eWZ7qjmzD0bfdUnPL5Id21XOlFV/Cp+xSvSIMqPuI3SspGhAhvp/qV\n\tfmFMThdOQYXhAxpP1xSxn/3B+K8s0HdcnjmRjYw0TgH9JxU3d7Pa+9jyKg9rlgnajRn0\n\tD4Ej232tRnuyBx58czLT8hMOVExzzLCjLyZtHKls75qvyIe0b3ts197t3wwSZbwoqXqn\n\tWQAShIRX1xPdDDenjZS7L23YMCqAmSZq5pKcSu26XcpvJLaSYSB5zpfEytlVCHqufVO5\n\t5Ziw==","X-Gm-Message-State":"AOJu0Yy0jl9XQjtZ8SVASFybtB/SwJ9CkBYoWDg7DlQSSShknJJpOOmL\n\tpY+2iOpKVD4eE6UiYZxOKMgALBcwIBnV43ncGrqr2JooDXXkL79AYA3qNon7J6HXeFKBOhI0IkP\n\tmQ0/ywzXmnAEt1rl7mq4rGWXv+0im6SDuwfZ7cIv+C84nXeDAkLU4oZ9UsXUslcBu978jWWxhDh\n\tYE3kh2hAbg","X-Gm-Gg":"AeBDiet+n+8lT8DCVdmf44uNMKgg77fc9+NipwMGpEA663/DZZUe7ivmNnRuIX/vAgk\n\tW6puxOaB7mEy7HIFziRzDZuKSTCkBG2fu7ciLtUIoxaLr8f7i8EsQNp/+5MncJaOtQzI7ifWlk5\n\t+KVSiAR2+MGvcBikGucWku5/Si15TQRUHr+Vd3ZE+Nsrpv3ad3DD1ePx6wip6EDNq4yyXxKctNo\n\tfMEERqiV4gAwhKIvXB6GoVnwfu+j+S76PvKotz6bT2u2rDT9OqHa6JYZh0sa0GuLulruEXQBJ4r\n\t3Ds3aPlyxWrj5viLNY6YamKH8cdfD63ehn+kwVUUP9eKPj12nrPGc6Z1IfGy9qjohBw24gk6PmK\n\t7yXlyPLUVcdQm3auvpqWTqwxBCLMgo6wMaXMCZ7OJcGySNnZ9wM7FY9SAenhWzCfD698ontKREc\n\tb8JXVzUhnjqj0rndX0FAPSeKmsMVqj60R7","X-Received":["by 2002:a05:622a:4c1a:b0:50d:a747:9e95 with SMTP id\n\td75a77b69052e-50da747b349mr74684161cf.20.1775649372650; \n\tWed, 08 Apr 2026 04:56:12 -0700 (PDT)","by 2002:a05:622a:4c1a:b0:50d:a747:9e95 with SMTP id\n\td75a77b69052e-50da747b349mr74683741cf.20.1775649372193; \n\tWed, 08 Apr 2026 04:56:12 -0700 (PDT)"],"From":"Hans de Goede ","To":"libcamera-devel@lists.libcamera.org","Cc":"Loic Poulain , Hans de Goede\n\t, Jacopo Mondi\n\t, =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?=\n\t, Kieran Bingham\n\t","Subject":"[PATCH v4 2/4] ipa: ipa_module: Remove pipelineName","Date":"Wed, 8 Apr 2026 13:56:04 +0200","Message-ID":"<20260408115606.12417-3-johannes.goede@oss.qualcomm.com>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260408115606.12417-1-johannes.goede@oss.qualcomm.com>","References":"<20260408115606.12417-1-johannes.goede@oss.qualcomm.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-Authority-Analysis":"v=2.4 cv=etfvCIpX c=1 sm=1 tr=0 ts=69d6425d cx=c_pps\n\ta=mPf7EqFMSY9/WdsSgAYMbA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10\n\ta=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22\n\ta=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=P1BnusSwAAAA:8\n\ta=EUspDBNiAAAA:8 a=lvZftHTMWe99GEGio_gA:9 a=3ZKOabzyN94A:10\n\ta=QEXdDO2ut3YA:10\n\ta=dawVfQjAaf238kedN5IG:22 a=D0XLA9XvdZm18NrgonBM:22","X-Proofpoint-ORIG-GUID":"3DXasSwzAlyDn8qfbWnpZG1f4SKBM3Sq","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDA4MDExMCBTYWx0ZWRfX949rAEOtjMdX\n\tLAFcwez37p+hBf8vNcDfc81xfyvzzmLXP0EscOR6lmDGmBIhrDUDxVEcUURR/KsrBHCngLwz53h\n\tudMJnIkgX4rXb8x8swO79ggDmmgnWr6tWkAKFy3h5LXZbUJd85bh++512ur3T7Tz1LpcqAae/b9\n\tmAdoDILStUpoWMwwBRssRle3ItrgBgYRB78WNGnywdNUCjKVFNw5acuDO/Oxcz+1OGuqhxtc7xd\n\t5daqPTmNsAyRGtvmxNAZSgo+XDMl5s2N6bQwuXtjUH+qKUUmkAp91MPx4IYk7uFBaQoDCrsvk7S\n\t9uinQANzy9Gl5uhg1uAPSVFwSTaXxwumsc+wKi6FgAA8zRRniEBKzrZFddGu7MzlVRtXilFBodx\n\tU93OuY4JCHy3OFqun01++4hPbxwTwIq34VRizYdzjabU7na31XiIp4ADUPn6pKDL0QlAHhdBe5y\n\tQ56ObG72DLyr8DeNEpQ==","X-Proofpoint-GUID":"3DXasSwzAlyDn8qfbWnpZG1f4SKBM3Sq","X-Proofpoint-Virus-Version":"vendor=baseguard\n\tengine=ICAP:2.0.293, Aquarius:18.0.1143, Hydra:6.1.51,\n\tFMLib:17.12.100.49\n\tdefinitions=2026-04-08_03,2026-04-08_01,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tpriorityscore=1501 lowpriorityscore=0 phishscore=0 bulkscore=0\n\timpostorscore=0 suspectscore=0 spamscore=0 clxscore=1015\n\tmalwarescore=0\n\tadultscore=0 classifier=typeunknown authscore=0 authtc= authcc=\n\troute=outbound adjust=0 reason=mlx scancount=1\n\tengine=8.22.0-2604010000\n\tdefinitions=main-2604080110","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Jacopo Mondi \n\nAll the IPA modules declare a pipelineName that is identical\nto their name. As we now support creating IPAs by name\n(either explicitly provided by the pipeline handlers or by using the\npipeline name), the duplicated information in IPAModuleInfo is\nredundant.\n\nRemove it.\n\nSigned-off-by: Jacopo Mondi \nReviewed-by: Barnabás Pőcze \nReviewed-by: Kieran Bingham \nReviewed-by: Hans de Goede \nSigned-off-by: Hans de Goede \n---\n include/libcamera/ipa/ipa_module_info.h | 1 -\n src/ipa/ipu3/ipu3.cpp | 1 -\n src/ipa/mali-c55/mali-c55.cpp | 1 -\n src/ipa/rkisp1/rkisp1.cpp | 1 -\n src/ipa/rpi/pisp/pisp.cpp | 1 -\n src/ipa/rpi/vc4/vc4.cpp | 1 -\n src/ipa/simple/soft_simple.cpp | 1 -\n src/ipa/vimc/vimc.cpp | 1 -\n src/libcamera/ipa_module.cpp | 15 ++++++---------\n test/ipa/ipa_module_test.cpp | 3 ---\n 10 files changed, 6 insertions(+), 20 deletions(-)","diff":"diff --git a/include/libcamera/ipa/ipa_module_info.h b/include/libcamera/ipa/ipa_module_info.h\nindex 3507a6d76..436ec82d7 100644\n--- a/include/libcamera/ipa/ipa_module_info.h\n+++ b/include/libcamera/ipa/ipa_module_info.h\n@@ -16,7 +16,6 @@ namespace libcamera {\n struct IPAModuleInfo {\n \tint moduleAPIVersion;\n \tuint32_t pipelineVersion;\n-\tchar pipelineName[256];\n \tchar name[256];\n } __attribute__((packed));\n \ndiff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\nindex 92f5bd072..8d48f6bf0 100644\n--- a/src/ipa/ipu3/ipu3.cpp\n+++ b/src/ipa/ipu3/ipu3.cpp\n@@ -672,7 +672,6 @@ const struct IPAModuleInfo ipaModuleInfo = {\n \tIPA_MODULE_API_VERSION,\n \t1,\n \t\"ipu3\",\n-\t\"ipu3\",\n };\n \n /**\ndiff --git a/src/ipa/mali-c55/mali-c55.cpp b/src/ipa/mali-c55/mali-c55.cpp\nindex fd5c9563d..07f892b9f 100644\n--- a/src/ipa/mali-c55/mali-c55.cpp\n+++ b/src/ipa/mali-c55/mali-c55.cpp\n@@ -380,7 +380,6 @@ const struct IPAModuleInfo ipaModuleInfo = {\n \tIPA_MODULE_API_VERSION,\n \t1,\n \t\"mali-c55\",\n-\t\"mali-c55\",\n };\n \n IPAInterface *ipaCreate()\ndiff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\nindex 373a343bd..adafe7569 100644\n--- a/src/ipa/rkisp1/rkisp1.cpp\n+++ b/src/ipa/rkisp1/rkisp1.cpp\n@@ -481,7 +481,6 @@ const struct IPAModuleInfo ipaModuleInfo = {\n \tIPA_MODULE_API_VERSION,\n \t1,\n \t\"rkisp1\",\n-\t\"rkisp1\",\n };\n \n IPAInterface *ipaCreate()\ndiff --git a/src/ipa/rpi/pisp/pisp.cpp b/src/ipa/rpi/pisp/pisp.cpp\nindex de2a6afeb..975d8bfdf 100644\n--- a/src/ipa/rpi/pisp/pisp.cpp\n+++ b/src/ipa/rpi/pisp/pisp.cpp\n@@ -1145,7 +1145,6 @@ const IPAModuleInfo ipaModuleInfo = {\n \tIPA_MODULE_API_VERSION,\n \t1,\n \t\"rpi/pisp\",\n-\t\"rpi/pisp\",\n };\n \n IPAInterface *ipaCreate()\ndiff --git a/src/ipa/rpi/vc4/vc4.cpp b/src/ipa/rpi/vc4/vc4.cpp\nindex b6ca44e7a..f30eee7ff 100644\n--- a/src/ipa/rpi/vc4/vc4.cpp\n+++ b/src/ipa/rpi/vc4/vc4.cpp\n@@ -633,7 +633,6 @@ const struct IPAModuleInfo ipaModuleInfo = {\n \tIPA_MODULE_API_VERSION,\n \t1,\n \t\"rpi/vc4\",\n-\t\"rpi/vc4\",\n };\n \n IPAInterface *ipaCreate()\ndiff --git a/src/ipa/simple/soft_simple.cpp b/src/ipa/simple/soft_simple.cpp\nindex 7d25bdd26..66f2c27ff 100644\n--- a/src/ipa/simple/soft_simple.cpp\n+++ b/src/ipa/simple/soft_simple.cpp\n@@ -343,7 +343,6 @@ const struct IPAModuleInfo ipaModuleInfo = {\n \tIPA_MODULE_API_VERSION,\n \t0,\n \t\"simple\",\n-\t\"simple\",\n };\n \n IPAInterface *ipaCreate()\ndiff --git a/src/ipa/vimc/vimc.cpp b/src/ipa/vimc/vimc.cpp\nindex a1351a0f4..822e00aff 100644\n--- a/src/ipa/vimc/vimc.cpp\n+++ b/src/ipa/vimc/vimc.cpp\n@@ -202,7 +202,6 @@ const struct IPAModuleInfo ipaModuleInfo = {\n \tIPA_MODULE_API_VERSION,\n \t0,\n \t\"vimc\",\n-\t\"vimc\",\n };\n \n IPAInterface *ipaCreate()\ndiff --git a/src/libcamera/ipa_module.cpp b/src/libcamera/ipa_module.cpp\nindex 0bd6f1462..53cea6b18 100644\n--- a/src/libcamera/ipa_module.cpp\n+++ b/src/libcamera/ipa_module.cpp\n@@ -215,18 +215,15 @@ Span elfLoadSymbol(Span elf, const char *symbol)\n * \\var IPAModuleInfo::pipelineVersion\n * \\brief The pipeline handler version that the IPA module is for\n *\n- * \\var IPAModuleInfo::pipelineName\n- * \\brief The name of the pipeline handler that the IPA module is for\n- *\n- * This name is used to match a pipeline handler with the module.\n- *\n * \\var IPAModuleInfo::name\n * \\brief The name of the IPA module\n *\n- * The name may be used to build file system paths to IPA-specific resources.\n- * It shall only contain printable characters, and may not contain '*', '?' or\n- * '\\'. For IPA modules included in libcamera, it shall match the directory of\n- * the IPA module in the source tree.\n+ * This name is used to match a the IPA module.\n+ *\n+ * The name may also be used to build file system paths to IPA-specific\n+ * resources. It shall only contain printable characters, and may not contain\n+ * '*', '?' or '\\'. For IPA modules included in libcamera, it shall match the\n+ * directory of the IPA module in the source tree.\n *\n * \\todo Allow user to choose to isolate open source IPAs\n */\ndiff --git a/test/ipa/ipa_module_test.cpp b/test/ipa/ipa_module_test.cpp\nindex 1c97da324..af71c3285 100644\n--- a/test/ipa/ipa_module_test.cpp\n+++ b/test/ipa/ipa_module_test.cpp\n@@ -37,12 +37,10 @@ protected:\n \t\t\tcerr << \"IPA module information mismatch: expected:\" << endl\n \t\t\t << \"moduleAPIVersion = \" << testInfo.moduleAPIVersion << endl\n \t\t\t << \"pipelineVersion = \" << testInfo.pipelineVersion << endl\n-\t\t\t << \"pipelineName = \" << testInfo.pipelineName << endl\n \t\t\t << \"name = \" << testInfo.name\n \t\t\t << \"got: \" << endl\n \t\t\t << \"moduleAPIVersion = \" << info.moduleAPIVersion << endl\n \t\t\t << \"pipelineVersion = \" << info.pipelineVersion << endl\n-\t\t\t << \"pipelineName = \" << info.pipelineName << endl\n \t\t\t << \"name = \" << info.name << endl;\n \t\t}\n \n@@ -58,7 +56,6 @@ protected:\n \t\t\tIPA_MODULE_API_VERSION,\n \t\t\t0,\n \t\t\t\"vimc\",\n-\t\t\t\"vimc\",\n \t\t};\n \n \t\tcount += runTest(\"src/ipa/vimc/ipa_vimc.so\", testInfo);\n","prefixes":["v4","2/4"]}