[{"id":38532,"web_url":"https://patchwork.libcamera.org/comment/38532/","msgid":"","date":"2026-04-08T09:05:22","subject":"Re: [PATCH 13/13] ipa: libipa: awb: factor out common prepare","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Kieran\n\nOn Tue, Apr 07, 2026 at 11:01:16PM +0100, Kieran Bingham wrote:\n> Move the common duplicated code from both the simple and rkisp1 IPA modules\n> and add these to the prepare function of libipa awb module.\n>\n> Signed-off-by: Kieran Bingham \n> ---\n> src/ipa/libipa/awb.cpp | 20 ++++++++++++++++++++\n> src/ipa/libipa/awb.h | 4 ++++\n> src/ipa/rkisp1/algorithms/awb.cpp | 11 ++---------\n> src/ipa/simple/algorithms/awb.cpp | 12 +++---------\n> 4 files changed, 29 insertions(+), 18 deletions(-)\n>\n> diff --git a/src/ipa/libipa/awb.cpp b/src/ipa/libipa/awb.cpp\n> index cac6b4bd206faa4f32680e16c7522685cfd30cac..b079a9c24b0d2d1e11b8da1087023af715765e31 100644\n> --- a/src/ipa/libipa/awb.cpp\n> +++ b/src/ipa/libipa/awb.cpp\n> @@ -227,6 +227,26 @@ void AwbAlgorithm::queueRequest(awb::ActiveState &state,\n> \tframeContext.temperatureK = state.manual.temperatureK;\n> }\n>\n> +/**\n> + * \\brief Prepare the AWB frame context ready for usage\n> + * \\param[in] state The AWB specific active state shared across frames\n> + * \\param[in] frame The frame number to apply the control values\n> + * \\param[in] frameContext The current frame's AWB specific context\n> + */\n> +void AwbAlgorithm::prepare(awb::ActiveState &state,\n> +\t\t\t [[maybe_unused]] const uint32_t frame,\n\nsame comment as on queueRequest. Should we keep 'frame' in the\nparameters list ?\n\n> +\t\t\t awb::FrameContext &frameContext)\n> +{\n> +\t/*\n> +\t * When AutoAWB is enabled, this is the latest opportunity to take\n> +\t * the most recent and up to date desired AWB gains.\n> +\t */\n> +\tif (frameContext.autoEnabled) {\n> +\t\tframeContext.gains = state.automatic.gains;\n> +\t\tframeContext.temperatureK = state.automatic.temperatureK;\n> +\t}\n> +}\n> +\n> /**\n> * \\fn AwbAlgorithm::calculateAwb()\n> * \\brief Calculate AWB data from the given statistics\n> diff --git a/src/ipa/libipa/awb.h b/src/ipa/libipa/awb.h\n> index 0256ff8ca3429288c317d3ee940255c4a5391357..ae061f4082ed947c5b8df95bd33566be6777849f 100644\n> --- a/src/ipa/libipa/awb.h\n> +++ b/src/ipa/libipa/awb.h\n> @@ -73,6 +73,10 @@ public:\n> \t\t\t awb::FrameContext &frameContext,\n> \t\t\t const ControlList &controls);\n>\n> +\tvoid prepare(awb::ActiveState &state,\n> +\t\t [[maybe_unused]] const uint32_t frame,\n> +\t\t awb::FrameContext &frameContext);\n> +\n> \tvirtual AwbResult calculateAwb(const AwbStats &stats, unsigned int lux) = 0;\n> \tvirtual std::optional> gainsFromColourTemperature(double colourTemperature) = 0;\n>\n> diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp\n> index b91132fc6177650b9338867359583bf5429ea7e5..9aacb0cff0e747dba588e45434c108d592742701 100644\n> --- a/src/ipa/rkisp1/algorithms/awb.cpp\n> +++ b/src/ipa/rkisp1/algorithms/awb.cpp\n> @@ -160,15 +160,8 @@ void Awb::queueRequest(IPAContext &context,\n> void Awb::prepare(IPAContext &context, const uint32_t frame,\n> \t\t IPAFrameContext &frameContext, RkISP1Params *params)\n> {\n> -\t/*\n> -\t * This is the latest time we can read the active state. This is the\n> -\t * most up-to-date automatic values we can read.\n> -\t */\n> -\tif (frameContext.awb.autoEnabled) {\n> -\t\tconst auto &awb = context.activeState.awb;\n> -\t\tframeContext.awb.gains = awb.automatic.gains;\n> -\t\tframeContext.awb.temperatureK = awb.automatic.temperatureK;\n> -\t}\n> +\tawbAlgo_->prepare(context.activeState.awb,\n> +\t\t\t frame, frameContext.awb);\n>\n> \tauto gainConfig = params->block();\n> \tgainConfig.setEnabled(true);\n> diff --git a/src/ipa/simple/algorithms/awb.cpp b/src/ipa/simple/algorithms/awb.cpp\n> index d8516871562724fc65ffbb67161ff4fd988c4b1c..6ce1ed340a5338e25f44145942de95f7f4f6c637 100644\n> --- a/src/ipa/simple/algorithms/awb.cpp\n> +++ b/src/ipa/simple/algorithms/awb.cpp\n> @@ -124,18 +124,12 @@ void Awb::queueRequest(IPAContext &context,\n> }\n>\n> void Awb::prepare(IPAContext &context,\n> -\t\t [[maybe_unused]] const uint32_t frame,\n> +\t\t const uint32_t frame,\n> \t\t IPAFrameContext &frameContext,\n> \t\t DebayerParams *params)\n> {\n> -\t/*\n> -\t * When AutoAWB is enabled, this is the latest opportunity to take\n> -\t * the most recent and up to date desired AWB gains.\n> -\t */\n> -\tif (frameContext.awb.autoEnabled) {\n> -\t\tframeContext.awb.gains = context.activeState.awb.automatic.gains;\n> -\t\tframeContext.awb.temperatureK = context.activeState.awb.automatic.temperatureK;\n> -\t}\n> +\tawbAlgo_->prepare(context.activeState.awb,\n> +\t\t\t frame, frameContext.awb);\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n>\n> \tparams->gains = frameContext.awb.gains;\n> }\n>\n> --\n> 2.53.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 37E64BDCBD\n\tfor ;\n\tWed, 8 Apr 2026 09:05:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5D06962DC1;\n\tWed, 8 Apr 2026 11:05:27 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0ADE062647\n\tfor ;\n\tWed, 8 Apr 2026 11:05:26 +0200 (CEST)","from ideasonboard.com (mob-109-113-47-41.net.vodafone.it\n\t[109.113.47.41])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C92911180;\n\tWed, 8 Apr 2026 11:03:57 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"pjK2Fx/G\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1775639037;\n\tbh=viQddMEndKfJYAivOO86ZvKl9BGsZvp6d661kmJ1rl0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=pjK2Fx/GyXhpPWkF/HPRV2T0ZAF94e/NsMn/gsOv/nuTp1YWJH+eky5OBjq/ryKFG\n\tSJIFhBFw5rLiJ92rTWmX0N0qR75aX7D9eo8xs4lR/fxs/Hecyt/1+z29OR1uIUjwEg\n\tIGb9VL9lvrUPxTAsj9D6m71O1ZtcRBDJ5fl/vypo=","Date":"Wed, 8 Apr 2026 11:05:22 +0200","From":"Jacopo Mondi ","To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 13/13] ipa: libipa: awb: factor out common prepare","Message-ID":"","References":"<20260407-kbingham-awb-split-v1-0-a39af3f4dc20@ideasonboard.com>\n\t<20260407-kbingham-awb-split-v1-13-a39af3f4dc20@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20260407-kbingham-awb-split-v1-13-a39af3f4dc20@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":38790,"web_url":"https://patchwork.libcamera.org/comment/38790/","msgid":"","date":"2026-05-07T14:43:43","subject":"Re: [PATCH 13/13] ipa: libipa: awb: factor out common prepare","submitter":{"id":242,"url":"https://patchwork.libcamera.org/api/people/242/","name":"Hans de Goede","email":"johannes.goede@oss.qualcomm.com"},"content":"Hi,\n\nOn 8-Apr-26 00:01, Kieran Bingham wrote:\n> Move the common duplicated code from both the simple and rkisp1 IPA modules\n> and add these to the prepare function of libipa awb module.\n> \n> Signed-off-by: Kieran Bingham \n> ---\n> src/ipa/libipa/awb.cpp | 20 ++++++++++++++++++++\n> src/ipa/libipa/awb.h | 4 ++++\n> src/ipa/rkisp1/algorithms/awb.cpp | 11 ++---------\n> src/ipa/simple/algorithms/awb.cpp | 12 +++---------\n> 4 files changed, 29 insertions(+), 18 deletions(-)\n> \n> diff --git a/src/ipa/libipa/awb.cpp b/src/ipa/libipa/awb.cpp\n> index cac6b4bd206faa4f32680e16c7522685cfd30cac..b079a9c24b0d2d1e11b8da1087023af715765e31 100644\n> --- a/src/ipa/libipa/awb.cpp\n> +++ b/src/ipa/libipa/awb.cpp\n> @@ -227,6 +227,26 @@ void AwbAlgorithm::queueRequest(awb::ActiveState &state,\n> \tframeContext.temperatureK = state.manual.temperatureK;\n> }\n> \n> +/**\n> + * \\brief Prepare the AWB frame context ready for usage\n> + * \\param[in] state The AWB specific active state shared across frames\n> + * \\param[in] frame The frame number to apply the control values\n> + * \\param[in] frameContext The current frame's AWB specific context\n> + */\n> +void AwbAlgorithm::prepare(awb::ActiveState &state,\n> +\t\t\t [[maybe_unused]] const uint32_t frame,\n> +\t\t\t awb::FrameContext &frameContext)\n> +{\n> +\t/*\n> +\t * When AutoAWB is enabled, this is the latest opportunity to take\n> +\t * the most recent and up to date desired AWB gains.\n> +\t */\n> +\tif (frameContext.autoEnabled) {\n> +\t\tframeContext.gains = state.automatic.gains;\n> +\t\tframeContext.temperatureK = state.automatic.temperatureK;\n> +\t}\n> +}\n> +\n> /**\n> * \\fn AwbAlgorithm::calculateAwb()\n> * \\brief Calculate AWB data from the given statistics\n> diff --git a/src/ipa/libipa/awb.h b/src/ipa/libipa/awb.h\n> index 0256ff8ca3429288c317d3ee940255c4a5391357..ae061f4082ed947c5b8df95bd33566be6777849f 100644\n> --- a/src/ipa/libipa/awb.h\n> +++ b/src/ipa/libipa/awb.h\n> @@ -73,6 +73,10 @@ public:\n> \t\t\t awb::FrameContext &frameContext,\n> \t\t\t const ControlList &controls);\n> \n> +\tvoid prepare(awb::ActiveState &state,\n> +\t\t [[maybe_unused]] const uint32_t frame,\n> +\t\t awb::FrameContext &frameContext);\nNit: [[maybe_unused]] is only necessary for the implementation of the method,\nnot for the prototype declaration in the class {} declaration.\n\nOtherwise the patch looks good to me:\n\nReviewed-by: Hans de Goede \n\nRegards,\n\nHans\n\n\n\n\n> \tvirtual AwbResult calculateAwb(const AwbStats &stats, unsigned int lux) = 0;\n> \tvirtual std::optional> gainsFromColourTemperature(double colourTemperature) = 0;\n> \n> diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp\n> index b91132fc6177650b9338867359583bf5429ea7e5..9aacb0cff0e747dba588e45434c108d592742701 100644\n> --- a/src/ipa/rkisp1/algorithms/awb.cpp\n> +++ b/src/ipa/rkisp1/algorithms/awb.cpp\n> @@ -160,15 +160,8 @@ void Awb::queueRequest(IPAContext &context,\n> void Awb::prepare(IPAContext &context, const uint32_t frame,\n> \t\t IPAFrameContext &frameContext, RkISP1Params *params)\n> {\n> -\t/*\n> -\t * This is the latest time we can read the active state. This is the\n> -\t * most up-to-date automatic values we can read.\n> -\t */\n> -\tif (frameContext.awb.autoEnabled) {\n> -\t\tconst auto &awb = context.activeState.awb;\n> -\t\tframeContext.awb.gains = awb.automatic.gains;\n> -\t\tframeContext.awb.temperatureK = awb.automatic.temperatureK;\n> -\t}\n> +\tawbAlgo_->prepare(context.activeState.awb,\n> +\t\t\t frame, frameContext.awb);\n> \n> \tauto gainConfig = params->block();\n> \tgainConfig.setEnabled(true);\n> diff --git a/src/ipa/simple/algorithms/awb.cpp b/src/ipa/simple/algorithms/awb.cpp\n> index d8516871562724fc65ffbb67161ff4fd988c4b1c..6ce1ed340a5338e25f44145942de95f7f4f6c637 100644\n> --- a/src/ipa/simple/algorithms/awb.cpp\n> +++ b/src/ipa/simple/algorithms/awb.cpp\n> @@ -124,18 +124,12 @@ void Awb::queueRequest(IPAContext &context,\n> }\n> \n> void Awb::prepare(IPAContext &context,\n> -\t\t [[maybe_unused]] const uint32_t frame,\n> +\t\t const uint32_t frame,\n> \t\t IPAFrameContext &frameContext,\n> \t\t DebayerParams *params)\n> {\n> -\t/*\n> -\t * When AutoAWB is enabled, this is the latest opportunity to take\n> -\t * the most recent and up to date desired AWB gains.\n> -\t */\n> -\tif (frameContext.awb.autoEnabled) {\n> -\t\tframeContext.awb.gains = context.activeState.awb.automatic.gains;\n> -\t\tframeContext.awb.temperatureK = context.activeState.awb.automatic.temperatureK;\n> -\t}\n> +\tawbAlgo_->prepare(context.activeState.awb,\n> +\t\t\t frame, frameContext.awb);\n> \n> \tparams->gains = frameContext.awb.gains;\n> }\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B3D57BDCB5\n\tfor ;\n\tThu, 7 May 2026 14:43:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CD1AA62010;\n\tThu, 7 May 2026 16:43:50 +0200 (CEST)","from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com\n\t[205.220.168.131])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 257E262010\n\tfor ;\n\tThu, 7 May 2026 16:43:48 +0200 (CEST)","from pps.filterd (m0279866.ppops.net [127.0.0.1])\n\tby mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n\t6478r3us3463995 for ;\n\tThu, 7 May 2026 14:43:47 GMT","from mail-vs1-f69.google.com (mail-vs1-f69.google.com\n\t[209.85.217.69])\n\tby mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e0hvn2k63-1\n\t(version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n\tfor ;\n\tThu, 07 May 2026 14:43:47 +0000 (GMT)","by mail-vs1-f69.google.com with SMTP id\n\tada2fe7eead31-62ee100050eso1489101137.0\n\tfor ;\n\tThu, 07 May 2026 07:43:47 -0700 (PDT)","from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec?\n\t(2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl.\n\t[2001:1c00:c32:7800:5bfa:a036:83f0:f9ec])\n\tby smtp.gmail.com with ESMTPSA id\n\ta640c23a62f3a-bc81cd34f4asm92732666b.2.2026.05.07.07.43.44\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tThu, 07 May 2026 07:43:44 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=qualcomm.com header.i=@qualcomm.com\n\theader.b=\"FdvnOKUX\"; dkim=pass (2048-bit key;\n\tunprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n\theader.b=\"R8l6cB+N\"; dkim-atps=neutral","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n\tcontent-transfer-encoding:content-type:date:from:in-reply-to\n\t:message-id:mime-version:references:subject:to; s=qcppdkim1; bh=\n\tNoEPpKt3ya+H6SuRs99okQdRt2rqfrbkCLhu5J6l/x4=; b=FdvnOKUXtCmdglQy\n\tEeiwd8xxPrCaRFGOG38Qr0Wc9T/NDNC83GwHt8b6tDBdKvtHpcPRIM7otBxLgJnJ\n\tx2O+GbC8kAs1YSBLudAkize6NDgKvrP9cnZkzsJWk6w24vhO0rXXEk0Fpv/d+5DN\n\tthGXybxscq9sm0O86g6266/NlX8BdAQHSn7dJzsHjBVfDbC2IVImmDV3tXZsZ2Sd\n\t+yfpgq82+1Iir+XwwQdputaXkKhuMoQ8fCSdWidEN/7sKfgJVqIJbl4c1lLHADMR\n\t1jKVS9meHeZ/N5C9U+i0ZsYqTdoXPvzUoj2oGc/Z/hdqQ6cDU14kl8Sg6X05n0Lw\n\tctLTXw==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=oss.qualcomm.com; s=google; t=1778165026; x=1778769826;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:in-reply-to:content-language:references\n\t:to:subject:from:user-agent:mime-version:date:message-id:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=NoEPpKt3ya+H6SuRs99okQdRt2rqfrbkCLhu5J6l/x4=;\n\tb=R8l6cB+NI8bHgX5G2g1t3JrFC9uJg3oANzUpocHvgniEcwt93/Fn0Awa8JaGwVEXnz\n\t2AKLFC2of4Xzm88QuMsCv52wF8Nxvs6ZHOMRorMX4RCrUbAfY+CaiRpxVV2K0mC8i1xh\n\t32lAdptlp3va6Q4t6Cg/TVUONKsJCsRCa9qQX/M2lv+xAkgvp+2FOjYmfeYcGAdiQvWF\n\tcHuuiA2q2l1inJ5tDGF4InsJavyiZofo6NzqiOn/0B3aHgbnKPxRXMhQ2aC/WPc9IX2I\n\tKbREYlnFXPGvt8FgIZJDz002Hn7rWquRhiB0AHvcVOaIc7QJxvpv+kV2qOrwQKN2KxsW\n\tTp9w=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20251104; t=1778165026; x=1778769826;\n\th=content-transfer-encoding:in-reply-to:content-language:references\n\t:to:subject:from:user-agent:mime-version:date:message-id:x-gm-gg\n\t:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n\tbh=NoEPpKt3ya+H6SuRs99okQdRt2rqfrbkCLhu5J6l/x4=;\n\tb=ebFvLgzhm7oa1hs8uqCbT1huqFY3awZtpoiKJc/oQPWfpm6IOqCTDpE07g4XHq++5i\n\tpDpWa/XEIO0DfO2I8j8srl1EPFtEFLF1fqegDtzhuDk1gUejJVHJPqveEweZNVfsZgba\n\tfaWo/UvW9BKzzvjDFo/wkeF4rI8YScdXspi79tXnGFnVHD72jASkci6k5B+8y7BuX9OI\n\t0NUYVEIcnVybbVGugi1LyPLqF5MxsBtL224RG7nCiET3YhWUYSdp2vdN+YkZ4rVYVGyb\n\tHrA/IEXgs48uAR9UJTIDUEHC9TKLzjjFS88INEnLjMsJIxku8DLFt+4xisMUS3XTj5dy\n\tkcrg==","X-Forwarded-Encrypted":"i=1;\n\tAFNElJ8ASKQb9te2q4Loe91TktU87jfiNlE3Muaj5g7UQVP6/i/1MBgvv3PHFmgAFbAU8qddB41iBzQcfhKkx9xpS8M=@lists.libcamera.org","X-Gm-Message-State":"AOJu0YwSTw6MUtFqrg1PgCLLC3CorlmV3mJ0vU1jjVUkLBLDmjmKtPBe\n\ttgY76QyjuUVpALOvorg5Q7KxAoehP+ARE5oQQreMUQYgNOPpKfL0ogBG7uVgJOw8W8wv1hUO25X\n\t2nojUeyJ7/tA+sTmcN4/fb2qC3Rpv6Q/QvCl5aUSlZFIThgn4WtOeSRIH5LwtjNwhAJNwh0BUKI\n\tRJ","X-Gm-Gg":"AeBDiesbCR4VQjhZ1jOJhZZpz96SHPT3nsUklssEN76/ciCEN5eqKmbQd3R9+dnt+Zc\n\t0neO8ze7w6FBvQxUGzU3dbKVCj3zK+3LiBE/alRPAocnoS2Au8gHDDhj9W7J7V/7KpSVJOcuI+t\n\ttpGPzULGPYjUwTGqwJyVMaq4hwuNVB0y33kXJhP+9O0Bm0Pa0OrhHZn7rumjoCBlhLXa7u4zWQf\n\tlJ98jSVK9AsDZcyCuFZ3iG96Qt4RuJCf9jaernK5QTmpcvfnFVURgE8BhAkMoV292YAf3aWz/3E\n\tKoDHk9/3XRwZYYOGMvVOtV5glvjfqVgueZ4nbYKB3MdVKK+Dpbkkkp+BK/fEbT1zwMsCIzFj2m3\n\tXC/cKii1CKTgfL/zLR2XIG07b95GI6IYOG48GBz6wXgdOco32CMsS9TRthIDtqlIxyyksd392Ge\n\tQ9uUyXhsIMUo0k2NG30FnJsLBM5N5GpMMPWWovO1gu7pS9e0qNouj/zatcOmzumQSa+PNXKD+JE\n\t57fRMom85llNPxwE2lXf6EpvSk=","X-Received":["by 2002:a05:6102:4429:b0:605:218d:ae0f with SMTP id\n\tada2fe7eead31-630f90009bamr4538056137.18.1778165026316; \n\tThu, 07 May 2026 07:43:46 -0700 (PDT)","by 2002:a05:6102:4429:b0:605:218d:ae0f with SMTP id\n\tada2fe7eead31-630f90009bamr4538023137.18.1778165025835; \n\tThu, 07 May 2026 07:43:45 -0700 (PDT)"],"Message-ID":"","Date":"Thu, 7 May 2026 16:43:43 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","From":"johannes.goede@oss.qualcomm.com","Subject":"Re: [PATCH 13/13] ipa: libipa: awb: factor out common prepare","To":"Kieran Bingham ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20260407-kbingham-awb-split-v1-0-a39af3f4dc20@ideasonboard.com>\n\t<20260407-kbingham-awb-split-v1-13-a39af3f4dc20@ideasonboard.com>","Content-Language":"en-US, nl","In-Reply-To":"<20260407-kbingham-awb-split-v1-13-a39af3f4dc20@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"7bit","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNTA3MDE0NyBTYWx0ZWRfXy3IkD/IEfmnl\n\ttbVn6/30t8l6wdSlnkmWAsu6TwCTnASkKyrGF7vF9d9cNxh5mzEosUdj9d4YKlyodLNNdO4tzAZ\n\tRQtL8FAqD67DZRLvb3uaG7uq/mLrDol/DGSB6jPc2zynHGtJawcGoF1kls/YunvnAyufBqA0Hu7\n\tTmEhoawYwuTe9fv/zKNmmJhoggB3dJmcj14MllGdPwsZ9fFLXtrbtoC4q16w0SkMfvxhVtMFwXp\n\tfO5eFMkwhcEu4jogIyYYi+pQe2IFqeXPrZHO45QYLcSpHegP4rl/acQQIHbPO/kCfum1Ky0Pue+\n\tX1EIbqTLAlJEokzV41iwppzwXQuAxy1MYYasxLhD61xESgyw/xGZRlxWvJqzty8hc/XqrS2/SHk\n\tY1Ji/sk4IwIDSGzQ5EwK6qIlAN5MDxz2of0iJ60o5Uh3eBdgwdDD6pM/GAGL9Q3+PI7teJdsCFN\n\toxHSkJHuMcc3Kq2x2RA==","X-Proofpoint-ORIG-GUID":"I6pG84Z6NS2J-lMRWiMk46TKxLhU7WJT","X-Proofpoint-GUID":"I6pG84Z6NS2J-lMRWiMk46TKxLhU7WJT","X-Authority-Analysis":"v=2.4 cv=ZZ4t8MVA c=1 sm=1 tr=0 ts=69fca523 cx=c_pps\n\ta=5HAIKLe1ejAbszaTRHs9Ug==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10\n\ta=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22\n\ta=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=P1BnusSwAAAA:8\n\ta=EUspDBNiAAAA:8 a=eNX8UtfC2NvNnhzep2EA:9 a=QEXdDO2ut3YA:10\n\ta=gYDTvv6II1OnSo0itH1n:22 a=D0XLA9XvdZm18NrgonBM:22","X-Proofpoint-Virus-Version":"vendor=baseguard\n\tengine=ICAP:2.0.293, Aquarius:18.0.1143, Hydra:6.1.51,\n\tFMLib:17.12.100.49\n\tdefinitions=2026-05-07_01,2026-05-06_01,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tlowpriorityscore=0 suspectscore=0 spamscore=0 priorityscore=1501\n\tbulkscore=0\n\tphishscore=0 clxscore=1015 impostorscore=0 malwarescore=0\n\tadultscore=0\n\tclassifier=typeunknown authscore=0 authtc= authcc= route=outbound\n\tadjust=0\n\treason=mlx scancount=1 engine=8.22.0-2604200000\n\tdefinitions=main-2605070147","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]