[{"id":3451,"web_url":"https://patchwork.libcamera.org/comment/3451/","msgid":"<20200115002702.GG4730@pendragon.ideasonboard.com>","date":"2020-01-15T00:27:02","subject":"Re: [libcamera-devel] [PATCH] meson: Bump required version to 0.47","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Nicolas,\n\nThank you for the patch.\n\nOn Tue, Jan 14, 2020 at 01:46:41PM -0500, Nicolas Dufresne wrote:\n> This is needed to use option type 'feature'. This is a tri-state\n> (auto/enabled/disabled) which comes with utility to enable them all, or\n> disabled them all to avoid any dynamic selection happening. It can also\n> be used as value to any \"required\" field.\n> \n> This will be used in GStreamer support. If you don't have a recent enough\n> meson in your distribution, you can always install or upgrate your version\n\ns/upgrate/upgrade/\n\n> using pip3.\n> \n> pip3 install --user meson\n> pip3 install --user --upgrade meson\n> \n> Signed-off-by: Nicolas Dufresne \n> ---\n> meson.build | 2 +-\n\nHow about also updating the README.md ?\n\ndiff --git a/README.rst b/README.rst\nindex 48e428cc816e..585c706d9e87 100644\n--- a/README.rst\n+++ b/README.rst\n@@ -45,7 +45,13 @@ A C++ toolchain: [required]\n \tEither {g++, clang}\n\n for libcamera: [required]\n-\tmeson ninja-build python3-yaml\n+\tmeson (>= 0.47) ninja-build python3-yaml\n+\n+\tIf your distribution doesn't provide a recent enough version meson, you\n+\tcan install or upgrade it using pip3.\n+\n+\tpip3 install --user meson\n+\tpip3 install --user --upgrade meson\n\n for device hotplug enumeration: [optional]\n \tpkg-config libudev-dev\n\nIf you're fine with all this there's no need to resubmit and I'll update\nthe patch when applying.\n\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/meson.build b/meson.build\n> index 6344885..eec1dcf 100644\n> --- a/meson.build\n> +++ b/meson.build\n> @@ -1,5 +1,5 @@\n> project('libcamera', 'c', 'cpp',\n> - meson_version : '>= 0.40',\n> + meson_version : '>= 0.47',\n> version : '0.0.0',\n> default_options : [\n> 'werror=true',","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 833DD60747\n\tfor ;\n\tWed, 15 Jan 2020 01:27:16 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc108967-cmbg20-2-0-cust420.5-4.cable.virginm.net [81.101.7.165])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A9D6D2D2;\n\tWed, 15 Jan 2020 01:27:15 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1579048036;\n\tbh=cq/H4mddWmP12eTL+Dw3yF5sX6PNvyMw3cmUSwu01gs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=k2a+Cnjo1g0WFi2C8x8t2AxCMzPzMUhE+vUPDRQSWwJ9ekCHJbq2Jn2FtaI8b7UmH\n\tH0QWtNmN7AVFGxok1zuGPTZd/sXnNgQ9dZurRCerD+7HaqSHsDZs9dXtQ/GF8KrwZ3\n\tHl/LQhoLU6JJ9Cip3ErnMBWKRHIHTo2jZZQsyyvE=","Date":"Wed, 15 Jan 2020 02:27:02 +0200","From":"Laurent Pinchart ","To":"Nicolas Dufresne ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200115002702.GG4730@pendragon.ideasonboard.com>","References":"<20200114184641.69674-1-nicolas.dufresne@collabora.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20200114184641.69674-1-nicolas.dufresne@collabora.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH] meson: Bump required version to 0.47","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 15 Jan 2020 00:27:16 -0000"}},{"id":3452,"web_url":"https://patchwork.libcamera.org/comment/3452/","msgid":"<892676fe0115f7942ddff8190ddbc634aabe4859.camel@collabora.com>","date":"2020-01-15T01:17:05","subject":"Re: [libcamera-devel] [PATCH] meson: Bump required version to 0.47","submitter":{"id":31,"url":"https://patchwork.libcamera.org/api/people/31/","name":"Nicolas Dufresne","email":"nicolas.dufresne@collabora.com"},"content":"Le mercredi 15 janvier 2020 à 02:27 +0200, Laurent Pinchart a écrit :\n> Hi Nicolas,\n> \n> Thank you for the patch.\n> \n> On Tue, Jan 14, 2020 at 01:46:41PM -0500, Nicolas Dufresne wrote:\n> > This is needed to use option type 'feature'. This is a tri-state\n> > (auto/enabled/disabled) which comes with utility to enable them all, or\n> > disabled them all to avoid any dynamic selection happening. It can also\n> > be used as value to any \"required\" field.\n> > \n> > This will be used in GStreamer support. If you don't have a recent enough\n> > meson in your distribution, you can always install or upgrate your version\n> \n> s/upgrate/upgrade/\n\nGood catch.\n\n> \n> > using pip3.\n> > \n> > pip3 install --user meson\n> > pip3 install --user --upgrade meson\n> > \n> > Signed-off-by: Nicolas Dufresne \n> > ---\n> > meson.build | 2 +-\n> \n> How about also updating the README.md ?\n> \n> diff --git a/README.rst b/README.rst\n> index 48e428cc816e..585c706d9e87 100644\n> --- a/README.rst\n> +++ b/README.rst\n> @@ -45,7 +45,13 @@ A C++ toolchain: [required]\n> \tEither {g++, clang}\n> \n> for libcamera: [required]\n> -\tmeson ninja-build python3-yaml\n> +\tmeson (>= 0.47) ninja-build python3-yaml\n> +\n> +\tIf your distribution doesn't provide a recent enough version meson, you\n\n\"recent enough meson version\" or \"recent enough version *of* meson\"\nmaybe ?\n\n> +\tcan install or upgrade it using pip3.\n> +\n> +\tpip3 install --user meson\n> +\tpip3 install --user --upgrade meson\n\nThere is probably an equivalent in RST to Markdown verbatim ``` ?\n\n> \n> for device hotplug enumeration: [optional]\n> \tpkg-config libudev-dev\n> \n> If you're fine with all this there's no need to resubmit and I'll update\n> the patch when applying.\n\nI'm fine with such changes yes. As a follow up, I was thinking of\nadding a feature for qcam compilation, which depends on qt5.\n\nSide note, be aware the pkg-config (or pkgconf these days) is needed by\nmeson for pretty much any external deps except maybe QT5.\n\n> \n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> > \n> > diff --git a/meson.build b/meson.build\n> > index 6344885..eec1dcf 100644\n> > --- a/meson.build\n> > +++ b/meson.build\n> > @@ -1,5 +1,5 @@\n> > project('libcamera', 'c', 'cpp',\n> > - meson_version : '>= 0.40',\n> > + meson_version : '>= 0.47',\n> > version : '0.0.0',\n> > default_options : [\n> > 'werror=true',","headers":{"Return-Path":"","Received":["from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7A41F60747\n\tfor ;\n\tWed, 15 Jan 2020 02:17:09 +0100 (CET)","from [127.0.0.1] (localhost [127.0.0.1])\n\t(Authenticated sender: nicolas) with ESMTPSA id B075728F759"],"Message-ID":"<892676fe0115f7942ddff8190ddbc634aabe4859.camel@collabora.com>","From":"Nicolas Dufresne ","Reply-To":"Nicolas Dufresne ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Date":"Tue, 14 Jan 2020 20:17:05 -0500","In-Reply-To":"<20200115002702.GG4730@pendragon.ideasonboard.com>","References":"<20200114184641.69674-1-nicolas.dufresne@collabora.com>\n\t<20200115002702.GG4730@pendragon.ideasonboard.com>","Organization":"Collabora","Content-Type":"multipart/signed; micalg=\"pgp-sha1\";\n\tprotocol=\"application/pgp-signature\"; \n\tboundary=\"=-BnEsn1haFOM+D3ATiA6S\"","User-Agent":"Evolution 3.34.2 (3.34.2-1.fc31) ","MIME-Version":"1.0","Subject":"Re: [libcamera-devel] [PATCH] meson: Bump required version to 0.47","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 15 Jan 2020 01:17:09 -0000"}},{"id":3465,"web_url":"https://patchwork.libcamera.org/comment/3465/","msgid":"<20200116231748.GB16210@pendragon.ideasonboard.com>","date":"2020-01-16T23:17:48","subject":"Re: [libcamera-devel] [PATCH] meson: Bump required version to 0.47","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Nicolas,\n\nOn Tue, Jan 14, 2020 at 08:17:05PM -0500, Nicolas Dufresne wrote:\n> Le mercredi 15 janvier 2020 à 02:27 +0200, Laurent Pinchart a écrit :\n> > On Tue, Jan 14, 2020 at 01:46:41PM -0500, Nicolas Dufresne wrote:\n> > > This is needed to use option type 'feature'. This is a tri-state\n> > > (auto/enabled/disabled) which comes with utility to enable them all, or\n> > > disabled them all to avoid any dynamic selection happening. It can also\n> > > be used as value to any \"required\" field.\n> > > \n> > > This will be used in GStreamer support. If you don't have a recent enough\n> > > meson in your distribution, you can always install or upgrate your version\n> > \n> > s/upgrate/upgrade/\n> \n> Good catch.\n> \n> > > using pip3.\n> > > \n> > > pip3 install --user meson\n> > > pip3 install --user --upgrade meson\n> > > \n> > > Signed-off-by: Nicolas Dufresne \n> > > ---\n> > > meson.build | 2 +-\n> > \n> > How about also updating the README.md ?\n> > \n> > diff --git a/README.rst b/README.rst\n> > index 48e428cc816e..585c706d9e87 100644\n> > --- a/README.rst\n> > +++ b/README.rst\n> > @@ -45,7 +45,13 @@ A C++ toolchain: [required]\n> > \tEither {g++, clang}\n> > \n> > for libcamera: [required]\n> > -\tmeson ninja-build python3-yaml\n> > +\tmeson (>= 0.47) ninja-build python3-yaml\n> > +\n> > +\tIf your distribution doesn't provide a recent enough version meson, you\n> \n> \"recent enough meson version\" or \"recent enough version *of* meson\"\n> maybe ?\n\nYes that's what I meant, sorry.\n\n> > +\tcan install or upgrade it using pip3.\n> > +\n> > +\tpip3 install --user meson\n> > +\tpip3 install --user --upgrade meson\n> \n> There is probably an equivalent in RST to Markdown verbatim ``` ?\n\nYes, it's ``. It however drops the line break. I've switched to using a\ncode block and pushed the patch.\n\n> > for device hotplug enumeration: [optional]\n> > \tpkg-config libudev-dev\n> > \n> > If you're fine with all this there's no need to resubmit and I'll update\n> > the patch when applying.\n> \n> I'm fine with such changes yes. As a follow up, I was thinking of\n> adding a feature for qcam compilation, which depends on qt5.\n\nSounds good to me. Maybe also a feature for compilation of the doc that\nwould depend on sphinx ? :-)\n\n> Side note, be aware the pkg-config (or pkgconf these days) is needed by\n> meson for pretty much any external deps except maybe QT5.\n> \n> > > 1 file changed, 1 insertion(+), 1 deletion(-)\n> > > \n> > > diff --git a/meson.build b/meson.build\n> > > index 6344885..eec1dcf 100644\n> > > --- a/meson.build\n> > > +++ b/meson.build\n> > > @@ -1,5 +1,5 @@\n> > > project('libcamera', 'c', 'cpp',\n> > > - meson_version : '>= 0.40',\n> > > + meson_version : '>= 0.47',\n> > > version : '0.0.0',\n> > > default_options : [\n> > > 'werror=true',","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2C51F6075C\n\tfor ;\n\tFri, 17 Jan 2020 00:18:03 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 886E72D2;\n\tFri, 17 Jan 2020 00:18:02 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1579216682;\n\tbh=n2ZYoFoDfYTg1x4TqepJXkvATs8bR4BkGQtXQYffURY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ePRGlML8H/p+iqaIThnhJlONT6cCxRxWOHwyxQlw8kwg6C7qTlRnitRJPsWPNuBq0\n\tmF2ZTntx+pz/eb4+2awcoH9KjeEpWJYc1uYHd00U7Ppk/DeOTDIKR3uHtHFpo17t/a\n\tUlPtuRC89FD1pk7b/smHCMEa4BkGIgOMMh4cMzPM=","Date":"Fri, 17 Jan 2020 01:17:48 +0200","From":"Laurent Pinchart ","To":"Nicolas Dufresne ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200116231748.GB16210@pendragon.ideasonboard.com>","References":"<20200114184641.69674-1-nicolas.dufresne@collabora.com>\n\t<20200115002702.GG4730@pendragon.ideasonboard.com>\n\t<892676fe0115f7942ddff8190ddbc634aabe4859.camel@collabora.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<892676fe0115f7942ddff8190ddbc634aabe4859.camel@collabora.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH] meson: Bump required version to 0.47","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 16 Jan 2020 23:18:03 -0000"}}]