[{"id":38632,"web_url":"https://patchwork.libcamera.org/comment/38632/","msgid":"<20260423205456.GA3132278@killaraus.ideasonboard.com>","date":"2026-04-23T20:54:56","subject":"Re: [PATCH v2 28/42] test: yaml-parser: Simplify test","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Thu, Apr 23, 2026 at 04:14:12PM +0200, Barnabás Pőcze wrote:\n> 2026. 04. 07. 17:34 keltezéssel, Laurent Pinchart írta:\n> > Signed-off-by: Laurent Pinchart \n> > ---\n> \n> I assume this can be done because most of it has been moved to `test/value-node.cpp` ?\n\nYes. How did I forget to add a commit message... Will fix in v3.\n\n> > test/yaml-parser.cpp | 469 +++++--------------------------------------\n> > 1 file changed, 50 insertions(+), 419 deletions(-)\n> > \n> > diff --git a/test/yaml-parser.cpp b/test/yaml-parser.cpp\n> > index 8c5826f4885b..0bbda3af8ea9 100644\n> > --- a/test/yaml-parser.cpp\n> > +++ b/test/yaml-parser.cpp\n> > [...]","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D2C52BDCB5\n\tfor ;\n\tThu, 23 Apr 2026 20:55:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C3FD562F5B;\n\tThu, 23 Apr 2026 22:55:04 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BE39162010\n\tfor ;\n\tThu, 23 Apr 2026 22:55:02 +0200 (CEST)","from killaraus.ideasonboard.com\n\t(2001-14ba-703d-e500--2a1.rev.dnainternet.fi\n\t[IPv6:2001:14ba:703d:e500::2a1])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 63E56838;\n\tThu, 23 Apr 2026 22:53:18 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"wVGivYXt\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1776977598;\n\tbh=8H+Y9tUZiSJSHC6dlGzEPFEGhnSMPAZx7wzisd06bTU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=wVGivYXt6Fuikzra9TMtyoRjw1GlCezkvgNkpDgP3J6yhRleAHalcRdCHspoSbMjx\n\ttkfERH/vya1vf///9Xv9H2tsTj5Ghfics2R7sY75CB2WWNY1ZzH0wSOIejkHxPy+bx\n\tDvHn4c11TAHrkdy9D5HMUmZ4Wbdqc1QFcHio4Kg4=","Date":"Thu, 23 Apr 2026 23:54:56 +0300","From":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v2 28/42] test: yaml-parser: Simplify test","Message-ID":"<20260423205456.GA3132278@killaraus.ideasonboard.com>","References":"<20260407153427.1825999-1-laurent.pinchart@ideasonboard.com>\n\t<20260407153427.1825999-29-laurent.pinchart@ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":38633,"web_url":"https://patchwork.libcamera.org/comment/38633/","msgid":"<20260423205904.GB3132278@killaraus.ideasonboard.com>","date":"2026-04-23T20:59:04","subject":"Re: [PATCH v2 28/42] test: yaml-parser: Simplify test","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Thu, Apr 23, 2026 at 03:17:27PM +0100, Isaac Scott wrote:\n> Hi Laurent,\n> \n> Typos inline :-)\n> \n> Quoting Laurent Pinchart (2026-04-07 16:34:13)\n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > test/yaml-parser.cpp | 469 +++++--------------------------------------\n> > 1 file changed, 50 insertions(+), 419 deletions(-)\n> > \n> > diff --git a/test/yaml-parser.cpp b/test/yaml-parser.cpp\n> > index 8c5826f4885b..0bbda3af8ea9 100644\n> > --- a/test/yaml-parser.cpp\n> > +++ b/test/yaml-parser.cpp\n\n[snip]\n> > @@ -576,7 +207,7 @@ protected:\n> > auto &level2Obj = level1Obj[\"level2\"];\n> > \n> > if (!level2Obj.isList() || level2Obj.size() != 2) {\n> > - cerr << \"level2 object should be 2 element list\" << std::endl;\n> > + cerr << \"level2 object should be a 2 elements list\" << std::endl;\n> \n> Right at the bottom ;-)\n> \n> s/elements/element/\n\nWhy is it singular if there are 2 elements ?\n\n> > return TestFail;\n> > }\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DD098BE173\n\tfor ;\n\tThu, 23 Apr 2026 20:59:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1C95A62F5B;\n\tThu, 23 Apr 2026 22:59:08 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 856C362010\n\tfor ;\n\tThu, 23 Apr 2026 22:59:06 +0200 (CEST)","from killaraus.ideasonboard.com\n\t(2001-14ba-703d-e500--2a1.rev.dnainternet.fi\n\t[IPv6:2001:14ba:703d:e500::2a1])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DDF04BCA;\n\tThu, 23 Apr 2026 22:57:26 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"TM++SPEs\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1776977847;\n\tbh=eld+LImYCY++i457xVln38pLMBQ6hgxicu8fanJMBv4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=TM++SPEs2i4oDT44EBQpszMc4z5mZ6VJM6VDaLZlg1IRq2VJWp3O0pIOjC8HMD5p8\n\t/QuPV71tsFHO2NmEMVOwdFJV2O+GS0RzDcHDOLWbArAh4uSQAPUSkXj1Ue68LDRIQD\n\t+qB7NCxcBQkbsT+mwAnc1iEeLQCL3NttY2fnS8mY=","Date":"Thu, 23 Apr 2026 23:59:04 +0300","From":"Laurent Pinchart ","To":"Isaac Scott ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v2 28/42] test: yaml-parser: Simplify test","Message-ID":"<20260423205904.GB3132278@killaraus.ideasonboard.com>","References":"<20260407153427.1825999-1-laurent.pinchart@ideasonboard.com>\n\t<20260407153427.1825999-29-laurent.pinchart@ideasonboard.com>\n\t<177695384792.47277.18329001947288763444@t16>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<177695384792.47277.18329001947288763444@t16>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]