[{"id":38631,"web_url":"https://patchwork.libcamera.org/comment/38631/","msgid":"<20260423203937.GE3086691@killaraus.ideasonboard.com>","date":"2026-04-23T20:39:37","subject":"Re: [PATCH v2 27/42] test: Add ValueNode unit test","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Thu, Apr 23, 2026 at 04:15:26PM +0200, Barnabás Pőcze wrote:\n> 2026. 04. 07. 17:34 keltezéssel, Laurent Pinchart írta:\n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > test/meson.build | 1 +\n> > test/value-node.cpp | 565 ++++++++++++++++++++++++++++++++++++++++++++\n> > 2 files changed, 566 insertions(+)\n> > create mode 100644 test/value-node.cpp\n> > \n> > diff --git a/test/meson.build b/test/meson.build\n> > index 52f04364e4fc..e4450625ee4c 100644\n> > --- a/test/meson.build\n> > +++ b/test/meson.build\n> > @@ -74,6 +74,7 @@ internal_tests = [\n> > {'name': 'timer-thread', 'sources': ['timer-thread.cpp']},\n> > {'name': 'unique-fd', 'sources': ['unique-fd.cpp']},\n> > {'name': 'utils', 'sources': ['utils.cpp']},\n> > + {'name': 'value-node', 'sources': ['value-node.cpp']},\n> > {'name': 'vector', 'sources': ['vector.cpp']},\n> > {'name': 'yaml-parser', 'sources': ['yaml-parser.cpp']},\n> > ]\n> > diff --git a/test/value-node.cpp b/test/value-node.cpp\n> > new file mode 100644\n> > index 000000000000..e9cb7ae11b9f\n> > --- /dev/null\n> > +++ b/test/value-node.cpp\n> > @@ -0,0 +1,565 @@\n> > +/* SPDX-License-Identifier: GPL-2.0-or-later */\n> > +/*\n> > + * Copyright (C) 2026, Ideas on Board\n> > + *\n> > + * ValueNode tests\n> > + */\n> > +\n> > +#include \n> > +#include \n> > +#include \n> > +#include \n> > +#include \n> > +#include \n> > +#include \n> > +#include \n> > +\n> > +#include \n> > +#include \n> > +\n> > +#include \"libcamera/internal/value_node.h\"\n> > +\n> > +#include \"test.h\"\n> > +\n> > +using namespace libcamera;\n> > +using namespace std;\n> > +\n> > +template\n> > +struct overloaded : Ts... {\n> > +\tusing Ts::operator()...;\n> > +};\n> > +template\n> > +overloaded(Ts...) -> overloaded;\n> \n> Would it be possible to instead cherry pick https://patchwork.libcamera.org/patch/26408/ ?\n> And then whoever merges it first wins?\n\nAbsolutely :-)\n\n> > [...]","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6F3C1BE173\n\tfor ;\n\tThu, 23 Apr 2026 20:39:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6FC4262F59;\n\tThu, 23 Apr 2026 22:39:40 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3F41A62010\n\tfor ;\n\tThu, 23 Apr 2026 22:39:39 +0200 (CEST)","from killaraus.ideasonboard.com\n\t(2001-14ba-703d-e500--2a1.rev.dnainternet.fi\n\t[IPv6:2001:14ba:703d:e500::2a1])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A28E8838;\n\tThu, 23 Apr 2026 22:37:59 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"qpDTQmoH\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1776976679;\n\tbh=je2DKITO/MCxwLXLVOYGdrXYBqNsqk0iQmdKzN3bhyU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=qpDTQmoHwHDKUIoDw4SAbPG36A/1cnLnke9ghsiaef2gsUvZRuGlT8ZZFEEjmsJ8q\n\tYVTICLRJxmJ4j6ogvjqBbMFE55qedwqRRfvLaoIhS1L04DpnJIRZaWHiTCTj+YVDvf\n\tP7d3tspi3VXmuTKl6phuqhphwjt+TDFRGXMPdGNA=","Date":"Thu, 23 Apr 2026 23:39:37 +0300","From":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v2 27/42] test: Add ValueNode unit test","Message-ID":"<20260423203937.GE3086691@killaraus.ideasonboard.com>","References":"<20260407153427.1825999-1-laurent.pinchart@ideasonboard.com>\n\t<20260407153427.1825999-28-laurent.pinchart@ideasonboard.com>\n\t<5f704a3e-0cb7-45d6-b4d4-3b7d7c14b403@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<5f704a3e-0cb7-45d6-b4d4-3b7d7c14b403@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]