{"id":26462,"url":"https://patchwork.libcamera.org/api/patches/26462/?format=json","web_url":"https://patchwork.libcamera.org/patch/26462/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260407153427.1825999-23-laurent.pinchart@ideasonboard.com>","date":"2026-04-07T15:34:07","name":"[v2,22/42] libcamera: value_node: Add mutable adapters","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"5c7603d20f58e74206d29359b143ac69e19bbda0","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/26462/mbox/","series":[{"id":5873,"url":"https://patchwork.libcamera.org/api/series/5873/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5873","date":"2026-04-07T15:33:45","name":"libcamera: Global configuration file improvements","version":2,"mbox":"https://patchwork.libcamera.org/series/5873/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/26462/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/26462/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4E2CDC3306\n\tfor ;\n\tTue, 7 Apr 2026 15:35:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 891AD62E0B;\n\tTue, 7 Apr 2026 17:35:04 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 014CC62DD4\n\tfor ;\n\tTue, 7 Apr 2026 17:34:59 +0200 (CEST)","from killaraus.ideasonboard.com\n\t(2001-14ba-703d-e500--2a1.rev.dnainternet.fi\n\t[IPv6:2001:14ba:703d:e500::2a1])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 6A1B678E\n\tfor ;\n\tTue, 7 Apr 2026 17:33:31 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"PMKYYp1X\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1775576011;\n\tbh=AFlAO62YzdTVI1vHXr1V9D7kB1G0XmGp6wg/1WxMcmQ=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=PMKYYp1Xo5jnAlZU3NFIkOrzKmy8tgYPXpoRDyG57vbgR6x6H5dBMLVtIU0OfrkXj\n\t0T308ctZwPOCuHvnvj01YGGJXp8U0on1sYa9TfFolCwVDHeG3Atna2lSRC5r8j3lCT\n\tEA1f8oAvN/2QQpPBFuT5Kn268iuNszlDmXBGLKj0=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH v2 22/42] libcamera: value_node: Add mutable adapters","Date":"Tue, 7 Apr 2026 18:34:07 +0300","Message-ID":"<20260407153427.1825999-23-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20260407153427.1825999-1-laurent.pinchart@ideasonboard.com>","References":"<20260407153427.1825999-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The ValueNode class was initially designed to store read-only property\ntrees. It is useful to also provide mutable access. Add non-const\nadapters and iterators and adapters. This allows obtaining a mutable\nValueNode instance when traversing a tree.\n\nSigned-off-by: Laurent Pinchart \nReviewed-by: Barnabás Pőcze \n---\n include/libcamera/internal/value_node.h | 32 ++++++++++++++++++-------\n src/libcamera/value_node.cpp | 10 ++++++++\n 2 files changed, 34 insertions(+), 8 deletions(-)","diff":"diff --git a/include/libcamera/internal/value_node.h b/include/libcamera/internal/value_node.h\nindex f8d0329f7670..3bdb537e9eab 100644\n--- a/include/libcamera/internal/value_node.h\n+++ b/include/libcamera/internal/value_node.h\n@@ -143,17 +143,31 @@ public:\n \t\t}\n \t};\n \n-\tclass DictAdapter : public Adapter,\n-\t\t\t\t\t const ValueContainer>\n+\tclass DictAdapter : public Adapter,\n+\t\t\t\t\t ValueContainer>\n \t{\n \tpublic:\n \t\tusing key_type = std::string;\n \t};\n \n-\tclass ListAdapter : public Adapter,\n-\t\t\t\t\t const ValueContainer>\n+\tclass ListAdapter : public Adapter,\n+\t\t\t\t\t ValueContainer>\n+\t{\n+\t};\n+\n+\tclass ConstDictAdapter : public Adapter,\n+\t\t\t\t\t\tconst ValueContainer>\n+\t{\n+\tpublic:\n+\t\tusing key_type = std::string;\n+\t};\n+\n+\tclass ConstListAdapter : public Adapter,\n+\t\t\t\t\t\tconst ValueContainer>\n \t{\n \t};\n #endif /* __DOXYGEN__ */\n@@ -211,8 +225,10 @@ public:\n \t\t\t.set(*this, std::forward(value));\n \t}\n \n-\tDictAdapter asDict() const { return DictAdapter{ list_ }; }\n-\tListAdapter asList() const { return ListAdapter{ list_ }; }\n+\tDictAdapter asDict() { return DictAdapter{ list_ }; }\n+\tListAdapter asList() { return ListAdapter{ list_ }; }\n+\tConstDictAdapter asDict() const { return ConstDictAdapter{ list_ }; }\n+\tConstListAdapter asList() const { return ConstListAdapter{ list_ }; }\n \n \tconst ValueNode &operator[](std::size_t index) const;\n \ndiff --git a/src/libcamera/value_node.cpp b/src/libcamera/value_node.cpp\nindex 6c9e2239165b..5aef72cd29a4 100644\n--- a/src/libcamera/value_node.cpp\n+++ b/src/libcamera/value_node.cpp\n@@ -335,6 +335,11 @@ template struct ValueNode::Accessor>;\n template struct ValueNode::Accessor>;\n #endif /* __DOXYGEN__ */\n \n+/**\n+ * \\fn ValueNode::asDict()\n+ * \\copydoc ValueNode::asDict() const\n+ */\n+\n /**\n * \\fn ValueNode::asDict() const\n * \\brief Wrap a dictionary ValueNode in an adapter that exposes iterators\n@@ -355,6 +360,11 @@ template struct ValueNode::Accessor>;\n * \\return An adapter of unspecified type compatible with range-based for loops\n */\n \n+/**\n+ * \\fn ValueNode::asList()\n+ * \\copydoc ValueNode::asList() const\n+ */\n+\n /**\n * \\fn ValueNode::asList() const\n * \\brief Wrap a list ValueNode in an adapter that exposes iterators\n","prefixes":["v2","22/42"]}