[{"id":38519,"web_url":"https://patchwork.libcamera.org/comment/38519/","msgid":"","date":"2026-04-07T13:16:04","subject":"Re: [PATCH 2/2] meson: Print missing application options in summary","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Laurent\n\nOn Mon, Apr 06, 2026 at 12:33:49AM +0300, Laurent Pinchart wrote:\n> The recently added application options (DNG output support, KMS and SDL2\n> outputs for cam, and JPEG support for cam) are not printed in the\n> summary. This makes it more difficult to quickly assess the\n> configuration when those options are set to the 'auto' value. Add them\n> to the summary, and move all application configuration options to a\n> dedicated section of the summary to improve readability.\n>\n> Signed-off-by: Laurent Pinchart \n\nThis shows up as\n Applications\n cam application : YES\n cam options : output-kms\n output-sdl2\n jpeg\n DNG output support : YES\n qcam application : NO\n lc-compliance application: YES\n\nin my local summary, which I think it's nice\n\nReviewed-by: Jacopo Mondi \n\n> ---\n> meson.build | 3 ---\n> src/apps/cam/meson.build | 5 +++++\n> src/apps/meson.build | 10 ++++++++++\n> 3 files changed, 15 insertions(+), 3 deletions(-)\n>\n> diff --git a/meson.build b/meson.build\n> index 2e2a27ef4c25..a6cfdd07605c 100644\n> --- a/meson.build\n> +++ b/meson.build\n> @@ -305,9 +305,6 @@ summary({\n> 'GStreamer support': gst_enabled,\n> 'Python bindings': pycamera_enabled,\n> 'V4L2 emulation support': v4l2_enabled,\n> - 'cam application': cam_enabled,\n> - 'qcam application': qcam_enabled,\n> - 'lc-compliance application': lc_compliance_enabled,\n> 'Unit tests': test_enabled,\n> },\n> section : 'Configuration',\n> diff --git a/src/apps/cam/meson.build b/src/apps/cam/meson.build\n> index 0fd8462700a9..067cfd81c64d 100644\n> --- a/src/apps/cam/meson.build\n> +++ b/src/apps/cam/meson.build\n> @@ -26,6 +26,8 @@ cam_deps = [\n> libtiff,\n> ]\n>\n> +cam_options = []\n> +\n> libdrm = dependency('libdrm', required : get_option('cam-output-kms'))\n> libsdl2 = dependency('SDL2', required : get_option('cam-output-sdl2'))\n> libjpeg = dependency('libjpeg', required : get_option('cam-jpeg'))\n> @@ -39,6 +41,7 @@ if libdrm.found()\n> cam_deps += [\n> libdrm,\n> ]\n> + cam_options += 'output-kms'\n> endif\n>\n> if libsdl2.found()\n> @@ -52,6 +55,7 @@ if libsdl2.found()\n> cam_deps += [\n> libsdl2,\n> ]\n> + cam_options += 'output-sdl2'\n>\n> if libjpeg.found()\n> cam_cpp_args += ['-DHAVE_LIBJPEG']\n> @@ -61,6 +65,7 @@ if libsdl2.found()\n> cam_deps += [\n> libjpeg,\n> ]\n> + cam_options += 'jpeg'\n> endif\n> endif\n>\n> diff --git a/src/apps/meson.build b/src/apps/meson.build\n> index bc3a79196949..bd2f7858e1a3 100644\n> --- a/src/apps/meson.build\n> +++ b/src/apps/meson.build\n> @@ -20,3 +20,13 @@ subdir('cam')\n> subdir('qcam')\n>\n> subdir('ipa-verify')\n> +\n> +summary({\n> + 'cam application': cam_enabled,\n> + 'cam options': cam_options,\n> + 'DNG output support': libtiff.found(),\n> + 'qcam application': qcam_enabled,\n> + 'lc-compliance application': lc_compliance_enabled,\n> + },\n> + section : 'Applications',\n> + bool_yn : true)\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 64F86BEFBE\n\tfor ;\n\tTue, 7 Apr 2026 13:16:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6122262D98;\n\tTue, 7 Apr 2026 15:16:09 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 55E4862846\n\tfor ;\n\tTue, 7 Apr 2026 15:16:08 +0200 (CEST)","from ideasonboard.com (mob-109-113-47-41.net.vodafone.it\n\t[109.113.47.41])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BD1E83C8;\n\tTue, 7 Apr 2026 15:14:40 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"U0we0TC4\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1775567680;\n\tbh=8C2WlWjEIl/LWk9HAZklGdy77eefdAHCPGMil1zDy1A=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=U0we0TC4sHNaeEmVhHVHVSRL8NZk9y+SnYokkka/juPMmyQyZNqrUngXyXQHAihBf\n\tXDtqRguu0lKAbrTDN82o+8g3W3OlzpHjtGV0fcAFNaZ4y6GVUizkvHk2klHS3QJSSu\n\tyMCPvrXGNkAKLrfX05QOGQqvTm/HNYAmDo66gmXg=","Date":"Tue, 7 Apr 2026 15:16:04 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 2/2] meson: Print missing application options in summary","Message-ID":"","References":"<20260405213349.1224164-1-laurent.pinchart@ideasonboard.com>\n\t<20260405213349.1224164-2-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20260405213349.1224164-2-laurent.pinchart@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]