[{"id":38520,"web_url":"https://patchwork.libcamera.org/comment/38520/","msgid":"","date":"2026-04-07T13:20:23","subject":"Re: [PATCH 1/2] meson: Print soft ISP boolean options as YES/NO","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Laurent\n\nOn Mon, Apr 06, 2026 at 12:33:48AM +0300, Laurent Pinchart wrote:\n> All boolean options in libcamera other than the soft ISP options are\n> printed as YES/NO (with colours when supported by the terminal). Extend\n> this to the soft ISP options for consistency.\n>\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Jacopo Mondi \n\n> ---\n> src/libcamera/software_isp/meson.build | 8 ++++++--\n> 1 file changed, 6 insertions(+), 2 deletions(-)\n>\n> diff --git a/src/libcamera/software_isp/meson.build b/src/libcamera/software_isp/meson.build\n> index 7a2f704bf158..15f9e4032dc1 100644\n> --- a/src/libcamera/software_isp/meson.build\n> +++ b/src/libcamera/software_isp/meson.build\n> @@ -1,7 +1,9 @@\n> # SPDX-License-Identifier: CC0-1.0\n>\n> softisp_enabled = pipelines.contains('simple')\n> -summary({'SoftISP support' : softisp_enabled}, section : 'Configuration')\n> +summary({'SoftISP support' : softisp_enabled},\n> + bool_yn : true,\n> + section : 'Configuration')\n>\n> if not softisp_enabled\n> subdir_done()\n> @@ -13,7 +15,9 @@ mesa_works = cc.check_header('EGL/egl.h',\n> required : get_option('softisp-gpu'),\n> dependencies : libegl)\n>\n> -summary({'SoftISP GPU acceleration' : mesa_works}, section : 'Configuration')\n> +summary({'SoftISP GPU acceleration' : mesa_works},\n> + bool_yn : true,\n> + section : 'Configuration')\n>\n> libcamera_internal_sources += files([\n> 'benchmark.cpp',\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4F133BDCBD\n\tfor ;\n\tTue, 7 Apr 2026 13:20:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7AFA762D9C;\n\tTue, 7 Apr 2026 15:20:34 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E488862846\n\tfor ;\n\tTue, 7 Apr 2026 15:20:32 +0200 (CEST)","from ideasonboard.com (mob-109-113-47-41.net.vodafone.it\n\t[109.113.47.41])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D79C0667;\n\tTue, 7 Apr 2026 15:19:02 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"pKjvQOum\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1775567945;\n\tbh=ABkfH1YW6facJRQsdIih+f58D5GKK4WWN9w1LgoeHAU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=pKjvQOumvWnYLZyeDxCeCvBm/p94giWjYpIb0eb4wxreNUHCXOrRtSdKpH5cmoza0\n\tOrv0pPWkQolUIA0XNKU+bzhESWMQhsCgeP2D6EYqEAWA5TAYoE1cLy/oJTaYqGF9rP\n\tNs+aOPoIMCzacFXgr3wxjph8EPzrDaRZkAYifhNg=","Date":"Tue, 7 Apr 2026 15:20:23 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 1/2] meson: Print soft ISP boolean options as YES/NO","Message-ID":"","References":"<20260405213349.1224164-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20260405213349.1224164-1-laurent.pinchart@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":38582,"web_url":"https://patchwork.libcamera.org/comment/38582/","msgid":"","date":"2026-04-13T07:48:45","subject":"Re: [PATCH 1/2] meson: Print soft ISP boolean options as YES/NO","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2026. 04. 05. 23:33 keltezéssel, Laurent Pinchart írta:\n> All boolean options in libcamera other than the soft ISP options are\n> printed as YES/NO (with colours when supported by the terminal). Extend\n> this to the soft ISP options for consistency.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n\nReviewed-by: Barnabás Pőcze \n\n\n> src/libcamera/software_isp/meson.build | 8 ++++++--\n> 1 file changed, 6 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/software_isp/meson.build b/src/libcamera/software_isp/meson.build\n> index 7a2f704bf158..15f9e4032dc1 100644\n> --- a/src/libcamera/software_isp/meson.build\n> +++ b/src/libcamera/software_isp/meson.build\n> @@ -1,7 +1,9 @@\n> # SPDX-License-Identifier: CC0-1.0\n> \n> softisp_enabled = pipelines.contains('simple')\n> -summary({'SoftISP support' : softisp_enabled}, section : 'Configuration')\n> +summary({'SoftISP support' : softisp_enabled},\n> + bool_yn : true,\n> + section : 'Configuration')\n> \n> if not softisp_enabled\n> subdir_done()\n> @@ -13,7 +15,9 @@ mesa_works = cc.check_header('EGL/egl.h',\n> required : get_option('softisp-gpu'),\n> dependencies : libegl)\n> \n> -summary({'SoftISP GPU acceleration' : mesa_works}, section : 'Configuration')\n> +summary({'SoftISP GPU acceleration' : mesa_works},\n> + bool_yn : true,\n> + section : 'Configuration')\n> \n> libcamera_internal_sources += files([\n> 'benchmark.cpp',","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0C483C32BB\n\tfor ;\n\tMon, 13 Apr 2026 07:48:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0123362E60;\n\tMon, 13 Apr 2026 09:48:51 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6050C62846\n\tfor ;\n\tMon, 13 Apr 2026 09:48:49 +0200 (CEST)","from [192.168.33.49] (185.182.214.8.nat.pool.zt.hu [185.182.214.8])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 96A0C16A;\n\tMon, 13 Apr 2026 09:47:17 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"CKC0tiyU\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1776066437;\n\tbh=wWp2NzjWiFrik9EDU0wNpxkvArWbAy2TR6Q5h6lviMY=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=CKC0tiyUv/EvQ1B+UM8GM0+SswApqIYEyCq0dH5CihU6TYnmx5QHTiyHGEIBvtvVe\n\tdyKx8C+x8twU03QS8SUslEu4ju/JYi+ujXytP7fVBFh02H8wQ/jcCIeiMan40CPA3M\n\tldivuBWa8ICe4UtQzs9ND0TPKOA/q9vVSx7h11zQ=","Message-ID":"","Date":"Mon, 13 Apr 2026 09:48:45 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 1/2] meson: Print soft ISP boolean options as YES/NO","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20260405213349.1224164-1-laurent.pinchart@ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20260405213349.1224164-1-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]