[{"id":38502,"web_url":"https://patchwork.libcamera.org/comment/38502/","msgid":"","date":"2026-04-07T10:14:49","subject":"Re: [PATCH] utils: update-kernel-headers: Fix destination path","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Laurent\n\nOn Mon, Apr 06, 2026 at 12:33:06AM +0300, Laurent Pinchart wrote:\n> The update-kernel-headers.sh script copies all headers to include/linux/\n> without creating subdirectories. This behaviour was correct until the\n> addition of linux/media/v4l2-isp.h, which should be copied to\n> include/linux/media/v4l2-isp.h, not include/linux/v4l2-isp.h. Fix it.\n>\n> Fixes: ee8f88fc64d4 (\"include: linux: Add v4l2-isp.h\")\n\nIndeed I had to manually move it\n\n> Signed-off-by: Laurent Pinchart \n> ---\n> utils/update-kernel-headers.sh | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/utils/update-kernel-headers.sh b/utils/update-kernel-headers.sh\n> index 168a0ea36e63..f9baa66d00b4 100755\n> --- a/utils/update-kernel-headers.sh\n> +++ b/utils/update-kernel-headers.sh\n> @@ -64,7 +64,7 @@ headers=\"\n> \"\n>\n> for header in $headers ; do\n> -\tname=$(basename \"${header}\")\n> +\tname=\"${header#*/}\"\n\nNow I wonder why \"drm/drm_fourcc.h\" doesn't live under \"linux/\" and if\n\"linux/media/v4l2-isp.h\" should have been \"media/v4l2-isp.h\".\n\nNot a question for this patch :)\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> \tcp \"${install_dir}/usr/include/${header}\" \"${header_dir}/${name}\"\n> done\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 39F03BDCBD\n\tfor ;\n\tTue, 7 Apr 2026 10:14:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 67E3762D8C;\n\tTue, 7 Apr 2026 12:14:54 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 82DBA62846\n\tfor ;\n\tTue, 7 Apr 2026 12:14:53 +0200 (CEST)","from ideasonboard.com (mob-109-113-47-41.net.vodafone.it\n\t[109.113.47.41])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 10CC2250;\n\tTue, 7 Apr 2026 12:13:26 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"hXpQm8ef\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1775556806;\n\tbh=giceejoqXOhLtZcdlapcVici7H9EMFydVjJve2vhfbQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=hXpQm8ef7XZMoqIDnF04hTIANKwdfd0fp6OcglSjD6po+nuEG7daW7NHucboOWyyU\n\tYHs1+7ChO/KwAQcpvmXljSkrv3TCEctOy58SOWHl5IU1SoRt2bAtbYUQ5utK8g9zr4\n\tzMhHhXn8eBhW1lMPYs5nT0TbKsIjAo8E+8FaVEa8=","Date":"Tue, 7 Apr 2026 12:14:49 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org, \n\tJacopo Mondi ","Subject":"Re: [PATCH] utils: update-kernel-headers: Fix destination path","Message-ID":"","References":"<20260405213306.1224047-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20260405213306.1224047-1-laurent.pinchart@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":38504,"web_url":"https://patchwork.libcamera.org/comment/38504/","msgid":"<20260407103334.GG1268443@killaraus.ideasonboard.com>","date":"2026-04-07T10:33:34","subject":"Re: [PATCH] utils: update-kernel-headers: Fix destination path","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Tue, Apr 07, 2026 at 12:14:49PM +0200, Jacopo Mondi wrote:\n> On Mon, Apr 06, 2026 at 12:33:06AM +0300, Laurent Pinchart wrote:\n> > The update-kernel-headers.sh script copies all headers to include/linux/\n> > without creating subdirectories. This behaviour was correct until the\n> > addition of linux/media/v4l2-isp.h, which should be copied to\n> > include/linux/media/v4l2-isp.h, not include/linux/v4l2-isp.h. Fix it.\n> >\n> > Fixes: ee8f88fc64d4 (\"include: linux: Add v4l2-isp.h\")\n> \n> Indeed I had to manually move it\n> \n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > utils/update-kernel-headers.sh | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> >\n> > diff --git a/utils/update-kernel-headers.sh b/utils/update-kernel-headers.sh\n> > index 168a0ea36e63..f9baa66d00b4 100755\n> > --- a/utils/update-kernel-headers.sh\n> > +++ b/utils/update-kernel-headers.sh\n> > @@ -64,7 +64,7 @@ headers=\"\n> > \"\n> >\n> > for header in $headers ; do\n> > -\tname=$(basename \"${header}\")\n> > +\tname=\"${header#*/}\"\n> \n> Now I wonder why \"drm/drm_fourcc.h\" doesn't live under \"linux/\" and if\n\nHistorical reasons I think.\n\n> \"linux/media/v4l2-isp.h\" should have been \"media/v4l2-isp.h\".\n\nThat would translate to /usr/include/media/ and I don't think we can\ngrap that namespace without talking with the relevant stakeholders. It\nmakes sense for kernel headers to all be in /usr/include/linux/.\n\n> Not a question for this patch :)\n> \n> Reviewed-by: Jacopo Mondi \n> \n> > \tcp \"${install_dir}/usr/include/${header}\" \"${header_dir}/${name}\"\n> > done","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CEC74BEFBE\n\tfor ;\n\tTue, 7 Apr 2026 10:33:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E090C62D82;\n\tTue, 7 Apr 2026 12:33:36 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A259962846\n\tfor ;\n\tTue, 7 Apr 2026 12:33:35 +0200 (CEST)","from killaraus.ideasonboard.com\n\t(2001-14ba-703d-e500--2a1.rev.dnainternet.fi\n\t[IPv6:2001:14ba:703d:e500::2a1])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 2FF9A3A4;\n\tTue, 7 Apr 2026 12:32:08 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"UsGZaeH/\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1775557928;\n\tbh=RfrC6Zk4r07qld6oZLgJDfEMi1x3/z8wWX25TBrmrjY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=UsGZaeH/30hR/TWKbWVVWHRCqsoOatbnURFAov/svxXxXhoDMFCY4ADTuDR8kQj1M\n\tzVtcd/gHUOlbwM38i+SxnfxXsFML2YM8Kms6ZymIAQiTwuRF82emi8rGTF5NOYLFRP\n\t1RB6oOqMHQMWZHbBb0ipBzuqmIUMxIT5QGORoU9k=","Date":"Tue, 7 Apr 2026 13:33:34 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH] utils: update-kernel-headers: Fix destination path","Message-ID":"<20260407103334.GG1268443@killaraus.ideasonboard.com>","References":"<20260405213306.1224047-1-laurent.pinchart@ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":38578,"web_url":"https://patchwork.libcamera.org/comment/38578/","msgid":"<0ae43f9f-5e27-4490-9820-ff7c60eb0d49@ideasonboard.com>","date":"2026-04-13T07:11:59","subject":"Re: [PATCH] utils: update-kernel-headers: Fix destination path","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2026. 04. 05. 23:33 keltezéssel, Laurent Pinchart írta:\n> The update-kernel-headers.sh script copies all headers to include/linux/\n> without creating subdirectories. This behaviour was correct until the\n> addition of linux/media/v4l2-isp.h, which should be copied to\n> include/linux/media/v4l2-isp.h, not include/linux/v4l2-isp.h. Fix it.\n> \n> Fixes: ee8f88fc64d4 (\"include: linux: Add v4l2-isp.h\")\n> Signed-off-by: Laurent Pinchart \n> ---\n> utils/update-kernel-headers.sh | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/utils/update-kernel-headers.sh b/utils/update-kernel-headers.sh\n> index 168a0ea36e63..f9baa66d00b4 100755\n> --- a/utils/update-kernel-headers.sh\n> +++ b/utils/update-kernel-headers.sh\n> @@ -64,7 +64,7 @@ headers=\"\n> \"\n> \n> for header in $headers ; do\n> -\tname=$(basename \"${header}\")\n> +\tname=\"${header#*/}\"\n> \tcp \"${install_dir}/usr/include/${header}\" \"${header_dir}/${name}\"\n\nThe subdirectories will have to be created manually?\n\nReviewed-by: Barnabás Pőcze \n\n\n> done\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2F4FBBDCBD\n\tfor ;\n\tMon, 13 Apr 2026 07:12:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E58A662E63;\n\tMon, 13 Apr 2026 09:12:04 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 14AB662846\n\tfor ;\n\tMon, 13 Apr 2026 09:12:03 +0200 (CEST)","from [192.168.33.49] (185.182.214.8.nat.pool.zt.hu [185.182.214.8])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1E5E77FE;\n\tMon, 13 Apr 2026 09:10:31 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"dW3T9/od\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1776064231;\n\tbh=jnoimBitV/MmnN6H/xBZOF/zmDsFyFEE8KGEiQC0bcI=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=dW3T9/odzhM5IC37rvvI/WEcQ85JWbOlkqxkNaJSVX4EK6O7zjF+BxBoABHw+Kr3+\n\tJWmg0Bhh6g+allutZ8uNsh39lfv6uNa3HcInD7GY1camhoxuOmRyC0JM1lKPSnaMoq\n\tZNPCFSFMRLTYo+nEc5wMhw/+/Oo0KxLPWlx/tYWY=","Message-ID":"<0ae43f9f-5e27-4490-9820-ff7c60eb0d49@ideasonboard.com>","Date":"Mon, 13 Apr 2026 09:11:59 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] utils: update-kernel-headers: Fix destination path","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Cc":"Jacopo Mondi ","References":"<20260405213306.1224047-1-laurent.pinchart@ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20260405213306.1224047-1-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]