[{"id":3438,"web_url":"https://patchwork.libcamera.org/comment/3438/","msgid":"<20200114015742.GE784242@oden.dyn.berto.se>","date":"2020-01-14T01:57:42","subject":"Re: [libcamera-devel] [PATCH v2] libcamera: log: Expand log level\n\tnames","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Kieran,\n\nThanks for your work.\n\nOn 2020-01-14 01:47:28 +0000, Kieran Bingham wrote:\n> When the log severity names were added, there was only 4 characters\n> reserved for their printing. When the FATAL level was added, this\n> increased to 5, and thus both DBG and ERR can be expanded to their full\n> spelling. This also brings the levels in line with the representation\n> that can be used when calling logSetLevel().\n> \n> Reviewed-by: Laurent Pinchart \n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> v2:\n> - Expand commit message\n> - Expand spacing before the log severity name is printed.\n> \n> src/libcamera/log.cpp | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/libcamera/log.cpp b/src/libcamera/log.cpp\n> index f4eb8c11adc3..7d59f411f5d7 100644\n> --- a/src/libcamera/log.cpp\n> +++ b/src/libcamera/log.cpp\n> @@ -83,10 +83,10 @@ static int log_severity_to_syslog(LogSeverity severity)\n> static const char *log_severity_name(LogSeverity severity)\n> {\n> \tstatic const char *const names[] = {\n> -\t\t\" DBG\",\n> +\t\t\"DEBUG\",\n> \t\t\" INFO\",\n> \t\t\" WARN\",\n> -\t\t\" ERR\",\n> +\t\t\"ERROR\",\n> \t\t\"FATAL\",\n> \t};\n> \n> @@ -196,7 +196,7 @@ void LogOutput::write(const LogMessage &msg)\n> \t\tbreak;\n> \tcase LoggingTargetStream:\n> \tcase LoggingTargetFile:\n> -\t\tstr = \"[\" + utils::time_point_to_string(msg.timestamp()) + \"]\"\n> +\t\tstr = \"[\" + utils::time_point_to_string(msg.timestamp()) + \"] \"\n> \t\t + log_severity_name(msg.severity()) + \" \"\n> \t\t + msg.category().name() + \" \" + msg.fileInfo() + \" \"\n> \t\t + msg.msg();\n> -- \n> 2.20.1\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lj1-x241.google.com (mail-lj1-x241.google.com\n\t[IPv6:2a00:1450:4864:20::241])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 07FBC6070F\n\tfor ;\n\tTue, 14 Jan 2020 02:57:44 +0100 (CET)","by mail-lj1-x241.google.com with SMTP id y4so12418485ljj.9\n\tfor ;\n\tMon, 13 Jan 2020 17:57:43 -0800 (PST)","from localhost (h-93-159.A463.priv.bahnhof.se. [46.59.93.159])\n\tby smtp.gmail.com with ESMTPSA id\n\to69sm6459285lff.14.2020.01.13.17.57.42\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 13 Jan 2020 17:57:42 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=f+oen9UreGGKV1n8VKcebqqi/H/wOcD8WH/aDUlGAsA=;\n\tb=XUMhKz5GTnsEIiIA9mAvrs8sQ/P2hlTCwPLYRiAbEpDrEVNqdMxX2wU39RNLG9vuxm\n\tSiiKEJrZD5fHxeVRk9W+89FspPcSVM5/WoDYrPZ2lKP1n29t9v4yzxQ7lDVBf8cFs4se\n\tmi7lz79BIDB/kcnZkhhBjG2B6YYP0I7SputagNiua0VobkSSyerGpKDQULG3MIQilXnW\n\tHX+mfaUT8Yx1hDlSh2Pd+cT59/Z2KmscXXu5wORlgTTVJ9ZeJnZr0YqELYC1T38ECmqS\n\tvQmS4M5mBDq0h5WTCagE9j9qkKzVXbFLPNEbhprexlRZSA9JFUrXiSLATuUvooP0HViQ\n\tggxw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=f+oen9UreGGKV1n8VKcebqqi/H/wOcD8WH/aDUlGAsA=;\n\tb=ZryvU3TOYZGwKhIUcdPLHDmFL//d9ppMLrxvO2Rg5vi0m8SzU/8M0gYrxskwI4ITlR\n\tfFCMv7cRGGP3cLq9uxOGkzwrrYUQmlAJJtkzLF8c5OoFdd5iGFpOhTRhBrPHmVImPNX4\n\ty+odWK8xz8SXzL618hfDwybVGNq6ly0GhMLaNpcQtTGJPfb5jP10xhGtXZ8MB+rVvuCA\n\tos7iFp3GpOjvQ2Aa7+ZOGRjHsNr5tEj7WvKEuJrMJlFvfmk7npf66DkbMc1gYcd27V6+\n\tMMkWrOSUqabwkHAPbk7gyIW99SjUo5Ge1Rc9NmrYp/ZQexCZMWRttrnmbZNaTonYmGxp\n\t3zbQ==","X-Gm-Message-State":"APjAAAWt0InlFDBMNivuZlEDl5Umj0wje8GpqiGGXbXEMWjjE9ssH/fn\n\tRSdq1Sd7PBFRKdHn4veuYGEfJDLLck0bWQ==","X-Google-Smtp-Source":"APXvYqx6v1KTCWk5Y6lsQDw0LU++8CvHvugchHGIlP/KMKaJEO2EtgLAXyHYXHHPKUnUC/FCAO89dQ==","X-Received":"by 2002:a05:651c:327:: with SMTP id\n\tb7mr12993683ljp.22.1578967063432; \n\tMon, 13 Jan 2020 17:57:43 -0800 (PST)","Date":"Tue, 14 Jan 2020 02:57:42 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Kieran Bingham ","Cc":"LibCamera Devel ","Message-ID":"<20200114015742.GE784242@oden.dyn.berto.se>","References":"<20200114014728.29981-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200114014728.29981-1-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2] libcamera: log: Expand log level\n\tnames","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 14 Jan 2020 01:57:44 -0000"}}]