[{"id":38517,"web_url":"https://patchwork.libcamera.org/comment/38517/","msgid":"","date":"2026-04-07T13:03:10","subject":"Re: [PATCH 11/11] include: linux: Convert drm_fourcc.h to use SPDX","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Laurent\n\nOn Sun, Apr 05, 2026 at 10:14:43PM +0300, Laurent Pinchart wrote:\n> drm_fourcc.h is the last file in libcamera to miss machine-parseable\n> license information. A patch to convert it to SPDX license identifiers\n> has been submitted to the kernel. Until it gets merged, apply the change\n> locally.\n\nFine to keep a modified version until upstream doesn't change as well\n\n>\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Jacopo Mondi \n\n> ---\n> include/linux/drm_fourcc.h | 20 +-------------------\n> 1 file changed, 1 insertion(+), 19 deletions(-)\n>\n> diff --git a/include/linux/drm_fourcc.h b/include/linux/drm_fourcc.h\n> index 8d7d89551bb3..b444c7f895e4 100644\n> --- a/include/linux/drm_fourcc.h\n> +++ b/include/linux/drm_fourcc.h\n> @@ -1,24 +1,6 @@\n> +/* SPDX-License-Identifier: MIT */\n> /*\n> * Copyright 2011 Intel Corporation\n> - *\n> - * Permission is hereby granted, free of charge, to any person obtaining a\n> - * copy of this software and associated documentation files (the \"Software\"),\n> - * to deal in the Software without restriction, including without limitation\n> - * the rights to use, copy, modify, merge, publish, distribute, sublicense,\n> - * and/or sell copies of the Software, and to permit persons to whom the\n> - * Software is furnished to do so, subject to the following conditions:\n> - *\n> - * The above copyright notice and this permission notice (including the next\n> - * paragraph) shall be included in all copies or substantial portions of the\n> - * Software.\n> - *\n> - * THE SOFTWARE IS PROVIDED \"AS IS\", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR\n> - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,\n> - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL\n> - * VA LINUX SYSTEMS AND/OR ITS SUPPLIERS BE LIABLE FOR ANY CLAIM, DAMAGES OR\n> - * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,\n> - * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR\n> - * OTHER DEALINGS IN THE SOFTWARE.\n> */\n>\n> #ifndef DRM_FOURCC_H\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4149BBEFBE\n\tfor ;\n\tTue, 7 Apr 2026 13:03:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D806B62DA1;\n\tTue, 7 Apr 2026 15:03:14 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 95D7D62846\n\tfor ;\n\tTue, 7 Apr 2026 15:03:13 +0200 (CEST)","from ideasonboard.com (mob-109-113-47-41.net.vodafone.it\n\t[109.113.47.41])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 197333C8;\n\tTue, 7 Apr 2026 15:01:46 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Vt8W2zKz\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1775566906;\n\tbh=c8xTFNG/hLLNo8bpu1dIEkCpxG2WIAIifK5rGLHOOfY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Vt8W2zKz7UvKn1qewRcRXUnwpm+miSgkijY2DOuy0goFkqThGEyXW+sGKfUIDOJrs\n\tSbY25a7GAa9rlVh4wBuTWp+tS0PkpNb79OPym4gNuQdqrgJ8jZQJ8okSq3+kfxsmMe\n\taeIobY/ktk3ac7TFY4TRCVb/lzAD/jkIUle69H1s=","Date":"Tue, 7 Apr 2026 15:03:10 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 11/11] include: linux: Convert drm_fourcc.h to use SPDX","Message-ID":"","References":"<20260405191443.1209948-1-laurent.pinchart@ideasonboard.com>\n\t<20260405191443.1209948-12-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20260405191443.1209948-12-laurent.pinchart@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":38593,"web_url":"https://patchwork.libcamera.org/comment/38593/","msgid":"","date":"2026-04-13T10:49:44","subject":"Re: [PATCH 11/11] include: linux: Convert drm_fourcc.h to use SPDX","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2026. 04. 05. 21:14 keltezéssel, Laurent Pinchart írta:\n> drm_fourcc.h is the last file in libcamera to miss machine-parseable\n> license information. A patch to convert it to SPDX license identifiers\n> has been submitted to the kernel. Until it gets merged, apply the change\n> locally.\n\nI see that v3 has been posted recently, but v2 was years ago. Is it expected\nthat it will be merged?\n\nReviewed-by: Barnabás Pőcze \n\n\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> include/linux/drm_fourcc.h | 20 +-------------------\n> 1 file changed, 1 insertion(+), 19 deletions(-)\n> \n> diff --git a/include/linux/drm_fourcc.h b/include/linux/drm_fourcc.h\n> index 8d7d89551bb3..b444c7f895e4 100644\n> --- a/include/linux/drm_fourcc.h\n> +++ b/include/linux/drm_fourcc.h\n> @@ -1,24 +1,6 @@\n> +/* SPDX-License-Identifier: MIT */\n> /*\n> * Copyright 2011 Intel Corporation\n> - *\n> - * Permission is hereby granted, free of charge, to any person obtaining a\n> - * copy of this software and associated documentation files (the \"Software\"),\n> - * to deal in the Software without restriction, including without limitation\n> - * the rights to use, copy, modify, merge, publish, distribute, sublicense,\n> - * and/or sell copies of the Software, and to permit persons to whom the\n> - * Software is furnished to do so, subject to the following conditions:\n> - *\n> - * The above copyright notice and this permission notice (including the next\n> - * paragraph) shall be included in all copies or substantial portions of the\n> - * Software.\n> - *\n> - * THE SOFTWARE IS PROVIDED \"AS IS\", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR\n> - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,\n> - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL\n> - * VA LINUX SYSTEMS AND/OR ITS SUPPLIERS BE LIABLE FOR ANY CLAIM, DAMAGES OR\n> - * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,\n> - * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR\n> - * OTHER DEALINGS IN THE SOFTWARE.\n> */\n> \n> #ifndef DRM_FOURCC_H","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E0D54BDCBD\n\tfor ;\n\tMon, 13 Apr 2026 10:49:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 253A462E79;\n\tMon, 13 Apr 2026 12:49:49 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3B6526271A\n\tfor ;\n\tMon, 13 Apr 2026 12:49:48 +0200 (CEST)","from [192.168.33.49] (185.182.214.8.nat.pool.zt.hu [185.182.214.8])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7039A4F1;\n\tMon, 13 Apr 2026 12:48:16 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"PmFQLg7H\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1776077296;\n\tbh=nPnKVlrePgWKk99U6ty/36xYX/N6Sp1pVuNZIPkxKOE=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=PmFQLg7H+g6MIGxavN6ZZua6dHCuGviVPgcxOQmz3VIIsctKuTq4sWHl6TWF4tvkV\n\twhqkcBshmGdhUCi/XR1AxgEFMmIIN/8yCSQ6plzYxA5+VvMdbJB7oL2KPkxspNHtHg\n\t6TbzG/qwuNDljrBFNmyt+8tqH4y+1SnErZHOgp+A=","Message-ID":"","Date":"Mon, 13 Apr 2026 12:49:44 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 11/11] include: linux: Convert drm_fourcc.h to use SPDX","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20260405191443.1209948-1-laurent.pinchart@ideasonboard.com>\n\t<20260405191443.1209948-12-laurent.pinchart@ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20260405191443.1209948-12-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]