[{"id":38516,"web_url":"https://patchwork.libcamera.org/comment/38516/","msgid":"<adUANhx8g-bl5GQI@zed>","date":"2026-04-07T13:02:25","subject":"Re: [PATCH 10/11] libcamera: rpi: Add missing SPDX headers","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"This is fine with me, but maybe someone from RPi should send a tag as\nwell\n\nOn Sun, Apr 05, 2026 at 10:14:42PM +0300, Laurent Pinchart wrote:\n> Multiple files in the Raspberry Pi pipeline handler and IPA module are\n> missing SPDX headers. Add them with the following licenses:\n>\n> - For code and documentation, use the BSD-2-Clause license, as for the\n>   rest of the Raspberry Pi code.\n>\n> - For the example pipeline handler configuration files, use the CC0-1.0\n>   license to facilitate their usage.\n>\n> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\nReviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n\n> ---\n>  src/ipa/rpi/controller/decompand_status.h         | 1 +\n>  src/ipa/rpi/controller/rpi/decompand.cpp          | 2 ++\n>  src/ipa/rpi/controller/rpi/decompand.h            | 1 +\n>  src/libcamera/pipeline/rpi/pisp/data/example.yaml | 1 +\n>  src/libcamera/pipeline/rpi/vc4/data/example.yaml  | 1 +\n>  utils/raspberrypi/ctt/README.md                   | 2 ++\n>  6 files changed, 8 insertions(+)\n>\n> diff --git a/src/ipa/rpi/controller/decompand_status.h b/src/ipa/rpi/controller/decompand_status.h\n> index 2d9888dca4f3..d024fe71936d 100644\n> --- a/src/ipa/rpi/controller/decompand_status.h\n> +++ b/src/ipa/rpi/controller/decompand_status.h\n> @@ -1,3 +1,4 @@\n> +/* SPDX-License-Identifier: BSD-2-Clause */\n>  #pragma once\n>\n>  #include \"libipa/pwl.h\"\n> diff --git a/src/ipa/rpi/controller/rpi/decompand.cpp b/src/ipa/rpi/controller/rpi/decompand.cpp\n> index 2d457926c060..b93e5c0b1974 100644\n> --- a/src/ipa/rpi/controller/rpi/decompand.cpp\n> +++ b/src/ipa/rpi/controller/rpi/decompand.cpp\n> @@ -1,3 +1,5 @@\n> +/* SPDX-License-Identifier: BSD-2-Clause */\n> +\n>  #include \"decompand.h\"\n>\n>  #include <libcamera/base/log.h>\n> diff --git a/src/ipa/rpi/controller/rpi/decompand.h b/src/ipa/rpi/controller/rpi/decompand.h\n> index 6db779c359a8..fdb4d733adda 100644\n> --- a/src/ipa/rpi/controller/rpi/decompand.h\n> +++ b/src/ipa/rpi/controller/rpi/decompand.h\n> @@ -1,3 +1,4 @@\n> +/* SPDX-License-Identifier: BSD-2-Clause */\n>  #pragma once\n>\n>  #include <libipa/pwl.h>\n> diff --git a/src/libcamera/pipeline/rpi/pisp/data/example.yaml b/src/libcamera/pipeline/rpi/pisp/data/example.yaml\n> index c5edbba074e8..4b0742452cf1 100644\n> --- a/src/libcamera/pipeline/rpi/pisp/data/example.yaml\n> +++ b/src/libcamera/pipeline/rpi/pisp/data/example.yaml\n> @@ -1,3 +1,4 @@\n> +# SPDX-License-Identifier: CC0-1.0\n>  {\n>          \"version\": 1.0,\n>          \"target\": \"pisp\",\n> diff --git a/src/libcamera/pipeline/rpi/vc4/data/example.yaml b/src/libcamera/pipeline/rpi/vc4/data/example.yaml\n> index 2ee2b864d55f..9e8d0fdb225f 100644\n> --- a/src/libcamera/pipeline/rpi/vc4/data/example.yaml\n> +++ b/src/libcamera/pipeline/rpi/vc4/data/example.yaml\n> @@ -1,3 +1,4 @@\n> +# SPDX-License-Identifier: CC0-1.0\n>  {\n>          \"version\": 1.0,\n>          \"target\": \"bcm2835\",\n> diff --git a/utils/raspberrypi/ctt/README.md b/utils/raspberrypi/ctt/README.md\n> index c3a738ad01ad..aa78274667b6 100644\n> --- a/utils/raspberrypi/ctt/README.md\n> +++ b/utils/raspberrypi/ctt/README.md\n> @@ -1,3 +1,5 @@\n> +.. SPDX-License-Identifier: BSD-2-Clause\n> +\n>  The Raspberry Pi CTT has moved from this location to the following GitHub\n>  repository:\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 07606BEFBE\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue,  7 Apr 2026 13:02:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2702A62D95;\n\tTue,  7 Apr 2026 15:02:32 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CCF8D62846\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue,  7 Apr 2026 15:02:29 +0200 (CEST)","from ideasonboard.com (mob-109-113-47-41.net.vodafone.it\n\t[109.113.47.41])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id ED14178E;\n\tTue,  7 Apr 2026 15:01:01 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"J/Wn5uRo\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1775566862;\n\tbh=gK79hd3roiIC5sjHxCNOI9nLAc0dpV3ffxW9BOAdBDA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=J/Wn5uRox239GpwLgucVVZUov8kH5Magn0m8kMbBfGkHDvzr3SLNcbYgnfP24xWLc\n\tSADevYb4b9iPLa/tHMeP+qFhOc4EUNIGUvgaRbtKJlBWDGykDfHFCoz+5Fqpbu+tRs\n\tbm3zKyjdwfg1o9hDPM7uceVZC4IMGtm/c9uRQYA8=","Date":"Tue, 7 Apr 2026 15:02:25 +0200","From":"Jacopo Mondi <jacopo.mondi@ideasonboard.com>","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org, \n\tNaushir Patuck <naush@raspberrypi.com>,\n\tDavid Plowman <david.plowman@raspberrypi.com>","Subject":"Re: [PATCH 10/11] libcamera: rpi: Add missing SPDX headers","Message-ID":"<adUANhx8g-bl5GQI@zed>","References":"<20260405191443.1209948-1-laurent.pinchart@ideasonboard.com>\n\t<20260405191443.1209948-11-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20260405191443.1209948-11-laurent.pinchart@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":38526,"web_url":"https://patchwork.libcamera.org/comment/38526/","msgid":"<CAEmqJPq4a1-rzUnn1+YaiWhwGFjp1+ziK-6SW_U+VFVBRKTziA@mail.gmail.com>","date":"2026-04-08T07:59:40","subject":"Re: [PATCH 10/11] libcamera: rpi: Add missing SPDX headers","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi Laurent,\n\nThanks for the fixes.\n\nOn Sun, 5 Apr 2026 at 20:15, Laurent Pinchart\n<laurent.pinchart@ideasonboard.com> wrote:\n>\n> Multiple files in the Raspberry Pi pipeline handler and IPA module are\n> missing SPDX headers. Add them with the following licenses:\n>\n> - For code and documentation, use the BSD-2-Clause license, as for the\n>   rest of the Raspberry Pi code.\n>\n> - For the example pipeline handler configuration files, use the CC0-1.0\n>   license to facilitate their usage.\n>\n> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\nReviewed-by: Naushir Patuck <naush@raspberrypi.com>\n\nShould we update all the tuning files in src/ipa/rpi/[vc4|pisp]/data/\nas part of this change?\n\nRegards,\nNaush\n\n> ---\n>  src/ipa/rpi/controller/decompand_status.h         | 1 +\n>  src/ipa/rpi/controller/rpi/decompand.cpp          | 2 ++\n>  src/ipa/rpi/controller/rpi/decompand.h            | 1 +\n>  src/libcamera/pipeline/rpi/pisp/data/example.yaml | 1 +\n>  src/libcamera/pipeline/rpi/vc4/data/example.yaml  | 1 +\n>  utils/raspberrypi/ctt/README.md                   | 2 ++\n>  6 files changed, 8 insertions(+)\n>\n> diff --git a/src/ipa/rpi/controller/decompand_status.h b/src/ipa/rpi/controller/decompand_status.h\n> index 2d9888dca4f3..d024fe71936d 100644\n> --- a/src/ipa/rpi/controller/decompand_status.h\n> +++ b/src/ipa/rpi/controller/decompand_status.h\n> @@ -1,3 +1,4 @@\n> +/* SPDX-License-Identifier: BSD-2-Clause */\n>  #pragma once\n>\n>  #include \"libipa/pwl.h\"\n> diff --git a/src/ipa/rpi/controller/rpi/decompand.cpp b/src/ipa/rpi/controller/rpi/decompand.cpp\n> index 2d457926c060..b93e5c0b1974 100644\n> --- a/src/ipa/rpi/controller/rpi/decompand.cpp\n> +++ b/src/ipa/rpi/controller/rpi/decompand.cpp\n> @@ -1,3 +1,5 @@\n> +/* SPDX-License-Identifier: BSD-2-Clause */\n> +\n>  #include \"decompand.h\"\n>\n>  #include <libcamera/base/log.h>\n> diff --git a/src/ipa/rpi/controller/rpi/decompand.h b/src/ipa/rpi/controller/rpi/decompand.h\n> index 6db779c359a8..fdb4d733adda 100644\n> --- a/src/ipa/rpi/controller/rpi/decompand.h\n> +++ b/src/ipa/rpi/controller/rpi/decompand.h\n> @@ -1,3 +1,4 @@\n> +/* SPDX-License-Identifier: BSD-2-Clause */\n>  #pragma once\n>\n>  #include <libipa/pwl.h>\n> diff --git a/src/libcamera/pipeline/rpi/pisp/data/example.yaml b/src/libcamera/pipeline/rpi/pisp/data/example.yaml\n> index c5edbba074e8..4b0742452cf1 100644\n> --- a/src/libcamera/pipeline/rpi/pisp/data/example.yaml\n> +++ b/src/libcamera/pipeline/rpi/pisp/data/example.yaml\n> @@ -1,3 +1,4 @@\n> +# SPDX-License-Identifier: CC0-1.0\n>  {\n>          \"version\": 1.0,\n>          \"target\": \"pisp\",\n> diff --git a/src/libcamera/pipeline/rpi/vc4/data/example.yaml b/src/libcamera/pipeline/rpi/vc4/data/example.yaml\n> index 2ee2b864d55f..9e8d0fdb225f 100644\n> --- a/src/libcamera/pipeline/rpi/vc4/data/example.yaml\n> +++ b/src/libcamera/pipeline/rpi/vc4/data/example.yaml\n> @@ -1,3 +1,4 @@\n> +# SPDX-License-Identifier: CC0-1.0\n>  {\n>          \"version\": 1.0,\n>          \"target\": \"bcm2835\",\n> diff --git a/utils/raspberrypi/ctt/README.md b/utils/raspberrypi/ctt/README.md\n> index c3a738ad01ad..aa78274667b6 100644\n> --- a/utils/raspberrypi/ctt/README.md\n> +++ b/utils/raspberrypi/ctt/README.md\n> @@ -1,3 +1,5 @@\n> +.. SPDX-License-Identifier: BSD-2-Clause\n> +\n>  The Raspberry Pi CTT has moved from this location to the following GitHub\n>  repository:\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E97D6BEFBE\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed,  8 Apr 2026 08:00:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 17FB462DCB;\n\tWed,  8 Apr 2026 10:00:19 +0200 (CEST)","from mail-ua1-x92d.google.com (mail-ua1-x92d.google.com\n\t[IPv6:2607:f8b0:4864:20::92d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 47AD862DAD\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed,  8 Apr 2026 10:00:17 +0200 (CEST)","by mail-ua1-x92d.google.com with SMTP id\n\ta1e0cc1a2514c-953e00e7dbdso128916241.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 08 Apr 2026 01:00:17 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"cc3J+XKj\"; dkim-atps=neutral","ARC-Seal":"i=1; a=rsa-sha256; t=1775635216; cv=none;\n\td=google.com; s=arc-20240605;\n\tb=kRJB+6YNR4j7h1kqeVhEg8SCKz+E2L9v8e5qTJ7g6UbuWPKEsALl9fYV9Lq9dIQU4G\n\tygQHA/YRhZBinrNAepD+J0969GYxoeWVQfoSjRomO2tB+eATG28IHedgs0N1ejwMoQ19\n\tpJaTnFTqhQCz7D5dq1MeRro6uJhSQUuSpg85sV6HAGJYY+SUHoI1t/pupGDou+oiPs2y\n\tkQcMtJBh20gYkcG2Yhd5SvvpoiyAUj4dcKxYJgmBMReUCcSZwk8QKLRQ+Wtbm6/ldlKr\n\tF3sV30F82Rq3+PZqqFmvP+cL7EtzhV248xyN10rw3EBMVNJbEVxsRy5Gx2U7atL9Imto\n\tYjpw==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=arc-20240605; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:dkim-signature;\n\tbh=NrsQ1MSlLhqzYzEGPcmpbvwe/iBok/6mOEOGw4vu0Hs=;\n\tfh=kAwbguIY0wmqf1QQypnTiLH20ruRu7+JSSp6fzxLlN4=;\n\tb=lKqkLoCVB5n/iTfNSoEgL3r4Q+/k0BWfpSPeyKHlm47+XGSUdu8zpyxB70vI1US8TM\n\tsB7azVWJPCuY9OuURIqjyR49YclQSdkYCffY/1vVw3mbvimk0Z02VUwtssgo3aRgzPeO\n\tTjP4BdaycEVd0r6xTm4VYipPmoeBopu3j7K0CZfb1wcv28fFB1nb/vBWFMNBVd7772qv\n\th/v14fNhAe7G4IaXJBibCh5QE6/sTwC4U04cjs6OZlz2cG/Hp3dZ8+4jVfz4CO8tDpZr\n\tHtqbB9HVqLFIYOJIgbWeRuEDw/WqsM2Id0j7fiZdw8RUtBdC1JkimbjnirOtH+jncfeo\n\tQLEw==; darn=lists.libcamera.org","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1775635216; x=1776240016;\n\tdarn=lists.libcamera.org; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=NrsQ1MSlLhqzYzEGPcmpbvwe/iBok/6mOEOGw4vu0Hs=;\n\tb=cc3J+XKj3xuhhWMYxzkdzx+qQ5aosq/gyKE1SUCiROPQURJY56UXr9oSqXgxIuZXMP\n\t3da37XcHQ5m38GDtvqJTyzbo1ipL0Immhm6Aki4CkCyyw5M4mpWmzcwBxM6yK8+FMu7q\n\tnJO6EFAy1KKcRJgFl+xAirxklfvU4RznOjSwBjfRg4EVNBPzuH0VlC/LHZNWbCfAy51h\n\tix5dSpv+tV3q26tS4lji3RRqP0MC3KZI0fO6VKSzJV0HpeyWG9I2Gkqc98pHnEVw/GOv\n\tdQO+xyjNQgPqkWKr87X5Hm4F74eAChL06QgUeePkQLzVjzpRhiBl09W4+m5C6oSig/dK\n\tWmyg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20251104; t=1775635216; x=1776240016;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=NrsQ1MSlLhqzYzEGPcmpbvwe/iBok/6mOEOGw4vu0Hs=;\n\tb=dkla6soiseRuUIc6NANNlBpeWiy/y/hxJ3UYyVFE6habau63UWQsSpxn3ak9YhKfaE\n\tXnmjzLYYC/xisxeJupgFTBuYdzgYz1yFU//R2+yCB0UXzlPxWCaVHkDjlQHE5/WaZ53Q\n\tQ9eHa8Ntl1GWqFkebek1Hlv8IWoPiGGyfiEopNambRF+rTcP9MiRTSt5xcJhSWk74/ch\n\tWu2NCHvbpd6KcAbM78nRE9aFhVtjW0LKJRJpExfOTTU5ytyFAUYn+ipuqdU4LLNOXPr3\n\tz+ZqNB459Ht1A58NQ2GPoyOqpPgoE9/bjxQps80XOHyMG/Hh9RsFteIa8j+JtbQtywkl\n\tzAzQ==","X-Gm-Message-State":"AOJu0YzZJTA4cxwhBw9Al7JGHHT7/c0KbcmDFV9jTLQzMM2HHHa/v1/P\n\thx0OXqwSgWhGeMO+R5zJaCI+6QshRGYlPDuyz0/VQei3sKIbqPd6MfK4dqxTf2ZbPzrouwx6QIl\n\t/e265Vowqv50SXV9VNinxEV0VO4WyvhYNT3xpxbj3iqkaGRQLLs297yo=","X-Gm-Gg":"AeBDietHQWuChzU4wjk8LM8DfIU/UIwqn/XlU3nq2An+L5Z36HFlt1ZZdWECeekDE3B\n\tiLpTgD0C7XUt1tQ3VRfF0TWilSbjdhoda1bnba7M2DA+GDRQPQjB/cicsXST8+W9zNRBIKLFpB+\n\t5/7vTnVcSOiuq/p0zkRiH6q/BUfKuCzP1CnnP+jF9cVKJABGwrDyn5pBjUoZzmhcGv2AL5Kivte\n\tNAyCJs87eB9uY//Dq0VRCvLUiVEmQCT+4t3soW0Et+NXjxdFc1ljiUr2xrPI/TxBsmSImAdrECF\n\tPW8Nxv3zv/E2GKwj/BiAXPodjWkAFGHYVbDTK9Ok5hurDwkAEEZkw3xCA5Cv5t+9BpLuXx3qzck\n\teKB6DLna6jEzlPV46xK4/6FRv","X-Received":"by 2002:a05:6122:178d:b0:56c:ce6a:90d4 with SMTP id\n\t71dfb90a1353d-56f188a9c8amr549024e0c.3.1775635215989; Wed, 08 Apr 2026\n\t01:00:15 -0700 (PDT)","MIME-Version":"1.0","References":"<20260405191443.1209948-1-laurent.pinchart@ideasonboard.com>\n\t<20260405191443.1209948-11-laurent.pinchart@ideasonboard.com>","In-Reply-To":"<20260405191443.1209948-11-laurent.pinchart@ideasonboard.com>","From":"Naushir Patuck <naush@raspberrypi.com>","Date":"Wed, 8 Apr 2026 08:59:40 +0100","X-Gm-Features":"AQROBzABL97cjk84gZKyHd8w5ro5pCU_TTHjN0zVLQw9cwzJ3OiPV6l4cTE31i0","Message-ID":"<CAEmqJPq4a1-rzUnn1+YaiWhwGFjp1+ziK-6SW_U+VFVBRKTziA@mail.gmail.com>","Subject":"Re: [PATCH 10/11] libcamera: rpi: Add missing SPDX headers","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":38527,"web_url":"https://patchwork.libcamera.org/comment/38527/","msgid":"<20260408082215.GD1214579@killaraus.ideasonboard.com>","date":"2026-04-08T08:22:15","subject":"Re: [PATCH 10/11] libcamera: rpi: Add missing SPDX headers","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Naush,\n\nOn Wed, Apr 08, 2026 at 08:59:40AM +0100, Naushir Patuck wrote:\n> On Sun, 5 Apr 2026 at 20:15, Laurent Pinchart wrote:\n> >\n> > Multiple files in the Raspberry Pi pipeline handler and IPA module are\n> > missing SPDX headers. Add them with the following licenses:\n> >\n> > - For code and documentation, use the BSD-2-Clause license, as for the\n> >   rest of the Raspberry Pi code.\n> >\n> > - For the example pipeline handler configuration files, use the CC0-1.0\n> >   license to facilitate their usage.\n> >\n> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> \n> Reviewed-by: Naushir Patuck <naush@raspberrypi.com>\n> \n> Should we update all the tuning files in src/ipa/rpi/[vc4|pisp]/data/\n> as part of this change?\n\nThe JSON files are covered by REUSE.toml (currently .reuse/dep5,\nconverted to REUSE.toml as part of this series), because JSON\ntechnically does not support comments. Now, because we're using a YAML\nparser, we could add SPDX headers to the JSON tuning files and libcamera\nshould be able to handle that.\n\n> > ---\n> >  src/ipa/rpi/controller/decompand_status.h         | 1 +\n> >  src/ipa/rpi/controller/rpi/decompand.cpp          | 2 ++\n> >  src/ipa/rpi/controller/rpi/decompand.h            | 1 +\n> >  src/libcamera/pipeline/rpi/pisp/data/example.yaml | 1 +\n> >  src/libcamera/pipeline/rpi/vc4/data/example.yaml  | 1 +\n> >  utils/raspberrypi/ctt/README.md                   | 2 ++\n> >  6 files changed, 8 insertions(+)\n> >\n> > diff --git a/src/ipa/rpi/controller/decompand_status.h b/src/ipa/rpi/controller/decompand_status.h\n> > index 2d9888dca4f3..d024fe71936d 100644\n> > --- a/src/ipa/rpi/controller/decompand_status.h\n> > +++ b/src/ipa/rpi/controller/decompand_status.h\n> > @@ -1,3 +1,4 @@\n> > +/* SPDX-License-Identifier: BSD-2-Clause */\n> >  #pragma once\n> >\n> >  #include \"libipa/pwl.h\"\n> > diff --git a/src/ipa/rpi/controller/rpi/decompand.cpp b/src/ipa/rpi/controller/rpi/decompand.cpp\n> > index 2d457926c060..b93e5c0b1974 100644\n> > --- a/src/ipa/rpi/controller/rpi/decompand.cpp\n> > +++ b/src/ipa/rpi/controller/rpi/decompand.cpp\n> > @@ -1,3 +1,5 @@\n> > +/* SPDX-License-Identifier: BSD-2-Clause */\n> > +\n> >  #include \"decompand.h\"\n> >\n> >  #include <libcamera/base/log.h>\n> > diff --git a/src/ipa/rpi/controller/rpi/decompand.h b/src/ipa/rpi/controller/rpi/decompand.h\n> > index 6db779c359a8..fdb4d733adda 100644\n> > --- a/src/ipa/rpi/controller/rpi/decompand.h\n> > +++ b/src/ipa/rpi/controller/rpi/decompand.h\n> > @@ -1,3 +1,4 @@\n> > +/* SPDX-License-Identifier: BSD-2-Clause */\n> >  #pragma once\n> >\n> >  #include <libipa/pwl.h>\n> > diff --git a/src/libcamera/pipeline/rpi/pisp/data/example.yaml b/src/libcamera/pipeline/rpi/pisp/data/example.yaml\n> > index c5edbba074e8..4b0742452cf1 100644\n> > --- a/src/libcamera/pipeline/rpi/pisp/data/example.yaml\n> > +++ b/src/libcamera/pipeline/rpi/pisp/data/example.yaml\n> > @@ -1,3 +1,4 @@\n> > +# SPDX-License-Identifier: CC0-1.0\n> >  {\n> >          \"version\": 1.0,\n> >          \"target\": \"pisp\",\n> > diff --git a/src/libcamera/pipeline/rpi/vc4/data/example.yaml b/src/libcamera/pipeline/rpi/vc4/data/example.yaml\n> > index 2ee2b864d55f..9e8d0fdb225f 100644\n> > --- a/src/libcamera/pipeline/rpi/vc4/data/example.yaml\n> > +++ b/src/libcamera/pipeline/rpi/vc4/data/example.yaml\n> > @@ -1,3 +1,4 @@\n> > +# SPDX-License-Identifier: CC0-1.0\n> >  {\n> >          \"version\": 1.0,\n> >          \"target\": \"bcm2835\",\n> > diff --git a/utils/raspberrypi/ctt/README.md b/utils/raspberrypi/ctt/README.md\n> > index c3a738ad01ad..aa78274667b6 100644\n> > --- a/utils/raspberrypi/ctt/README.md\n> > +++ b/utils/raspberrypi/ctt/README.md\n> > @@ -1,3 +1,5 @@\n> > +.. SPDX-License-Identifier: BSD-2-Clause\n> > +\n> >  The Raspberry Pi CTT has moved from this location to the following GitHub\n> >  repository:\n> >","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 962D3BDCBD\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed,  8 Apr 2026 08:22:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 57D6362DB3;\n\tWed,  8 Apr 2026 10:22:18 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0976962647\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed,  8 Apr 2026 10:22:17 +0200 (CEST)","from killaraus.ideasonboard.com\n\t(2001-14ba-703d-e500--2a1.rev.dnainternet.fi\n\t[IPv6:2001:14ba:703d:e500::2a1])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id A0F911544; \n\tWed,  8 Apr 2026 10:20:48 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"nxDTlEm6\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1775636448;\n\tbh=PoFWjr/nnQnsgPS6VjqKRM3Q6V/ZVZq3HkK0Fv89DUo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=nxDTlEm6jPqLNCLUd2koSXa4Gk4P9/IQL4g0vYQPra++uuP8vCghn9oXxgSVieLCN\n\tTcLtUeV2dc1aQ56I80oWymMZmz6k0fxK8d9X443KEEJR2DnsnigiUEl4uFzvJspe8u\n\th4F1jSlNeoINAUIUArw/wRCjPNTPm3tMN8Ucp13Q=","Date":"Wed, 8 Apr 2026 11:22:15 +0300","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Naushir Patuck <naush@raspberrypi.com>","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 10/11] libcamera: rpi: Add missing SPDX headers","Message-ID":"<20260408082215.GD1214579@killaraus.ideasonboard.com>","References":"<20260405191443.1209948-1-laurent.pinchart@ideasonboard.com>\n\t<20260405191443.1209948-11-laurent.pinchart@ideasonboard.com>\n\t<CAEmqJPq4a1-rzUnn1+YaiWhwGFjp1+ziK-6SW_U+VFVBRKTziA@mail.gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<CAEmqJPq4a1-rzUnn1+YaiWhwGFjp1+ziK-6SW_U+VFVBRKTziA@mail.gmail.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]