[{"id":38594,"web_url":"https://patchwork.libcamera.org/comment/38594/","msgid":"<5dccda52-53d4-4c0b-b589-116ccd41884d@ideasonboard.com>","date":"2026-04-13T10:54:17","subject":"Re: [PATCH 09/11] libcamera: Add missing SPDX headers","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2026. 04. 05. 21:14 keltezéssel, Laurent Pinchart írta:\n> Multiple files in libcamera are missing SPDX headers. Add them with the\n> following licenses:\n> \n> - CC-BY-SA-4.0 for documentation\n> \n> - CC0-1.0 for build system, development tool configuration files and\n> TODO lists, as we consider them non-copyrightable, and for example\n> configuration files to facilitate their use\n> \n> - BSD-2-Clause for a file copied from the Raspberry Pi tuning tool (and\n> add the corresponding copyright information)\n> \n> While at it, add a missing blank line to\n> src/libcamera/pipeline/virtual/README.md.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n\nLooks ok to me, but haven't checked if it covers all missing files.\n\nReviewed-by: Barnabás Pőcze \n\n\n> .b4-config | 2 ++\n> Documentation/mainpage.dox | 2 ++\n> Documentation/thread-safety.dox | 2 ++\n> src/libcamera/pipeline/virtual/README.md | 3 +++\n> src/libcamera/pipeline/virtual/data/meson.build | 2 ++\n> src/libcamera/software_isp/TODO.md | 2 ++\n> utils/tuning/config-example.yaml | 1 +\n> utils/tuning/libtuning/ctt_colors.py | 5 +++++\n> utils/tuning/requirements.txt | 1 +\n> 9 files changed, 20 insertions(+)\n> \n> diff --git a/.b4-config b/.b4-config\n> index 371e3e9c2485..99d0361ce453 100644\n> --- a/.b4-config\n> +++ b/.b4-config\n> @@ -1,2 +1,4 @@\n> +# SPDX-License-Identifier: CC0-1.0\n> +\n> [b4]\n> send-series-to = libcamera-devel@lists.libcamera.org\n> diff --git a/Documentation/mainpage.dox b/Documentation/mainpage.dox\n> index 99e67e7ab13d..b651788ee918 100644\n> --- a/Documentation/mainpage.dox\n> +++ b/Documentation/mainpage.dox\n> @@ -1,3 +1,5 @@\n> +// SPDX-License-Identifier: CC-BY-SA-4.0\n> +\n> /**\n> \\if internal\n> \\mainpage libcamera internal API reference\n> diff --git a/Documentation/thread-safety.dox b/Documentation/thread-safety.dox\n> index df4c457c89d6..0bc02bfc071f 100644\n> --- a/Documentation/thread-safety.dox\n> +++ b/Documentation/thread-safety.dox\n> @@ -1,3 +1,5 @@\n> +// SPDX-License-Identifier: CC-BY-SA-4.0\n> +\n> /**\n> * \\page thread-safety Reentrancy and Thread-Safety\n> *\n> diff --git a/src/libcamera/pipeline/virtual/README.md b/src/libcamera/pipeline/virtual/README.md\n> index a9f39c15172b..0b2f03d8d719 100644\n> --- a/src/libcamera/pipeline/virtual/README.md\n> +++ b/src/libcamera/pipeline/virtual/README.md\n> @@ -1,3 +1,5 @@\n> +\n> +\n> # Virtual Pipeline Handler\n> \n> Virtual pipeline handler emulates fake external camera(s) for testing.\n> @@ -9,6 +11,7 @@ Virtual pipeline handler emulates fake external camera(s) for testing.\n> `share/libcamera/pipeline/virtual/virtual.yaml`.\n> \n> ### Config File Format\n> +\n> The config file contains the information about cameras' properties to register.\n> The config file should be a yaml file with dictionary of the cameraIds\n> associated with their properties as top level. The default value will be applied\n> diff --git a/src/libcamera/pipeline/virtual/data/meson.build b/src/libcamera/pipeline/virtual/data/meson.build\n> index ce63f9a27d43..0cade65bfa15 100644\n> --- a/src/libcamera/pipeline/virtual/data/meson.build\n> +++ b/src/libcamera/pipeline/virtual/data/meson.build\n> @@ -1,3 +1,5 @@\n> +# SPDX-License-Identifier: CC0-1.0\n> +\n> install_data('virtual.yaml',\n> install_dir : pipeline_data_dir / 'virtual',\n> install_tag : 'runtime',\n> diff --git a/src/libcamera/software_isp/TODO.md b/src/libcamera/software_isp/TODO.md\n> index 036cf2b7f9ce..0f27da2d243f 100644\n> --- a/src/libcamera/software_isp/TODO.md\n> +++ b/src/libcamera/software_isp/TODO.md\n> @@ -1,3 +1,5 @@\n> +\n> +\n> # Software ISP TODO list\n> \n> This file contains the TODO list for the software ISP.\n> diff --git a/utils/tuning/config-example.yaml b/utils/tuning/config-example.yaml\n> index 680f9213b269..0929d90ef747 100644\n> --- a/utils/tuning/config-example.yaml\n> +++ b/utils/tuning/config-example.yaml\n> @@ -1,3 +1,4 @@\n> +# SPDX-License-Identifier: CC0-1.0\n> general:\n> disable: []\n> plot: []\n> diff --git a/utils/tuning/libtuning/ctt_colors.py b/utils/tuning/libtuning/ctt_colors.py\n> index cb4d236b04d7..7e9ba646fa5b 100644\n> --- a/utils/tuning/libtuning/ctt_colors.py\n> +++ b/utils/tuning/libtuning/ctt_colors.py\n> @@ -1,4 +1,9 @@\n> +# SPDX-License-Identifier: BSD-2-Clause\n> +#\n> +# Copyright (C) 2023, Raspberry Pi Ltd\n> +#\n> # Program to convert from RGB to LAB color space\n> +\n> def RGB_to_LAB(RGB): # where RGB is a 1x3 array. e.g RGB = [100, 255, 230]\n> num = 0\n> XYZ = [0, 0, 0]\n> diff --git a/utils/tuning/requirements.txt b/utils/tuning/requirements.txt\n> index 3705769be7ff..8e14ce0911da 100644\n> --- a/utils/tuning/requirements.txt\n> +++ b/utils/tuning/requirements.txt\n> @@ -1,3 +1,4 @@\n> +# SPDX-License-Identifier: CC0-1.0\n> coloredlogs\n> matplotlib\n> numpy","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F13C3C32BB\n\tfor ;\n\tMon, 13 Apr 2026 10:54:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1D1C362E7F;\n\tMon, 13 Apr 2026 12:54:24 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B94F66271A\n\tfor ;\n\tMon, 13 Apr 2026 12:54:22 +0200 (CEST)","from [192.168.33.49] (185.182.214.8.nat.pool.zt.hu [185.182.214.8])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BDCDD4F1;\n\tMon, 13 Apr 2026 12:52:50 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Z/Le1w6d\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1776077570;\n\tbh=JFHvAsUaJu+nJrvxbTuGSqdC4E8LV6x0k8kBJ/JKzTs=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=Z/Le1w6dwSBE9k2wgBvr59vWcRrGeh7Vf9L1JlswFQ58MXho0E0NrFTMthb5O9bPc\n\tJJK/OLWwsD205bOy9NIVIIYdaDViD2GqYGwEy3HimSlQnx7WSqBaTCbg1YsnuSAxaS\n\ttpb79XBUywAB7LBieW2FZ9yh709niujoZcNego/k=","Message-ID":"<5dccda52-53d4-4c0b-b589-116ccd41884d@ideasonboard.com>","Date":"Mon, 13 Apr 2026 12:54:17 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 09/11] libcamera: Add missing SPDX headers","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20260405191443.1209948-1-laurent.pinchart@ideasonboard.com>\n\t<20260405191443.1209948-10-laurent.pinchart@ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20260405191443.1209948-10-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]