[{"id":38515,"web_url":"https://patchwork.libcamera.org/comment/38515/","msgid":"","date":"2026-04-07T12:50:38","subject":"Re: [PATCH 08/11] utils: ipc: extract-docs: Work around reuse tool\n\tproblem","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Laurent\n\nOn Sun, Apr 05, 2026 at 10:14:40PM +0300, Laurent Pinchart wrote:\n> The reuse tool fails to lint the extract-docs.py file because it\n> considers the 'SPDX-License-Identifier' string in a regex as a malformed\n> license identifier. Work around the issue by adding parentheses in the\n> regular expression, which doesn't affect the behaviour of the regex\n> matching but prevents the reuse tool from seeing the line.\n\nsmart move\n\n>\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Jacopo Mondi \n\n> ---\n> utils/codegen/ipc/extract-docs.py | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/utils/codegen/ipc/extract-docs.py b/utils/codegen/ipc/extract-docs.py\n> index 61f44caef52a..c51c4ab01a81 100755\n> --- a/utils/codegen/ipc/extract-docs.py\n> +++ b/utils/codegen/ipc/extract-docs.py\n> @@ -12,7 +12,7 @@ import sys\n>\n> regex_block_start = re.compile(r'^/\\*\\*$')\n> regex_block_end = re.compile(r'^ \\*/$')\n> -regex_spdx = re.compile(r'^/\\* SPDX-License-Identifier: .* \\*/$')\n> +regex_spdx = re.compile(r'^/\\* (SPDX)-License-Identifier: .* \\*/$')\n>\n>\n> def main(argv):\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 09927BDCBD\n\tfor ;\n\tTue, 7 Apr 2026 12:50:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AF2CE62D91;\n\tTue, 7 Apr 2026 14:50:42 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 56ACE62846\n\tfor ;\n\tTue, 7 Apr 2026 14:50:41 +0200 (CEST)","from ideasonboard.com (mob-109-113-47-41.net.vodafone.it\n\t[109.113.47.41])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D83C5667;\n\tTue, 7 Apr 2026 14:49:13 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"bRwGa/nM\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1775566154;\n\tbh=OPzOim1QhZ0ROQFEvN6d9N5t7BbGM/5deSsjO0TstCE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=bRwGa/nMbtgdK0Q8OrfLNbwQ07kG0cTJS45Qlo3vCOQSpfCfFHM33HPCHhtkHSDpg\n\tQkHz61mQvfVUD9rOZSbBTbTWQemxUr928Dndzw6BQFMHLijBI9QGXa+5V0JzgkmSSh\n\t0QH5u3ilQMgpDahprI0hg/TRLfyY6gCk7MCW8UlQ=","Date":"Tue, 7 Apr 2026 14:50:38 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 08/11] utils: ipc: extract-docs: Work around reuse tool\n\tproblem","Message-ID":"","References":"<20260405191443.1209948-1-laurent.pinchart@ideasonboard.com>\n\t<20260405191443.1209948-9-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20260405191443.1209948-9-laurent.pinchart@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":38592,"web_url":"https://patchwork.libcamera.org/comment/38592/","msgid":"<9d1199cb-62ff-4ef9-98d2-74b649b16cf9@ideasonboard.com>","date":"2026-04-13T10:40:02","subject":"Re: [PATCH 08/11] utils: ipc: extract-docs: Work around reuse tool\n\tproblem","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2026. 04. 05. 21:14 keltezéssel, Laurent Pinchart írta:\n> The reuse tool fails to lint the extract-docs.py file because it\n> considers the 'SPDX-License-Identifier' string in a regex as a malformed\n> license identifier. Work around the issue by adding parentheses in the\n> regular expression, which doesn't affect the behaviour of the regex\n> matching but prevents the reuse tool from seeing the line.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n\nThis is for sure a hack...\n\nReviewed-by: Barnabás Pőcze \n\n\n> utils/codegen/ipc/extract-docs.py | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/utils/codegen/ipc/extract-docs.py b/utils/codegen/ipc/extract-docs.py\n> index 61f44caef52a..c51c4ab01a81 100755\n> --- a/utils/codegen/ipc/extract-docs.py\n> +++ b/utils/codegen/ipc/extract-docs.py\n> @@ -12,7 +12,7 @@ import sys\n> \n> regex_block_start = re.compile(r'^/\\*\\*$')\n> regex_block_end = re.compile(r'^ \\*/$')\n> -regex_spdx = re.compile(r'^/\\* SPDX-License-Identifier: .* \\*/$')\n> +regex_spdx = re.compile(r'^/\\* (SPDX)-License-Identifier: .* \\*/$')\n> \n> \n> def main(argv):","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0663EC32BB\n\tfor ;\n\tMon, 13 Apr 2026 10:40:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8BFB262E7A;\n\tMon, 13 Apr 2026 12:40:06 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C8A5B62E6B\n\tfor ;\n\tMon, 13 Apr 2026 12:40:05 +0200 (CEST)","from [192.168.33.49] (185.182.214.8.nat.pool.zt.hu [185.182.214.8])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1D7574F1;\n\tMon, 13 Apr 2026 12:38:34 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"E+stJVp1\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1776076714;\n\tbh=5jR1loVbfOhhTgohKM+YprKNGGfwQuKTkwyhuDEkVVQ=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=E+stJVp1dX6j47mdbGv0sAXWKxX5xpFzzENWpNEFU/fau7hW5ZvhtV4W6wDGo+9Ur\n\tOAp1hCX0WV02GXXQNzGpf9Crqm3PTLptwDhbbi+z7zL7Hp7W3EhQ6GVETChAoocW9u\n\tR2S1O1VMObA+DXN9oG3aKVj8ZtX9enpPFSdG2M0M=","Message-ID":"<9d1199cb-62ff-4ef9-98d2-74b649b16cf9@ideasonboard.com>","Date":"Mon, 13 Apr 2026 12:40:02 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 08/11] utils: ipc: extract-docs: Work around reuse tool\n\tproblem","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20260405191443.1209948-1-laurent.pinchart@ideasonboard.com>\n\t<20260405191443.1209948-9-laurent.pinchart@ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20260405191443.1209948-9-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]