[{"id":38512,"web_url":"https://patchwork.libcamera.org/comment/38512/","msgid":"","date":"2026-04-07T12:40:16","subject":"Re: [PATCH 05/11] reuse: Update file paths in REUSE.toml","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Laurent\n\nOn Sun, Apr 05, 2026 at 10:14:37PM +0300, Laurent Pinchart wrote:\n> Multiple files listed in REUSE.toml have moved within the repository\n> without any update to the REUSE.toml file. Fix it.\n>\n> Signed-off-by: Laurent Pinchart \n> ---\n> REUSE.toml | 17 +++++++++++++----\n> 1 file changed, 13 insertions(+), 4 deletions(-)\n>\n> diff --git a/REUSE.toml b/REUSE.toml\n> index 046ae4df22ce..36bfe506aa2c 100644\n> --- a/REUSE.toml\n> +++ b/REUSE.toml\n> @@ -4,26 +4,35 @@ SPDX-PackageSupplier = \"Laurent Pinchart \"\n> SPDX-PackageDownloadLocation = \"https://git.libcamera.org/libcamera/libcamera.git/\"\n>\n> [[annotations]]\n> -path = [\"Documentation/binning.svg\", \"Documentation/camera-sensor-model.rst\", \"Documentation/sensor_model.svg\", \"Documentation/theme/static/libcamera-logo-text.svg\"]\n> +path = [\n> +\t\"Documentation/binning.svg\",\n> +\t\"Documentation/camera-sensor-model.rst\",\n> +\t\"Documentation/images/rotation/**.svg\",\n\nIs the double * intentional ?\n\n> +\t\"Documentation/sensor_model.svg\",\n> +\t\"Documentation/theme/static/libcamera-logo-text.svg\",\n> +]\n> precedence = \"aggregate\"\n> SPDX-FileCopyrightText = \"Copyright 2023 Ideas On Board Oy\"\n> SPDX-License-Identifier = \"CC-BY-SA-4.0\"\n>\n> [[annotations]]\n> -path = [\"src/ipa/rpi/vc4/data/**.json\", \"utils/raspberrypi/ctt/ctt_config_example.json\", \"utils/raspberrypi/ctt/ctt_ref.pgm\"]\n> +path = [\"src/ipa/rpi/vc4/data/**.json\"]\n> precedence = \"aggregate\"\n> SPDX-FileCopyrightText = \"2019-2020 Raspberry Pi Ltd\"\n> SPDX-License-Identifier = \"BSD-2-Clause\"\n>\n> [[annotations]]\n> -path = \"src/qcam/assets/feathericons/**.svg\"\n> +path = \"src/apps/qcam/assets/feathericons/**.svg\"\n> precedence = \"aggregate\"\n> SPDX-FileCopyrightText = \"2019 Cole Bemis (and other Feather icons contributors)\"\n> SPDX-License-Identifier = \"MIT\"\n> SPDX-FileComment = \"https://feathericons.com/\"\n>\n> [[annotations]]\n> -path = [\"utils/ipc/mojo\", \"utils/ipc/tools\"]\n> +path = [\n> +\t\"utils/codegen/ipc/mojo/**\",\n> +\t\"utils/codegen/ipc/tools/**\",\n> +]\n> precedence = \"aggregate\"\n> SPDX-FileCopyrightText = \"Copyright 2013-2020 The Chromium Authors. All rights reserved.\"\n> SPDX-License-Identifier = \"BSD-3-Clause\"\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CFA28BDCBD\n\tfor ;\n\tTue, 7 Apr 2026 12:40:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0A1B362D91;\n\tTue, 7 Apr 2026 14:40:21 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7DFF062846\n\tfor ;\n\tTue, 7 Apr 2026 14:40:19 +0200 (CEST)","from ideasonboard.com (mob-109-113-47-41.net.vodafone.it\n\t[109.113.47.41])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D3126667;\n\tTue, 7 Apr 2026 14:38:51 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"GtvY5tEl\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1775565532;\n\tbh=8lT71p2mbFQ0I5wAoN+IyVME5VD5EmLItv46oqM7+BI=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=GtvY5tElsxR4luOErAtQyFA47ANg6/hBdNLcZj+7Z6ErdKf78I0Nxxhtc8FW5wFw8\n\tBXkVFqlii8LN3tAj/pCS/TrnZmF3hqrrX2pELlj+nOGznCgD/a7BlQF7GYp8CFshEs\n\tklHdklI52iIUqqk3scb2I6FiAvqI1Ag2kjTsgSHE=","Date":"Tue, 7 Apr 2026 14:40:16 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 05/11] reuse: Update file paths in REUSE.toml","Message-ID":"","References":"<20260405191443.1209948-1-laurent.pinchart@ideasonboard.com>\n\t<20260405191443.1209948-6-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20260405191443.1209948-6-laurent.pinchart@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":38518,"web_url":"https://patchwork.libcamera.org/comment/38518/","msgid":"<20260407130445.GJ1268443@killaraus.ideasonboard.com>","date":"2026-04-07T13:04:45","subject":"Re: [PATCH 05/11] reuse: Update file paths in REUSE.toml","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Tue, Apr 07, 2026 at 02:40:16PM +0200, Jacopo Mondi wrote:\n> On Sun, Apr 05, 2026 at 10:14:37PM +0300, Laurent Pinchart wrote:\n> > Multiple files listed in REUSE.toml have moved within the repository\n> > without any update to the REUSE.toml file. Fix it.\n> >\n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > REUSE.toml | 17 +++++++++++++----\n> > 1 file changed, 13 insertions(+), 4 deletions(-)\n> >\n> > diff --git a/REUSE.toml b/REUSE.toml\n> > index 046ae4df22ce..36bfe506aa2c 100644\n> > --- a/REUSE.toml\n> > +++ b/REUSE.toml\n> > @@ -4,26 +4,35 @@ SPDX-PackageSupplier = \"Laurent Pinchart \"\n> > SPDX-PackageDownloadLocation = \"https://git.libcamera.org/libcamera/libcamera.git/\"\n> >\n> > [[annotations]]\n> > -path = [\"Documentation/binning.svg\", \"Documentation/camera-sensor-model.rst\", \"Documentation/sensor_model.svg\", \"Documentation/theme/static/libcamera-logo-text.svg\"]\n> > +path = [\n> > +\t\"Documentation/binning.svg\",\n> > +\t\"Documentation/camera-sensor-model.rst\",\n> > +\t\"Documentation/images/rotation/**.svg\",\n> \n> Is the double * intentional ?\n\n* matches everything except forward slashes (i.e. path separators).\n** and **/ match everything including forward slashes (i.e. path separators).\n\nIt was intentional, but thinking more about it, I'll use a single star.\n\n> > +\t\"Documentation/sensor_model.svg\",\n> > +\t\"Documentation/theme/static/libcamera-logo-text.svg\",\n> > +]\n> > precedence = \"aggregate\"\n> > SPDX-FileCopyrightText = \"Copyright 2023 Ideas On Board Oy\"\n> > SPDX-License-Identifier = \"CC-BY-SA-4.0\"\n> >\n> > [[annotations]]\n> > -path = [\"src/ipa/rpi/vc4/data/**.json\", \"utils/raspberrypi/ctt/ctt_config_example.json\", \"utils/raspberrypi/ctt/ctt_ref.pgm\"]\n> > +path = [\"src/ipa/rpi/vc4/data/**.json\"]\n> > precedence = \"aggregate\"\n> > SPDX-FileCopyrightText = \"2019-2020 Raspberry Pi Ltd\"\n> > SPDX-License-Identifier = \"BSD-2-Clause\"\n> >\n> > [[annotations]]\n> > -path = \"src/qcam/assets/feathericons/**.svg\"\n> > +path = \"src/apps/qcam/assets/feathericons/**.svg\"\n> > precedence = \"aggregate\"\n> > SPDX-FileCopyrightText = \"2019 Cole Bemis (and other Feather icons contributors)\"\n> > SPDX-License-Identifier = \"MIT\"\n> > SPDX-FileComment = \"https://feathericons.com/\"\n> >\n> > [[annotations]]\n> > -path = [\"utils/ipc/mojo\", \"utils/ipc/tools\"]\n> > +path = [\n> > +\t\"utils/codegen/ipc/mojo/**\",\n> > +\t\"utils/codegen/ipc/tools/**\",\n> > +]\n> > precedence = \"aggregate\"\n> > SPDX-FileCopyrightText = \"Copyright 2013-2020 The Chromium Authors. All rights reserved.\"\n> > SPDX-License-Identifier = \"BSD-3-Clause\"\n> \n> Reviewed-by: Jacopo Mondi ","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DE711BDCBD\n\tfor ;\n\tTue, 7 Apr 2026 13:04:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A53EF62D9D;\n\tTue, 7 Apr 2026 15:04:47 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CE51162D95\n\tfor ;\n\tTue, 7 Apr 2026 15:04:46 +0200 (CEST)","from killaraus.ideasonboard.com\n\t(2001-14ba-703d-e500--2a1.rev.dnainternet.fi\n\t[IPv6:2001:14ba:703d:e500::2a1])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 571073C8;\n\tTue, 7 Apr 2026 15:03:19 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"YzsMHyBd\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1775566999;\n\tbh=1LAGmajTezS1FUmH/EBJGNLqoldqE5oiPky1UzCkqEw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=YzsMHyBdMsx7rMjAZL6fqUap/locXjIYmXzH6Mtv9I7cTFE+MpLjnLJYQPxgizo8t\n\tPvughjJ+ZmV1IzopsMaJiyXWRhUtGgFkoRA8mmnkVxYmxWwl3Qb2J1ci+B/uIvY8pH\n\tWtZ4SCoEKRtZT+gjdNa9fR3gFxmNdNCshriTdWqA=","Date":"Tue, 7 Apr 2026 16:04:45 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 05/11] reuse: Update file paths in REUSE.toml","Message-ID":"<20260407130445.GJ1268443@killaraus.ideasonboard.com>","References":"<20260405191443.1209948-1-laurent.pinchart@ideasonboard.com>\n\t<20260405191443.1209948-6-laurent.pinchart@ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":38597,"web_url":"https://patchwork.libcamera.org/comment/38597/","msgid":"<45d651bd-0ccd-4eb9-bf4c-92ab52f10b46@ideasonboard.com>","date":"2026-04-13T11:02:45","subject":"Re: [PATCH 05/11] reuse: Update file paths in REUSE.toml","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2026. 04. 07. 15:04 keltezéssel, Laurent Pinchart írta:\n> On Tue, Apr 07, 2026 at 02:40:16PM +0200, Jacopo Mondi wrote:\n>> On Sun, Apr 05, 2026 at 10:14:37PM +0300, Laurent Pinchart wrote:\n>>> Multiple files listed in REUSE.toml have moved within the repository\n>>> without any update to the REUSE.toml file. Fix it.\n>>>\n>>> Signed-off-by: Laurent Pinchart \n>>> ---\n>>> REUSE.toml | 17 +++++++++++++----\n>>> 1 file changed, 13 insertions(+), 4 deletions(-)\n>>>\n>>> diff --git a/REUSE.toml b/REUSE.toml\n>>> index 046ae4df22ce..36bfe506aa2c 100644\n>>> --- a/REUSE.toml\n>>> +++ b/REUSE.toml\n>>> @@ -4,26 +4,35 @@ SPDX-PackageSupplier = \"Laurent Pinchart \"\n>>> SPDX-PackageDownloadLocation = \"https://git.libcamera.org/libcamera/libcamera.git/\"\n>>>\n>>> [[annotations]]\n>>> -path = [\"Documentation/binning.svg\", \"Documentation/camera-sensor-model.rst\", \"Documentation/sensor_model.svg\", \"Documentation/theme/static/libcamera-logo-text.svg\"]\n>>> +path = [\n>>> +\t\"Documentation/binning.svg\",\n>>> +\t\"Documentation/camera-sensor-model.rst\",\n>>> +\t\"Documentation/images/rotation/**.svg\",\n>>\n>> Is the double * intentional ?\n> \n> * matches everything except forward slashes (i.e. path separators).\n> ** and **/ match everything including forward slashes (i.e. path separators).\n> \n> It was intentional, but thinking more about it, I'll use a single star.\n\nReviewed-by: Barnabás Pőcze \n\n\n> \n>>> +\t\"Documentation/sensor_model.svg\",\n>>> +\t\"Documentation/theme/static/libcamera-logo-text.svg\",\n>>> +]\n>>> precedence = \"aggregate\"\n>>> SPDX-FileCopyrightText = \"Copyright 2023 Ideas On Board Oy\"\n>>> SPDX-License-Identifier = \"CC-BY-SA-4.0\"\n>>>\n>>> [[annotations]]\n>>> -path = [\"src/ipa/rpi/vc4/data/**.json\", \"utils/raspberrypi/ctt/ctt_config_example.json\", \"utils/raspberrypi/ctt/ctt_ref.pgm\"]\n>>> +path = [\"src/ipa/rpi/vc4/data/**.json\"]\n>>> precedence = \"aggregate\"\n>>> SPDX-FileCopyrightText = \"2019-2020 Raspberry Pi Ltd\"\n>>> SPDX-License-Identifier = \"BSD-2-Clause\"\n>>>\n>>> [[annotations]]\n>>> -path = \"src/qcam/assets/feathericons/**.svg\"\n>>> +path = \"src/apps/qcam/assets/feathericons/**.svg\"\n>>> precedence = \"aggregate\"\n>>> SPDX-FileCopyrightText = \"2019 Cole Bemis (and other Feather icons contributors)\"\n>>> SPDX-License-Identifier = \"MIT\"\n>>> SPDX-FileComment = \"https://feathericons.com/\"\n>>>\n>>> [[annotations]]\n>>> -path = [\"utils/ipc/mojo\", \"utils/ipc/tools\"]\n>>> +path = [\n>>> +\t\"utils/codegen/ipc/mojo/**\",\n>>> +\t\"utils/codegen/ipc/tools/**\",\n>>> +]\n>>> precedence = \"aggregate\"\n>>> SPDX-FileCopyrightText = \"Copyright 2013-2020 The Chromium Authors. All rights reserved.\"\n>>> SPDX-License-Identifier = \"BSD-3-Clause\"\n>>\n>> Reviewed-by: Jacopo Mondi \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5F9CABDCBD\n\tfor ;\n\tMon, 13 Apr 2026 11:02:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 94B5262E8F;\n\tMon, 13 Apr 2026 13:02:50 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 62BFD6271A\n\tfor ;\n\tMon, 13 Apr 2026 13:02:49 +0200 (CEST)","from [192.168.33.49] (185.182.214.8.nat.pool.zt.hu [185.182.214.8])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8828E78C;\n\tMon, 13 Apr 2026 13:01:17 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"l9thyLC6\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1776078077;\n\tbh=Y4XoK8VUoxFhP6gQ1m56jDQMPgDj+K8FuNElyTBxF5c=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=l9thyLC62Rg+BrqFnIQOFtKeDDHAPl7qkCPbIGmHMAwIKbXNED8hpDXNpKTKI1Fc0\n\tUVEqkY/k/7bO2DrtBBUAa2lW+dad3FDdCEMzqMBIERgeQEwS93ijbdTFIxiOmZksKz\n\tA7fbuU+xWtKv5dn4sYZ7ZrbmX0HzzbOMSxkpo2iU=","Message-ID":"<45d651bd-0ccd-4eb9-bf4c-92ab52f10b46@ideasonboard.com>","Date":"Mon, 13 Apr 2026 13:02:45 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 05/11] reuse: Update file paths in REUSE.toml","To":"Laurent Pinchart ,\n\tJacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","References":"<20260405191443.1209948-1-laurent.pinchart@ideasonboard.com>\n\t<20260405191443.1209948-6-laurent.pinchart@ideasonboard.com>\n\t\n\t<20260407130445.GJ1268443@killaraus.ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20260407130445.GJ1268443@killaraus.ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]