[{"id":3437,"web_url":"https://patchwork.libcamera.org/comment/3437/","msgid":"<20200114012750.GA27182@pendragon.ideasonboard.com>","date":"2020-01-14T01:27:50","subject":"Re: [libcamera-devel] [PATCH] libcamera: log: Expand log level names","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Tue, Jan 14, 2020 at 01:26:26AM +0000, Kieran Bingham wrote:\n> When the log severity names were added, there was only 4 characters\n> reserved for their printing. When the FATAL level was added, this\n> increased to 5, and thus both DBG and ERR can be expanded to their full\n> spelling.\n> \n> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n> ---\n>  src/libcamera/log.cpp | 4 ++--\n>  1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/log.cpp b/src/libcamera/log.cpp\n> index f4eb8c11adc3..4fc4b5ce0d39 100644\n> --- a/src/libcamera/log.cpp\n> +++ b/src/libcamera/log.cpp\n> @@ -83,10 +83,10 @@ static int log_severity_to_syslog(LogSeverity severity)\n>  static const char *log_severity_name(LogSeverity severity)\n>  {\n>  \tstatic const char *const names[] = {\n> -\t\t\"  DBG\",\n> +\t\t\"DEBUG\",\n>  \t\t\" INFO\",\n>  \t\t\" WARN\",\n> -\t\t\"  ERR\",\n> +\t\t\"ERROR\",\n>  \t\t\"FATAL\",\n>  \t};\n>","headers":{"Return-Path":"<laurent.pinchart@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C15756070F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 14 Jan 2020 02:28:03 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc108967-cmbg20-2-0-cust420.5-4.cable.virginm.net [81.101.7.165])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5699B563;\n\tTue, 14 Jan 2020 02:28:03 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1578965283;\n\tbh=6O9VPMz7mCLaKMUO2aLFLEsdEh0SGbKI4bdrAyVkl4s=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=l4acSFQUOdT8of9JPkxruPt6KeSYPUIVg+9pvU4hYlWPvPo19NFk4u/9DK3aV5BDk\n\tSi/BwbPRtqjzHXNoQotL8/IIZDP02CtJy0slgRPKXQiEU2r+CM8dG/ADyO/VGxREPg\n\tWrx3Qh3toQPsluaecocZsDTQBS9fq7AbLT0egugg=","Date":"Tue, 14 Jan 2020 03:27:50 +0200","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Cc":"LibCamera Devel <libcamera-devel@lists.libcamera.org>","Message-ID":"<20200114012750.GA27182@pendragon.ideasonboard.com>","References":"<20200114012626.25265-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20200114012626.25265-1-kieran.bingham@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH] libcamera: log: Expand log level names","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Tue, 14 Jan 2020 01:28:03 -0000"}}]