[{"id":38508,"web_url":"https://patchwork.libcamera.org/comment/38508/","msgid":"","date":"2026-04-07T12:30:26","subject":"Re: [PATCH 03/11] subprojects: Add nlohmann_json to .gitignore","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Laurent\n\nOn Sun, Apr 05, 2026 at 10:14:35PM +0300, Laurent Pinchart wrote:\n> libcamera use the nlohmann_json wrap indirectly through libpisp. This\n> causes the nlohmann_json.wrap being copied to /subprojects at configure\n> time, and nlohmann_json being downloaded to /nlohmann_json-3.11.2. Add\n> corresponding entries to .gitignore.\n>\n> Signed-off-by: Laurent Pinchart \n> ---\n> subprojects/.gitignore | 2 ++\n> 1 file changed, 2 insertions(+)\n>\n> diff --git a/subprojects/.gitignore b/subprojects/.gitignore\n> index d2ba90074717..1ca3e141b22e 100644\n> --- a/subprojects/.gitignore\n> +++ b/subprojects/.gitignore\n> @@ -3,5 +3,7 @@\n> /googletest-release*\n> /libpisp\n> /libyuv\n> +/nlohmann_json-3.11.2\n\nThis would need to be updated whenever the version required by libpisp\nchanges. Should we use a wildcard for this entry ?\n\n\n> +/nlohmann_json.wrap\n> /packagecache\n> /yaml-0.2.5\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1BF76BDCBD\n\tfor ;\n\tTue, 7 Apr 2026 12:30:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 05E7C62D8B;\n\tTue, 7 Apr 2026 14:30:32 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 10BC762846\n\tfor ;\n\tTue, 7 Apr 2026 14:30:30 +0200 (CEST)","from ideasonboard.com (mob-109-113-47-41.net.vodafone.it\n\t[109.113.47.41])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4941963C;\n\tTue, 7 Apr 2026 14:29:02 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"oSnP3p+l\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1775564942;\n\tbh=x6scIZHBgMVFHz+MGV6j0Z9YAVcmODMBA5uLb4EZDYc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=oSnP3p+lsSYqfO0Z4FWepaojxz4bT+GKPaH52P35rAmoTrGzo2y7Kid0ny/8UmD4l\n\tpEtQssjBkFw+0OTZKfVYU4fpzYax3vkSjQdibAkzgou5dfVJOk+x7CKUUSMBr7aZmI\n\tmaPFrfdtMM0AFTgPVzA+F5FoZlWcTi7JMqJVL7iw=","Date":"Tue, 7 Apr 2026 14:30:26 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 03/11] subprojects: Add nlohmann_json to .gitignore","Message-ID":"","References":"<20260405191443.1209948-1-laurent.pinchart@ideasonboard.com>\n\t<20260405191443.1209948-4-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20260405191443.1209948-4-laurent.pinchart@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":38509,"web_url":"https://patchwork.libcamera.org/comment/38509/","msgid":"<20260407123450.GH1268443@killaraus.ideasonboard.com>","date":"2026-04-07T12:34:50","subject":"Re: [PATCH 03/11] subprojects: Add nlohmann_json to .gitignore","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Tue, Apr 07, 2026 at 02:30:26PM +0200, Jacopo Mondi wrote:\n> On Sun, Apr 05, 2026 at 10:14:35PM +0300, Laurent Pinchart wrote:\n> > libcamera use the nlohmann_json wrap indirectly through libpisp. This\n> > causes the nlohmann_json.wrap being copied to /subprojects at configure\n> > time, and nlohmann_json being downloaded to /nlohmann_json-3.11.2. Add\n> > corresponding entries to .gitignore.\n> >\n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > subprojects/.gitignore | 2 ++\n> > 1 file changed, 2 insertions(+)\n> >\n> > diff --git a/subprojects/.gitignore b/subprojects/.gitignore\n> > index d2ba90074717..1ca3e141b22e 100644\n> > --- a/subprojects/.gitignore\n> > +++ b/subprojects/.gitignore\n> > @@ -3,5 +3,7 @@\n> > /googletest-release*\n> > /libpisp\n> > /libyuv\n> > +/nlohmann_json-3.11.2\n> \n> This would need to be updated whenever the version required by libpisp\n> changes. Should we use a wildcard for this entry ?\n\nGood point. I'll replace it with\n\n/nlohmann_json-*\n\n> > +/nlohmann_json.wrap\n> > /packagecache\n> > /yaml-0.2.5","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 40EBBBEFBE\n\tfor ;\n\tTue, 7 Apr 2026 12:34:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2ACBE62D98;\n\tTue, 7 Apr 2026 14:34:54 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 32B7E62846\n\tfor ;\n\tTue, 7 Apr 2026 14:34:52 +0200 (CEST)","from killaraus.ideasonboard.com\n\t(2001-14ba-703d-e500--2a1.rev.dnainternet.fi\n\t[IPv6:2001:14ba:703d:e500::2a1])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 9465E4B3;\n\tTue, 7 Apr 2026 14:33:24 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"sv2iPYqU\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1775565204;\n\tbh=Ag7S0FKBRoY4uQn3xbsz/5mep+2dOLrqnSSFLzux7xo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=sv2iPYqUw19pt4z/R/xGWPsYs2zCKJRlnsEj5ERr4v2Qf6M21tXRfOf4XaFwm2K8L\n\tmNC4Fw7QO2GAxI37AmzCrPCYqsKjaaFqeeCj1U1dDbxCKsf2fW6R6d7R1gX/k10NDz\n\tw3OVxwawOTeeKtu9WaCv9LYw+0PNQSqLK3/KGYx8=","Date":"Tue, 7 Apr 2026 15:34:50 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 03/11] subprojects: Add nlohmann_json to .gitignore","Message-ID":"<20260407123450.GH1268443@killaraus.ideasonboard.com>","References":"<20260405191443.1209948-1-laurent.pinchart@ideasonboard.com>\n\t<20260405191443.1209948-4-laurent.pinchart@ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":38510,"web_url":"https://patchwork.libcamera.org/comment/38510/","msgid":"<20260407123552.GI1268443@killaraus.ideasonboard.com>","date":"2026-04-07T12:35:52","subject":"Re: [PATCH 03/11] subprojects: Add nlohmann_json to .gitignore","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Tue, Apr 07, 2026 at 03:34:52PM +0300, Laurent Pinchart wrote:\n> On Tue, Apr 07, 2026 at 02:30:26PM +0200, Jacopo Mondi wrote:\n> > On Sun, Apr 05, 2026 at 10:14:35PM +0300, Laurent Pinchart wrote:\n> > > libcamera use the nlohmann_json wrap indirectly through libpisp. This\n> > > causes the nlohmann_json.wrap being copied to /subprojects at configure\n> > > time, and nlohmann_json being downloaded to /nlohmann_json-3.11.2. Add\n> > > corresponding entries to .gitignore.\n> > >\n> > > Signed-off-by: Laurent Pinchart \n> > > ---\n> > > subprojects/.gitignore | 2 ++\n> > > 1 file changed, 2 insertions(+)\n> > >\n> > > diff --git a/subprojects/.gitignore b/subprojects/.gitignore\n> > > index d2ba90074717..1ca3e141b22e 100644\n> > > --- a/subprojects/.gitignore\n> > > +++ b/subprojects/.gitignore\n> > > @@ -3,5 +3,7 @@\n> > > /googletest-release*\n> > > /libpisp\n> > > /libyuv\n> > > +/nlohmann_json-3.11.2\n> > \n> > This would need to be updated whenever the version required by libpisp\n> > changes. Should we use a wildcard for this entry ?\n> \n> Good point. I'll replace it with\n> \n> /nlohmann_json-*\n\nActually, with\n\n/nlohmann_json*\n\nand I'll drop the next line as the wild card will cover both.\n\n> > > +/nlohmann_json.wrap\n> > > /packagecache\n> > > /yaml-0.2.5","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8F7A8BEFBE\n\tfor ;\n\tTue, 7 Apr 2026 12:35:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3780B62D8B;\n\tTue, 7 Apr 2026 14:35:55 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9923562846\n\tfor ;\n\tTue, 7 Apr 2026 14:35:53 +0200 (CEST)","from killaraus.ideasonboard.com\n\t(2001-14ba-703d-e500--2a1.rev.dnainternet.fi\n\t[IPv6:2001:14ba:703d:e500::2a1])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 231254B3;\n\tTue, 7 Apr 2026 14:34:26 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"XNDbO8jk\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1775565266;\n\tbh=MjYZOvaA7wxbNi83+r9E0/WACc+BWAwSfxTs0grI3kc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=XNDbO8jkVF1V70OoP4oRWA1u0I8iYiaVHhnqahQzrj+EkBYjRZlXW2Oofokauea3m\n\theSMjtdnWyKL/shnXsgHul1YIJefuuT2KOm5qRI2GSF2+j/T1/h2DRSrJEBldsiipp\n\t4DYrouYw3C+lZBfNnb7ftLYPIMnBdmyYy4lEaNTc=","Date":"Tue, 7 Apr 2026 15:35:52 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 03/11] subprojects: Add nlohmann_json to .gitignore","Message-ID":"<20260407123552.GI1268443@killaraus.ideasonboard.com>","References":"<20260405191443.1209948-1-laurent.pinchart@ideasonboard.com>\n\t<20260405191443.1209948-4-laurent.pinchart@ideasonboard.com>\n\t\n\t<20260407123450.GH1268443@killaraus.ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20260407123450.GH1268443@killaraus.ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":38591,"web_url":"https://patchwork.libcamera.org/comment/38591/","msgid":"<5b55181c-8033-4977-8d13-1da242dd1e53@ideasonboard.com>","date":"2026-04-13T10:38:16","subject":"Re: [PATCH 03/11] subprojects: Add nlohmann_json to .gitignore","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2026. 04. 07. 14:35 keltezéssel, Laurent Pinchart írta:\n> On Tue, Apr 07, 2026 at 03:34:52PM +0300, Laurent Pinchart wrote:\n>> On Tue, Apr 07, 2026 at 02:30:26PM +0200, Jacopo Mondi wrote:\n>>> On Sun, Apr 05, 2026 at 10:14:35PM +0300, Laurent Pinchart wrote:\n>>>> libcamera use the nlohmann_json wrap indirectly through libpisp. This\n>>>> causes the nlohmann_json.wrap being copied to /subprojects at configure\n>>>> time, and nlohmann_json being downloaded to /nlohmann_json-3.11.2. Add\n>>>> corresponding entries to .gitignore.\n>>>>\n>>>> Signed-off-by: Laurent Pinchart \n>>>> ---\n>>>> subprojects/.gitignore | 2 ++\n>>>> 1 file changed, 2 insertions(+)\n>>>>\n>>>> diff --git a/subprojects/.gitignore b/subprojects/.gitignore\n>>>> index d2ba90074717..1ca3e141b22e 100644\n>>>> --- a/subprojects/.gitignore\n>>>> +++ b/subprojects/.gitignore\n>>>> @@ -3,5 +3,7 @@\n>>>> /googletest-release*\n>>>> /libpisp\n>>>> /libyuv\n>>>> +/nlohmann_json-3.11.2\n>>>\n>>> This would need to be updated whenever the version required by libpisp\n>>> changes. Should we use a wildcard for this entry ?\n>>\n>> Good point. I'll replace it with\n>>\n>> /nlohmann_json-*\n> \n> Actually, with\n> \n> /nlohmann_json*\n> \n> and I'll drop the next line as the wild card will cover both.\n\nReviewed-by: Barnabás Pőcze \n\nfor the above, with the wildcard.\n\n\n> \n>>>> +/nlohmann_json.wrap\n>>>> /packagecache\n>>>> /yaml-0.2.5\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F2571C32BB\n\tfor ;\n\tMon, 13 Apr 2026 10:38:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A63E662E84;\n\tMon, 13 Apr 2026 12:38:23 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 079C962E6B\n\tfor ;\n\tMon, 13 Apr 2026 12:38:22 +0200 (CEST)","from [192.168.33.49] (185.182.214.8.nat.pool.zt.hu [185.182.214.8])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1EF174BB;\n\tMon, 13 Apr 2026 12:36:48 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"HSGYPV4L\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1776076610;\n\tbh=1NR9TXKn/bkGy1GBBqZfxnlG7Jl7BYOnxIdsCczS6ZI=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=HSGYPV4Lr7HsJDdDrcutxtqH8OdNpVLasjd0hXuTFonz2x2Cpt6zwAp0LXdixLNGI\n\tPJ4/NC0cugM+KMJjSaJRvo2IToDG+IY7zipyW2MT28RLL+GukDMqDdBOe/FrEEN/ri\n\toDPsX+IrzTywWf6DOPhzobPOv9bCsotsI5jFCuNw=","Message-ID":"<5b55181c-8033-4977-8d13-1da242dd1e53@ideasonboard.com>","Date":"Mon, 13 Apr 2026 12:38:16 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 03/11] subprojects: Add nlohmann_json to .gitignore","To":"Laurent Pinchart ,\n\tJacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","References":"<20260405191443.1209948-1-laurent.pinchart@ideasonboard.com>\n\t<20260405191443.1209948-4-laurent.pinchart@ideasonboard.com>\n\t\n\t<20260407123450.GH1268443@killaraus.ideasonboard.com>\n\t<20260407123552.GI1268443@killaraus.ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20260407123552.GI1268443@killaraus.ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]