{"id":26414,"url":"https://patchwork.libcamera.org/api/patches/26414/?format=json","web_url":"https://patchwork.libcamera.org/patch/26414/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260401-mali-cru-v8-8-44c48f990e28@ideasonboard.com>","date":"2026-04-01T16:25:57","name":"[v8,8/8] libcamera: mali-c55: Fix sensor size computation","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"6c316a80ebcbf0901c3362311a408f227862c38e","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/?format=json","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/26414/mbox/","series":[{"id":5864,"url":"https://patchwork.libcamera.org/api/series/5864/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5864","date":"2026-04-01T16:25:49","name":"libcamera: mali-c55: Add support for memory-to-memory","version":8,"mbox":"https://patchwork.libcamera.org/series/5864/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/26414/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/26414/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5C776C32F9\n\tfor ;\n\tWed, 1 Apr 2026 16:26:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C5A0662D76;\n\tWed, 1 Apr 2026 18:26:10 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4765E62D66\n\tfor ;\n\tWed, 1 Apr 2026 18:26:03 +0200 (CEST)","from [100.93.44.16] (net-93-65-100-155.cust.vodafonedsl.it\n\t[93.65.100.155])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 194CFF04;\n\tWed, 1 Apr 2026 18:24:40 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"nJhH43Qo\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1775060680;\n\tbh=KqKprtini/35wm23jEEMQd4FCaoFI/KUjFpUo2GXVn4=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=nJhH43Qo3NqTq7N5PDslZk5/YlB2j2YlQT0NAg3uCwXmchhRYo//WdiFtYSC4NBib\n\t84brX33wAxtoQAp3mEzh9z6WZ+KDI8O4aDsNojoxnEwAYF1FFeQQo3JFg5e8BIu3J1\n\tJSq1S02GcLKFpqT1pfS4xgFuY32YKh+xfZGBh3BU=","From":"Jacopo Mondi ","Date":"Wed, 01 Apr 2026 18:25:57 +0200","Subject":"[PATCH v8 8/8] libcamera: mali-c55: Fix sensor size computation","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260401-mali-cru-v8-8-44c48f990e28@ideasonboard.com>","References":"<20260401-mali-cru-v8-0-44c48f990e28@ideasonboard.com>","In-Reply-To":"<20260401-mali-cru-v8-0-44c48f990e28@ideasonboard.com>","To":"Daniel Scally , \n\tlibcamera-devel@lists.libcamera.org","Cc":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tJacopo Mondi ","X-Mailer":"b4 0.14.3","X-Developer-Signature":"v=1; a=openpgp-sha256; l=1117;\n\ti=jacopo.mondi@ideasonboard.com; h=from:subject:message-id;\n\tbh=KqKprtini/35wm23jEEMQd4FCaoFI/KUjFpUo2GXVn4=;\n\tb=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBpzUcXPJAJ0NEj9SgacQmm+ZaNpoj4UtECTiG2I\n\tif7QUddKHKJAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCac1HFwAKCRByNAaPFqFW\n\tPL9rD/9N+tHRSt96G4godhc8ycAFi5rIpj7VVjs1Hdg1IFpgcyVu/BbchL6RvZ/fXIMjCGW8vAH\n\tDswBbgo2/WdTOHyIwgsmLUCW+NkGRSJA8sN6p9OFBwXCa/LHY35kmhIb/Xq9Tw4Jxe/F7ESPS6x\n\tDEpUMLKyo1JiIIl428a+I+TuHf/AFZJNILVrDrPlZSMSq/pa0PVJla6jdGpb8hln5g+FhW2BQf6\n\tuk1sUiuiKZyD2SQaqObDemV6cHBGs39srr1K+eC7Tj1D4nz+pP6ZsrsRlM7Wr6pYoYo/LE2fToe\n\tYq+I3jlbnlHpjGq6tgEaSF4taTNXgpiLtJFSQLfPaKIvJJD8QXIEjGRLOg2IfXX79oZp46XiCnJ\n\ttDI6iCuw6SlvsuhJ9iFU+9LrXPN7b72Bwij7tlpt3kd+YMcVqZyXvTQxwiX/iVYL2pMbTAQPSQi\n\ttBU4M15IA9FVhHg+Ed0Hdzr9HL+gBeQQG0v30ooicf7xYkyIL8ixdZXoz5UldDcmxw1XOrpJ/Rm\n\tGb1/wdX6mn8n5RZ9ffDV/Dh33ANNmuTWeP2wZ+9VfY/pDnndLgYiGAEH8NhWuMSHOpXyMuVkwyy\n\tGoYWgIEY8cu96JFzcggXLYK6CfkQDdcqJD9J1Aiu93Icy2TigDKv80WfI18G2b1cCR4GyKff0ki\n\ttDWPvjdhdON9dPA==","X-Developer-Key":"i=jacopo.mondi@ideasonboard.com; a=openpgp;\n\tfpr=72392EDC88144A65C701EA9BA5826A2587AD026B","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The last size in the list is always selected unconditionally because\nthe current best distance is not updated properly during the search.\n\nFix the size computation procedure which has an inverted assignment.\n\nSigned-off-by: Jacopo Mondi \nReviewed-by: Daniel Scally \nTested-by: Daniel Scally \nReviewed-by: Barnabás Pőcze \n---\n src/libcamera/pipeline/mali-c55/mali-c55.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\nindex a78ffc21c808..0aa4d5e1780b 100644\n--- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n+++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n@@ -662,7 +662,7 @@ CameraConfiguration::Status MaliC55CameraConfiguration::validate()\n \t\t\t\tstd::abs(static_cast(minSensorSize.height) -\n \t\t\t\t\t static_cast(size.height));\n \t\tif (dist < distance) {\n-\t\t\tdist = distance;\n+\t\t\tdistance = dist;\n \t\t\tbestSize = size;\n \t\t}\n \t}\n","prefixes":["v8","8/8"]}