[{"id":38472,"web_url":"https://patchwork.libcamera.org/comment/38472/","msgid":"","date":"2026-04-01T07:31:38","subject":"Re: [PATCH 2/2] egl: Switch to linux/drm_fourcc.h","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Bryan\n\nOn Wed, Apr 01, 2026 at 12:46:44AM +0100, Bryan O'Donoghue wrote:\n> Take the copy of drm_fourcc.h from th imported kernel headers instead of\n> from libdrm which may or may not be installed within the build environment.\n>\n> Signed-off-by: Bryan O'Donoghue \n> ---\n> src/libcamera/egl.cpp | 3 +--\n> 1 file changed, 1 insertion(+), 2 deletions(-)\n>\n> diff --git a/src/libcamera/egl.cpp b/src/libcamera/egl.cpp\n> index 5b9bbf410..a61803396 100644\n> --- a/src/libcamera/egl.cpp\n> +++ b/src/libcamera/egl.cpp\n\nThis seems to be indeed the only user of this header in the whole code\nbase\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> @@ -16,11 +16,10 @@\n>\n> #include \n> #include \n> +#include \n>\n> #include \n>\n> -#include \n> -\n> namespace libcamera {\n>\n> LOG_DEFINE_CATEGORY(eGL)\n> --\n> 2.52.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7338EBDCBD\n\tfor ;\n\tWed, 1 Apr 2026 07:31:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9DAA962D4A;\n\tWed, 1 Apr 2026 09:31:43 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E4BBD62781\n\tfor ;\n\tWed, 1 Apr 2026 09:31:41 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2001:b07:6462:5de2:520d:d7a3:63ca:99e8])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D4EAC250;\n\tWed, 1 Apr 2026 09:30:18 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"lmR7dW/T\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1775028619;\n\tbh=4G0q2vYNFeZtUoWzilEiWwGlymemHhNwywA3jNEGOn8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=lmR7dW/Th+GL2jb7wLB8uDgUftdMrrXINdOylN+6lUlw+M6ziZqxg49fFwoAuzvqe\n\tP+Q/kDEvzElWWXvuA4SaNJqTkEMBYA05n9UfoZzKKlGMGz2mn+z0VF8r79HOeDLGR4\n\tiIVqBVfutN/H7gaFHdtPhiyg8zt9mRtK59rPE3P4=","Date":"Wed, 1 Apr 2026 09:31:38 +0200","From":"Jacopo Mondi ","To":"Bryan O'Donoghue ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 2/2] egl: Switch to linux/drm_fourcc.h","Message-ID":"","References":"<20260331234644.14654-1-bryan.odonoghue@linaro.org>\n\t<20260331234644.14654-3-bryan.odonoghue@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20260331234644.14654-3-bryan.odonoghue@linaro.org>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":38474,"web_url":"https://patchwork.libcamera.org/comment/38474/","msgid":"<20260401073512.GB3642621@killaraus.ideasonboard.com>","date":"2026-04-01T07:35:12","subject":"Re: [PATCH 2/2] egl: Switch to linux/drm_fourcc.h","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Wed, Apr 01, 2026 at 12:46:44AM +0100, Bryan O'Donoghue wrote:\n> Take the copy of drm_fourcc.h from th imported kernel headers instead of\n\ns/from th/from the/\n\n> from libdrm which may or may not be installed within the build environment.\n> \n> Signed-off-by: Bryan O'Donoghue \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/egl.cpp | 3 +--\n> 1 file changed, 1 insertion(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/egl.cpp b/src/libcamera/egl.cpp\n> index 5b9bbf410..a61803396 100644\n> --- a/src/libcamera/egl.cpp\n> +++ b/src/libcamera/egl.cpp\n> @@ -16,11 +16,10 @@\n> \n> #include \n> #include \n> +#include \n> \n> #include \n> \n> -#include \n> -\n> namespace libcamera {\n> \n> LOG_DEFINE_CATEGORY(eGL)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4B0E0BEFBE\n\tfor ;\n\tWed, 1 Apr 2026 07:35:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0961362D4D;\n\tWed, 1 Apr 2026 09:35:16 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6292C62781\n\tfor ;\n\tWed, 1 Apr 2026 09:35:14 +0200 (CEST)","from killaraus.ideasonboard.com\n\t(2001-14ba-703d-e500--2a1.rev.dnainternet.fi\n\t[IPv6:2001:14ba:703d:e500::2a1])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 67A58F52;\n\tWed, 1 Apr 2026 09:33:51 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"sFuMyb4y\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1775028831;\n\tbh=xDEvajWpXfo319GgeaLWnNMuDSnGuNwxspUMOEhhiLw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=sFuMyb4y6py6kZnpnyMtSRIcGy/Q5vpn9uPRN9aH+ZcjAHZrG6rdnzFKksGgylXrj\n\t2E2fQIAM2M0mXNNfDUnMA5Quk+s63cso8E2mETYzZYaFsu5mM02aLYlnHNXw5Dqdvy\n\tHldkwHF+I5I2KKa+vGn3G4dsptKvZ5LdrsT3Bwwg=","Date":"Wed, 1 Apr 2026 10:35:12 +0300","From":"Laurent Pinchart ","To":"Bryan O'Donoghue ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 2/2] egl: Switch to linux/drm_fourcc.h","Message-ID":"<20260401073512.GB3642621@killaraus.ideasonboard.com>","References":"<20260331234644.14654-1-bryan.odonoghue@linaro.org>\n\t<20260331234644.14654-3-bryan.odonoghue@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20260331234644.14654-3-bryan.odonoghue@linaro.org>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]