[{"id":38489,"web_url":"https://patchwork.libcamera.org/comment/38489/","msgid":"","date":"2026-04-02T10:07:10","subject":"Re: [PATCH 2/2] libcamera: camera: Report the pipeline handler name","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Kieran\n\nOn Mon, Mar 30, 2026 at 12:40:25PM +0100, Kieran Bingham wrote:\n> Add the Pipeline handler name to the Camera Properties when a camera is\n> constructed.\n>\n> This helps support and identify how the camera is being managed\n> internally and what configuration has taken effect, especially as the\n> pipeline handler chosen can be impacted by both environment variables\n> and configuration files.\n>\n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Jacopo Mondi \n\n> ---\n> src/libcamera/camera.cpp | 1 +\n> 1 file changed, 1 insertion(+)\n>\n> diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\n> index f724a1be5e3d..93b9e603dd57 100644\n> --- a/src/libcamera/camera.cpp\n> +++ b/src/libcamera/camera.cpp\n> @@ -931,6 +931,7 @@ Camera::Camera(std::unique_ptr d, const std::string &id,\n> \t: Extensible(std::move(d))\n> {\n> \t_d()->id_ = id;\n> +\t_d()->properties_.set(properties::PipelineHandler, _d()->pipe_->name());\n> \t_d()->streams_ = streams;\n> \t_d()->validator_ = std::make_unique(this);\n> }\n>\n> --\n> 2.52.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 012B2BEFBE\n\tfor ;\n\tThu, 2 Apr 2026 10:07:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A75A662D5F;\n\tThu, 2 Apr 2026 12:07:15 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 706EB62CFD\n\tfor ;\n\tThu, 2 Apr 2026 12:07:13 +0200 (CEST)","from ideasonboard.com (static.170.20.224.46.clients.your-server.de\n\t[46.224.20.170])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BF5D12295;\n\tThu, 2 Apr 2026 12:05:49 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"bTGoEgZG\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1775124349;\n\tbh=IMe4a94gMvuCA2aPdPDkxKir62x153p9eww2kJtvcug=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=bTGoEgZG3JutMJrIi3PTk6clg1+OGNu+tFYB2nwS5rg02cEvTJvs0Xbn50Iol+Gun\n\tmk3O2kkjLT6QYzyUvKmHFO1TH/PzPdbtBk9Z5Wcq0osMFTCojQf+U+TVyZ7fF33jlo\n\twnUDF4TtbiS6bCwKepjAP+CeOekkfGhwJ8MjOLSQ=","Date":"Thu, 2 Apr 2026 12:07:10 +0200","From":"Jacopo Mondi ","To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 2/2] libcamera: camera: Report the pipeline handler name","Message-ID":"","References":"<20260330-kbingham-pipeline-handler-property-v1-0-fdab13d5d263@ideasonboard.com>\n\t<20260330-kbingham-pipeline-handler-property-v1-2-fdab13d5d263@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20260330-kbingham-pipeline-handler-property-v1-2-fdab13d5d263@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":38492,"web_url":"https://patchwork.libcamera.org/comment/38492/","msgid":"<20260402115522.GC3757725@killaraus.ideasonboard.com>","date":"2026-04-02T11:55:22","subject":"Re: [PATCH 2/2] libcamera: camera: Report the pipeline handler name","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Mon, Mar 30, 2026 at 12:40:25PM +0100, Kieran Bingham wrote:\n> Add the Pipeline handler name to the Camera Properties when a camera is\n> constructed.\n> \n> This helps support and identify how the camera is being managed\n> internally and what configuration has taken effect, especially as the\n> pipeline handler chosen can be impacted by both environment variables\n> and configuration files.\n> \n> Signed-off-by: Kieran Bingham \n> ---\n> src/libcamera/camera.cpp | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\n> index f724a1be5e3d..93b9e603dd57 100644\n> --- a/src/libcamera/camera.cpp\n> +++ b/src/libcamera/camera.cpp\n> @@ -931,6 +931,7 @@ Camera::Camera(std::unique_ptr d, const std::string &id,\n> \t: Extensible(std::move(d))\n> {\n> \t_d()->id_ = id;\n> +\t_d()->properties_.set(properties::PipelineHandler, _d()->pipe_->name());\n\nSeems easy.\n\nReviewed-by: Laurent Pinchart \n\n> \t_d()->streams_ = streams;\n> \t_d()->validator_ = std::make_unique(this);\n> }\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A49D5BEFBE\n\tfor ;\n\tThu, 2 Apr 2026 11:55:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CC54962D5E;\n\tThu, 2 Apr 2026 13:55:24 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A04AE62CEB\n\tfor ;\n\tThu, 2 Apr 2026 13:55:23 +0200 (CEST)","from killaraus.ideasonboard.com\n\t(2001-14ba-703d-e500--2a1.rev.dnainternet.fi\n\t[IPv6:2001:14ba:703d:e500::2a1])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id A716C2295; \n\tThu, 2 Apr 2026 13:53:59 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ItR/YBFK\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1775130839;\n\tbh=loygWxszdSLrcyE2x+wkq8+bE75TjCTGufC6SpRyH+A=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ItR/YBFKun2+6dDCLmAV96AwGhQCGKON0voueVeTYh9J3pQ78l5HfHglLeNOWR78K\n\tyyOGgyGn6JSJG1eGI5Kx/AZlMYR78l6rXq/xP6RmvmRqgc2hxAkCJciUqJysM2I5kJ\n\tA1rZx//VCnwLAR2EjvebaIzaIQt9tshMEsTb5+Xc=","Date":"Thu, 2 Apr 2026 14:55:22 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 2/2] libcamera: camera: Report the pipeline handler name","Message-ID":"<20260402115522.GC3757725@killaraus.ideasonboard.com>","References":"<20260330-kbingham-pipeline-handler-property-v1-0-fdab13d5d263@ideasonboard.com>\n\t<20260330-kbingham-pipeline-handler-property-v1-2-fdab13d5d263@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20260330-kbingham-pipeline-handler-property-v1-2-fdab13d5d263@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]