{"id":26348,"url":"https://patchwork.libcamera.org/api/patches/26348/?format=json","web_url":"https://patchwork.libcamera.org/patch/26348/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260325151416.2114564-7-stefan.klug@ideasonboard.com>","date":"2026-03-25T15:13:38","name":"[v2,06/32] pipeline: rkisp1: Include frame number when pushing to delayed controls","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"91e26a962a568ebada99c4573f5ba48869d4b66d","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/26348/mbox/","series":[{"id":5849,"url":"https://patchwork.libcamera.org/api/series/5849/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5849","date":"2026-03-25T15:13:32","name":"rkisp1: pipeline rework for PFC","version":2,"mbox":"https://patchwork.libcamera.org/series/5849/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/26348/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/26348/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B5817BE086\n\tfor ;\n\tWed, 25 Mar 2026 15:15:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6FE2C6284B;\n\tWed, 25 Mar 2026 16:15:00 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0A294627D7\n\tfor ;\n\tWed, 25 Mar 2026 16:14:59 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:b16a:5ed9:4ada:a95a])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 13D9C1943; \n\tWed, 25 Mar 2026 16:13:41 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"T8AKW9/5\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1774451621;\n\tbh=129Z8a31qMQqyivzB+cAoXFqgdyhkmvW0MDCa8PtwJQ=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=T8AKW9/5foFXfPB1lMKq1zSW2bhW5EsftFWc6gAMC+mAfbOekfJ2pUhPestQpZ80G\n\tbP0E79M9VYEY2eAwAIwq6TuS/TSC5eab9qeKk48AVKGQu7qxn948IbxCETC2LFE6Ih\n\tnYfsJkAMSH7HxgDcunj7JdNVRIb0eW7vfhLGEEhE=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ,\n\tPaul Elder ","Subject":"[PATCH v2 06/32] pipeline: rkisp1: Include frame number when pushing\n\tto delayed controls","Date":"Wed, 25 Mar 2026 16:13:38 +0100","Message-ID":"<20260325151416.2114564-7-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.51.0","In-Reply-To":"<20260325151416.2114564-1-stefan.klug@ideasonboard.com>","References":"<20260325151416.2114564-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Pass the frame number when pushing to delayed controls, to ease further\ndevelopment.\n\nSigned-off-by: Stefan Klug \nReviewed-by: Paul Elder \n\n---\n\nChanges in v2:\n- Collected tag\n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex 320a4dc5a899..31e5ae103209 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -495,10 +495,10 @@ void RkISP1CameraData::paramsComputed(unsigned int frame, unsigned int bytesused\n \t\tselfPath_->queueBuffer(info->selfPathBuffer);\n }\n \n-void RkISP1CameraData::setSensorControls([[maybe_unused]] unsigned int frame,\n+void RkISP1CameraData::setSensorControls(unsigned int frame,\n \t\t\t\t\t const ControlList &sensorControls)\n {\n-\tdelayedCtrls_->push(sensorControls);\n+\tdelayedCtrls_->push(frame, sensorControls);\n }\n \n void RkISP1CameraData::metadataReady(unsigned int frame, const ControlList &metadata)\n","prefixes":["v2","06/32"]}