[{"id":38450,"web_url":"https://patchwork.libcamera.org/comment/38450/","msgid":"","date":"2026-03-30T09:00:03","subject":"Re: [PATCH] libcamera: Make converter/softISP configure()'s\n\toutputCfgs argument really const","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"Hi\n\n2026. 03. 25. 11:56 keltezéssel, Hans de Goede írta:\n> The intent of the outputCfgs argument to the configure() function of\n> converter classes and the softISP is to allow the passed in stream-configs\n> to not be changed.\n> \n> But only the vector is const, the reference inside the vector are not\n> const, which allows modifying the stream-configs as can be seen inside\n> DebayerEGL::configure() which was using a non const reference outputCfg\n> helper variable.\n> \n> Fix this by making the references inside the vector const.\n> \n> Signed-off-by: Hans de Goede \n> ---\n> include/libcamera/internal/converter.h | 2 +-\n> include/libcamera/internal/converter/converter_dw100.h | 2 +-\n> include/libcamera/internal/converter/converter_v4l2_m2m.h | 2 +-\n> include/libcamera/internal/software_isp/software_isp.h | 2 +-\n> src/libcamera/converter/converter_dw100.cpp | 2 +-\n> src/libcamera/converter/converter_v4l2_m2m.cpp | 2 +-\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 +-\n> src/libcamera/pipeline/simple/simple.cpp | 2 +-\n> src/libcamera/software_isp/debayer.h | 2 +-\n> src/libcamera/software_isp/debayer_cpu.cpp | 2 +-\n> src/libcamera/software_isp/debayer_cpu.h | 2 +-\n> src/libcamera/software_isp/debayer_egl.cpp | 4 ++--\n> src/libcamera/software_isp/debayer_egl.h | 2 +-\n> src/libcamera/software_isp/software_isp.cpp | 2 +-\n> 14 files changed, 15 insertions(+), 15 deletions(-)\n> \n> diff --git a/include/libcamera/internal/converter.h b/include/libcamera/internal/converter.h\n> index 4b811686f..08e80a22f 100644\n> --- a/include/libcamera/internal/converter.h\n> +++ b/include/libcamera/internal/converter.h\n> @@ -71,7 +71,7 @@ public:\n> \t\t\t\t Alignment align = Alignment::Down) = 0;\n> \n> \tvirtual int configure(const StreamConfiguration &inputCfg,\n> -\t\t\t const std::vector> &outputCfgs) = 0;\n> +\t\t\t const std::vector> &outputCfgs) = 0;\n\nCould be made `Span>`.\nBut looks ok to me in any case.\n\nReviewed-by: Barnabás Pőcze \n\n\n\n> \tvirtual bool isConfigured(const Stream *stream) const = 0;\n> \tvirtual int exportBuffers(const Stream *stream, unsigned int count,\n> \t\t\t\t std::vector> *buffers) = 0;\n> diff --git a/include/libcamera/internal/converter/converter_dw100.h b/include/libcamera/internal/converter/converter_dw100.h\n> index d70c8fe76..0a41b180a 100644\n> --- a/include/libcamera/internal/converter/converter_dw100.h\n> +++ b/include/libcamera/internal/converter/converter_dw100.h\n> @@ -34,7 +34,7 @@ public:\n> \tint init(const YamlObject ¶ms);\n> \n> \tint configure(const StreamConfiguration &inputCfg,\n> -\t\t const std::vector>\n> +\t\t const std::vector>\n> \t\t\t &outputCfg);\n> \tbool isConfigured(const Stream *stream) const;\n> \n> diff --git a/include/libcamera/internal/converter/converter_v4l2_m2m.h b/include/libcamera/internal/converter/converter_v4l2_m2m.h\n> index 6d2453bb9..63cea6b08 100644\n> --- a/include/libcamera/internal/converter/converter_v4l2_m2m.h\n> +++ b/include/libcamera/internal/converter/converter_v4l2_m2m.h\n> @@ -54,7 +54,7 @@ public:\n> \t\t\t const Size &size, Alignment align = Alignment::Down) override;\n> \n> \tint configure(const StreamConfiguration &inputCfg,\n> -\t\t const std::vector>\n> +\t\t const std::vector>\n> \t\t &outputCfg) override;\n> \tbool isConfigured(const Stream *stream) const override;\n> \tint exportBuffers(const Stream *stream, unsigned int count,\n> diff --git a/include/libcamera/internal/software_isp/software_isp.h b/include/libcamera/internal/software_isp/software_isp.h\n> index ad89c9b3c..585e0d6d9 100644\n> --- a/include/libcamera/internal/software_isp/software_isp.h\n> +++ b/include/libcamera/internal/software_isp/software_isp.h\n> @@ -64,7 +64,7 @@ public:\n> \tstrideAndFrameSize(const PixelFormat &outputFormat, const Size &size);\n> \n> \tint configure(const StreamConfiguration &inputCfg,\n> -\t\t const std::vector> &outputCfgs,\n> +\t\t const std::vector> &outputCfgs,\n> \t\t const ipa::soft::IPAConfigInfo &configInfo);\n> \n> \tint exportBuffers(const Stream *stream, unsigned int count,\n> diff --git a/src/libcamera/converter/converter_dw100.cpp b/src/libcamera/converter/converter_dw100.cpp\n> index df5155cfd..7899fe8c2 100644\n> --- a/src/libcamera/converter/converter_dw100.cpp\n> +++ b/src/libcamera/converter/converter_dw100.cpp\n> @@ -142,7 +142,7 @@ int ConverterDW100Module::init(const YamlObject ¶ms)\n> * \\copydoc libcamera::V4L2M2MConverter::configure\n> */\n> int ConverterDW100Module::configure(const StreamConfiguration &inputCfg,\n> -\t\t\t\t const std::vector>\n> +\t\t\t\t const std::vector>\n> \t\t\t\t\t &outputCfgs)\n> {\n> \tint ret;\n> diff --git a/src/libcamera/converter/converter_v4l2_m2m.cpp b/src/libcamera/converter/converter_v4l2_m2m.cpp\n> index 4427a37c6..ffba0434e 100644\n> --- a/src/libcamera/converter/converter_v4l2_m2m.cpp\n> +++ b/src/libcamera/converter/converter_v4l2_m2m.cpp\n> @@ -548,7 +548,7 @@ Size V4L2M2MConverter::adjustSizes(const Size &cfgSize,\n> * \\copydoc libcamera::Converter::configure\n> */\n> int V4L2M2MConverter::configure(const StreamConfiguration &inputCfg,\n> -\t\t\t\tconst std::vector> &outputCfgs)\n> +\t\t\t\tconst std::vector> &outputCfgs)\n> {\n> \tint ret = 0;\n> \n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index 320a4dc5a..faeeecd96 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -1037,7 +1037,7 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)\n> \tdata->properties_.set(properties::ScalerCropMaximum, sensorCrop);\n> \n> \tstd::map streamConfig;\n> -\tstd::vector> outputCfgs;\n> +\tstd::vector> outputCfgs;\n> \n> \tfor (const StreamConfiguration &cfg : *config) {\n> \t\tif (cfg.stream() == &data->mainPathStream_) {\n> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> index 4a0b9f58d..9497ac13b 100644\n> --- a/src/libcamera/pipeline/simple/simple.cpp\n> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> @@ -1562,7 +1562,7 @@ int SimplePipelineHandler::configure(Camera *camera, CameraConfiguration *c)\n> \t}\n> \n> \t/* Configure the converter if needed. */\n> -\tstd::vector> outputCfgs;\n> +\tstd::vector> outputCfgs;\n> \tdata->useConversion_ = config->needConversion();\n> \n> \tdata->rawStream_ = nullptr;\n> diff --git a/src/libcamera/software_isp/debayer.h b/src/libcamera/software_isp/debayer.h\n> index ce9350b7b..ea1ec6dcf 100644\n> --- a/src/libcamera/software_isp/debayer.h\n> +++ b/src/libcamera/software_isp/debayer.h\n> @@ -39,7 +39,7 @@ public:\n> \tvirtual ~Debayer() = 0;\n> \n> \tvirtual int configure(const StreamConfiguration &inputCfg,\n> -\t\t\t const std::vector> &outputCfgs,\n> +\t\t\t const std::vector> &outputCfgs,\n> \t\t\t bool ccmEnabled) = 0;\n> \n> \tvirtual std::vector formats(PixelFormat inputFormat) = 0;\n> diff --git a/src/libcamera/software_isp/debayer_cpu.cpp b/src/libcamera/software_isp/debayer_cpu.cpp\n> index 1de70b3b7..dd0fff871 100644\n> --- a/src/libcamera/software_isp/debayer_cpu.cpp\n> +++ b/src/libcamera/software_isp/debayer_cpu.cpp\n> @@ -540,7 +540,7 @@ int DebayerCpu::setDebayerFunctions(PixelFormat inputFormat,\n> }\n> \n> int DebayerCpu::configure(const StreamConfiguration &inputCfg,\n> -\t\t\t const std::vector> &outputCfgs,\n> +\t\t\t const std::vector> &outputCfgs,\n> \t\t\t bool ccmEnabled)\n> {\n> \tif (getInputConfig(inputCfg.pixelFormat, inputConfig_) != 0)\n> diff --git a/src/libcamera/software_isp/debayer_cpu.h b/src/libcamera/software_isp/debayer_cpu.h\n> index a96998e92..c6f263e1b 100644\n> --- a/src/libcamera/software_isp/debayer_cpu.h\n> +++ b/src/libcamera/software_isp/debayer_cpu.h\n> @@ -35,7 +35,7 @@ public:\n> \t~DebayerCpu();\n> \n> \tint configure(const StreamConfiguration &inputCfg,\n> -\t\t const std::vector> &outputCfgs,\n> +\t\t const std::vector> &outputCfgs,\n> \t\t bool ccmEnabled);\n> \tSize patternSize(PixelFormat inputFormat);\n> \tstd::vector formats(PixelFormat input);\n> diff --git a/src/libcamera/software_isp/debayer_egl.cpp b/src/libcamera/software_isp/debayer_egl.cpp\n> index 9a0606b5a..547b3c3bd 100644\n> --- a/src/libcamera/software_isp/debayer_egl.cpp\n> +++ b/src/libcamera/software_isp/debayer_egl.cpp\n> @@ -277,7 +277,7 @@ int DebayerEGL::initBayerShaders(PixelFormat inputFormat, PixelFormat outputForm\n> }\n> \n> int DebayerEGL::configure(const StreamConfiguration &inputCfg,\n> -\t\t\t const std::vector> &outputCfgs,\n> +\t\t\t const std::vector> &outputCfgs,\n> \t\t\t [[maybe_unused]] bool ccmEnabled)\n> {\n> \tif (getInputConfig(inputCfg.pixelFormat, inputConfig_) != 0)\n> @@ -307,7 +307,7 @@ int DebayerEGL::configure(const StreamConfiguration &inputCfg,\n> \t\treturn -EINVAL;\n> \t}\n> \n> -\tStreamConfiguration &outputCfg = outputCfgs[0];\n> +\tconst StreamConfiguration &outputCfg = outputCfgs[0];\n> \tSizeRange outSizeRange = sizes(inputCfg.pixelFormat, inputCfg.size);\n> \tstd::tie(outputConfig_.stride, outputConfig_.frameSize) =\n> \t\tstrideAndFrameSize(outputCfg.pixelFormat, outputCfg.size);\n> diff --git a/src/libcamera/software_isp/debayer_egl.h b/src/libcamera/software_isp/debayer_egl.h\n> index 3abff1ad2..6bbe487a3 100644\n> --- a/src/libcamera/software_isp/debayer_egl.h\n> +++ b/src/libcamera/software_isp/debayer_egl.h\n> @@ -42,7 +42,7 @@ public:\n> \t~DebayerEGL();\n> \n> \tint configure(const StreamConfiguration &inputCfg,\n> -\t\t const std::vector> &outputCfgs,\n> +\t\t const std::vector> &outputCfgs,\n> \t\t bool ccmEnabled);\n> \n> \tSize patternSize(PixelFormat inputFormat);\n> diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\n> index 4cf5639d9..60228369f 100644\n> --- a/src/libcamera/software_isp/software_isp.cpp\n> +++ b/src/libcamera/software_isp/software_isp.cpp\n> @@ -262,7 +262,7 @@ SoftwareIsp::strideAndFrameSize(const PixelFormat &outputFormat, const Size &siz\n> * \\return 0 on success, a negative errno on failure\n> */\n> int SoftwareIsp::configure(const StreamConfiguration &inputCfg,\n> -\t\t\t const std::vector> &outputCfgs,\n> +\t\t\t const std::vector> &outputCfgs,\n> \t\t\t const ipa::soft::IPAConfigInfo &configInfo)\n> {\n> \tASSERT(ipa_ && debayer_);","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DC66DBE086\n\tfor ;\n\tMon, 30 Mar 2026 09:00:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D93E262CF4;\n\tMon, 30 Mar 2026 11:00:08 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4B6BD62CEF\n\tfor ;\n\tMon, 30 Mar 2026 11:00:08 +0200 (CEST)","from [192.168.33.33] (185.221.143.129.nat.pool.zt.hu\n\t[185.221.143.129])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C473D316;\n\tMon, 30 Mar 2026 10:58:46 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"R5+vbIwJ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1774861126;\n\tbh=ymKIQ1baGMOUlMOU/B29xQCrY4qtrcwJS83pztQa3gk=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=R5+vbIwJ72N5y9seBSzmYCxvy+H3sYxJIHBzRyoExBStPB38gCxhiHR5w9GRZFHVz\n\trLiWZ7kAzqmBp0kVA9b+NENfM6qgWCCc/W9FB/YQN3iC6tElkJ0PdMNfssy6vAMvXo\n\tl86hG6SDNeqbgVSgTb342M7o8TI48pCohOypUpQY=","Message-ID":"","Date":"Mon, 30 Mar 2026 11:00:03 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] libcamera: Make converter/softISP configure()'s\n\toutputCfgs argument really const","To":"Hans de Goede ,\n\tlibcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal ","References":"<20260325105618.8601-1-johannes.goede@oss.qualcomm.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20260325105618.8601-1-johannes.goede@oss.qualcomm.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":38486,"web_url":"https://patchwork.libcamera.org/comment/38486/","msgid":"<177505196818.2795797.8482595872458166479@ping.linuxembedded.co.uk>","date":"2026-04-01T13:59:28","subject":"Re: [PATCH] libcamera: Make converter/softISP configure()'s\n\toutputCfgs argument really const","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2026-03-30 10:00:03)\n> Hi\n> \n> 2026. 03. 25. 11:56 keltezéssel, Hans de Goede írta:\n> > The intent of the outputCfgs argument to the configure() function of\n> > converter classes and the softISP is to allow the passed in stream-configs\n> > to not be changed.\n> > \n> > But only the vector is const, the reference inside the vector are not\n> > const, which allows modifying the stream-configs as can be seen inside\n> > DebayerEGL::configure() which was using a non const reference outputCfg\n> > helper variable.\n> > \n> > Fix this by making the references inside the vector const.\n> > \n> > Signed-off-by: Hans de Goede \n> > ---\n> > include/libcamera/internal/converter.h | 2 +-\n> > include/libcamera/internal/converter/converter_dw100.h | 2 +-\n> > include/libcamera/internal/converter/converter_v4l2_m2m.h | 2 +-\n> > include/libcamera/internal/software_isp/software_isp.h | 2 +-\n> > src/libcamera/converter/converter_dw100.cpp | 2 +-\n> > src/libcamera/converter/converter_v4l2_m2m.cpp | 2 +-\n> > src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 +-\n> > src/libcamera/pipeline/simple/simple.cpp | 2 +-\n> > src/libcamera/software_isp/debayer.h | 2 +-\n> > src/libcamera/software_isp/debayer_cpu.cpp | 2 +-\n> > src/libcamera/software_isp/debayer_cpu.h | 2 +-\n> > src/libcamera/software_isp/debayer_egl.cpp | 4 ++--\n> > src/libcamera/software_isp/debayer_egl.h | 2 +-\n> > src/libcamera/software_isp/software_isp.cpp | 2 +-\n> > 14 files changed, 15 insertions(+), 15 deletions(-)\n> > \n> > diff --git a/include/libcamera/internal/converter.h b/include/libcamera/internal/converter.h\n> > index 4b811686f..08e80a22f 100644\n> > --- a/include/libcamera/internal/converter.h\n> > +++ b/include/libcamera/internal/converter.h\n> > @@ -71,7 +71,7 @@ public:\n> > Alignment align = Alignment::Down) = 0;\n> > \n> > virtual int configure(const StreamConfiguration &inputCfg,\n> > - const std::vector> &outputCfgs) = 0;\n> > + const std::vector> &outputCfgs) = 0;\n> \n> Could be made `Span>`.\n> But looks ok to me in any case.\n> \n> Reviewed-by: Barnabás Pőcze \n\nI'm fine with this too, span could be something for later, or after we\nhave std::span!\n\n\nReviewed-by: Kieran Bingham \n\n> \n> \n> \n> > virtual bool isConfigured(const Stream *stream) const = 0;\n> > virtual int exportBuffers(const Stream *stream, unsigned int count,\n> > std::vector> *buffers) = 0;\n> > diff --git a/include/libcamera/internal/converter/converter_dw100.h b/include/libcamera/internal/converter/converter_dw100.h\n> > index d70c8fe76..0a41b180a 100644\n> > --- a/include/libcamera/internal/converter/converter_dw100.h\n> > +++ b/include/libcamera/internal/converter/converter_dw100.h\n> > @@ -34,7 +34,7 @@ public:\n> > int init(const YamlObject ¶ms);\n> > \n> > int configure(const StreamConfiguration &inputCfg,\n> > - const std::vector>\n> > + const std::vector>\n> > &outputCfg);\n> > bool isConfigured(const Stream *stream) const;\n> > \n> > diff --git a/include/libcamera/internal/converter/converter_v4l2_m2m.h b/include/libcamera/internal/converter/converter_v4l2_m2m.h\n> > index 6d2453bb9..63cea6b08 100644\n> > --- a/include/libcamera/internal/converter/converter_v4l2_m2m.h\n> > +++ b/include/libcamera/internal/converter/converter_v4l2_m2m.h\n> > @@ -54,7 +54,7 @@ public:\n> > const Size &size, Alignment align = Alignment::Down) override;\n> > \n> > int configure(const StreamConfiguration &inputCfg,\n> > - const std::vector>\n> > + const std::vector>\n> > &outputCfg) override;\n> > bool isConfigured(const Stream *stream) const override;\n> > int exportBuffers(const Stream *stream, unsigned int count,\n> > diff --git a/include/libcamera/internal/software_isp/software_isp.h b/include/libcamera/internal/software_isp/software_isp.h\n> > index ad89c9b3c..585e0d6d9 100644\n> > --- a/include/libcamera/internal/software_isp/software_isp.h\n> > +++ b/include/libcamera/internal/software_isp/software_isp.h\n> > @@ -64,7 +64,7 @@ public:\n> > strideAndFrameSize(const PixelFormat &outputFormat, const Size &size);\n> > \n> > int configure(const StreamConfiguration &inputCfg,\n> > - const std::vector> &outputCfgs,\n> > + const std::vector> &outputCfgs,\n> > const ipa::soft::IPAConfigInfo &configInfo);\n> > \n> > int exportBuffers(const Stream *stream, unsigned int count,\n> > diff --git a/src/libcamera/converter/converter_dw100.cpp b/src/libcamera/converter/converter_dw100.cpp\n> > index df5155cfd..7899fe8c2 100644\n> > --- a/src/libcamera/converter/converter_dw100.cpp\n> > +++ b/src/libcamera/converter/converter_dw100.cpp\n> > @@ -142,7 +142,7 @@ int ConverterDW100Module::init(const YamlObject ¶ms)\n> > * \\copydoc libcamera::V4L2M2MConverter::configure\n> > */\n> > int ConverterDW100Module::configure(const StreamConfiguration &inputCfg,\n> > - const std::vector>\n> > + const std::vector>\n> > &outputCfgs)\n> > {\n> > int ret;\n> > diff --git a/src/libcamera/converter/converter_v4l2_m2m.cpp b/src/libcamera/converter/converter_v4l2_m2m.cpp\n> > index 4427a37c6..ffba0434e 100644\n> > --- a/src/libcamera/converter/converter_v4l2_m2m.cpp\n> > +++ b/src/libcamera/converter/converter_v4l2_m2m.cpp\n> > @@ -548,7 +548,7 @@ Size V4L2M2MConverter::adjustSizes(const Size &cfgSize,\n> > * \\copydoc libcamera::Converter::configure\n> > */\n> > int V4L2M2MConverter::configure(const StreamConfiguration &inputCfg,\n> > - const std::vector> &outputCfgs)\n> > + const std::vector> &outputCfgs)\n> > {\n> > int ret = 0;\n> > \n> > diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> > index 320a4dc5a..faeeecd96 100644\n> > --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> > +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> > @@ -1037,7 +1037,7 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)\n> > data->properties_.set(properties::ScalerCropMaximum, sensorCrop);\n> > \n> > std::map streamConfig;\n> > - std::vector> outputCfgs;\n> > + std::vector> outputCfgs;\n> > \n> > for (const StreamConfiguration &cfg : *config) {\n> > if (cfg.stream() == &data->mainPathStream_) {\n> > diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> > index 4a0b9f58d..9497ac13b 100644\n> > --- a/src/libcamera/pipeline/simple/simple.cpp\n> > +++ b/src/libcamera/pipeline/simple/simple.cpp\n> > @@ -1562,7 +1562,7 @@ int SimplePipelineHandler::configure(Camera *camera, CameraConfiguration *c)\n> > }\n> > \n> > /* Configure the converter if needed. */\n> > - std::vector> outputCfgs;\n> > + std::vector> outputCfgs;\n> > data->useConversion_ = config->needConversion();\n> > \n> > data->rawStream_ = nullptr;\n> > diff --git a/src/libcamera/software_isp/debayer.h b/src/libcamera/software_isp/debayer.h\n> > index ce9350b7b..ea1ec6dcf 100644\n> > --- a/src/libcamera/software_isp/debayer.h\n> > +++ b/src/libcamera/software_isp/debayer.h\n> > @@ -39,7 +39,7 @@ public:\n> > virtual ~Debayer() = 0;\n> > \n> > virtual int configure(const StreamConfiguration &inputCfg,\n> > - const std::vector> &outputCfgs,\n> > + const std::vector> &outputCfgs,\n> > bool ccmEnabled) = 0;\n> > \n> > virtual std::vector formats(PixelFormat inputFormat) = 0;\n> > diff --git a/src/libcamera/software_isp/debayer_cpu.cpp b/src/libcamera/software_isp/debayer_cpu.cpp\n> > index 1de70b3b7..dd0fff871 100644\n> > --- a/src/libcamera/software_isp/debayer_cpu.cpp\n> > +++ b/src/libcamera/software_isp/debayer_cpu.cpp\n> > @@ -540,7 +540,7 @@ int DebayerCpu::setDebayerFunctions(PixelFormat inputFormat,\n> > }\n> > \n> > int DebayerCpu::configure(const StreamConfiguration &inputCfg,\n> > - const std::vector> &outputCfgs,\n> > + const std::vector> &outputCfgs,\n> > bool ccmEnabled)\n> > {\n> > if (getInputConfig(inputCfg.pixelFormat, inputConfig_) != 0)\n> > diff --git a/src/libcamera/software_isp/debayer_cpu.h b/src/libcamera/software_isp/debayer_cpu.h\n> > index a96998e92..c6f263e1b 100644\n> > --- a/src/libcamera/software_isp/debayer_cpu.h\n> > +++ b/src/libcamera/software_isp/debayer_cpu.h\n> > @@ -35,7 +35,7 @@ public:\n> > ~DebayerCpu();\n> > \n> > int configure(const StreamConfiguration &inputCfg,\n> > - const std::vector> &outputCfgs,\n> > + const std::vector> &outputCfgs,\n> > bool ccmEnabled);\n> > Size patternSize(PixelFormat inputFormat);\n> > std::vector formats(PixelFormat input);\n> > diff --git a/src/libcamera/software_isp/debayer_egl.cpp b/src/libcamera/software_isp/debayer_egl.cpp\n> > index 9a0606b5a..547b3c3bd 100644\n> > --- a/src/libcamera/software_isp/debayer_egl.cpp\n> > +++ b/src/libcamera/software_isp/debayer_egl.cpp\n> > @@ -277,7 +277,7 @@ int DebayerEGL::initBayerShaders(PixelFormat inputFormat, PixelFormat outputForm\n> > }\n> > \n> > int DebayerEGL::configure(const StreamConfiguration &inputCfg,\n> > - const std::vector> &outputCfgs,\n> > + const std::vector> &outputCfgs,\n> > [[maybe_unused]] bool ccmEnabled)\n> > {\n> > if (getInputConfig(inputCfg.pixelFormat, inputConfig_) != 0)\n> > @@ -307,7 +307,7 @@ int DebayerEGL::configure(const StreamConfiguration &inputCfg,\n> > return -EINVAL;\n> > }\n> > \n> > - StreamConfiguration &outputCfg = outputCfgs[0];\n> > + const StreamConfiguration &outputCfg = outputCfgs[0];\n> > SizeRange outSizeRange = sizes(inputCfg.pixelFormat, inputCfg.size);\n> > std::tie(outputConfig_.stride, outputConfig_.frameSize) =\n> > strideAndFrameSize(outputCfg.pixelFormat, outputCfg.size);\n> > diff --git a/src/libcamera/software_isp/debayer_egl.h b/src/libcamera/software_isp/debayer_egl.h\n> > index 3abff1ad2..6bbe487a3 100644\n> > --- a/src/libcamera/software_isp/debayer_egl.h\n> > +++ b/src/libcamera/software_isp/debayer_egl.h\n> > @@ -42,7 +42,7 @@ public:\n> > ~DebayerEGL();\n> > \n> > int configure(const StreamConfiguration &inputCfg,\n> > - const std::vector> &outputCfgs,\n> > + const std::vector> &outputCfgs,\n> > bool ccmEnabled);\n> > \n> > Size patternSize(PixelFormat inputFormat);\n> > diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\n> > index 4cf5639d9..60228369f 100644\n> > --- a/src/libcamera/software_isp/software_isp.cpp\n> > +++ b/src/libcamera/software_isp/software_isp.cpp\n> > @@ -262,7 +262,7 @@ SoftwareIsp::strideAndFrameSize(const PixelFormat &outputFormat, const Size &siz\n> > * \\return 0 on success, a negative errno on failure\n> > */\n> > int SoftwareIsp::configure(const StreamConfiguration &inputCfg,\n> > - const std::vector> &outputCfgs,\n> > + const std::vector> &outputCfgs,\n> > const ipa::soft::IPAConfigInfo &configInfo)\n> > {\n> > ASSERT(ipa_ && debayer_);\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8603CBEFBE\n\tfor ;\n\tWed, 1 Apr 2026 13:59:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8DC4D62D57;\n\tWed, 1 Apr 2026 15:59:32 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 54DF662CCA\n\tfor ;\n\tWed, 1 Apr 2026 15:59:31 +0200 (CEST)","from monstersaurus.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 037CFCE7;\n\tWed, 1 Apr 2026 15:58:07 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"sOWH+vrO\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1775051888;\n\tbh=3Fj5uagbHjsaN39Kq4x8PIKgNBrkTqoRpbBqtxlGSZ0=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=sOWH+vrOevfQ61t6zO6M1JPVRRTEF8z+33prxXYvpivJijtlmP/L7nErO3pSSpDCV\n\tMdwFD/fBLIwHHXI8qtjHAfSUPiSc6jJc8JrQZtoxDqAtuEMdWCPZOOnFBihHwiHMK5\n\tjGx5Nx5S5DeaYQ18A6a2El3vOb6HkVmpU7oVPsX8=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","References":"<20260325105618.8601-1-johannes.goede@oss.qualcomm.com>\n\t","Subject":"Re: [PATCH] libcamera: Make converter/softISP configure()'s\n\toutputCfgs argument really const","From":"Kieran Bingham ","Cc":"Milan Zamazal ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tHans de Goede , \n\tlibcamera-devel@lists.libcamera.org","Date":"Wed, 01 Apr 2026 14:59:28 +0100","Message-ID":"<177505196818.2795797.8482595872458166479@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]