[{"id":38416,"web_url":"https://patchwork.libcamera.org/comment/38416/","msgid":"<CAEmqJPpkfvyANYcSfrz70Y=XoQzVL8OpAoxoTjWy8mLURyZUWQ@mail.gmail.com>","date":"2026-03-26T09:16:42","subject":"Re: [PATCH v1 2/3] controls: rpi: Add ControlId control","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi David,\n\nThank you for the patch.\n\nOn Tue, 24 Mar 2026 at 15:17, David Plowman\n<david.plowman@raspberrypi.com> wrote:\n>\n> The ControlId identifies the sequence number of the request whose\n> controls have been applied to the images in this request for the first\n> time.\n>\n> Signed-off-by: David Plowman <david.plowman@raspberrypi.com>\n> ---\n>  src/libcamera/control_ids_rpi.yaml | 10 ++++++++++\n>  1 file changed, 10 insertions(+)\n>\n> diff --git a/src/libcamera/control_ids_rpi.yaml b/src/libcamera/control_ids_rpi.yaml\n> index a8615112..aca023d7 100644\n> --- a/src/libcamera/control_ids_rpi.yaml\n> +++ b/src/libcamera/control_ids_rpi.yaml\n> @@ -183,4 +183,14 @@ controls:\n>          \\sa SyncMode\n>          \\sa SyncReady\n>          \\sa SyncTimer\n> +\n> +  - ControlId:\n> +      type: int64_t\n> +      direction: out\n> +      description: |\n> +        This is the sequence number of the request whose control list has\n> +        just been applied. Controls normally take several frames to apply,\n> +        so the number here will refer to a request submitted a number of\n> +        frames earlier.\n\nThis name, while it makes sense, is a bit unfortunate as we have class\nControlId in the public libcamera API.  Maybe a bit confusing for\nusers? Maybe ControlReference or ControlRef?\n\nRegards,\nNaush\n\n> +\n>  ...\n> --\n> 2.47.3\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 60EF6BDCBD\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 26 Mar 2026 09:17:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 95C496284A;\n\tThu, 26 Mar 2026 10:17:22 +0100 (CET)","from mail-vk1-xa2a.google.com (mail-vk1-xa2a.google.com\n\t[IPv6:2607:f8b0:4864:20::a2a])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7B95F62655\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 26 Mar 2026 10:17:21 +0100 (CET)","by mail-vk1-xa2a.google.com with SMTP id\n\t71dfb90a1353d-56ba601577aso49790e0c.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 26 Mar 2026 02:17:21 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"qC8G9gT1\"; dkim-atps=neutral","ARC-Seal":"i=1; a=rsa-sha256; t=1774516640; cv=none;\n\td=google.com; s=arc-20240605;\n\tb=YFSS2OyBq6SHkdPA6riNJ+I/xIiZwl52VsJpCZwddKg0I0CZ5YtztpItHHRlR+4cp0\n\tiP0j8mLjClHadI7hTcX6Ro5eQv6vnzElP2d9ACpDAfXMYoscM9aeuvGQdBz78VU+LjM3\n\t+AwzPJkBt74iJ7xDZKnKj8gAdx8QZBnHRT/hvZaHDGAgBh5lMG4EuiIaAHSTVWnnpHVi\n\ta3bhmYlt511PLytOIB/1q+52NETnpKPpjckDvHU8p4ZsWC3ArrqBYacnVNEa+OGkBA3a\n\t3uKGgIBpzLWJ+RoaOgnJbz2QqwTZIYYIcB44Q9hlxRmhwpRLtj8mqk6Wvel3Ujc5o8zr\n\tGF1w==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=arc-20240605; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:dkim-signature;\n\tbh=OtSWDgIb/C7eizmGGqVJhMyGzvTJ5xHT8ZDHhL9sRF8=;\n\tfh=raf7gMhxwhTsDETG3li6wpOfdJf6YyDg/c7aYJ8coN8=;\n\tb=ivYFd6pRLedfkuU5es6hPOH/1WbbHUdkX7eGJLJwJ7wQpn2LWjpcax5locyx+yj8bw\n\tCox2PQynFyORSDvnKN2OsPwJAQCxg/nDBWB4UNwmatBWH81bB0EKaxdtSau/mVpFwsE6\n\tZDz7rglswwMeACJNXCkqu/R06xDUNAm4NEYrqqVcgx21nAg2XB2O/whQfO8w2YsNCikc\n\t75s7OpsOUuAac+2wgXc4Az85PV5AuXmjNnTxfRV5v6j8h0RbYTZnqCzAJOGlfzUv0tKE\n\tqtCzDLsn+guUTN4N97m5UDEgBHv7nOSKUwqtyuR5+h5bC1bKD1iTe0XugVE3P4mdI8oy\n\t3zhw==; darn=lists.libcamera.org","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1774516640; x=1775121440;\n\tdarn=lists.libcamera.org; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=OtSWDgIb/C7eizmGGqVJhMyGzvTJ5xHT8ZDHhL9sRF8=;\n\tb=qC8G9gT1PmZvbRQioQEl8mny7vrtSaPMYyFLJfUJTi/mdijr9h2UWU/y430PJujNqI\n\tnHB73vmRKNIvHapbdVbxqcgjn4QyDJs3LO1YmabWAP3FplF41v/eGCewnE5fckZesKeX\n\t4WBEhogx15+n+oYPGVjpWlfEIpaC+DcA65ZE8A8gRokUOmGaPp+jOmvyAAtw622NYweD\n\tOZI6Fye3+AUPLTbxlvukn5k0o/AfWe9SdylcP5I2KqZq4XkZCkqAvKPxDLRYw9eyRLW9\n\t9pl2715KX5KBjhWpQ4JjYsW7EOYb3q6jQaz2/y8fSFt9pMV1ebKSRIJ8OfddDyL6BRtR\n\tb8Ug==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20251104; t=1774516640; x=1775121440;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=OtSWDgIb/C7eizmGGqVJhMyGzvTJ5xHT8ZDHhL9sRF8=;\n\tb=DpdQ8i0WF9eRfOKAF7Q0B8xqTfEXzdfT3Fmu0FGg7xZTMAXAp1U3V9we/oxJFaE/6O\n\tCYw0i1Y+18rff/tCANZnO/jIQgp20YkHODLmg8Jpksp2BC6uwkdgPWWL6Zql0WvhidUX\n\tLysILDlPDcEk5RoYTQQS9K54MTD+ji0OFJbq8bXPzHIAnWE0GQ4a7wquNGm18bRJC66I\n\t3zEkhFRSHtGZnHi+zHq54Yhp1TF5PE+haeCDPDeSOCfyXa68iqPDdCSH/u+VziWwDvKy\n\tEQZlZrN6JvMdBMM78Eg8NQj49C1xJUHmtBXlBY6nKrlgbfYc0u+ylSpCMZ/RsOcbt3wR\n\tln6Q==","X-Gm-Message-State":"AOJu0YwXoWmZFOYTi8ctQkzPR4KF1JusaUtU6k1ncNCnnKEqh98LkE96\n\t1WloGibTKluyR35Qbmpe8lWGHai/1FeDSDQ7AZiJz9ilrPViDHvQuqUeS0NLddtATb+LPKV3veQ\n\tmzyOQVat4moDMVgH7iTC360D+oEO9/JVyuUT4JHKbuQc65KbJQvYhXfs=","X-Gm-Gg":"ATEYQzy7GIiOLHShLxXGg9Ts9lcpsVOxFPNU0yM4InsqT61m0Y1UGsw32tp/31uezBe\n\tyOXX/AUEBQHhFZPdBUCR0kjRu2cJ/lQpmLoLvQcLrxV3mQLR+wmd34b9pEPhl0egQ1CcitnLw19\n\tDWM3v5JcE269PD3mxuIaFis+tgaQRAqPhZiKkseh85X2yZxi4wqWiwuhHIBTWJu+22Y6XIYc5t6\n\tTL+VlJFgeQAtaXPqfkz0Ft58vie8PkAHISYSrSq9dTleBNo5jRYgxghrQ3mOcuA76Pl8kz27sO8\n\tg62A4EidTaR0G4GDNFwicmMGlDSHmaX1hD+925e20cQGP5XPWMu8ZJrSlhdHjOI9xDNOoi8dkHs\n\tNqdBP2sZleqmX/Hj+HkdwPg==","X-Received":"by 2002:a05:6102:3049:b0:602:789e:9dee with SMTP id\n\tada2fe7eead31-60378fe9607mr1728794137.0.1774516640179;\n\tThu, 26 Mar 2026 02:17:20 -0700 (PDT)","MIME-Version":"1.0","References":"<20260324151714.3345-1-david.plowman@raspberrypi.com>\n\t<20260324151714.3345-3-david.plowman@raspberrypi.com>","In-Reply-To":"<20260324151714.3345-3-david.plowman@raspberrypi.com>","From":"Naushir Patuck <naush@raspberrypi.com>","Date":"Thu, 26 Mar 2026 09:16:42 +0000","X-Gm-Features":"AQROBzB4tAshG1tAF1Fmo96zkDOWLUlZYmedRH7CK_h90zqv4NqK23oXIyW3UTA","Message-ID":"<CAEmqJPpkfvyANYcSfrz70Y=XoQzVL8OpAoxoTjWy8mLURyZUWQ@mail.gmail.com>","Subject":"Re: [PATCH v1 2/3] controls: rpi: Add ControlId control","To":"David Plowman <david.plowman@raspberrypi.com>","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":38439,"web_url":"https://patchwork.libcamera.org/comment/38439/","msgid":"<CAHW6GYKvGSVAnYxKcSna3yS2C=CZWMz4tsszUN2S5CBYfMp=Xw@mail.gmail.com>","date":"2026-03-27T11:43:23","subject":"Re: [PATCH v1 2/3] controls: rpi: Add ControlId control","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi Naush\n\nThanks for the review.\n\nOn Thu, 26 Mar 2026 at 09:17, Naushir Patuck <naush@raspberrypi.com> wrote:\n>\n> Hi David,\n>\n> Thank you for the patch.\n>\n> On Tue, 24 Mar 2026 at 15:17, David Plowman\n> <david.plowman@raspberrypi.com> wrote:\n> >\n> > The ControlId identifies the sequence number of the request whose\n> > controls have been applied to the images in this request for the first\n> > time.\n> >\n> > Signed-off-by: David Plowman <david.plowman@raspberrypi.com>\n> > ---\n> >  src/libcamera/control_ids_rpi.yaml | 10 ++++++++++\n> >  1 file changed, 10 insertions(+)\n> >\n> > diff --git a/src/libcamera/control_ids_rpi.yaml b/src/libcamera/control_ids_rpi.yaml\n> > index a8615112..aca023d7 100644\n> > --- a/src/libcamera/control_ids_rpi.yaml\n> > +++ b/src/libcamera/control_ids_rpi.yaml\n> > @@ -183,4 +183,14 @@ controls:\n> >          \\sa SyncMode\n> >          \\sa SyncReady\n> >          \\sa SyncTimer\n> > +\n> > +  - ControlId:\n> > +      type: int64_t\n> > +      direction: out\n> > +      description: |\n> > +        This is the sequence number of the request whose control list has\n> > +        just been applied. Controls normally take several frames to apply,\n> > +        so the number here will refer to a request submitted a number of\n> > +        frames earlier.\n>\n> This name, while it makes sense, is a bit unfortunate as we have class\n> ControlId in the public libcamera API.  Maybe a bit confusing for\n> users? Maybe ControlReference or ControlRef?\n>\n> Regards,\n> Naush\n\nHappy to rename, of course the billion dollar question is... to what?\nSome more ideas:\n\nControlListRef\nControlListId\nControlListSequence\n\nIn the absence of strong screams to the contrary, I shall make a\npseudo-random choice...\n\nActually, I think I like ControlListSequence best? It is, after all,\nthe sequence number (of the request) where the control list came\nfrom...\n\nThanks\nDavid\n\n>\n> > +\n> >  ...\n> > --\n> > 2.47.3\n> >","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DA78BBE086\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 27 Mar 2026 11:43:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3BE7D62CC9;\n\tFri, 27 Mar 2026 12:43:37 +0100 (CET)","from mail-ed1-x530.google.com (mail-ed1-x530.google.com\n\t[IPv6:2a00:1450:4864:20::530])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D28BF62CB8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 27 Mar 2026 12:43:35 +0100 (CET)","by mail-ed1-x530.google.com with SMTP id\n\t4fb4d7f45d1cf-666f646f5cfso4612247a12.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 27 Mar 2026 04:43:35 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"DvCu1Zcw\"; dkim-atps=neutral","ARC-Seal":"i=1; a=rsa-sha256; t=1774611815; cv=none;\n\td=google.com; s=arc-20240605;\n\tb=Avr5t0lW1dP1i57PRSjjl4gHThsICJz/yyc+i92TYyZ+Ag06a/vI/StTDrtHCSfVfA\n\tzwttr/HcpW3tT1ccHGFaFkkJnRk7sbd9oy+p+fBKmk3DsT5vxhk8vgHZHRtN6Gr9e88h\n\toYntGG3bL4ReRzBDfBei7j4MLTY6TufclGMzSvMDyfOkg7BBR2l7AmczgDOMExHCY1w5\n\tLtZ21zz1L46fIabPRVas4UPhhbg85R0aswp/0a7FP7K9hNHmH4ceQYpk53sboJVRQVpW\n\tj68lDxVRhJzc2Zx4nzjw9UHuH2K1rEwSOrI99efX+LmN3KVmyzSr+zS7Ymtc72RnBhC5\n\tj56w==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=arc-20240605; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:dkim-signature;\n\tbh=yf0rkOueiiSKt4Im+GSRB+yAobbXv6qMZtecam+Fazk=;\n\tfh=pViFh4rhBx6810yKb0wI4WZcwBOqDHh72fUf/cLkiP4=;\n\tb=HRgXTUltQcd/pSa4R/j/gSf97w4PgN96oM0kU+d3LG9Fx5D0+TUemvIHFNF0iq00II\n\tfwY/opjp/DVT8JStZAE7NstuRRM/76JgaanL3pvfvboHHVZzmpU2scNdHt5FDOzVlpN5\n\tM6GSC+HMv6DKh4JHGEv1EFXI5xxT3xUpW0ZQULDV15Nru0m6L20Q7TcHXsY97fOD9PgG\n\tybHg9s/F8LdCWdQ5E98pCn8Z04hU6k2cdgySX4NdxjMmn/oIWsEsHoWRZz/GRtVBbRNJ\n\tqOwO0Q0mPSrW5LGAVTToFyi3oWt56TSuFGyddtvT5VqdJl9Vu5vHjmJsTgnf092eO2sr\n\tXrDA==; darn=lists.libcamera.org","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1774611815; x=1775216615;\n\tdarn=lists.libcamera.org; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=yf0rkOueiiSKt4Im+GSRB+yAobbXv6qMZtecam+Fazk=;\n\tb=DvCu1ZcwFR5jx1DJpv4ddMPOBfaU9pLpAUqIqjXeS80yxKr7G9cMYXvNXQRCfbQ844\n\t7YKeeJ8pjgJBZR3W4yRnDG8C5AUy+7jcYoSc7D/choLgydUN4HIbPcG4yT8C7ASGJDmL\n\tQt5YcQqwgemUseWTQ5JyWShlIn5qZtWYmBNy3DCOaqWs2kofowHPthfgDzZn1IIR4Vu6\n\tyft2QOEoP/nLnhDhp8Xa07zOz4Eq/3brvnxooqkfpIpUWTwbPv9FmAf1VnGMt52viZ/e\n\tsHbIVa0LATpdVkacTKyHPvRfOYayTm2RJ02DXjtKDunvzn1urcOVW6QfBuI8d/IiUS3T\n\tnsUw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20251104; t=1774611815; x=1775216615;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=yf0rkOueiiSKt4Im+GSRB+yAobbXv6qMZtecam+Fazk=;\n\tb=WiFJQlNAvHcBbRbnpUC4++ZhMmHxKu7W2SdTiaaaX1a3HCjRlBOI1R0yG0lvV6fmQ3\n\tSZCn+FFfdPNwdqIqETf5lSz2tvrA+7d1XxzepFpswZuActcVGbrunl10ynocrqkq3GFe\n\tYYKe8UnkBe9GYwyQOUu7mXumWUhV/w3nRb+4jOJ8IkVQun2U5Bc6VfDN/tnSObhO9UZp\n\tjXMHcSaetE02AFPf4EugbQGnXU5Z1xf+QL2f/2Fovncq+Fp0KgfnEJ97iY3ZfAuN22tn\n\tucDThbz9tYXtb0Ukp0GVrpZjOoXddb+yzlVwZkimd8fLRHTG7ukt03K9cywKjvw0VdBP\n\tbyCA==","X-Gm-Message-State":"AOJu0YzkMN+11Gg8jhNIIED461DLxqy5YKvp6NUV6qNeFsO8z8Gq6Ln3\n\t5VIBQ+spi4zehzr6rMCpJQjbHoLaRNP7RELTcYUu854uIiL7PWja7kS+ffJijcqfdQ8UbGQsscT\n\tuCqgkxXv7mmtzLWIAEc/yw45PAXC3jBcYXYGItR0VdQ==","X-Gm-Gg":"ATEYQzypC/a54N2kdbTCi1qxJgVAWhyWTOnSUuAXVmuGayjqJ2rFHqouM/pnx+9K7Zi\n\tPi9zWB1FkrUOA7v+AMYpSjkfIRMV5Ys3jL1ZmhM5gkLPYBVAkiOGZgm4dxQDfQZanDlgZVJTKy2\n\tNuQkl6L7O+rZBka2kpN9S6OS6qVuQO1d041yXQsf8SqBkL+gNGOcF2X5tXJTm5jEAP4swFtfa8i\n\tW1q3qXYB/Fq2Ix4fvk1e+SSU9t04YsqG+oVKFf4EGwzQWM3Sr1DT6c/bEhxFLtqaaXwNfq8p9C2\n\ttNGiRac5k5K1nePylyllO8f2F7sQRKP+aiXng63vD2SPhcBKe7EwOEfLwXu9btxp9rc1BJWEfUy\n\tRc/Ku03ztNyhnO2sv/b9S4uI=","X-Received":"by 2002:a17:907:3dac:b0:b98:14e:32c0 with SMTP id\n\ta640c23a62f3a-b9b2e5e6da4mr325218866b.14.1774611815154;\n\tFri, 27 Mar 2026 04:43:35 -0700 (PDT)","MIME-Version":"1.0","References":"<20260324151714.3345-1-david.plowman@raspberrypi.com>\n\t<20260324151714.3345-3-david.plowman@raspberrypi.com>\n\t<CAEmqJPpkfvyANYcSfrz70Y=XoQzVL8OpAoxoTjWy8mLURyZUWQ@mail.gmail.com>","In-Reply-To":"<CAEmqJPpkfvyANYcSfrz70Y=XoQzVL8OpAoxoTjWy8mLURyZUWQ@mail.gmail.com>","From":"David Plowman <david.plowman@raspberrypi.com>","Date":"Fri, 27 Mar 2026 11:43:23 +0000","X-Gm-Features":"AQROBzAfVOB7vY42tGkLwv4hZH8z90B7tcb4AYWquwS4gjHY3TTFRl7MbmAlbYI","Message-ID":"<CAHW6GYKvGSVAnYxKcSna3yS2C=CZWMz4tsszUN2S5CBYfMp=Xw@mail.gmail.com>","Subject":"Re: [PATCH v1 2/3] controls: rpi: Add ControlId control","To":"Naushir Patuck <naush@raspberrypi.com>","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":38440,"web_url":"https://patchwork.libcamera.org/comment/38440/","msgid":"<CAEmqJPotukR6jr56hkXRwOduaKB-g58-qj35rubmYzG26nub2w@mail.gmail.com>","date":"2026-03-27T11:45:34","subject":"Re: [PATCH v1 2/3] controls: rpi: Add ControlId control","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"On Fri, 27 Mar 2026 at 11:43, David Plowman\n<david.plowman@raspberrypi.com> wrote:\n>\n> Hi Naush\n>\n> Thanks for the review.\n>\n> On Thu, 26 Mar 2026 at 09:17, Naushir Patuck <naush@raspberrypi.com> wrote:\n> >\n> > Hi David,\n> >\n> > Thank you for the patch.\n> >\n> > On Tue, 24 Mar 2026 at 15:17, David Plowman\n> > <david.plowman@raspberrypi.com> wrote:\n> > >\n> > > The ControlId identifies the sequence number of the request whose\n> > > controls have been applied to the images in this request for the first\n> > > time.\n> > >\n> > > Signed-off-by: David Plowman <david.plowman@raspberrypi.com>\n> > > ---\n> > >  src/libcamera/control_ids_rpi.yaml | 10 ++++++++++\n> > >  1 file changed, 10 insertions(+)\n> > >\n> > > diff --git a/src/libcamera/control_ids_rpi.yaml b/src/libcamera/control_ids_rpi.yaml\n> > > index a8615112..aca023d7 100644\n> > > --- a/src/libcamera/control_ids_rpi.yaml\n> > > +++ b/src/libcamera/control_ids_rpi.yaml\n> > > @@ -183,4 +183,14 @@ controls:\n> > >          \\sa SyncMode\n> > >          \\sa SyncReady\n> > >          \\sa SyncTimer\n> > > +\n> > > +  - ControlId:\n> > > +      type: int64_t\n> > > +      direction: out\n> > > +      description: |\n> > > +        This is the sequence number of the request whose control list has\n> > > +        just been applied. Controls normally take several frames to apply,\n> > > +        so the number here will refer to a request submitted a number of\n> > > +        frames earlier.\n> >\n> > This name, while it makes sense, is a bit unfortunate as we have class\n> > ControlId in the public libcamera API.  Maybe a bit confusing for\n> > users? Maybe ControlReference or ControlRef?\n> >\n> > Regards,\n> > Naush\n>\n> Happy to rename, of course the billion dollar question is... to what?\n> Some more ideas:\n>\n> ControlListRef\n> ControlListId\n> ControlListSequence\n>\n> In the absence of strong screams to the contrary, I shall make a\n> pseudo-random choice...\n>\n> Actually, I think I like ControlListSequence best? It is, after all,\n> the sequence number (of the request) where the control list came\n> from...\n\nThat works for me!\n\nNaush\n\n>\n> Thanks\n> David\n>\n> >\n> > > +\n> > >  ...\n> > > --\n> > > 2.47.3\n> > >","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B912ABE086\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 27 Mar 2026 11:46:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id ECBA862CCC;\n\tFri, 27 Mar 2026 12:46:13 +0100 (CET)","from mail-vk1-xa30.google.com (mail-vk1-xa30.google.com\n\t[IPv6:2607:f8b0:4864:20::a30])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 75D2462CB8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 27 Mar 2026 12:46:11 +0100 (CET)","by mail-vk1-xa30.google.com with SMTP id\n\t71dfb90a1353d-56ba601577aso125737e0c.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 27 Mar 2026 04:46:11 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"O7LuU+Wv\"; dkim-atps=neutral","ARC-Seal":"i=1; a=rsa-sha256; t=1774611970; cv=none;\n\td=google.com; s=arc-20240605;\n\tb=LMbrJyjXNmUnL6AH3cI4sHXI/Xa66U0ixeSROPi5KLqRfPFG1uK/QoHl4JFsBsjGRf\n\tCyG5bzGQOFSNoDCZ/0v+FQvCu/8brMkykolCAHRgvcWyY2JO4dIU7CpyDFcvvoricDmd\n\t/is76YLoIIP1Mlk+p+SE60nsaC+M0WH1wUZQklkhN5RTz1SRzypcg339rkdukrYp02lY\n\t+b3aBCcYrm0219e3CLac7jQJnnQXCZvZz6UjO7HNEXBLaYaYQ9S3tC62Q/za1N42xJ+d\n\tmTC4XO3t3zKJAa3tTqFD8d6qWbvcmBqsMrIhALvwLLC8HV1IJsn3hz23HImgANpnv8/7\n\tB5PA==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=arc-20240605; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:dkim-signature;\n\tbh=P46RVEPgF48bCyXwCwmT8oAYvLSA6RFtT2qEFGRh5jY=;\n\tfh=raf7gMhxwhTsDETG3li6wpOfdJf6YyDg/c7aYJ8coN8=;\n\tb=G+3onREMckVmI4CpPReklxf8sQHBNgER4WkISOzD5uG189gvgocleE5OgsYgEtRFTO\n\tfRnUC+qJgWEAKIvvJhobVABqxUCUq3usHKX6dxbgSVLyk45F/AUUckDJinD5tFmJR/kj\n\tgbhPfe1ad/oyDl1GapVm7KCbig8BZXS3i8QSo83VtBRqaEhsxqaccM/qmIGVgZAUpLqD\n\tGWiT+jE5fKSCJmSN6z7OORwDvBeH5cbYcnCol+GZZ0rrtZAfY1pZZFPgRFhv26yBVwwf\n\tjn713k3x6Uy0mMdEgZox1N77q1noWOGKWwbWTmbWwKHnJcB205g8PISWrAZW97gE4fKu\n\tnajQ==; darn=lists.libcamera.org","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1774611970; x=1775216770;\n\tdarn=lists.libcamera.org; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=P46RVEPgF48bCyXwCwmT8oAYvLSA6RFtT2qEFGRh5jY=;\n\tb=O7LuU+WvDmh3O6PsdURKRe/DlE9CWpWADyVxAel8mwXMmLZsj3c4mHODyReuoBa/91\n\tweq0bEnb78yDYn5ZTCbrtfz9kGyQPmggxrPr3g8RA4JOZqEwJR0h9izihYCN5sfnXBZc\n\tVAmLqIIMIDjan1gSyd99dKj8HQlBXATOYvSIWM6nnejcsL6zFGAEH84LTolXakI887sB\n\tckyIrb2pJxq2lQksBuBzm7mon5YKXk8qadm8mzpL6/G8uOiimGs1VBgiyfx6Uv4ML9sl\n\tdzbfdKtVxJ+2fpcg3TjHPIphufrFrGSDF4ZyqNRarnxCJuKDk66BceMSTjFy9y9kEQkB\n\tzm9w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20251104; t=1774611970; x=1775216770;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=P46RVEPgF48bCyXwCwmT8oAYvLSA6RFtT2qEFGRh5jY=;\n\tb=JL9t53z2dv13uDbeUSSN3xbGZ+GPMkzrwz9ho/7iU0/8qVpRQrWPh4P0MenA1Wxl5h\n\t1G1SoNuPkpmOwtGYwl5CHi4ASGiLyFqZcpIIfc0cljpKIZEx1jT/uPvXI4EZdzw47jUP\n\twLZH++tidQ7NJWVzIt6TPcBjZ1/40OkKrvTEX6E96mSOc/DmHbXSvNaY8L7xdMoVi4TF\n\t8sDIRIHbe9SPRrN/JKo46q01Yl1Fkli3U447Y77Ntkews/kgX1s069E52WmaUwZkZvLD\n\tA/4k2etW9eP5J4ymiNMOCrnMRjrYS0uY0bcGCcUOv8QvZzcln8u2vitA4TTgNEdRfnhU\n\t9poA==","X-Gm-Message-State":"AOJu0Yz2yXz/wtPVrsp4OknWY6CCuFdmWIkaNtggXNCarRfkXnzNZTUa\n\tbs8vj34/rX3LF9GbP2ZRtoId7PgzQbYUlB6rsXmHAiXaUDDhXEZZHBzpRVN1GUnKA/7dz/kmW0N\n\tFzDeoLuXVtIjYE3kWoe9a3ItqCwXFiY/VJBM0NhBhvQ==","X-Gm-Gg":"ATEYQzzdiqVp2My7FwnVHKhdvV3GN6L8vdbVp7bRQ3xpquy2gY7Wkenmp9QJ38aZIJ0\n\tSqeAiYhRK8yLNKkwUO0mneglZDv43MGMM9bsINvxLirqeI+vvzDYhzzWG8zAWzlvP8MQX8pK7Dj\n\tAk98KvcZL4upFk1U6rzqOlIs0go6hIPLcUIj5d0+Pk/2XiKDDCUo54kvpoCSkbLR37qIuURlxGb\n\tDxH0egHFwSOPrYiH8gwfIJOVVK2TRU0wjsPYy8Jtkb+ZXuHGzROGyFrz+a+siDh6974ph0UJXX8\n\tgsOAYpaClHjwkWo2Amph5xg7LX9ko4LlO4YTePbQU23DorQpWEUtE75k8TjZVXo/kRthMNBV88F\n\tgqdJjdCUdmjqff0IEL0AgQ9w=","X-Received":"by 2002:a05:6102:2154:b0:602:789e:9dee with SMTP id\n\tada2fe7eead31-604f8d9b4a2mr303192137.0.1774611970112; Fri, 27 Mar 2026\n\t04:46:10 -0700 (PDT)","MIME-Version":"1.0","References":"<20260324151714.3345-1-david.plowman@raspberrypi.com>\n\t<20260324151714.3345-3-david.plowman@raspberrypi.com>\n\t<CAEmqJPpkfvyANYcSfrz70Y=XoQzVL8OpAoxoTjWy8mLURyZUWQ@mail.gmail.com>\n\t<CAHW6GYKvGSVAnYxKcSna3yS2C=CZWMz4tsszUN2S5CBYfMp=Xw@mail.gmail.com>","In-Reply-To":"<CAHW6GYKvGSVAnYxKcSna3yS2C=CZWMz4tsszUN2S5CBYfMp=Xw@mail.gmail.com>","From":"Naushir Patuck <naush@raspberrypi.com>","Date":"Fri, 27 Mar 2026 11:45:34 +0000","X-Gm-Features":"AQROBzBgKE4R65AQLHNBM4IZNuFM5z0ZPUjYYQbXXFmtmECMrxe2bty21BpjxNU","Message-ID":"<CAEmqJPotukR6jr56hkXRwOduaKB-g58-qj35rubmYzG26nub2w@mail.gmail.com>","Subject":"Re: [PATCH v1 2/3] controls: rpi: Add ControlId control","To":"David Plowman <david.plowman@raspberrypi.com>","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]