{"id":26314,"url":"https://patchwork.libcamera.org/api/patches/26314/?format=json","web_url":"https://patchwork.libcamera.org/patch/26314/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260323102724.1385487-2-barnabas.pocze@ideasonboard.com>","date":"2026-03-23T10:27:18","name":"[RFC,v2,1/7] gstreamer: Add `-Wno-volatile` for GCC","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"0e43282bf3b15c2296bfb1f2c5dc36c596c60960","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/26314/mbox/","series":[{"id":5837,"url":"https://patchwork.libcamera.org/api/series/5837/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5837","date":"2026-03-23T10:27:17","name":"C++20 migration","version":2,"mbox":"https://patchwork.libcamera.org/series/5837/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/26314/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/26314/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 76388C32DE\n\tfor ;\n\tMon, 23 Mar 2026 10:27:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1DF936275D;\n\tMon, 23 Mar 2026 11:27:30 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9562162745\n\tfor ;\n\tMon, 23 Mar 2026 11:27:27 +0100 (CET)","from pb-laptop.local (185.221.143.129.nat.pool.zt.hu\n\t[185.221.143.129])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1F46A189C;\n\tMon, 23 Mar 2026 11:26:11 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"o/PwRFGG\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1774261571;\n\tbh=1Zbs79fFLhxiKcFW+fadyrtBr7zoonqptL9IgKheJ4E=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=o/PwRFGGHZzs2AyH8eLVaqeBfwTbo82MXcS4HLnuI8bYoP9+A1EXEPEMTIyjsTHkQ\n\tp4ZZRBtfpisMPJ1G36NeVWUj4Wb5rqArSZT7pSHN2HC/nEGg9ft+zOt3k7qqtpt/I5\n\t4Luezvv012cT5ZGj3xAuIeFNbQpXwGVHYCk1Jr4U=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Cc":"Laurent Pinchart ,\n\tNaushir Patuck ","Subject":"[RFC PATCH v2 1/7] gstreamer: Add `-Wno-volatile` for GCC","Date":"Mon, 23 Mar 2026 11:27:18 +0100","Message-ID":"<20260323102724.1385487-2-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260323102724.1385487-1-barnabas.pocze@ideasonboard.com>","References":"<20260323102724.1385487-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Older versions of glib may use `volatile` qualified variables, triggering\nthe warning in C++20. So suppress it.\n\nLink: https://gitlab.gnome.org/GNOME/glib/-/merge_requests/1719\nSigned-off-by: Barnabás Pőcze \nReviewed-by: Laurent Pinchart \nReviewed-by: Naushir Patuck \n---\n src/gstreamer/meson.build | 7 +++++++\n 1 file changed, 7 insertions(+)","diff":"diff --git a/src/gstreamer/meson.build b/src/gstreamer/meson.build\nindex fd83e073d..602f978e8 100644\n--- a/src/gstreamer/meson.build\n+++ b/src/gstreamer/meson.build\n@@ -50,6 +50,13 @@ if cc.get_id() == 'clang' and glib_dep.version().version_compare('<2.63.0')\n libcamera_gst_cpp_args += ['-Wno-unused-function']\n endif\n \n+# In C++20 many operations involving the `volatile` qualifier became deprecated.\n+# glib however made use of `volatile` in certain macros that would trigger\n+# this warning. See https://gitlab.gnome.org/GNOME/glib/-/merge_requests/1719.\n+if cc.get_id() == 'gcc' and glib_dep.version().version_compare('<2.67.1')\n+ libcamera_gst_cpp_args += ['-Wno-volatile']\n+endif\n+\n libcamera_gst = shared_library('gstlibcamera',\n libcamera_gst_sources,\n cpp_args : libcamera_gst_cpp_args,\n","prefixes":["RFC","v2","1/7"]}