[{"id":38397,"web_url":"https://patchwork.libcamera.org/comment/38397/","msgid":"","date":"2026-03-24T15:51:34","subject":"Re: [PATCH v2 5/7] meson: Use dependency object when checking for\n\theaders","submitter":{"id":226,"url":"https://patchwork.libcamera.org/api/people/226/","name":"Bryan O'Donoghue","email":"bod.linux@nxsw.ie"},"content":"On 23/03/2026 08:19, Barnabás Pőcze wrote:\n> A dependency might very well have custom include directories,\n> so use it when checking for the header file.\n> \n> Signed-off-by: Barnabás Pőcze \n> Reviewed-by: Milan Zamazal \n> Reviewed-by: Laurent Pinchart \n> ---\n> src/libcamera/meson.build | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> index 06ed34101..72b7bf02d 100644\n> --- a/src/libcamera/meson.build\n> +++ b/src/libcamera/meson.build\n> @@ -70,9 +70,9 @@ libcamera_deps = []\n> libatomic = cc.find_library('atomic', required : false)\n> libthreads = dependency('threads')\n> \n> -mesa_works = cc.check_header('EGL/egl.h', required: false)\n> libegl = dependency('egl', required : false)\n> libglesv2 = dependency('glesv2', required : false)\n> +mesa_works = cc.check_header('EGL/egl.h', required : false, dependencies : libegl)\n> \n> subdir('base')\n> subdir('converter')\n> --\n> 2.53.0\n> \nReviewed-by: Bryan O'Donoghue ","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E04F4BD87C\n\tfor ;\n\tTue, 24 Mar 2026 15:51:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A2B8C62793;\n\tTue, 24 Mar 2026 16:51:40 +0100 (CET)","from tor.source.kernel.org (tor.source.kernel.org\n\t[IPv6:2600:3c04:e001:324:0:1991:8:25])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 56B7562787\n\tfor ;\n\tTue, 24 Mar 2026 16:51:39 +0100 (CET)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby tor.source.kernel.org (Postfix) with ESMTP id 3463C600C4;\n\tTue, 24 Mar 2026 15:51:38 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id E7E05C2BC87;\n\tTue, 24 Mar 2026 15:51:35 +0000 (UTC)"],"Message-ID":"","Date":"Tue, 24 Mar 2026 15:51:34 +0000","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 5/7] meson: Use dependency object when checking for\n\theaders","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal ,\n\tLaurent Pinchart ","References":"<20260323082000.1324115-1-barnabas.pocze@ideasonboard.com>\n\t\n\t<20260323082000.1324115-6-barnabas.pocze@ideasonboard.com>","From":"Bryan O'Donoghue ","Content-Language":"en-US","In-Reply-To":"<20260323082000.1324115-6-barnabas.pocze@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]