[{"id":38396,"web_url":"https://patchwork.libcamera.org/comment/38396/","msgid":"<80749f70-6398-43a3-a3d5-21228718018b@nxsw.ie>","date":"2026-03-24T15:50:46","subject":"Re: [PATCH v2 4/7] meson: Remove `gles_headless_enabled`","submitter":{"id":226,"url":"https://patchwork.libcamera.org/api/people/226/","name":"Bryan O'Donoghue","email":"bod.linux@nxsw.ie"},"content":"On 23/03/2026 08:19, Barnabás Pőcze wrote:\n> Use the `mesa_works` variable instead to simplify, the two variables\n> have the same value.\n> \n> Signed-off-by: Barnabás Pőcze \n> Reviewed-by: Milan Zamazal \n> Reviewed-by: Laurent Pinchart \n> ---\n> src/libcamera/meson.build | 6 ------\n> src/libcamera/software_isp/meson.build | 4 ++--\n> 2 files changed, 2 insertions(+), 8 deletions(-)\n> \n> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> index 28ce93de6..06ed34101 100644\n> --- a/src/libcamera/meson.build\n> +++ b/src/libcamera/meson.build\n> @@ -74,12 +74,6 @@ mesa_works = cc.check_header('EGL/egl.h', required: false)\n> libegl = dependency('egl', required : false)\n> libglesv2 = dependency('glesv2', required : false)\n> \n> -if mesa_works\n> - gles_headless_enabled = true\n> -else\n> - gles_headless_enabled = false\n> -endif\n> -\n> subdir('base')\n> subdir('converter')\n> subdir('ipa')\n> diff --git a/src/libcamera/software_isp/meson.build b/src/libcamera/software_isp/meson.build\n> index 4c61909fd..118d3f92f 100644\n> --- a/src/libcamera/software_isp/meson.build\n> +++ b/src/libcamera/software_isp/meson.build\n> @@ -2,7 +2,7 @@\n> \n> softisp_enabled = pipelines.contains('simple')\n> summary({'SoftISP support' : softisp_enabled}, section : 'Configuration')\n> -summary({'SoftISP GPU acceleration' : gles_headless_enabled}, section : 'Configuration')\n> +summary({'SoftISP GPU acceleration' : mesa_works}, section : 'Configuration')\n> \n> if not softisp_enabled\n> subdir_done()\n> @@ -16,7 +16,7 @@ libcamera_internal_sources += files([\n> 'swstats_cpu.cpp',\n> ])\n> \n> -if gles_headless_enabled\n> +if mesa_works\n> config_h.set('HAVE_DEBAYER_EGL', 1)\n> libcamera_internal_sources += files([\n> '../egl.cpp',\n> --\n> 2.53.0\n> \nReviewed-by: Bryan O'Donoghue ","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 84A6EBE086\n\tfor ;\n\tTue, 24 Mar 2026 15:50:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 45F1462790;\n\tTue, 24 Mar 2026 16:50:51 +0100 (CET)","from sea.source.kernel.org (sea.source.kernel.org\n\t[IPv6:2600:3c0a:e001:78e:0:1991:8:25])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B614162787\n\tfor ;\n\tTue, 24 Mar 2026 16:50:49 +0100 (CET)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby sea.source.kernel.org (Postfix) with ESMTP id 9AF3E419B2;\n\tTue, 24 Mar 2026 15:50:48 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 95216C19424;\n\tTue, 24 Mar 2026 15:50:47 +0000 (UTC)"],"Message-ID":"<80749f70-6398-43a3-a3d5-21228718018b@nxsw.ie>","Date":"Tue, 24 Mar 2026 15:50:46 +0000","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 4/7] meson: Remove `gles_headless_enabled`","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal ,\n\tLaurent Pinchart ","References":"<20260323082000.1324115-1-barnabas.pocze@ideasonboard.com>\n\t\n\t<20260323082000.1324115-5-barnabas.pocze@ideasonboard.com>","From":"Bryan O'Donoghue ","Content-Language":"en-US","In-Reply-To":"<20260323082000.1324115-5-barnabas.pocze@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]