[{"id":38375,"web_url":"https://patchwork.libcamera.org/comment/38375/","msgid":"<177425902289.3380983.13988253565681069533@ping.linuxembedded.co.uk>","date":"2026-03-23T09:43:42","subject":"Re: [PATCH v2 2/7] meson: Add `egl.cpp` to sources alongside\n\t`debayer_egl.cpp`","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2026-03-23 08:19:55)\n> There are no other users of `egl.cpp`, so simplify by adding it to the\n> sources array at the same time.\n\nI think this sounds correct now, but I would anticipate this to change\n'sometime'.\n\nI think the egl component should be used by the virtual pipeline handler\nto generate test patterns, or perhaps a dedicated test-pattern-generator\nobject which could be shared across pipelines.\n\nI think additional pre- and post- processors would also be considered in\nother pipelines which would make use of the EGL component. A GPU Dewarp,\na utility to do HDR merges ...\n\nBut that's future-ware, so I don't object to this patch if you still\nwant to do this.\n\nAcked-by: Kieran Bingham \n\n> \n> Signed-off-by: Barnabás Pőcze \n> ---\n> src/libcamera/meson.build | 3 ---\n> src/libcamera/software_isp/meson.build | 1 +\n> 2 files changed, 1 insertion(+), 3 deletions(-)\n> \n> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> index c6c109a30..28ce93de6 100644\n> --- a/src/libcamera/meson.build\n> +++ b/src/libcamera/meson.build\n> @@ -75,9 +75,6 @@ libegl = dependency('egl', required : false)\n> libglesv2 = dependency('glesv2', required : false)\n> \n> if mesa_works\n> - libcamera_internal_sources += files([\n> - 'egl.cpp',\n> - ])\n> gles_headless_enabled = true\n> else\n> gles_headless_enabled = false\n> diff --git a/src/libcamera/software_isp/meson.build b/src/libcamera/software_isp/meson.build\n> index c61ac7d59..a55b76b58 100644\n> --- a/src/libcamera/software_isp/meson.build\n> +++ b/src/libcamera/software_isp/meson.build\n> @@ -19,6 +19,7 @@ libcamera_internal_sources += files([\n> if softisp_enabled and gles_headless_enabled\n> config_h.set('HAVE_DEBAYER_EGL', 1)\n> libcamera_internal_sources += files([\n> + '../egl.cpp',\n> 'debayer_egl.cpp',\n> ])\n> endif\n> -- \n> 2.53.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3A294BD87C\n\tfor ;\n\tMon, 23 Mar 2026 09:43:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1D31662745;\n\tMon, 23 Mar 2026 10:43:47 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 09A2D62737\n\tfor ;\n\tMon, 23 Mar 2026 10:43:46 +0100 (CET)","from monstersaurus.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8E5AC19DF;\n\tMon, 23 Mar 2026 10:42:29 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Z+RLAj1d\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1774258949;\n\tbh=Ddczbspl/zyYoLvtmnPNEc+fYBXZJS5Ci/FdIQbnhN4=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=Z+RLAj1diOJnUAFbQRU+L3Bf0t5jp+ZJWsg/p33W2Bq96ShdQ5TOWegDc0niotC4O\n\t5snAjcG4xhKRwPik9UwkBHNVZ2y7xszomS2eU1AI3XAsfY+433wGEEOJIt+cJ2uyfL\n\tOb+pkOMA4kKaIy/Z6mMm5KayLG+OTw4w0/EPZW6M=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20260323082000.1324115-3-barnabas.pocze@ideasonboard.com>","References":"<20260323082000.1324115-1-barnabas.pocze@ideasonboard.com>\n\t<20260323082000.1324115-3-barnabas.pocze@ideasonboard.com>","Subject":"Re: [PATCH v2 2/7] meson: Add `egl.cpp` to sources alongside\n\t`debayer_egl.cpp`","From":"Kieran Bingham ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 23 Mar 2026 09:43:42 +0000","Message-ID":"<177425902289.3380983.13988253565681069533@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":38399,"web_url":"https://patchwork.libcamera.org/comment/38399/","msgid":"<30c8e60b-7449-4d4a-928a-4c2e1ec0d7f6@nxsw.ie>","date":"2026-03-24T15:57:00","subject":"Re: [PATCH v2 2/7] meson: Add `egl.cpp` to sources alongside\n\t`debayer_egl.cpp`","submitter":{"id":226,"url":"https://patchwork.libcamera.org/api/people/226/","name":"Bryan O'Donoghue","email":"bod.linux@nxsw.ie"},"content":"On 23/03/2026 08:19, Barnabás Pőcze wrote:\n> There are no other users of `egl.cpp`, so simplify by adding it to the\n> sources array at the same time.\n> \n> Signed-off-by: Barnabás Pőcze \n> ---\n> src/libcamera/meson.build | 3 ---\n> src/libcamera/software_isp/meson.build | 1 +\n> 2 files changed, 1 insertion(+), 3 deletions(-)\n> \n> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> index c6c109a30..28ce93de6 100644\n> --- a/src/libcamera/meson.build\n> +++ b/src/libcamera/meson.build\n> @@ -75,9 +75,6 @@ libegl = dependency('egl', required : false)\n> libglesv2 = dependency('glesv2', required : false)\n> \n> if mesa_works\n> - libcamera_internal_sources += files([\n> - 'egl.cpp',\n> - ])\n> gles_headless_enabled = true\n> else\n> gles_headless_enabled = false\n> diff --git a/src/libcamera/software_isp/meson.build b/src/libcamera/software_isp/meson.build\n> index c61ac7d59..a55b76b58 100644\n> --- a/src/libcamera/software_isp/meson.build\n> +++ b/src/libcamera/software_isp/meson.build\n> @@ -19,6 +19,7 @@ libcamera_internal_sources += files([\n> if softisp_enabled and gles_headless_enabled\n> config_h.set('HAVE_DEBAYER_EGL', 1)\n> libcamera_internal_sources += files([\n> + '../egl.cpp',\n> 'debayer_egl.cpp',\n> ])\n> endif\n> --\n> 2.53.0\n> \n\nI don't really like the way the relative path ends up looking but, I'll \ndefer to your preferences.\n\nReviewed-by: Bryan O'Donoghue \n\n---\nbod","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DC848BE086\n\tfor ;\n\tTue, 24 Mar 2026 15:57:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9FCE46279E;\n\tTue, 24 Mar 2026 16:57:07 +0100 (CET)","from tor.source.kernel.org (tor.source.kernel.org\n\t[IPv6:2600:3c04:e001:324:0:1991:8:25])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8711A62791\n\tfor ;\n\tTue, 24 Mar 2026 16:57:06 +0100 (CET)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby tor.source.kernel.org (Postfix) with ESMTP id 449E260103;\n\tTue, 24 Mar 2026 15:57:05 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 50B54C19424;\n\tTue, 24 Mar 2026 15:57:04 +0000 (UTC)"],"Message-ID":"<30c8e60b-7449-4d4a-928a-4c2e1ec0d7f6@nxsw.ie>","Date":"Tue, 24 Mar 2026 15:57:00 +0000","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 2/7] meson: Add `egl.cpp` to sources alongside\n\t`debayer_egl.cpp`","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20260323082000.1324115-1-barnabas.pocze@ideasonboard.com>\n\t\n\t<20260323082000.1324115-3-barnabas.pocze@ideasonboard.com>","From":"Bryan O'Donoghue ","Content-Language":"en-US","In-Reply-To":"<20260323082000.1324115-3-barnabas.pocze@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]