{"id":26305,"url":"https://patchwork.libcamera.org/api/patches/26305/?format=json","web_url":"https://patchwork.libcamera.org/patch/26305/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260323082000.1324115-3-barnabas.pocze@ideasonboard.com>","date":"2026-03-23T08:19:55","name":"[v2,2/7] meson: Add `egl.cpp` to sources alongside `debayer_egl.cpp`","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"5f8d631f450150954040fbeba52e607974313999","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/26305/mbox/","series":[{"id":5835,"url":"https://patchwork.libcamera.org/api/series/5835/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5835","date":"2026-03-23T08:19:53","name":"meson: Add `softisp-gpu` option","version":2,"mbox":"https://patchwork.libcamera.org/series/5835/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/26305/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/26305/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 488FBBE086\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 23 Mar 2026 08:20:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D062862743;\n\tMon, 23 Mar 2026 09:20:09 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E029A62738\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 23 Mar 2026 09:20:03 +0100 (CET)","from pb-laptop.local (185.221.143.129.nat.pool.zt.hu\n\t[185.221.143.129])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 979A1874\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 23 Mar 2026 09:18:47 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"RvY5epPf\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1774253927;\n\tbh=mqWQLksu8V5Mv2Jj6II9zydGu4UxOBmsVrhMh9PzK5s=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=RvY5epPfwSNmWWimB/ZVbDnvZMe7zFT58o5VkXRvE+IJT8cBOpsyjiKGYAEG/uNS6\n\t49dqYnQrz49P/GATH5aNhQ6wIVJgqYDX7XqN6xQiExnlTz5BEZIKr+8kSOrBXnAPWy\n\tW05s3Smn1nNOaKC0tWtmppiQKzFxvighEsJ27MNU=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH v2 2/7] meson: Add `egl.cpp` to sources alongside\n\t`debayer_egl.cpp`","Date":"Mon, 23 Mar 2026 09:19:55 +0100","Message-ID":"<20260323082000.1324115-3-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260323082000.1324115-1-barnabas.pocze@ideasonboard.com>","References":"<20260323082000.1324115-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"There are no other users of `egl.cpp`, so simplify by adding it to the\nsources array at the same time.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n src/libcamera/meson.build              | 3 ---\n src/libcamera/software_isp/meson.build | 1 +\n 2 files changed, 1 insertion(+), 3 deletions(-)","diff":"diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\nindex c6c109a30..28ce93de6 100644\n--- a/src/libcamera/meson.build\n+++ b/src/libcamera/meson.build\n@@ -75,9 +75,6 @@ libegl = dependency('egl', required : false)\n libglesv2 = dependency('glesv2', required : false)\n \n if mesa_works\n-    libcamera_internal_sources += files([\n-        'egl.cpp',\n-    ])\n     gles_headless_enabled = true\n else\n     gles_headless_enabled = false\ndiff --git a/src/libcamera/software_isp/meson.build b/src/libcamera/software_isp/meson.build\nindex c61ac7d59..a55b76b58 100644\n--- a/src/libcamera/software_isp/meson.build\n+++ b/src/libcamera/software_isp/meson.build\n@@ -19,6 +19,7 @@ libcamera_internal_sources += files([\n if softisp_enabled and gles_headless_enabled\n     config_h.set('HAVE_DEBAYER_EGL', 1)\n     libcamera_internal_sources += files([\n+        '../egl.cpp',\n         'debayer_egl.cpp',\n     ])\n endif\n","prefixes":["v2","2/7"]}