[{"id":38395,"web_url":"https://patchwork.libcamera.org/comment/38395/","msgid":"<36ce0dd0-d586-4925-bd3d-583b059f4678@nxsw.ie>","date":"2026-03-24T15:49:55","subject":"Re: [PATCH v2 1/7] meson: Drop unnecessary egl, gles feature defines","submitter":{"id":226,"url":"https://patchwork.libcamera.org/api/people/226/","name":"Bryan O'Donoghue","email":"bod.linux@nxsw.ie"},"content":"On 23/03/2026 08:19, Barnabás Pőcze wrote:\n> `HAVE_LIBEGL` and `HAVE_GLESV2` are not used, so drop them.\n> \n> Signed-off-by: Barnabás Pőcze \n> Reviewed-by: Milan Zamazal \n> Reviewed-by: Laurent Pinchart \n> ---\n> src/libcamera/meson.build | 8 --------\n> 1 file changed, 8 deletions(-)\n> \n> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> index d15943586..c6c109a30 100644\n> --- a/src/libcamera/meson.build\n> +++ b/src/libcamera/meson.build\n> @@ -74,14 +74,6 @@ mesa_works = cc.check_header('EGL/egl.h', required: false)\n> libegl = dependency('egl', required : false)\n> libglesv2 = dependency('glesv2', required : false)\n> \n> -if libegl.found()\n> - config_h.set('HAVE_LIBEGL', 1)\n> -endif\n> -\n> -if libglesv2.found()\n> - config_h.set('HAVE_GLESV2', 1)\n> -endif\n> -\n> if mesa_works\n> libcamera_internal_sources += files([\n> 'egl.cpp',\n> --\n> 2.53.0\n> \n\nReviewed-by: Bryan O'Donoghue ","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 51944BE086\n\tfor ;\n\tTue, 24 Mar 2026 15:50:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 728DC62796;\n\tTue, 24 Mar 2026 16:50:02 +0100 (CET)","from sea.source.kernel.org (sea.source.kernel.org\n\t[IPv6:2600:3c0a:e001:78e:0:1991:8:25])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1CC4E62780\n\tfor ;\n\tTue, 24 Mar 2026 16:50:01 +0100 (CET)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby sea.source.kernel.org (Postfix) with ESMTP id 5FEB142E03;\n\tTue, 24 Mar 2026 15:49:59 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 637F1C19424;\n\tTue, 24 Mar 2026 15:49:58 +0000 (UTC)"],"Message-ID":"<36ce0dd0-d586-4925-bd3d-583b059f4678@nxsw.ie>","Date":"Tue, 24 Mar 2026 15:49:55 +0000","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 1/7] meson: Drop unnecessary egl, gles feature defines","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal ,\n\tLaurent Pinchart ","References":"<20260323082000.1324115-1-barnabas.pocze@ideasonboard.com>\n\t\n\t<20260323082000.1324115-2-barnabas.pocze@ideasonboard.com>","From":"Bryan O'Donoghue ","Content-Language":"en-US","In-Reply-To":"<20260323082000.1324115-2-barnabas.pocze@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]