[{"id":38351,"web_url":"https://patchwork.libcamera.org/comment/38351/","msgid":"","date":"2026-03-10T12:14:02","subject":"Re: [PATCH v7 5/5] Documentation/runtime_configuration: Add missing\n\tsoftware_isp.mode doc","submitter":{"id":242,"url":"https://patchwork.libcamera.org/api/people/242/","name":"Hans de Goede","email":"johannes.goede@oss.qualcomm.com"},"content":"Hi,\n\nOn 10-Mar-26 13:01, Hans de Goede wrote:\n> The software_isp.mode setting was missing from the runtime_configuration\n> documentation, add it.\n> \n> Reviewed-by: Milan Zamazal \n> Signed-off-by: Hans de Goede \n\nI forgot to pick up Kieran's Reviewed-by for v6 here, let me re-add\nthat now:\n\nReviewed-by: Kieran Bingham \n\nRegards,\n\nHans\n\n\n\n\n\n> ---\n> Changes in v7:\n> - Move back to being part of the series, sorry for the confusion\n> \n> Changes in v6:\n> - Use \"LIBCAMERA_SOFTISP_MODE, software_isp.mode\" as item title\n> - Add Milan's Reviewed-by\n> - Send out as standalone patch, v5 of rest of series is ready as is\n> \n> Changes in v5:\n> - New patch in v5 of this series\n> ---\n> Documentation/runtime_configuration.rst | 9 +++++++++\n> 1 file changed, 9 insertions(+)\n> \n> diff --git a/Documentation/runtime_configuration.rst b/Documentation/runtime_configuration.rst\n> index 651929a4d..a95de2f43 100644\n> --- a/Documentation/runtime_configuration.rst\n> +++ b/Documentation/runtime_configuration.rst\n> @@ -51,6 +51,7 @@ file structure:\n> measure:\n> skip: # non-negative integer, frames to skip initially\n> number: # non-negative integer, frames to measure\n> + mode: # cpu/gpu\n> threads: # integer >= 1, number of render threads to use, default 2\n> \n> Configuration file example\n> @@ -85,6 +86,7 @@ Configuration file example\n> measure:\n> skip: 50\n> number: 30\n> + mode: gpu\n> threads: 2\n> \n> List of variables and configuration options\n> @@ -141,6 +143,13 @@ LIBCAMERA__TUNING_FILE\n> \n> Example value: ``/usr/local/share/libcamera/ipa/rpi/vc4/custom_sensor.json``\n> \n> +LIBCAMERA_SOFTISP_MODE, software_isp.mode\n> + Select if the software ISP should use GPU or CPU image processsing,\n> + one of ``cpu`` or ``gpu``. When set to ``gpu`` and EGL is not available\n> + the software ISP will automatically fall back to the CPU.\n> +\n> + Example value: ``gpu``\n> +\n> pipelines.simple.supported_devices.driver, pipelines.simple.supported_devices.software_isp\n> Override whether software ISP is enabled for the given driver.\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4F092BDCC1\n\tfor ;\n\tTue, 10 Mar 2026 12:14:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BC05662643;\n\tTue, 10 Mar 2026 13:14:08 +0100 (CET)","from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com\n\t[205.220.180.131])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8430762633\n\tfor ;\n\tTue, 10 Mar 2026 13:14:06 +0100 (CET)","from pps.filterd (m0279870.ppops.net [127.0.0.1])\n\tby mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n\t62A9AaAG3754828 for ;\n\tTue, 10 Mar 2026 12:14:05 GMT","from mail-qk1-f197.google.com (mail-qk1-f197.google.com\n\t[209.85.222.197])\n\tby mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ct477k3xg-1\n\t(version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n\tfor ;\n\tTue, 10 Mar 2026 12:14:05 +0000 (GMT)","by mail-qk1-f197.google.com with SMTP id\n\taf79cd13be357-8cd81506677so1347009485a.1\n\tfor ;\n\tTue, 10 Mar 2026 05:14:05 -0700 (PDT)","from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec?\n\t(2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl.\n\t[2001:1c00:c32:7800:5bfa:a036:83f0:f9ec])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-48541aa73easm69297365e9.3.2026.03.10.05.14.02\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tTue, 10 Mar 2026 05:14:03 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=qualcomm.com header.i=@qualcomm.com\n\theader.b=\"EKXYGWQB\"; dkim=pass (2048-bit key;\n\tunprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n\theader.b=\"fe9P58Mp\"; dkim-atps=neutral","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n\tcc:content-transfer-encoding:content-type:date:from:in-reply-to\n\t:message-id:mime-version:references:subject:to; s=qcppdkim1; bh=\n\tqGDuONvFNKtT8RJP2FPqc2pEU5gBDoe3l7wyVTExk0E=; b=EKXYGWQBU5u9wptK\n\tMGZ8CnWsaqBNWtqNyfAPjkaMQuMZYL1DfF4+t3kttJokdR2FjEEafZB5tic/8NI0\n\tZ2HeULMW1RcTCe4hTr3D2IlNTCXyJbydyjs9rfeNoxyrAJIdSLMEiX+RvZ1RoB7N\n\t+FjTpwuOpFgcRB8fthJZgPvxKTwjXkRezFc6eMp52jLERtViaiu+tMtvwtc3k11l\n\tXhggI6bhrMWTbQEqO7xYJhYrnNHdELud1t5XV0W3jzJk8Tf+7T8BLX2RySOJvv2M\n\tzXToWttPfvID3uh6DRWgAKf5q1aUyQnkzbjiYaTOt/o8RPBDPzFrlwyTjjXWEBDj\n\tJO6KVQ==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=oss.qualcomm.com; s=google; t=1773144844; x=1773749644;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:in-reply-to:content-language:references\n\t:cc:to:subject:from:user-agent:mime-version:date:message-id:from:to\n\t:cc:subject:date:message-id:reply-to;\n\tbh=qGDuONvFNKtT8RJP2FPqc2pEU5gBDoe3l7wyVTExk0E=;\n\tb=fe9P58MpipJlgasB0o/znODH9lIOvz7VNIiHiGWKScWmDQbOBaEW+bWWF/5NkY2Joy\n\t13xfI24S2k5sKHnQJpnh+FS+EERTYf6MjqWhWqs5vCJZZmcz+B/UnoJed1zKDkG/Q4mv\n\t06ZO1yUX0R8+sVyeW8su5ZsP+V4RAOO4c7EQAkaICDQHfqlfe4vQz5H1QV17Xlu2SOU5\n\tPgfaDRqQVysZ3V2vI7FbXk8Yk6tfM3+Fsb0LjVjv1okVxEc+48qVPIsxfcmZup3Rbyo1\n\t5xHS22dJNmgUNdYYGG1740x3M42lzOu/nGaa/6MPmbfYg3LsOb94wOYCiKEpJeUAffgK\n\t5pSA=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1773144844; x=1773749644;\n\th=content-transfer-encoding:in-reply-to:content-language:references\n\t:cc:to:subject:from:user-agent:mime-version:date:message-id:x-gm-gg\n\t:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n\tbh=qGDuONvFNKtT8RJP2FPqc2pEU5gBDoe3l7wyVTExk0E=;\n\tb=pGt2eZfxGLDtpgiTR0r7iknLGrUPJ7iS2rEK4DuuKp+AH8LwhuRYinPhKb0qEIgFzA\n\t2h1qzqOnQbZyf1aEaR5oQr3jgGnX+KYl4NbVrcpVUIBW0CS4gdi77njdmn1zsdD9Ua9T\n\tGN4q9d7ZlZleWq/uWidv7hvlbx9bBJI/cUoHBD5ljtjHEx20vNdgAiPT7Rt40LXcb7a+\n\tGpOqWgX8Q0i6OnoqKvZPV6G3Wxbu4AIw2zQrO/pcKAiUldVQL4MEEmBrvZa3hWnrfJ2G\n\tqg8VpE2o3kzJizVbSCilXdRpWXgkDyYp7nid0BmbC44Ge4UpVhWqBHQ9nkuzdxMtKbUE\n\tVxmw==","X-Gm-Message-State":"AOJu0Yz4Pt0x1wv9miVfGZauRId9dp4r7B+zFUxyyyCTYofUvd8HGzv+\n\t8bo/zgBMvstDleMbjyDvfwDFGkSs+XE3ffeU2GXlJJptkl4YtcKf6XiobJ3/HBNERcR6fJalmfO\n\t2A21HZM2eAdpM+b/KFIkj/agkjejHQAOmZ2G7fN9BrFmJhiASfHKPvrDq0luIhihbXavLH/4bb+\n\tA8jlpFiXrL","X-Gm-Gg":"ATEYQzxegxlflMJjOhXzfm/WgMhXI64Gx9FKtjdoos7e0rOMbuKxS58dIHgBhs6NGD2\n\tmIGSBskbwGB9FuRXfGF+Rn33qhvvOqnNMsIXocxYTqBfstaXKVUL23X0YqJpvnIFrl9AFeX9b95\n\t3/xHwAVO4D2/j1I5kJURhs5BZS7Ytgn49Z6B44Idkobt9Ei+f2JsGfj11rzSfw20CFHuJZX3thQ\n\tVvXpia4c1Jrns/PhKRLiy2wXrPjSmzxncK/7Bm3qGxNO50LcccYMf5oQmVmE1FpotsUe/N6qOVp\n\tb3ZKJKVoXggBXypMsXLALsWO1C/0ff71ZFJbmTgDwY2cO9q61gLnRyvgT2288ji5TaZvT62L0l0\n\t4cXtURnjDS42SfdVoVDmXNGYrURGI6JgweGBRUtTGVquROC4HP//8sx3LMcn5NkPuBZFMFFRI+N\n\t3Gp8tfLO7IXWc92moISJdGjkEYrPCxI60URPa2V8CpDNOExFMx4FvkNoQPPsFGJxw5GWnFojCWV\n\tZx1q365i+gZhNWY","X-Received":["by 2002:a05:620a:444d:b0:8cd:8751:2b26 with SMTP id\n\taf79cd13be357-8cd87512fcfmr851436985a.58.1773144844448; \n\tTue, 10 Mar 2026 05:14:04 -0700 (PDT)","by 2002:a05:620a:444d:b0:8cd:8751:2b26 with SMTP id\n\taf79cd13be357-8cd87512fcfmr851433685a.58.1773144843959; \n\tTue, 10 Mar 2026 05:14:03 -0700 (PDT)"],"Message-ID":"","Date":"Tue, 10 Mar 2026 13:14:02 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","From":"Hans de Goede ","Subject":"Re: [PATCH v7 5/5] Documentation/runtime_configuration: Add missing\n\tsoftware_isp.mode doc","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal ","References":"<20260310120106.79922-1-johannes.goede@oss.qualcomm.com>\n\t<20260310120106.79922-6-johannes.goede@oss.qualcomm.com>","Content-Language":"en-US, nl","In-Reply-To":"<20260310120106.79922-6-johannes.goede@oss.qualcomm.com>","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"7bit","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwMzEwMDEwNiBTYWx0ZWRfX3KvSE1r+iOs1\n\tO9qPy4aQ7/UG3XEzIYn/ivUWxRvK2WV2vqz5Pb0mbMoGikiPMTqmxXsAkwUBPCdo9nFwxXCgFwh\n\tL+CqCDwYCF/TSGLphzB4+Djw2F1XGRaWPDHn6+OKt7dkHsqXJTfm8bRNKILMXxlDqxlSr7dKz6F\n\tYwERYjXcNMzTHB9o7carOB2oDp8xSHRqefBPr7nz98lc7r0TWlYtIp8ofdQT+lIr4oeEA1+mevU\n\tEDyhGfhjX0KlgFzxAI9N3KR9fwkbcyLHcCn/DE3UDdXHUUT0MBVmDXzR77+enZUuhqOqVP9NyvS\n\t08qZFuNisSVjpTjsJkLsFZfOvucupjePN+OEIibOu67E2zq9kOCUbtGNBf8HUJTu3oGfLKE+SpS\n\tkKVmibld7dOzxEjpjS3ilCKn3hA2k2zZwk6yQapgcg3AhakB/90RmToivrka9uJn3FSX33Z9dkx\n\tfJg3xPPI+rCQk71FsFQ==","X-Proofpoint-GUID":"eBH_nBkcOaajieJUItxttrLebIAVj2Zo","X-Authority-Analysis":"v=2.4 cv=KLxXzVFo c=1 sm=1 tr=0 ts=69b00b0d cx=c_pps\n\ta=50t2pK5VMbmlHzFWWp8p/g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10\n\ta=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22\n\ta=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=20KFwNOVAAAA:8\n\ta=EUspDBNiAAAA:8 a=P1BnusSwAAAA:8 a=JTFxiGgBDO8w6SsYsdAA:9\n\ta=QEXdDO2ut3YA:10\n\ta=IoWCM6iH3mJn3m4BftBB:22 a=D0XLA9XvdZm18NrgonBM:22","X-Proofpoint-ORIG-GUID":"eBH_nBkcOaajieJUItxttrLebIAVj2Zo","X-Proofpoint-Virus-Version":"vendor=baseguard\n\tengine=ICAP:2.0.293, Aquarius:18.0.1143, Hydra:6.1.51,\n\tFMLib:17.12.100.49\n\tdefinitions=2026-03-10_02,2026-03-09_02,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tsuspectscore=0 malwarescore=0 bulkscore=0 impostorscore=0 spamscore=0\n\tphishscore=0 priorityscore=1501 lowpriorityscore=0 adultscore=0\n\tclxscore=1015\n\tclassifier=typeunknown authscore=0 authtc= authcc= route=outbound\n\tadjust=0\n\treason=mlx scancount=1 engine=8.22.0-2602130000\n\tdefinitions=main-2603100106","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]