[{"id":38346,"web_url":"https://patchwork.libcamera.org/comment/38346/","msgid":"<6fb5a6fe-27c8-49fb-ad7b-094bd4afd441@ideasonboard.com>","date":"2026-03-06T15:21:21","subject":"Re: [PATCH v3 1/3] ipa: simple: agc: Replace bang-bang controller\n\twith proportional","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"Hi\n\n2026. 03. 05. 21:10 keltezéssel, Javier Tia írta:\n> The AGC's updateExposure() uses a fixed ~10% step per frame regardless\n> of how far the current exposure is from optimal. With a hysteresis dead\n> band of only +/-4%, the controller overshoots when the correct value\n> falls within one step, causing visible brightness oscillation (flicker).\n> \n> Replace the fixed-step bang-bang controller with a proportional one\n> where the correction factor scales linearly with the MSV error:\n> \n> factor = 1.0 + clamp(error * 0.04, -0.15, +0.15)\n> \n> At maximum error (~2.5), this gives the same ~10% step as before. Near\n> the target, steps shrink to <1%, eliminating overshoot. The existing\n> hysteresis (kExposureSatisfactory) still prevents hunting on noise.\n> \n> Tested on OV2740 behind Intel IPU6 ISYS (ThinkPad X1 Carbon Gen 10)\n> where the old controller produced continuous brightness flicker. The\n> proportional controller converges in ~3 seconds from cold start with\n> no visible oscillation.\n> \n> Signed-off-by: Javier Tia \n> Reviewed-by: Milan Zamazal \n> ---\n> src/ipa/simple/algorithms/agc.cpp | 73 ++++++++++++++++++++++++++-------------\n> 1 file changed, 49 insertions(+), 24 deletions(-)\n> \n> diff --git a/src/ipa/simple/algorithms/agc.cpp b/src/ipa/simple/algorithms/agc.cpp\n> index 2f7e040c..a13a7552 100644\n> --- a/src/ipa/simple/algorithms/agc.cpp\n> +++ b/src/ipa/simple/algorithms/agc.cpp\n> @@ -7,6 +7,8 @@\n> \n> #include \"agc.h\"\n> \n> +#include \n> +#include \n> #include \n> \n> #include \n> @@ -37,52 +39,74 @@ static constexpr float kExposureOptimal = kExposureBinsCount / 2.0;\n> */\n> static constexpr float kExposureSatisfactory = 0.2;\n> \n> +/*\n> + * Proportional gain for exposure/gain adjustment. Maps the MSV error to a\n> + * multiplicative correction factor:\n> + *\n> + * factor = 1.0 + kExpProportionalGain * error\n> + *\n> + * With kExpProportionalGain = 0.04:\n> + * - max error ~2.5 -> factor 1.10 (~10% step, same as before)\n> + * - error 1.0 -> factor 1.04 (~4% step)\n> + * - error 0.3 -> factor 1.012 (~1.2% step)\n> + *\n> + * This replaces the fixed 10% bang-bang step with a proportional correction\n> + * that converges smoothly and avoids overshooting near the target.\n> + */\n> +static constexpr float kExpProportionalGain = 0.04;\n\nI suppose this is very subjective, but in my testing I felt that this was a bit slow.\nIn any case, it's probably fine, especially for \"web camera\" usage.\n\n\n> +\n> +/*\n> + * Maximum multiplicative step per frame, to bound the correction when the\n> + * scene changes dramatically.\n> + */\n> +static constexpr float kExpMaxStep = 0.15;\n\n2.5 * 0.04 = 0.1, which is smaller than `kExpMaxStep`. Is this necessary?\n\n\nTested-by: Barnabás Pőcze # ThinkPad X1 Yoga Gen 7 + ov2740\n\n> +\n> Agc::Agc()\n> {\n> }\n> \n> void Agc::updateExposure(IPAContext &context, IPAFrameContext &frameContext, double exposureMSV)\n> {\n> -\t/*\n> -\t * kExpDenominator of 10 gives ~10% increment/decrement;\n> -\t * kExpDenominator of 5 - about ~20%\n> -\t */\n> -\tstatic constexpr uint8_t kExpDenominator = 10;\n> -\tstatic constexpr uint8_t kExpNumeratorUp = kExpDenominator + 1;\n> -\tstatic constexpr uint8_t kExpNumeratorDown = kExpDenominator - 1;\n> -\n> \tint32_t &exposure = frameContext.sensor.exposure;\n> \tdouble &again = frameContext.sensor.gain;\n> \n> -\tif (exposureMSV < kExposureOptimal - kExposureSatisfactory) {\n> +\tdouble error = kExposureOptimal - exposureMSV;\n> +\n> +\tif (std::abs(error) <= kExposureSatisfactory)\n> +\t\treturn;\n> +\n> +\t/*\n> +\t * Compute a proportional correction factor. The sign of the error\n> +\t * determines the direction: positive error means too dark (increase),\n> +\t * negative means too bright (decrease).\n> +\t */\n> +\tfloat step = std::clamp(static_cast(error) * kExpProportionalGain,\n> +\t\t\t\t-kExpMaxStep, kExpMaxStep);\n> +\tfloat factor = 1.0f + step;\n> +\n> +\tif (factor > 1.0f) {\n> +\t\t/* Scene too dark: increase exposure first, then gain. */\n> \t\tif (exposure < context.configuration.agc.exposureMax) {\n> -\t\t\tint32_t next = exposure * kExpNumeratorUp / kExpDenominator;\n> -\t\t\tif (next - exposure < 1)\n> -\t\t\t\texposure += 1;\n> -\t\t\telse\n> -\t\t\t\texposure = next;\n> +\t\t\tint32_t next = static_cast(exposure * factor);\n> +\t\t\texposure = std::max(next, exposure + 1);\n> \t\t} else {\n> -\t\t\tdouble next = again * kExpNumeratorUp / kExpDenominator;\n> +\t\t\tdouble next = again * factor;\n> \t\t\tif (next - again < context.configuration.agc.againMinStep)\n> \t\t\t\tagain += context.configuration.agc.againMinStep;\n> \t\t\telse\n> \t\t\t\tagain = next;\n> \t\t}\n> -\t}\n> -\n> -\tif (exposureMSV > kExposureOptimal + kExposureSatisfactory) {\n> +\t} else {\n> +\t\t/* Scene too bright: decrease gain first, then exposure. */\n> \t\tif (again > context.configuration.agc.again10) {\n> -\t\t\tdouble next = again * kExpNumeratorDown / kExpDenominator;\n> +\t\t\tdouble next = again * factor;\n> \t\t\tif (again - next < context.configuration.agc.againMinStep)\n> \t\t\t\tagain -= context.configuration.agc.againMinStep;\n> \t\t\telse\n> \t\t\t\tagain = next;\n> \t\t} else {\n> -\t\t\tint32_t next = exposure * kExpNumeratorDown / kExpDenominator;\n> -\t\t\tif (exposure - next < 1)\n> -\t\t\t\texposure -= 1;\n> -\t\t\telse\n> -\t\t\t\texposure = next;\n> +\t\t\tint32_t next = static_cast(exposure * factor);\n> +\t\t\texposure = std::min(next, exposure - 1);\n> \t\t}\n> \t}\n> \n> @@ -96,6 +120,7 @@ void Agc::updateExposure(IPAContext &context, IPAFrameContext &frameContext, dou\n> \n> \tLOG(IPASoftExposure, Debug)\n> \t\t<< \"exposureMSV \" << exposureMSV\n> +\t\t<< \" error \" << error << \" factor \" << factor\n> \t\t<< \" exp \" << exposure << \" again \" << again;\n> }\n> \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5A229BDCC1\n\tfor ;\n\tFri, 6 Mar 2026 15:21:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 989A962624;\n\tFri, 6 Mar 2026 16:21:26 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 86779620FA\n\tfor ;\n\tFri, 6 Mar 2026 16:21:25 +0100 (CET)","from [192.168.33.103] (185.182.214.224.nat.pool.zt.hu\n\t[185.182.214.224])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1A973454;\n\tFri, 6 Mar 2026 16:20:21 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"WeU8qSzm\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1772810421;\n\tbh=kVXV1xjvp7PhOf4QZteqHjQDwe6xx1krYiKy6a9WVbY=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=WeU8qSzm4fKvU7bL75WC0zfNQ440QMYKfR4nux5qq+2uygPdsh2wFtp5Ys/Hww9Wc\n\t5sdYb0Vf2ifrog9qTJz0C4p58S38GzG5cKRzX/f0GoTUDpmzd45oiPOrXlYZBUtAqy\n\tNeBF8Ka8lPg/re5AtxREsHQofLcxQZByLCLPC4+8=","Message-ID":"<6fb5a6fe-27c8-49fb-ad7b-094bd4afd441@ideasonboard.com>","Date":"Fri, 6 Mar 2026 16:21:21 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v3 1/3] ipa: simple: agc: Replace bang-bang controller\n\twith proportional","To":"Javier Tia , libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal ","References":"<20260305-agc-proportional-v3-0-25abc1bfacca@jetm.me>\n\t<20260305-agc-proportional-v3-1-25abc1bfacca@jetm.me>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20260305-agc-proportional-v3-1-25abc1bfacca@jetm.me>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":38349,"web_url":"https://patchwork.libcamera.org/comment/38349/","msgid":"<85jyvpm0h3.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","date":"2026-03-06T15:39:04","subject":"Re: [PATCH v3 1/3] ipa: simple: agc: Replace bang-bang controller\n\twith proportional","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Barnabás Pőcze writes:\n\n> Hi\n>\n> 2026. 03. 05. 21:10 keltezéssel, Javier Tia írta:\n>> The AGC's updateExposure() uses a fixed ~10% step per frame regardless\n>> of how far the current exposure is from optimal. With a hysteresis dead\n>> band of only +/-4%, the controller overshoots when the correct value\n>> falls within one step, causing visible brightness oscillation (flicker).\n>> Replace the fixed-step bang-bang controller with a proportional one\n>> where the correction factor scales linearly with the MSV error:\n>> factor = 1.0 + clamp(error * 0.04, -0.15, +0.15)\n>> At maximum error (~2.5), this gives the same ~10% step as before. Near\n>> the target, steps shrink to <1%, eliminating overshoot. The existing\n>> hysteresis (kExposureSatisfactory) still prevents hunting on noise.\n>> Tested on OV2740 behind Intel IPU6 ISYS (ThinkPad X1 Carbon Gen 10)\n>> where the old controller produced continuous brightness flicker. The\n>> proportional controller converges in ~3 seconds from cold start with\n>> no visible oscillation.\n>> Signed-off-by: Javier Tia \n>> Reviewed-by: Milan Zamazal \n>> ---\n>> src/ipa/simple/algorithms/agc.cpp | 73 ++++++++++++++++++++++++++-------------\n>> 1 file changed, 49 insertions(+), 24 deletions(-)\n>> diff --git a/src/ipa/simple/algorithms/agc.cpp b/src/ipa/simple/algorithms/agc.cpp\n>> index 2f7e040c..a13a7552 100644\n>> --- a/src/ipa/simple/algorithms/agc.cpp\n>> +++ b/src/ipa/simple/algorithms/agc.cpp\n>> @@ -7,6 +7,8 @@\n>> #include \"agc.h\"\n>> +#include \n>> +#include \n>> #include \n>> #include \n>> @@ -37,52 +39,74 @@ static constexpr float kExposureOptimal = kExposureBinsCount / 2.0;\n>> */\n>> static constexpr float kExposureSatisfactory = 0.2;\n>> +/*\n>> + * Proportional gain for exposure/gain adjustment. Maps the MSV error to a\n>> + * multiplicative correction factor:\n>> + *\n>> + * factor = 1.0 + kExpProportionalGain * error\n>> + *\n>> + * With kExpProportionalGain = 0.04:\n>> + * - max error ~2.5 -> factor 1.10 (~10% step, same as before)\n>> + * - error 1.0 -> factor 1.04 (~4% step)\n>> + * - error 0.3 -> factor 1.012 (~1.2% step)\n>> + *\n>> + * This replaces the fixed 10% bang-bang step with a proportional correction\n>> + * that converges smoothly and avoids overshooting near the target.\n>> + */\n>> +static constexpr float kExpProportionalGain = 0.04;\n>\n> I suppose this is very subjective, but in my testing I felt that this was a bit slow.\n\nI have the same impression.\n\nWell, changing the constant any time later is easy, a harder part might\nbe to agree on a good value.\n\n> In any case, it's probably fine, especially for \"web camera\" usage.\n>\n>\n>> +\n>> +/*\n>> + * Maximum multiplicative step per frame, to bound the correction when the\n>> + * scene changes dramatically.\n>> + */\n>> +static constexpr float kExpMaxStep = 0.15;\n>\n> 2.5 * 0.04 = 0.1, which is smaller than `kExpMaxStep`. Is this necessary?\n>\n>\n> Tested-by: Barnabás Pőcze # ThinkPad X1 Yoga Gen 7 + ov2740\n>\n>> +\n>> Agc::Agc()\n>> {\n>> }\n>> void Agc::updateExposure(IPAContext &context, IPAFrameContext &frameContext, double exposureMSV)\n>> {\n>> -\t/*\n>> -\t * kExpDenominator of 10 gives ~10% increment/decrement;\n>> -\t * kExpDenominator of 5 - about ~20%\n>> -\t */\n>> -\tstatic constexpr uint8_t kExpDenominator = 10;\n>> -\tstatic constexpr uint8_t kExpNumeratorUp = kExpDenominator + 1;\n>> -\tstatic constexpr uint8_t kExpNumeratorDown = kExpDenominator - 1;\n>> -\n>> \tint32_t &exposure = frameContext.sensor.exposure;\n>> \tdouble &again = frameContext.sensor.gain;\n>> -\tif (exposureMSV < kExposureOptimal - kExposureSatisfactory) {\n>> +\tdouble error = kExposureOptimal - exposureMSV;\n>> +\n>> +\tif (std::abs(error) <= kExposureSatisfactory)\n>> +\t\treturn;\n>> +\n>> +\t/*\n>> +\t * Compute a proportional correction factor. The sign of the error\n>> +\t * determines the direction: positive error means too dark (increase),\n>> +\t * negative means too bright (decrease).\n>> +\t */\n>> +\tfloat step = std::clamp(static_cast(error) * kExpProportionalGain,\n>> +\t\t\t\t-kExpMaxStep, kExpMaxStep);\n>> +\tfloat factor = 1.0f + step;\n>> +\n>> +\tif (factor > 1.0f) {\n>> +\t\t/* Scene too dark: increase exposure first, then gain. */\n>> \t\tif (exposure < context.configuration.agc.exposureMax) {\n>> -\t\t\tint32_t next = exposure * kExpNumeratorUp / kExpDenominator;\n>> -\t\t\tif (next - exposure < 1)\n>> -\t\t\t\texposure += 1;\n>> -\t\t\telse\n>> -\t\t\t\texposure = next;\n>> +\t\t\tint32_t next = static_cast(exposure * factor);\n>> +\t\t\texposure = std::max(next, exposure + 1);\n>> \t\t} else {\n>> -\t\t\tdouble next = again * kExpNumeratorUp / kExpDenominator;\n>> +\t\t\tdouble next = again * factor;\n>> \t\t\tif (next - again < context.configuration.agc.againMinStep)\n>> \t\t\t\tagain += context.configuration.agc.againMinStep;\n>> \t\t\telse\n>> \t\t\t\tagain = next;\n>> \t\t}\n>> -\t}\n>> -\n>> -\tif (exposureMSV > kExposureOptimal + kExposureSatisfactory) {\n>> +\t} else {\n>> +\t\t/* Scene too bright: decrease gain first, then exposure. */\n>> \t\tif (again > context.configuration.agc.again10) {\n>> -\t\t\tdouble next = again * kExpNumeratorDown / kExpDenominator;\n>> +\t\t\tdouble next = again * factor;\n>> \t\t\tif (again - next < context.configuration.agc.againMinStep)\n>> \t\t\t\tagain -= context.configuration.agc.againMinStep;\n>> \t\t\telse\n>> \t\t\t\tagain = next;\n>> \t\t} else {\n>> -\t\t\tint32_t next = exposure * kExpNumeratorDown / kExpDenominator;\n>> -\t\t\tif (exposure - next < 1)\n>> -\t\t\t\texposure -= 1;\n>> -\t\t\telse\n>> -\t\t\t\texposure = next;\n>> +\t\t\tint32_t next = static_cast(exposure * factor);\n>> +\t\t\texposure = std::min(next, exposure - 1);\n>> \t\t}\n>> \t}\n>> @@ -96,6 +120,7 @@ void Agc::updateExposure(IPAContext &context, IPAFrameContext &frameContext, dou\n>> \tLOG(IPASoftExposure, Debug)\n>> \t\t<< \"exposureMSV \" << exposureMSV\n>> +\t\t<< \" error \" << error << \" factor \" << factor\n>> \t\t<< \" exp \" << exposure << \" again \" << again;\n>> }\n>>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7F739BE086\n\tfor ;\n\tFri, 6 Mar 2026 15:39:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C3E346261B;\n\tFri, 6 Mar 2026 16:39:17 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 165D0620FA\n\tfor ;\n\tFri, 6 Mar 2026 16:39:15 +0100 (CET)","from mail-wr1-f72.google.com (mail-wr1-f72.google.com\n\t[209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-417-evCDh3whM7aPhkbOI-zqew-1; Fri, 06 Mar 2026 10:39:13 -0500","by mail-wr1-f72.google.com with SMTP id\n\tffacd0b85a97d-439c54e0f6aso2787352f8f.0\n\tfor ;\n\tFri, 06 Mar 2026 07:39:13 -0800 (PST)","from mzamazal-thinkpadp1gen7.tpbc.csb\n\t(ip-77-48-47-2.net.vodafone.cz. [77.48.47.2])\n\tby smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-439dae2b9ccsm5404280f8f.19.2026.03.06.07.39.07\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 06 Mar 2026 07:39:10 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"HarHQuVd\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1772811554;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=fJIIYGiZyCXXEjPft1Bm5d72XeaKFbdY4N2WlHjH9Go=;\n\tb=HarHQuVdqU7wGXy/GyD+40pFCshT+lggJxBYwEzcKJn4radbspLAL+40f+a6gt9ASLZmTv\n\tS6nIZiG2beJa4Oyf/1jdvVUpzyEDlDOAbhuoPa+hMOn9GIUliSpJ94LT2nNLc6jN8S6glW\n\tpre6vKVG+utXRIN+BhSdbhfDK4GzwPo=","X-MC-Unique":"evCDh3whM7aPhkbOI-zqew-1","X-Mimecast-MFC-AGG-ID":"evCDh3whM7aPhkbOI-zqew_1772811552","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1772811552; x=1773416352;\n\th=content-transfer-encoding:mime-version:user-agent:message-id:date\n\t:references:in-reply-to:subject:cc:to:from:x-gm-gg\n\t:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n\tbh=53V9YUOUMPGL77gOLxzw2yKDWQF8HbRFYDMDGP1sSmE=;\n\tb=lwEqLwYe/zS+oZ0lIJReOMqGAubxH5qeGny/pcP3kVb4nNKtSQt4k+pOv3BBR+2SBs\n\tqWYMMJdy2Fqy/U70Mlyt8hwXsa1XHV8g/dY0ddRwUJ0vFInuPmoJ7tAODcmVTFETU6Hx\n\tb2fGQZnv1yjvmAXcUSn1xsuBlFWH/uXV5aLtzS02abDja4DD9cgkHNp/BiWRtFH13NMe\n\tzMB1i+kz+fMz59hnXnUheyGqeF8oAxnBKVMJJkZxXuSfa6pxvgZsn1VyLbP0RHnLevKb\n\tVL7KcyS8O9g3NN7NgER/TI6oSk/vXibpdTqnRA0EQV1vojXNA5vB+XIRJXpHFYiA9sFP\n\tu7Vw==","X-Forwarded-Encrypted":"i=1;\n\tAJvYcCWv30ZSe07JTFunIDErnEcm4hk1ucgng3rRPD6loHuh+4IfteI7gwq73pdS2KXlFIxnJ0vThopA0xNR8PdREsc=@lists.libcamera.org","X-Gm-Message-State":"AOJu0YyuYb+TGxzz0v4EQp71XdFHSB/rD1acXzVKgzgqqH4giUgCi8nb\n\th2dnDsI81OozvmTsdzv2KhxlFcoylAFtVDxAneJg9hQZzfkssXsTaPYnGfBih4Ot+gqJynIBSCZ\n\tNyjKIg4sN3/5n5dECqA9iWm5pkQ86ZFUn2UhNHYgMibafre+jTgdrvFx5ZcRkMzTK1JJTwn6Shw\n\tOYQJkdmjbShEG58FbBPE9I9MBn6598Jz69a6dLBUOOn0WvsBzLzUF00XoLgWg=","X-Gm-Gg":"ATEYQzxvTOOO5l4ZcM61vORz4zYp+zf+WM3X5haGV968uBleOZIUm5TGx58baVwZjNv\n\tMts8QbTmSp0dnhfINyPEe/adwObCONweNvJ+vsoqwTq+jgJuTazKvZXBRW0BskcDHnEBV1tm9oV\n\t5iUAsU7bvU74dGD0GV2iktdESp9PK1BU/msdiEnDVOGOW+rtgMWK3PmHCTLZnSGaj4m6EMKFdxh\n\tq+qDUlgtZ1bct+Kfo/m+cg2ca3tEnYFzgE0Iz9FCPRozrYHJNmEyWNnG1zHzQBDKFc2GLY15S9r\n\tsZpS/XQ/yxmcHtclHUUt4YX458Xgxx2X6fTthm5AOjmLltjsVgNZ7+riEGv1xOLy35UAxV6t/n1\n\tHM8WB0uc0ZYghh6Ye1Cr5eRVt6GrFcy+hqkMG2DZ2kLAfmV5oPwdZSVjWV61wsDS0PuAsbzwraM\n\tY=","X-Received":["by 2002:a05:6000:2313:b0:435:96a1:ee4d with SMTP id\n\tffacd0b85a97d-439da364098mr4918015f8f.14.1772811551869; \n\tFri, 06 Mar 2026 07:39:11 -0800 (PST)","by 2002:a05:6000:2313:b0:435:96a1:ee4d with SMTP id\n\tffacd0b85a97d-439da364098mr4917927f8f.14.1772811551204; \n\tFri, 06 Mar 2026 07:39:11 -0800 (PST)"],"From":"Milan Zamazal ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"Javier Tia , libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v3 1/3] ipa: simple: agc: Replace bang-bang controller\n\twith proportional","In-Reply-To":"<6fb5a6fe-27c8-49fb-ad7b-094bd4afd441@ideasonboard.com> (\n\t=?utf-8?b?IkJhcm5hYsOhcyBQxZFjemUiJ3M=?= message of \"Fri,\n\t6 Mar 2026 16:21:21 +0100\")","References":"<20260305-agc-proportional-v3-0-25abc1bfacca@jetm.me>\n\t<20260305-agc-proportional-v3-1-25abc1bfacca@jetm.me>\n\t<6fb5a6fe-27c8-49fb-ad7b-094bd4afd441@ideasonboard.com>","Date":"Fri, 06 Mar 2026 16:39:04 +0100","Message-ID":"<85jyvpm0h3.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"IPpCIB5cYu7LJt5-twibRXhLY02Bwj6iwRcToGxgHtI_1772811552","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]