[{"id":38338,"web_url":"https://patchwork.libcamera.org/comment/38338/","msgid":"<85seaeccm7.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","date":"2026-03-05T19:14:40","subject":"Re: [PATCH v2 3/4] ipa: simple: data: Add OV2740 tuning file","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Hi Javier,\n\nJavier Tia writes:\n\n> Add a tuning file for the OmniVision OV2740 sensor for the Simple/SoftISP\n> pipeline, tested on a ThinkPad X1 Carbon Gen 10 (Alder Lake, Intel IPU6).\n>\n> No CCM is needed: AWB grey-world convergence gives R/G ~ 0.98 and\n> B/G ~ 0.99 under 6500 K lighting after the statistics normalization fix.\n\nDoes it make any sense to add a basically empty tuning file, equal to\nuncalibrated.yaml? I suppose we still need CCMs for the sensor to get\ncorrect colours (in addition to having correct white balance).\n\n> Signed-off-by: Javier Tia \n> ---\n> src/ipa/simple/data/meson.build | 1 +\n> src/ipa/simple/data/ov2740.yaml | 13 +++++++++++++\n> 2 files changed, 14 insertions(+)\n> create mode 100644 src/ipa/simple/data/ov2740.yaml\n>\n> diff --git a/src/ipa/simple/data/meson.build b/src/ipa/simple/data/meson.build\n> index 92795ee4..e3e4de74 100644\n> --- a/src/ipa/simple/data/meson.build\n> +++ b/src/ipa/simple/data/meson.build\n> @@ -1,6 +1,7 @@\n> # SPDX-License-Identifier: CC0-1.0\n> \n> conf_files = files([\n> + 'ov2740.yaml',\n> 'uncalibrated.yaml',\n> ])\n> \n> diff --git a/src/ipa/simple/data/ov2740.yaml b/src/ipa/simple/data/ov2740.yaml\n> new file mode 100644\n> index 00000000..35cce1c1\n> --- /dev/null\n> +++ b/src/ipa/simple/data/ov2740.yaml\n> @@ -0,0 +1,13 @@\n> +# SPDX-License-Identifier: CC0-1.0\n> +#\n> +# OmniVision OV2740 tuning for libcamera Simple/SoftISP pipeline.\n> +#\n> +# Tested on ThinkPad X1 Carbon Gen 10 (Alder Lake) with Intel IPU6 ISYS.\n> +%YAML 1.1\n> +---\n> +version: 1\n> +algorithms:\n> + - BlackLevel:\n> + - Awb:\n> + - Adjust:\n> + - Agc:","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2F530BE086\n\tfor ;\n\tThu, 5 Mar 2026 19:14:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4AB56625B1;\n\tThu, 5 Mar 2026 20:14:49 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 68EAE622AE\n\tfor ;\n\tThu, 5 Mar 2026 20:14:47 +0100 (CET)","from mail-wr1-f72.google.com (mail-wr1-f72.google.com\n\t[209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-553-SpZ0YwgBO0W5TnMQXnBWTQ-1; Thu, 05 Mar 2026 14:14:44 -0500","by mail-wr1-f72.google.com with SMTP id\n\tffacd0b85a97d-439b484ee04so3212051f8f.1\n\tfor ;\n\tThu, 05 Mar 2026 11:14:44 -0800 (PST)","from mzamazal-thinkpadp1gen7.tpbc.csb\n\t(ip-77-48-47-2.net.vodafone.cz. [77.48.47.2])\n\tby smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-439b4175fd2sm37682275f8f.14.2026.03.05.11.14.41\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 05 Mar 2026 11:14:41 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"M1PV8yKJ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1772738086;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=8uXwktVneR/NvUGh7r9Sx+PKlnOf54G6ldncIcX84Mw=;\n\tb=M1PV8yKJvdBEfAwLkST2G0AwTDPOHRp+Vup/W/1li8y+i0mlJ1QxPMmwrmz6/YNEbogvPP\n\tAJhAwJP+MbXhQDNSzTNG9TKkoXG+AZ6lHhIRoRWfXTzAaCdom5GjF617nA8dLSfBJNyNpc\n\t8dPk+Vig/xWLDuaeyMCLB4MIiWQYyBo=","X-MC-Unique":"SpZ0YwgBO0W5TnMQXnBWTQ-1","X-Mimecast-MFC-AGG-ID":"SpZ0YwgBO0W5TnMQXnBWTQ_1772738083","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1772738083; x=1773342883;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject\n\t:date:message-id:reply-to;\n\tbh=8uXwktVneR/NvUGh7r9Sx+PKlnOf54G6ldncIcX84Mw=;\n\tb=ZAhZQrfwx5gEOeq62uek1GyE37BYCI4/Ri7P7CTzfxYm2dG+ZOjFA2LN9mD1t1bBmZ\n\tZBuwOhl/HePraECBUpp6bVOVHWgIyOWddnN5M855iz4vQwl4G3dchRO9CiANI8C+qn0v\n\tiYxp/mjEkSH1k/jP2oIsEx3OPNxZmXaxjoRhRVB4KfeX++7Vi1O1/fK08N4AgpE695tH\n\tEAvnLzEkwF+5PCOOy4lZPn+HSGUyyUUgFdMFxW6nK5QubsmS0NFEfwJQzyTb3VxGkMQr\n\tTfXCQknbBpthoY/CbwmwiP2WXBqKQBVgw/w+nII63zHfi6g2sRAJWD1jIDTrlCyIaf67\n\tzI2A==","X-Gm-Message-State":"AOJu0Ywb7ocwS5KRnCrkwVuohFJEnolvviv6Y75b/gMGmCpNgaDEEXjB\n\tptJv0n6456JJvaAn4NmzkQcrLT2eCu2eMaoj9OzERMmxEp1v4K+gHS6kZOZJIoDaMUO5gzjlWjJ\n\twwh1p28N6eip2tyi4cSiGVn766NWePuSVxB6EXXMht62Hvu5LOD7bbPIVO4Fo8u1HkCb4ONOHWI\n\tEnl/bBMCGlaX8ddUE0E7MAGNdLtxo11kerXvRutTUHLFtnpKpcFX+1d1/5qMM=","X-Gm-Gg":"ATEYQzz0UdNphh2CAAweAtDb74AIC9kZBPdl1yhM5Ldqrz9atQMu2KCNELOS84eZ6+l\n\tfEbWfsSwm6apH7yPvvdtBlDEGI41cO8lscmYVAtByKwzt3/nzG6tTEXFnrr+VZ7cZL6CwSkUvMs\n\tqn1uiro7bYms174jT9uTGUgWQQSC+0UeDEI0xIV08i5U+JA6/xc0ds30RMIG0yN+IuQAQ3vFi1I\n\tgvJlVcrV96F/GI5s2iUzD8RCi9MRk2d6aatF8yKyXupS+16eI++h3sGspeh2CSbnywweGZyYd69\n\tYCXe+KUHrz4AXpzSthOVcPaIQVJ83tU0ncygeVI4unNctrr7VF9/BsKZlrDVS/eADb+0H/loPoI\n\tm/cYPMbXepLOJI6WTOTCcmvIXEKs7UivG0yFFGI9XqSE8nqyd9ihtfqDjr+APq9K8eLwIEa3o8l\n\tQ=","X-Received":["by 2002:a5d:5847:0:b0:439:c153:ae3d with SMTP id\n\tffacd0b85a97d-439cfa30f77mr6642090f8f.6.1772738082866; \n\tThu, 05 Mar 2026 11:14:42 -0800 (PST)","by 2002:a5d:5847:0:b0:439:c153:ae3d with SMTP id\n\tffacd0b85a97d-439cfa30f77mr6642044f8f.6.1772738082374; \n\tThu, 05 Mar 2026 11:14:42 -0800 (PST)"],"From":"Milan Zamazal ","To":"Javier Tia ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v2 3/4] ipa: simple: data: Add OV2740 tuning file","In-Reply-To":"<20260304232539.C3F581EA006C@mailuser.phl.internal> (Javier\n\tTia's message of \"Wed, 04 Mar 2026 17:14:00 -0600\")","References":"<20260304232539.C3F581EA006C@mailuser.phl.internal>","Date":"Thu, 05 Mar 2026 20:14:40 +0100","Message-ID":"<85seaeccm7.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"AKvuOaBIU3vsdQWm273QBMAtMe96x1mJk2KeSseU6eY_1772738083","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]