[{"id":38331,"web_url":"https://patchwork.libcamera.org/comment/38331/","msgid":"<34f28eee-a0ec-4d42-8d34-900de548ce6a@ideasonboard.com>","date":"2026-03-04T13:37:04","subject":"Re: [PATCH] utils: Add missing SPDX headers to scripts","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2026. 03. 04. 14:35 keltezéssel, Laurent Pinchart írta:\n> The gen-header.sh and gen-shader-headers.sh scripts are missing an SPDX\n> header. Fix it.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> Barnabás, Bryan, you've authored some code in those files. Could you\n> please send a R-b or A-b ?\n> ---\n\nAcked-by: Barnabás Pőcze \n\n\n> utils/codegen/gen-header.sh | 1 +\n> utils/gen-shader-headers.sh | 1 +\n> 2 files changed, 2 insertions(+)\n> \n> diff --git a/utils/codegen/gen-header.sh b/utils/codegen/gen-header.sh\n> index c78f085992ef..9e833ff9244a 100755\n> --- a/utils/codegen/gen-header.sh\n> +++ b/utils/codegen/gen-header.sh\n> @@ -1,4 +1,5 @@\n> #!/bin/sh\n> +# SPDX-License-Identifier: GPL-2.0-or-later\n> \n> dst_file=\"$1\"\n> shift\n> diff --git a/utils/gen-shader-headers.sh b/utils/gen-shader-headers.sh\n> index 92f6f8181520..0d6649521a7a 100755\n> --- a/utils/gen-shader-headers.sh\n> +++ b/utils/gen-shader-headers.sh\n> @@ -1,4 +1,5 @@\n> #!/bin/sh\n> +# SPDX-License-Identifier: GPL-2.0-or-later\n> \n> set -e\n> \n> \n> base-commit: 14ba4d168085dd27aed9bcb043996d6a5f28867e","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3DFA3C0DA4\n\tfor ;\n\tWed, 4 Mar 2026 13:37:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7B9FE6239F;\n\tWed, 4 Mar 2026 14:37:12 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8AA8362380\n\tfor ;\n\tWed, 4 Mar 2026 14:37:11 +0100 (CET)","from [192.168.33.100] (185.182.214.224.nat.pool.zt.hu\n\t[185.182.214.224])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BCF7F838;\n\tWed, 4 Mar 2026 14:36:08 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"uPfV5m4D\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1772631368;\n\tbh=Hj7MirlpCiAb00pJMENZhWnMILEQ2VyEHBKbcHucCkM=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=uPfV5m4D3+fQbueKpNzoKm7NBEXQZMwrkw9pFDBgFFRDZ7wIjofJYawPt1TVfoRIY\n\tXHN03rYGFCGU6SA9y6UXVrHjqoMVvvgAEKjH1NWVKPX65eIUg/JAZuciZrt9BRNVs7\n\tDHfQce0AMXte48bx9CbkSUDn2gn6Nbu9jilEf8i0=","Message-ID":"<34f28eee-a0ec-4d42-8d34-900de548ce6a@ideasonboard.com>","Date":"Wed, 4 Mar 2026 14:37:04 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] utils: Add missing SPDX headers to scripts","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Cc":"Bryan O'Donoghue ","References":"<20260304133511.4020197-1-laurent.pinchart@ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20260304133511.4020197-1-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":38398,"web_url":"https://patchwork.libcamera.org/comment/38398/","msgid":"<323d6d92-9127-4384-be43-4fd71a2c7a53@nxsw.ie>","date":"2026-03-24T15:55:38","subject":"Re: [PATCH] utils: Add missing SPDX headers to scripts","submitter":{"id":226,"url":"https://patchwork.libcamera.org/api/people/226/","name":"Bryan O'Donoghue","email":"bod.linux@nxsw.ie"},"content":"On 04/03/2026 13:35, Laurent Pinchart wrote:\n> The gen-header.sh and gen-shader-headers.sh scripts are missing an SPDX\n> header. Fix it.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> Barnabás, Bryan, you've authored some code in those files. Could you\n> please send a R-b or A-b ?\n> ---\n> utils/codegen/gen-header.sh | 1 +\n> utils/gen-shader-headers.sh | 1 +\n> 2 files changed, 2 insertions(+)\n> \n> diff --git a/utils/codegen/gen-header.sh b/utils/codegen/gen-header.sh\n> index c78f085992ef..9e833ff9244a 100755\n> --- a/utils/codegen/gen-header.sh\n> +++ b/utils/codegen/gen-header.sh\n> @@ -1,4 +1,5 @@\n> #!/bin/sh\n> +# SPDX-License-Identifier: GPL-2.0-or-later\n> \n> dst_file=\"$1\"\n> shift\n> diff --git a/utils/gen-shader-headers.sh b/utils/gen-shader-headers.sh\n> index 92f6f8181520..0d6649521a7a 100755\n> --- a/utils/gen-shader-headers.sh\n> +++ b/utils/gen-shader-headers.sh\n> @@ -1,4 +1,5 @@\n> #!/bin/sh\n> +# SPDX-License-Identifier: GPL-2.0-or-later\n> \n> set -e\n> \n> \n> base-commit: 14ba4d168085dd27aed9bcb043996d6a5f28867e\n> --\n> Regards,\n> \n> Laurent Pinchart\n> \n\nThat's fine omission not intent here.\n\nReviewed-by: Bryan O'Donoghue \n\n---\nbod","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 03226BD87C\n\tfor ;\n\tTue, 24 Mar 2026 15:55:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3A42A62798;\n\tTue, 24 Mar 2026 16:55:43 +0100 (CET)","from tor.source.kernel.org (tor.source.kernel.org\n\t[IPv6:2600:3c04:e001:324:0:1991:8:25])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EA06B62791\n\tfor ;\n\tTue, 24 Mar 2026 16:55:41 +0100 (CET)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby tor.source.kernel.org (Postfix) with ESMTP id 1A80C60121;\n\tTue, 24 Mar 2026 15:55:41 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 02808C2BC87;\n\tTue, 24 Mar 2026 15:55:39 +0000 (UTC)"],"Message-ID":"<323d6d92-9127-4384-be43-4fd71a2c7a53@nxsw.ie>","Date":"Tue, 24 Mar 2026 15:55:38 +0000","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] utils: Add missing SPDX headers to scripts","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Cc":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tBryan O'Donoghue ","References":"<5S-53N_AFIAcHGn98w3khjpKFNRz0OtQYpiTcY1O1wURzmwDE9Pbaxsp37HsB5n_yAgwGuPKkM6vMz2lslRfMw==@protonmail.internalid>\n\t<20260304133511.4020197-1-laurent.pinchart@ideasonboard.com>","From":"Bryan O'Donoghue ","Content-Language":"en-US","In-Reply-To":"<20260304133511.4020197-1-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]