[{"id":38332,"web_url":"https://patchwork.libcamera.org/comment/38332/","msgid":"<8ae5860b-344a-403c-a7d2-8e8d9fcd2bd5@ideasonboard.com>","date":"2026-03-04T13:47:40","subject":"Re: [PATCH v5 4/5] software_isp: Log input config from configure()","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"Hi\n\n2026. 03. 04. 8:50 keltezéssel, Hans de Goede írta:\n> As shown by commit 94d32fdc55a3 (\"pipeline: simple: Consider output sizes\n> when choosing pipe config\"), the extra pixel columns CPU debayering\n> requires on the input side makes resolution selection non trivial.\n> \n> Add logging of the selected input config on a successful configure() so\n> that the logs clearly show which sensor mode has been selected.\n> \n> Reviewed-by: Milan Zamazal \n> Signed-off-by: Hans de Goede \n> ---\n> Changes in v2:\n> - Move from DebayerCpu::configure() to SoftwareIsp::configure() so that\n> the input fmt also gets logged when using the DebayerEgl class\n> ---\n> src/libcamera/software_isp/software_isp.cpp | 12 +++++++++++-\n> 1 file changed, 11 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\n> index 562cdba22..4cf5639d9 100644\n> --- a/src/libcamera/software_isp/software_isp.cpp\n> +++ b/src/libcamera/software_isp/software_isp.cpp\n> @@ -21,6 +21,7 @@\n> #include \n> #include \n> \n> +#include \"libcamera/internal/bayer_format.h\"\n> #include \"libcamera/internal/framebuffer.h\"\n> #include \"libcamera/internal/ipa_manager.h\"\n> #include \"libcamera/internal/software_isp/debayer_params.h\"\n> @@ -270,7 +271,16 @@ int SoftwareIsp::configure(const StreamConfiguration &inputCfg,\n> \tif (ret < 0)\n> \t\treturn ret;\n> \n> -\treturn debayer_->configure(inputCfg, outputCfgs, ccmEnabled_);\n> +\tret = debayer_->configure(inputCfg, outputCfgs, ccmEnabled_);\n> +\tif (ret < 0)\n> +\t\treturn ret;\n> +\n> +\tLOG(SoftwareIsp, Info)\n> +\t\t<< \"Input \" << inputCfg.size\n> +\t\t<< \"-\" << BayerFormat::fromPixelFormat(inputCfg.pixelFormat)\n> +\t\t<< \" stride \" << inputCfg.stride;\n\nI feel like \"INFO\" is a bit too high for this, nonetheless:\n\nReviewed-by: Barnabás Pőcze \n\n\n> +\n> +\treturn 0;\n> }\n> \n> /**","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AC65CBE086\n\tfor ;\n\tWed, 4 Mar 2026 13:47:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D45C9623A1;\n\tWed, 4 Mar 2026 14:47:45 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 37A2A62380\n\tfor ;\n\tWed, 4 Mar 2026 14:47:45 +0100 (CET)","from [192.168.33.100] (185.182.214.224.nat.pool.zt.hu\n\t[185.182.214.224])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 878C7838;\n\tWed, 4 Mar 2026 14:46:42 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Fo3oGylm\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1772632002;\n\tbh=jBKNtE84sJAruI1OMIo1WV26HbRZtsqYslfNvNlp4jg=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=Fo3oGylm8V0bVxtOxvqw7onx5zxr7QCdGBx+uZ2D7rQp2GLWq104K6ZcQYozde+iu\n\tWz+dVD86jhVtmD/tt8qfAK+rdAyUkYTO6LbM/W/AQV/pKuiHoWin5o0tCgjtSryNOP\n\tEFtIjleDY6tvc10vVuVYUxdeKjhcvbP7SSFFxeAM=","Message-ID":"<8ae5860b-344a-403c-a7d2-8e8d9fcd2bd5@ideasonboard.com>","Date":"Wed, 4 Mar 2026 14:47:40 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v5 4/5] software_isp: Log input config from configure()","To":"Hans de Goede ,\n\tlibcamera-devel@lists.libcamera.org, Milan Zamazal ","References":"<20260304075052.11599-1-johannes.goede@oss.qualcomm.com>\n\t<20260304075052.11599-5-johannes.goede@oss.qualcomm.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20260304075052.11599-5-johannes.goede@oss.qualcomm.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]